Re: Review Request 66282: Mock ConnManager field in TestTableDefWriter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66282/#review200193 --- Ship it! Ship It! - Boglarka Egyed On March 27, 2018, noon, Szabolcs Vasas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66282/ > --- > > (Updated March 27, 2018, noon) > > > Review request for Sqoop. > > > Bugs: SQOOP-3308 > https://issues.apache.org/jira/browse/SQOOP-3308 > > > Repository: sqoop-trunk > > > Description > --- > > This patch removes the externalColTypes field from TableDefWriter since it > was only used for testing purposes. > TestTableDefWriter is fixed to mock the ConnManager object provided to the > TableDefWriter constructor and a minor refactoring is done on the class. > > > Diffs > - > > src/java/org/apache/sqoop/hive/TableDefWriter.java e1424c383 > src/test/org/apache/sqoop/hive/TestTableDefWriter.java 496b5add9 > > > Diff: https://reviews.apache.org/r/66282/diff/4/ > > > Testing > --- > > ant clean test > > > Thanks, > > Szabolcs Vasas > >
Re: Review Request 66282: Mock ConnManager field in TestTableDefWriter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66282/#review200178 --- Nice and clean refactor +1 - Laszlo Bodor On March 27, 2018, noon, Szabolcs Vasas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66282/ > --- > > (Updated March 27, 2018, noon) > > > Review request for Sqoop. > > > Bugs: SQOOP-3308 > https://issues.apache.org/jira/browse/SQOOP-3308 > > > Repository: sqoop-trunk > > > Description > --- > > This patch removes the externalColTypes field from TableDefWriter since it > was only used for testing purposes. > TestTableDefWriter is fixed to mock the ConnManager object provided to the > TableDefWriter constructor and a minor refactoring is done on the class. > > > Diffs > - > > src/java/org/apache/sqoop/hive/TableDefWriter.java e1424c383 > src/test/org/apache/sqoop/hive/TestTableDefWriter.java 496b5add9 > > > Diff: https://reviews.apache.org/r/66282/diff/4/ > > > Testing > --- > > ant clean test > > > Thanks, > > Szabolcs Vasas > >
Re: Review Request 66282: Mock ConnManager field in TestTableDefWriter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66282/#review200121 --- Ship it! Ship It! - daniel voros On March 27, 2018, noon, Szabolcs Vasas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66282/ > --- > > (Updated March 27, 2018, noon) > > > Review request for Sqoop. > > > Bugs: SQOOP-3308 > https://issues.apache.org/jira/browse/SQOOP-3308 > > > Repository: sqoop-trunk > > > Description > --- > > This patch removes the externalColTypes field from TableDefWriter since it > was only used for testing purposes. > TestTableDefWriter is fixed to mock the ConnManager object provided to the > TableDefWriter constructor and a minor refactoring is done on the class. > > > Diffs > - > > src/java/org/apache/sqoop/hive/TableDefWriter.java e1424c383 > src/test/org/apache/sqoop/hive/TestTableDefWriter.java 496b5add9 > > > Diff: https://reviews.apache.org/r/66282/diff/4/ > > > Testing > --- > > ant clean test > > > Thanks, > > Szabolcs Vasas > >
Re: Review Request 66282: Mock ConnManager field in TestTableDefWriter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66282/ --- (Updated March 27, 2018, noon) Review request for Sqoop. Changes --- Some more refactoring is added to TestTableDefWriter. Bugs: SQOOP-3308 https://issues.apache.org/jira/browse/SQOOP-3308 Repository: sqoop-trunk Description --- This patch removes the externalColTypes field from TableDefWriter since it was only used for testing purposes. TestTableDefWriter is fixed to mock the ConnManager object provided to the TableDefWriter constructor and a minor refactoring is done on the class. Diffs (updated) - src/java/org/apache/sqoop/hive/TableDefWriter.java e1424c383 src/test/org/apache/sqoop/hive/TestTableDefWriter.java 496b5add9 Diff: https://reviews.apache.org/r/66282/diff/4/ Changes: https://reviews.apache.org/r/66282/diff/3-4/ Testing --- ant clean test Thanks, Szabolcs Vasas
Re: Review Request 66282: Mock ConnManager field in TestTableDefWriter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66282/#review199972 --- Ship it! Nice addition, ship it! - daniel voros On March 26, 2018, 2:02 p.m., Szabolcs Vasas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66282/ > --- > > (Updated March 26, 2018, 2:02 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-3308 > https://issues.apache.org/jira/browse/SQOOP-3308 > > > Repository: sqoop-trunk > > > Description > --- > > This patch removes the externalColTypes field from TableDefWriter since it > was only used for testing purposes. > TestTableDefWriter is fixed to mock the ConnManager object provided to the > TableDefWriter constructor and a minor refactoring is done on the class. > > > Diffs > - > > src/java/org/apache/sqoop/hive/TableDefWriter.java e1424c383 > src/test/org/apache/sqoop/hive/TestTableDefWriter.java 496b5add9 > > > Diff: https://reviews.apache.org/r/66282/diff/3/ > > > Testing > --- > > ant clean test > > > Thanks, > > Szabolcs Vasas > >
Re: Review Request 66282: Mock ConnManager field in TestTableDefWriter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66282/ --- (Updated March 26, 2018, 2:02 p.m.) Review request for Sqoop. Bugs: SQOOP-3308 https://issues.apache.org/jira/browse/SQOOP-3308 Repository: sqoop-trunk Description --- This patch removes the externalColTypes field from TableDefWriter since it was only used for testing purposes. TestTableDefWriter is fixed to mock the ConnManager object provided to the TableDefWriter constructor and a minor refactoring is done on the class. Diffs (updated) - src/java/org/apache/sqoop/hive/TableDefWriter.java e1424c383 src/test/org/apache/sqoop/hive/TestTableDefWriter.java 496b5add9 Diff: https://reviews.apache.org/r/66282/diff/3/ Changes: https://reviews.apache.org/r/66282/diff/2-3/ Testing --- ant clean test Thanks, Szabolcs Vasas
Re: Review Request 66282: Mock ConnManager field in TestTableDefWriter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66282/ --- (Updated March 26, 2018, 1:58 p.m.) Review request for Sqoop. Bugs: SQOOP-3308 https://issues.apache.org/jira/browse/SQOOP-3308 Repository: sqoop-trunk Description --- This patch removes the externalColTypes field from TableDefWriter since it was only used for testing purposes. TestTableDefWriter is fixed to mock the ConnManager object provided to the TableDefWriter constructor and a minor refactoring is done on the class. Diffs (updated) - src/java/org/apache/sqoop/hive/TableDefWriter.java e1424c383 src/test/org/apache/sqoop/hive/TestTableDefWriter.java 496b5add9 Diff: https://reviews.apache.org/r/66282/diff/2/ Changes: https://reviews.apache.org/r/66282/diff/1-2/ Testing --- ant clean test Thanks, Szabolcs Vasas
Review Request 66282: Mock ConnManager field in TestTableDefWriter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66282/ --- Review request for Sqoop. Bugs: SQOOP-3308 https://issues.apache.org/jira/browse/SQOOP-3308 Repository: sqoop-trunk Description --- This patch removes the externalColTypes field from TableDefWriter since it was only used for testing purposes. TestTableDefWriter is fixed to mock the ConnManager object provided to the TableDefWriter constructor and a minor refactoring is done on the class. Diffs - src/java/org/apache/sqoop/hive/TableDefWriter.java e1424c383 src/test/org/apache/sqoop/hive/TestTableDefWriter.java 496b5add9 Diff: https://reviews.apache.org/r/66282/diff/1/ Testing --- ant clean test Thanks, Szabolcs Vasas
