[GitHub] storm pull request: [STORM-609] Add storm-redis to storm external
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/365#issuecomment-70575248 @harshach @revans2 @ptgoetz I'd like to hear your thoughts about this. Anything including code reviews, thought about Storm + Redis, and so on is very appreciated. Thanks in advance! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-505: Fix debug string construction
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/359#issuecomment-70576802 @d2r looks like this PR already merged into master but somehow PR didn't get closed. Can you please close the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-469
Github user rekhajoshm commented on the pull request: https://github.com/apache/storm/pull/385#issuecomment-70607612 Thanks Harshch for having a look.Somehow you seem to have reviewed both storm-469 and storm-528 commits together? 1. commit 2931487 is for storm-469, tested and works on my storm cluster and gives me link to truncated text the log link, which works. 2. commit ef19e71 is for storm-528 and as informed to jmlogan, i will update the files in a while.Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-469
Github user rekhajoshm commented on the pull request: https://github.com/apache/storm/pull/385#issuecomment-70571273 jmlogan: you are right about the extra files.few more changes.will update commit.thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: [STORM-629] Place Link to Source Code Reposito...
GitHub user Lewuathe opened a pull request: https://github.com/apache/storm/pull/386 [STORM-629] Place Link to Source Code Repository on Webpage Attach some links to GitHub repository on download page and contributing page. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Lewuathe/storm attach-source-code-link Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/386.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #386 commit dd20c3ad91b0a8c3c824f3d3ff28636fdfda9690 Author: lewuathe lewua...@me.com Date: 2015-01-19T11:42:15Z [STORM-629] Place Link to Source Code Repository on Webpage --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-469
Github user Parth-Brahmbhatt commented on the pull request: https://github.com/apache/storm/pull/385#issuecomment-70523175 -1. I don't think the change is necessary. Storm ships with a logviewer daemon. If users want more details on some exception in ui, they have the ability to do so by ensuring that they have the logviewer daemons started which should allow them to navigate and view the entire log file through ui. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: [STORM-629] Place Link to Source Code Reposito...
Github user Parth-Brahmbhatt commented on the pull request: https://github.com/apache/storm/pull/386#issuecomment-70523906 +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
