[jira] [Commented] (STORM-1700) Introduce 'whitelist' / 'blacklist' option to MetricsConsumer

2016-05-02 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/STORM-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15268226#comment-15268226
 ] 

ASF GitHub Bot commented on STORM-1700:
---

Github user HeartSaVioR commented on the pull request:

https://github.com/apache/storm/pull/1324#issuecomment-216452966
  
@unsleepy22 Addressed "dropping older metrics points when consumer can't 
catch up" to STORM-1698, and rebase this pull request.


> Introduce 'whitelist' / 'blacklist' option to MetricsConsumer
> -
>
> Key: STORM-1700
> URL: https://issues.apache.org/jira/browse/STORM-1700
> Project: Apache Storm
>  Issue Type: Sub-task
>  Components: storm-core
>Affects Versions: 1.0.0, 2.0.0
>Reporter: Jungtaek Lim
>Assignee: Jungtaek Lim
>
> Storm provides various metrics by default, and so on some external modules 
> (storm-kafka).
> When we register MetricsConsumer, MetricsConsumer should handle all of 
> metrics. If MetricsConsumer cannot keep up with these metrics, only way to 
> keep up is increasing parallelism, which seems limited. Furthermore, some 
> users don't want to care about some metrics since unintended metrics will 
> fill external storage.
> Though MetricsConsumer itself can filter metrics by name, it would be better 
> to support filter by Storm side. It will reduce the redundant works for Storm 
> community.
> If we provide filter options, it would be great.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] storm pull request: STORM-1700 Introduce 'whitelist' / 'blacklist'...

2016-05-02 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request:

https://github.com/apache/storm/pull/1324#issuecomment-216452966
  
@unsleepy22 Addressed "dropping older metrics points when consumer can't 
catch up" to STORM-1698, and rebase this pull request.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: [VOTE] Release Apache Storm 1.0.1 (rc3)

2016-05-02 Thread Arun Mahadevan
+1 (binding)
- Extracted all binaries.
- Ran sample topologies.
- Verified Stateful bolt changes added in 1.0.1 works as expected.

Thanks,
Arun





On 5/3/16, 4:52 AM, "Harsha"  wrote:

>+1 (binding)
>  - Deployed 3-node cluster  and example topologies
>  - Verified the binaries signature.
>Thanks,
>Harsha
>
>On Sun, May 1, 2016, at 07:11 PM, Jungtaek Lim wrote:
>> +1 (binding)
>> 
>> - build succeed from source code
>> - binary extracted well, and supervisor launches worker fine even though
>> JAVA_HOME is unset (STORM-1741) / also checked when JAVA_HOME is set
>> 
>> Thanks all of efforts you all have been done with this release.
>> 
>> Thanks,
>> Jungtaek Lim (HeartSaVioR)
>> 
>> 
>> 2016년 4월 30일 (토) 오전 10:08, Xin Wang 님이 작성:
>> 
>> > +1 (Non binding)
>> >
>> > 2016-04-30 5:28 GMT+08:00 P. Taylor Goetz :
>> >
>> > > If at first you don't succeed... ;)
>> > >
>> > > This is a call to vote on releasing Apache Storm 1.0.1 (rc3)
>> > >
>> > > Full list of changes in this release:
>> > >
>> > >
>> > >
>> > https://git-wip-us.apache.org/repos/asf?p=storm.git;a=blob_plain;f=CHANGELOG.md;hb=b5c16f919ad4099e6fb25f1095c9af8b64ac9f91
>> > >
>> > > The tag/commit to be voted upon is v1.0.1:
>> > >
>> > >
>> > >
>> > https://git-wip-us.apache.org/repos/asf?p=storm.git;a=tree;h=14b2ac0fe33759a50a2392ebdc7ad3821d43b89f;hb=b5c16f919ad4099e6fb25f1095c9af8b64ac9f91
>> > >
>> > > The source archive being voted upon can be found here:
>> > >
>> > >
>> > >
>> > https://dist.apache.org/repos/dist/dev/storm/apache-storm-1.0.1-rc3/apache-storm-1.0.1-src.tar.gz
>> > >
>> > > Other release files, signatures and digests can be found here:
>> > >
>> > > https://dist.apache.org/repos/dist/dev/storm/apache-storm-1.0.1-rc3/
>> > >
>> > > The release artifacts are signed with the following key:
>> > >
>> > >
>> > >
>> > https://git-wip-us.apache.org/repos/asf?p=storm.git;a=blob_plain;f=KEYS;hb=22b832708295fa2c15c4f3c70ac0d2bc6fded4bd
>> > >
>> > > The Nexus staging repository for this release is:
>> > >
>> > > https://repository.apache.org/content/repositories/orgapachestorm-1033/
>> > >
>> > > Please vote on releasing this package as Apache Storm 1.0.1.
>> > >
>> > > When voting, please list the actions taken to verify the release.
>> > >
>> > > This vote will be open for at least 72 hours.
>> > >
>> > > [ ] +1 Release this package as Apache Storm 1.0.1
>> > > [ ]  0 No opinion
>> > > [ ] -1 Do not release this package because...
>> > >
>> > > Thanks to everyone who contributed to this release.
>> > >
>> > > -Taylor
>> > >
>> >
>



[jira] [Commented] (STORM-1707) Improve supervisor latency by removing 2-min wait

2016-05-02 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/STORM-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15268169#comment-15268169
 ] 

ASF GitHub Bot commented on STORM-1707:
---

Github user hustfxj commented on the pull request:

https://github.com/apache/storm/pull/1370#issuecomment-216446889
  
LGTM


> Improve supervisor latency by removing 2-min wait
> -
>
> Key: STORM-1707
> URL: https://issues.apache.org/jira/browse/STORM-1707
> Project: Apache Storm
>  Issue Type: Improvement
>Reporter: Paul Poulosky
>Assignee: Paul Poulosky
>
> After launching workers, the supervisor waits up to 2 minutes synchronously 
> for the workers to be "launched".
> We should remove this, and instead keep track of launch time, making the 
> "killer" function smart enough to determine the difference between a worker 
> that's still launching, one that's timed out, etc.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] storm pull request: [STORM-1707] Remove two minute timeout after w...

2016-05-02 Thread hustfxj
Github user hustfxj commented on the pull request:

https://github.com/apache/storm/pull/1370#issuecomment-216446889
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (STORM-1757) Apache Beam Runner for Storm

2016-05-02 Thread Jungtaek Lim (JIRA)

[ 
https://issues.apache.org/jira/browse/STORM-1757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15268166#comment-15268166
 ] 

Jungtaek Lim commented on STORM-1757:
-

I also would like to participate in.
Before that, how about discussing at dev@ to make sure potential contributors 
can also collaborate as well?
I guess this could be a great item for GSoC if we release 1.0.0 before starting 
GSoC, but it's not late for potential contributors.

> Apache Beam Runner for Storm
> 
>
> Key: STORM-1757
> URL: https://issues.apache.org/jira/browse/STORM-1757
> Project: Apache Storm
>  Issue Type: Brainstorming
>Reporter: P. Taylor Goetz
>Priority: Minor
>
> This is a call for interested parties to collaborate on an Apache Beam [1] 
> runner for Storm, and express their thoughts and opinions.
> Given the addition of the Windowing API to Apache Storm, we should be able to 
> map naturally to the Beam API. If not, it may be indicative of shortcomings 
> of the Storm API that should be addressed.
> [1] http://beam.incubator.apache.org



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (STORM-1757) Apache Beam Runner for Storm

2016-05-02 Thread Arun Mahadevan (JIRA)

[ 
https://issues.apache.org/jira/browse/STORM-1757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15268155#comment-15268155
 ] 

Arun Mahadevan commented on STORM-1757:
---

Would like to collaborate in this effort.

> Apache Beam Runner for Storm
> 
>
> Key: STORM-1757
> URL: https://issues.apache.org/jira/browse/STORM-1757
> Project: Apache Storm
>  Issue Type: Brainstorming
>Reporter: P. Taylor Goetz
>Priority: Minor
>
> This is a call for interested parties to collaborate on an Apache Beam [1] 
> runner for Storm, and express their thoughts and opinions.
> Given the addition of the Windowing API to Apache Storm, we should be able to 
> map naturally to the Beam API. If not, it may be indicative of shortcomings 
> of the Storm API that should be addressed.
> [1] http://beam.incubator.apache.org



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (STORM-1700) Introduce 'whitelist' / 'blacklist' option to MetricsConsumer

2016-05-02 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/STORM-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15268135#comment-15268135
 ] 

ASF GitHub Bot commented on STORM-1700:
---

Github user HeartSaVioR commented on the pull request:

https://github.com/apache/storm/pull/1324#issuecomment-216442018
  
For now I applied caching the filter result to avoid determine filter every 
time.


> Introduce 'whitelist' / 'blacklist' option to MetricsConsumer
> -
>
> Key: STORM-1700
> URL: https://issues.apache.org/jira/browse/STORM-1700
> Project: Apache Storm
>  Issue Type: Sub-task
>  Components: storm-core
>Affects Versions: 1.0.0, 2.0.0
>Reporter: Jungtaek Lim
>Assignee: Jungtaek Lim
>
> Storm provides various metrics by default, and so on some external modules 
> (storm-kafka).
> When we register MetricsConsumer, MetricsConsumer should handle all of 
> metrics. If MetricsConsumer cannot keep up with these metrics, only way to 
> keep up is increasing parallelism, which seems limited. Furthermore, some 
> users don't want to care about some metrics since unintended metrics will 
> fill external storage.
> Though MetricsConsumer itself can filter metrics by name, it would be better 
> to support filter by Storm side. It will reduce the redundant works for Storm 
> community.
> If we provide filter options, it would be great.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] storm pull request: STORM-1700 Introduce 'whitelist' / 'blacklist'...

2016-05-02 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request:

https://github.com/apache/storm/pull/1324#issuecomment-216442018
  
For now I applied caching the filter result to avoid determine filter every 
time.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Updated] (STORM-1757) Apache Beam Runner for Storm

2016-05-02 Thread P. Taylor Goetz (JIRA)

 [ 
https://issues.apache.org/jira/browse/STORM-1757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

P. Taylor Goetz updated STORM-1757:
---
Assignee: (was: Sriharsha Chintalapani)

Switching to unassigned. This was intended to be a discussion about an 
implementation.

> Apache Beam Runner for Storm
> 
>
> Key: STORM-1757
> URL: https://issues.apache.org/jira/browse/STORM-1757
> Project: Apache Storm
>  Issue Type: Brainstorming
>Reporter: P. Taylor Goetz
>Priority: Minor
>
> This is a call for interested parties to collaborate on an Apache Beam [1] 
> runner for Storm, and express their thoughts and opinions.
> Given the addition of the Windowing API to Apache Storm, we should be able to 
> map naturally to the Beam API. If not, it may be indicative of shortcomings 
> of the Storm API that should be addressed.
> [1] http://beam.incubator.apache.org



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (STORM-1743) consumerAutoCommitMode not work in storm-kafka-client

2016-05-02 Thread Jifeng Yin (JIRA)

 [ 
https://issues.apache.org/jira/browse/STORM-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jifeng Yin updated STORM-1743:
--
Assignee: Hugo Louro

> consumerAutoCommitMode not work in storm-kafka-client
> -
>
> Key: STORM-1743
> URL: https://issues.apache.org/jira/browse/STORM-1743
> Project: Apache Storm
>  Issue Type: Bug
>Affects Versions: 1.0.0
>Reporter: Jifeng Yin
>Assignee: Hugo Louro
>
> poll() checks the numUncommittedOffsets, however, it's never updated under 
> consumerAutoCommitMode.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (STORM-1757) Apache Beam Runner for Storm

2016-05-02 Thread Sriharsha Chintalapani (JIRA)

 [ 
https://issues.apache.org/jira/browse/STORM-1757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sriharsha Chintalapani reassigned STORM-1757:
-

Assignee: Sriharsha Chintalapani

> Apache Beam Runner for Storm
> 
>
> Key: STORM-1757
> URL: https://issues.apache.org/jira/browse/STORM-1757
> Project: Apache Storm
>  Issue Type: Brainstorming
>Reporter: P. Taylor Goetz
>Assignee: Sriharsha Chintalapani
>Priority: Minor
>
> This is a call for interested parties to collaborate on an Apache Beam [1] 
> runner for Storm, and express their thoughts and opinions.
> Given the addition of the Windowing API to Apache Storm, we should be able to 
> map naturally to the Beam API. If not, it may be indicative of shortcomings 
> of the Storm API that should be addressed.
> [1] http://beam.incubator.apache.org



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (STORM-1757) Apache Beam Runner for Storm

2016-05-02 Thread Sriharsha Chintalapani (JIRA)

[ 
https://issues.apache.org/jira/browse/STORM-1757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15267952#comment-15267952
 ] 

Sriharsha Chintalapani commented on STORM-1757:
---

I am working on it here https://issues.apache.org/jira/browse/BEAM-216. Will 
share the design docs.

> Apache Beam Runner for Storm
> 
>
> Key: STORM-1757
> URL: https://issues.apache.org/jira/browse/STORM-1757
> Project: Apache Storm
>  Issue Type: Brainstorming
>Reporter: P. Taylor Goetz
>Assignee: Sriharsha Chintalapani
>Priority: Minor
>
> This is a call for interested parties to collaborate on an Apache Beam [1] 
> runner for Storm, and express their thoughts and opinions.
> Given the addition of the Windowing API to Apache Storm, we should be able to 
> map naturally to the Beam API. If not, it may be indicative of shortcomings 
> of the Storm API that should be addressed.
> [1] http://beam.incubator.apache.org



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (STORM-1757) Apache Beam Runner for Storm

2016-05-02 Thread P. Taylor Goetz (JIRA)
P. Taylor Goetz created STORM-1757:
--

 Summary: Apache Beam Runner for Storm
 Key: STORM-1757
 URL: https://issues.apache.org/jira/browse/STORM-1757
 Project: Apache Storm
  Issue Type: Brainstorming
Reporter: P. Taylor Goetz
Priority: Minor


This is a call for interested parties to collaborate on an Apache Beam [1] 
runner for Storm, and express their thoughts and opinions.

Given the addition of the Windowing API to Apache Storm, we should be able to 
map naturally to the Beam API. If not, it may be indicative of shortcomings of 
the Storm API that should be addressed.


[1] http://beam.incubator.apache.org



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] storm pull request: STORM-1754: Correct java version in 0.10.x sto...

2016-05-02 Thread hustfxj
Github user hustfxj commented on the pull request:

https://github.com/apache/storm/pull/1385#issuecomment-216408694
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (STORM-1754) Correct java version in 0.10.x storm-starter

2016-05-02 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/STORM-1754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15267854#comment-15267854
 ] 

ASF GitHub Bot commented on STORM-1754:
---

Github user hustfxj commented on the pull request:

https://github.com/apache/storm/pull/1385#issuecomment-216408694
  
+1


> Correct java version in 0.10.x storm-starter
> 
>
> Key: STORM-1754
> URL: https://issues.apache.org/jira/browse/STORM-1754
> Project: Apache Storm
>  Issue Type: Bug
>  Components: documentation
>Reporter: Xin Wang
>Assignee: Xin Wang
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: [VOTE] Release Apache Storm 1.0.1 (rc3)

2016-05-02 Thread Harsha
+1 (binding)
  - Deployed 3-node cluster  and example topologies
  - Verified the binaries signature.
Thanks,
Harsha

On Sun, May 1, 2016, at 07:11 PM, Jungtaek Lim wrote:
> +1 (binding)
> 
> - build succeed from source code
> - binary extracted well, and supervisor launches worker fine even though
> JAVA_HOME is unset (STORM-1741) / also checked when JAVA_HOME is set
> 
> Thanks all of efforts you all have been done with this release.
> 
> Thanks,
> Jungtaek Lim (HeartSaVioR)
> 
> 
> 2016년 4월 30일 (토) 오전 10:08, Xin Wang 님이 작성:
> 
> > +1 (Non binding)
> >
> > 2016-04-30 5:28 GMT+08:00 P. Taylor Goetz :
> >
> > > If at first you don't succeed... ;)
> > >
> > > This is a call to vote on releasing Apache Storm 1.0.1 (rc3)
> > >
> > > Full list of changes in this release:
> > >
> > >
> > >
> > https://git-wip-us.apache.org/repos/asf?p=storm.git;a=blob_plain;f=CHANGELOG.md;hb=b5c16f919ad4099e6fb25f1095c9af8b64ac9f91
> > >
> > > The tag/commit to be voted upon is v1.0.1:
> > >
> > >
> > >
> > https://git-wip-us.apache.org/repos/asf?p=storm.git;a=tree;h=14b2ac0fe33759a50a2392ebdc7ad3821d43b89f;hb=b5c16f919ad4099e6fb25f1095c9af8b64ac9f91
> > >
> > > The source archive being voted upon can be found here:
> > >
> > >
> > >
> > https://dist.apache.org/repos/dist/dev/storm/apache-storm-1.0.1-rc3/apache-storm-1.0.1-src.tar.gz
> > >
> > > Other release files, signatures and digests can be found here:
> > >
> > > https://dist.apache.org/repos/dist/dev/storm/apache-storm-1.0.1-rc3/
> > >
> > > The release artifacts are signed with the following key:
> > >
> > >
> > >
> > https://git-wip-us.apache.org/repos/asf?p=storm.git;a=blob_plain;f=KEYS;hb=22b832708295fa2c15c4f3c70ac0d2bc6fded4bd
> > >
> > > The Nexus staging repository for this release is:
> > >
> > > https://repository.apache.org/content/repositories/orgapachestorm-1033/
> > >
> > > Please vote on releasing this package as Apache Storm 1.0.1.
> > >
> > > When voting, please list the actions taken to verify the release.
> > >
> > > This vote will be open for at least 72 hours.
> > >
> > > [ ] +1 Release this package as Apache Storm 1.0.1
> > > [ ]  0 No opinion
> > > [ ] -1 Do not release this package because...
> > >
> > > Thanks to everyone who contributed to this release.
> > >
> > > -Taylor
> > >
> >


[jira] [Commented] (STORM-1754) Correct java version in 0.10.x storm-starter

2016-05-02 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/STORM-1754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15266653#comment-15266653
 ] 

ASF GitHub Bot commented on STORM-1754:
---

Github user dossett commented on the pull request:

https://github.com/apache/storm/pull/1385#issuecomment-216244851
  
+1


> Correct java version in 0.10.x storm-starter
> 
>
> Key: STORM-1754
> URL: https://issues.apache.org/jira/browse/STORM-1754
> Project: Apache Storm
>  Issue Type: Bug
>  Components: documentation
>Reporter: Xin Wang
>Assignee: Xin Wang
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] storm pull request: STORM-1754: Correct java version in 0.10.x sto...

2016-05-02 Thread dossett
Github user dossett commented on the pull request:

https://github.com/apache/storm/pull/1385#issuecomment-216244851
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (STORM-1756) Storm-kafka tests leak resources due to retained references to KafkaServer

2016-05-02 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/STORM-1756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15266570#comment-15266570
 ] 

ASF GitHub Bot commented on STORM-1756:
---

GitHub user srdo opened a pull request:

https://github.com/apache/storm/pull/1387

STORM-1756: Explicitly null KafkaServer reference in KafkaTestBroker …

…to prevent out of memory on large test classes.

I'm not clear on whether JUnit keeps the reference for the lifetime of the 
module test, or whether they're released after all tests in a class have run. 
Either way, a test class with a KafkaTestBroker field and many tests would 
likely still run out of memory.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/srdo/storm STORM-1756

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/storm/pull/1387.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1387


commit 0f760c20f2a5d1376d20f1dcb259bdb000cc1d35
Author: Stig Rohde Døssing 
Date:   2016-05-02T13:07:07Z

STORM-1756: Explicitly null KafkaServer reference in KafkaTestBroker to 
prevent out of memory on large test classes




> Storm-kafka tests leak resources due to retained references to KafkaServer
> --
>
> Key: STORM-1756
> URL: https://issues.apache.org/jira/browse/STORM-1756
> Project: Apache Storm
>  Issue Type: Bug
>  Components: storm-kafka
>Reporter: Stig Rohde Døssing
>Assignee: Stig Rohde Døssing
>
> Since JUnit keeps a reference to each test class until all tests for a module 
> have run, the KafkaTestBroker fields are not eligible for garbage collection 
> until all tests have run. KafkaTestBroker keeps a reference to 
> KafkaServerStartable/KafkaServer, which allocates resources that are also not 
> eligible for collection. This very quickly causes surefire to run out of 
> memory if this class is used more than a few places.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] storm pull request: STORM-1756: Explicitly null KafkaServer refere...

2016-05-02 Thread srdo
GitHub user srdo opened a pull request:

https://github.com/apache/storm/pull/1387

STORM-1756: Explicitly null KafkaServer reference in KafkaTestBroker …

…to prevent out of memory on large test classes.

I'm not clear on whether JUnit keeps the reference for the lifetime of the 
module test, or whether they're released after all tests in a class have run. 
Either way, a test class with a KafkaTestBroker field and many tests would 
likely still run out of memory.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/srdo/storm STORM-1756

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/storm/pull/1387.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1387


commit 0f760c20f2a5d1376d20f1dcb259bdb000cc1d35
Author: Stig Rohde Døssing 
Date:   2016-05-02T13:07:07Z

STORM-1756: Explicitly null KafkaServer reference in KafkaTestBroker to 
prevent out of memory on large test classes




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (STORM-1756) Storm-kafka tests leak resources due to retained references to KafkaServer

2016-05-02 Thread JIRA
Stig Rohde Døssing created STORM-1756:
-

 Summary: Storm-kafka tests leak resources due to retained 
references to KafkaServer
 Key: STORM-1756
 URL: https://issues.apache.org/jira/browse/STORM-1756
 Project: Apache Storm
  Issue Type: Bug
  Components: storm-kafka
Reporter: Stig Rohde Døssing
Assignee: Stig Rohde Døssing


Since JUnit keeps a reference to each test class until all tests for a module 
have run, the KafkaTestBroker fields are not eligible for garbage collection 
until all tests have run. KafkaTestBroker keeps a reference to 
KafkaServerStartable/KafkaServer, which allocates resources that are also not 
eligible for collection. This very quickly causes surefire to run out of memory 
if this class is used more than a few places.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (STORM-1755) Revert the kafka client version upgrade in storm-kafka module

2016-05-02 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/STORM-1755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15266495#comment-15266495
 ] 

ASF GitHub Bot commented on STORM-1755:
---

GitHub user abhishekagarwal87 opened a pull request:

https://github.com/apache/storm/pull/1386

STORM-1755: Revert the kafka client version to 0.8.x in storm-kafka 



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/abhishekagarwal87/storm STORM-1755

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/storm/pull/1386.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1386


commit 267ea8e38fdad7c405ecdc363917f3f8d88120c0
Author: Abhishek Agarwal 
Date:   2016-05-02T12:18:06Z

STORM-1755: Revert the kafka client version to 0.8.x in storm-kafka module




> Revert the kafka client version upgrade in storm-kafka module
> -
>
> Key: STORM-1755
> URL: https://issues.apache.org/jira/browse/STORM-1755
> Project: Apache Storm
>  Issue Type: Improvement
>  Components: storm-kafka
>Affects Versions: 1.0.1
>Reporter: Abhishek Agarwal
>Assignee: Abhishek Agarwal
>
> storm-kafka module does not use any feature of new API. The newer kafka 
> client (0.9.x) is not backward compatible with 0.8.x brokers and upgrading 
> storm-kafka version in topology could break the currently running topologies. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] storm pull request: STORM-1755: Revert the kafka client version to...

2016-05-02 Thread abhishekagarwal87
GitHub user abhishekagarwal87 opened a pull request:

https://github.com/apache/storm/pull/1386

STORM-1755: Revert the kafka client version to 0.8.x in storm-kafka 



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/abhishekagarwal87/storm STORM-1755

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/storm/pull/1386.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1386


commit 267ea8e38fdad7c405ecdc363917f3f8d88120c0
Author: Abhishek Agarwal 
Date:   2016-05-02T12:18:06Z

STORM-1755: Revert the kafka client version to 0.8.x in storm-kafka module




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (STORM-1755) Revert the kafka client version upgrade in storm-kafka module

2016-05-02 Thread Abhishek Agarwal (JIRA)
Abhishek Agarwal created STORM-1755:
---

 Summary: Revert the kafka client version upgrade in storm-kafka 
module
 Key: STORM-1755
 URL: https://issues.apache.org/jira/browse/STORM-1755
 Project: Apache Storm
  Issue Type: Improvement
  Components: storm-kafka
Affects Versions: 1.0.1
Reporter: Abhishek Agarwal
Assignee: Abhishek Agarwal


storm-kafka module does not use any feature of new API. The newer kafka client 
(0.9.x) is not backward compatible with 0.8.x brokers and upgrading storm-kafka 
version in topology could break the currently running topologies. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (STORM-1754) Correct java version in 0.10.x storm-starter

2016-05-02 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/STORM-1754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15266407#comment-15266407
 ] 

ASF GitHub Bot commented on STORM-1754:
---

Github user vesense commented on the pull request:

https://github.com/apache/storm/pull/1385#issuecomment-216203475
  
Thanks @abhishekagarwal87 Done.


> Correct java version in 0.10.x storm-starter
> 
>
> Key: STORM-1754
> URL: https://issues.apache.org/jira/browse/STORM-1754
> Project: Apache Storm
>  Issue Type: Bug
>  Components: documentation
>Reporter: Xin Wang
>Assignee: Xin Wang
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] storm pull request: STORM-1754: Correct java version in 0.10.x sto...

2016-05-02 Thread vesense
Github user vesense commented on the pull request:

https://github.com/apache/storm/pull/1385#issuecomment-216203475
  
Thanks @abhishekagarwal87 Done.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (STORM-1239) port backtype.storm.scheduler.IsolationScheduler to java

2016-05-02 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/STORM-1239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15266387#comment-15266387
 ] 

ASF GitHub Bot commented on STORM-1239:
---

Github user vesense commented on the pull request:

https://github.com/apache/storm/pull/1359#issuecomment-216197215
  
@abhishekagarwal87 @revans2 Could you take a look?


> port  backtype.storm.scheduler.IsolationScheduler to java
> -
>
> Key: STORM-1239
> URL: https://issues.apache.org/jira/browse/STORM-1239
> Project: Apache Storm
>  Issue Type: New Feature
>  Components: storm-core
>Reporter: Robert Joseph Evans
>Assignee: Xin Wang
>  Labels: java-migration, jstorm-merger
>
> port the isolation scheduler to java



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] storm pull request: STORM-1239: port backtype.storm.scheduler.Isol...

2016-05-02 Thread vesense
Github user vesense commented on the pull request:

https://github.com/apache/storm/pull/1359#issuecomment-216197215
  
@abhishekagarwal87 @revans2 Could you take a look?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] storm pull request: STORM-1754: Correct java version in 0.10.x sto...

2016-05-02 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on the pull request:

https://github.com/apache/storm/pull/1385#issuecomment-216142879
  
can you add the JIRA id in commit message and update the commit message to 
"correct java version in documentation"? Looks good otherwise 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (STORM-1754) Correct java version in 0.10.x storm-starter

2016-05-02 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/STORM-1754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15266227#comment-15266227
 ] 

ASF GitHub Bot commented on STORM-1754:
---

Github user abhishekagarwal87 commented on the pull request:

https://github.com/apache/storm/pull/1385#issuecomment-216142879
  
can you add the JIRA id in commit message and update the commit message to 
"correct java version in documentation"? Looks good otherwise 


> Correct java version in 0.10.x storm-starter
> 
>
> Key: STORM-1754
> URL: https://issues.apache.org/jira/browse/STORM-1754
> Project: Apache Storm
>  Issue Type: Bug
>  Components: documentation
>Reporter: Xin Wang
>Assignee: Xin Wang
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)