[GitHub] storm pull request #2021: [STORM-2427] Fix event logger enable disable UI bu...

[arunmahadevan]

GitHub user arunmahadevan opened a pull request:

https://github.com/apache/storm/pull/2021

[STORM-2427] Fix event logger enable disable UI buttons

Applying relevant commits from 1.x and some minor fix.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/arunmahadevan/storm STORM-2427

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/storm/pull/2021.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2021


commit f0a52862e340dde5849d06fd7984e0d308f14291
Author: Roshan Naik 
Date:   2016-03-30T23:30:43Z

Enable/disable Debug button on UI if eventloggers are enabled. Also show 
tooltip on Debug button

commit 3186330e6a6e2565972751cc28a87f307797b8ba
Author: Roshan Naik 
Date:   2016-04-01T01:16:52Z

Showing tooltip on Debug button only when disabled and event loggers are 
disabled. Also enable/disable of Debug button along with toltip in component 
page

commit b1ee165c68ecb6e8f50993c4181a70ff011da145
Author: Arun Mahadevan 
Date:   2017-03-21T05:18:11Z

Remove loggersTotal != null check as it implies 1 eventlogger per worker




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1999: STORM-2409: Storm-Kafka-Client KafkaSpout Support for Fai...

[satishd]

Github user satishd commented on the issue:

https://github.com/apache/storm/pull/1999
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #2019: STORM-2423 - Join Bolt should use explicit instead...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/storm/pull/2019


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #2019: STORM-2423 - Join Bolt should use explicit instead of def...

[roshannaik]

Github user roshannaik commented on the issue:

https://github.com/apache/storm/pull/2019
  
@satishd 
I have fixed the UTs. The MockCollector.emit used in the UT needed to be 
updated to correspond with  the emit method used by the JoinBolt.  Have 
squashed the commits.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #2018: STORM-2416: Improve Release Packaging to Reduce Fi...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/storm/pull/2018


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #2018: STORM-2416: Improve Release Packaging to Reduce File Size

[HeartSaVioR]

Github user HeartSaVioR commented on the issue:

https://github.com/apache/storm/pull/2018
  
@ptgoetz 
OK either applying or not applying this to 1.0.x is fine for me. 
Given that you're planning to apply this to master branch as well, I think 
this is mergeable now.
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1924: STORM-2343: New Kafka spout can stop emitting tuples if m...

[srdo]

Github user srdo commented on the issue:

https://github.com/apache/storm/pull/1924
  
Sorry to keep changing this. I hope these are the last few changes. The 
spout should now seek to the lowest retriable offset for each partition when 
retrying tuples, instead of seeking back to the last committed offset. This 
means there's not as far as I can see any reason to worry about maxPollRecords 
being set too low compared to maxUncommittedOffsets, so I've reverted that part 
of KafkaSpoutConfig.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1999: STORM-2409: Storm-Kafka-Client KafkaSpout Support for Fai...

[harshach]

Github user harshach commented on the issue:

https://github.com/apache/storm/pull/1999
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #2009: STORM-2407: KafkaTridentSpoutOpaque Doesn't Poll D...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/storm/pull/2009


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #2020: STORM-2425: Storm Hive Bolt not closing open transactions

[harshach]

Github user harshach commented on the issue:

https://github.com/apache/storm/pull/2020
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #2019: STORM-2423 - Join Bolt should use explicit instead of def...

[revans2]

Github user revans2 commented on the issue:

https://github.com/apache/storm/pull/2019
  
+1 for the concept, would like to understand the test failures though.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #2018: STORM-2416: Improve Release Packaging to Reduce File Size

[ptgoetz]

Github user ptgoetz commented on the issue:

https://github.com/apache/storm/pull/2018
  
@HeartSaVioR Yes, that's my plan. I prioritized the 1.1.x branch since it's 
needed for the 1.1.0 release.

I'm not sure we want to apply it to the 1.0.x branch since we have a number 
of releases from that branch and this change would change the structure of the 
distribution. I could go either way, though, and am open to others' opinions.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #2018: STORM-2416: Improve Release Packaging to Reduce Fi...

[ptgoetz]

Github user ptgoetz commented on a diff in the pull request:

https://github.com/apache/storm/pull/2018#discussion_r106933223
  
--- Diff: examples/storm-perf/pom.xml ---
@@ -22,8 +22,8 @@
 
 storm
 org.apache.storm
-1.1.1-SNAPSHOT
-..
+1.1.0-SNAPSHOT
+../pom.xml
--- End diff --

@HeartSaVioR Nice catch, fixed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #2002: [STORM-2410]modify Trident-state.md

[liu-zhaokun]

Github user liu-zhaokun commented on the issue:

https://github.com/apache/storm/pull/2002
  
Hello,@HeartSaVioR 
It's not easy to clean up the commits.And there is only one file changed in 
the end.Is it necessary to clean up the commits?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #2018: STORM-2416: Improve Release Packaging to Reduce File Size

[HeartSaVioR]

Github user HeartSaVioR commented on the issue:

https://github.com/apache/storm/pull/2018
  
@ptgoetz 
Could you make the change for master branch? Maybe 1.0.x branch too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #2000: STORM-2411 Setting topology.eventlogger.executors=...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/storm/pull/2000


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #2002: [STORM-2410]modify Trident-state.md

[HeartSaVioR]

Github user HeartSaVioR commented on the issue:

https://github.com/apache/storm/pull/2002
  
+1
Please clean up your commits. I think only a commit is sufficient.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #2000: STORM-2411 Setting topology.eventlogger.executors=0 in de...

[HeartSaVioR]

Github user HeartSaVioR commented on the issue:

https://github.com/apache/storm/pull/2000
  
+1 This makes consistent with 1.x branch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #2012: STORM-2419 - Fix storm-perf module's parent module...

[satishd]

Github user satishd closed the pull request at:

https://github.com/apache/storm/pull/2012


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #2007: Logger output Pattern for Integration-Tests/cluster.xml M...

[HeartSaVioR]

Github user HeartSaVioR commented on the issue:

https://github.com/apache/storm/pull/2007
  
@hmcl Thanks for the great work. I merged into master, 1.x, 1.0.x branches.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #2007: Logger output Pattern for Integration-Tests/cluste...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/storm/pull/2007


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #2020: STORM-2425: Storm Hive Bolt not closing open transactions

[satishd]

Github user satishd commented on the issue:

https://github.com/apache/storm/pull/2020
  
+1 LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #2016: STORM-2422: Reduce the size of a serialized triden...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/storm/pull/2016


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #2016: STORM-2422: Reduce the size of a serialized trident topol...

[HeartSaVioR]

Github user HeartSaVioR commented on the issue:

https://github.com/apache/storm/pull/2016
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #2020: STORM-2425: Storm Hive Bolt not closing open trans...

[arunmahadevan]

GitHub user arunmahadevan opened a pull request:

https://github.com/apache/storm/pull/2020

STORM-2425: Storm Hive Bolt not closing open transactions

Invoking `retireIdleWriters` when the hive bolt receives a tick tuple will 
periodically close the idle connections.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/arunmahadevan/storm STORM-2425

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/storm/pull/2020.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2020


commit 3ce63b8551bd710451308f5d6e140a1a622564e4
Author: Arun Mahadevan 
Date:   2017-03-16T06:46:10Z

STORM-2425: Storm Hive Bolt not closing open transactions

Invoking `retireIdleWriters` when the hive bolt receives a tick tuple will 
periodically close the idle connections.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #2018: STORM-2416: Improve Release Packaging to Reduce File Size

[HeartSaVioR]

Github user HeartSaVioR commented on the issue:

https://github.com/apache/storm/pull/2018
  
Looks great otherwise. I'd be +1 once build issue is fixed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #2018: STORM-2416: Improve Release Packaging to Reduce Fi...

[HeartSaVioR]

Github user HeartSaVioR commented on a diff in the pull request:

https://github.com/apache/storm/pull/2018#discussion_r106855963
  
--- Diff: examples/storm-perf/pom.xml ---
@@ -22,8 +22,8 @@
 
 storm
 org.apache.storm
-1.1.1-SNAPSHOT
-..
+1.1.0-SNAPSHOT
+../pom.xml
--- End diff --

@ptgoetz 
Fixing this to `../../pom.xml` resolved the error on `mvn clean install 
-DskipTests`. Please address this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #2005: STORM-2414 Skip checking meta's ACL when subject h...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/storm/pull/2005


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #2014: STORM-2038: Disable symlinks with a config option ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/storm/pull/2014


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1974: STORM-2038: Disable symlinks with a config option

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/storm/pull/1974


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #2015: STORM-2038: Disable symlinks with a config option ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/storm/pull/2015


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #2005: STORM-2414 Skip checking meta's ACL when subject has writ...

[satishd]

Github user satishd commented on the issue:

https://github.com/apache/storm/pull/2005
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #2005: STORM-2414 Skip checking meta's ACL when subject h...

[HeartSaVioR]

Github user HeartSaVioR commented on a diff in the pull request:

https://github.com/apache/storm/pull/2005#discussion_r106837872
  
--- Diff: 
storm-core/src/jvm/org/apache/storm/blobstore/LocalFsBlobStore.java ---
@@ -219,17 +219,37 @@ public void setBlobMeta(String key, SettableBlobMeta 
meta, Subject who) throws A
 @Override
 public void deleteBlob(String key, Subject who) throws 
AuthorizationException, KeyNotFoundException {
 validateKey(key);
-checkForBlobOrDownload(key);
-SettableBlobMeta meta = getStoredBlobMeta(key);
-_aclHandler.hasPermissions(meta.get_acl(), WRITE, who, key);
+
+if (!_aclHandler.checkForValidUsers(who, WRITE)) {
+// need to get ACL from meta
+checkForBlobOrDownload(key);
+SettableBlobMeta meta = getStoredBlobMeta(key);
+_aclHandler.hasPermissions(meta.get_acl(), WRITE, who, key);
+} else {
+// able to delete the blob without checking meta's ACL
--- End diff --

Same as above.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #2005: STORM-2414 Skip checking meta's ACL when subject h...

[HeartSaVioR]

Github user HeartSaVioR commented on a diff in the pull request:

https://github.com/apache/storm/pull/2005#discussion_r106837874
  
--- Diff: 
storm-core/src/jvm/org/apache/storm/blobstore/LocalFsBlobStore.java ---
@@ -219,17 +219,37 @@ public void setBlobMeta(String key, SettableBlobMeta 
meta, Subject who) throws A
 @Override
 public void deleteBlob(String key, Subject who) throws 
AuthorizationException, KeyNotFoundException {
 validateKey(key);
-checkForBlobOrDownload(key);
-SettableBlobMeta meta = getStoredBlobMeta(key);
-_aclHandler.hasPermissions(meta.get_acl(), WRITE, who, key);
+
+if (!_aclHandler.checkForValidUsers(who, WRITE)) {
+// need to get ACL from meta
+checkForBlobOrDownload(key);
+SettableBlobMeta meta = getStoredBlobMeta(key);
+_aclHandler.hasPermissions(meta.get_acl(), WRITE, who, key);
+} else {
+// able to delete the blob without checking meta's ACL
+// skip checking everything and continue deleting local files
+}
+
 try {
-fbs.deleteKey(DATA_PREFIX+key);
-fbs.deleteKey(META_PREFIX+key);
+deleteKeyIgnoringFileNotFound(DATA_PREFIX + key);
+deleteKeyIgnoringFileNotFound(META_PREFIX + key);
 } catch (IOException e) {
 throw new RuntimeException(e);
 }
 }
 
+private void deleteKeyIgnoringFileNotFound(String key) throws 
IOException {
+try {
+fbs.deleteKey(key);
+} catch (IOException e) {
+if (e instanceof FileNotFoundException) {
+// ignoring
--- End diff --

Same as above.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #2005: STORM-2414 Skip checking meta's ACL when subject h...

[HeartSaVioR]

Github user HeartSaVioR commented on a diff in the pull request:

https://github.com/apache/storm/pull/2005#discussion_r106837869
  
--- Diff: 
storm-core/src/jvm/org/apache/storm/blobstore/LocalFsBlobStore.java ---
@@ -219,17 +219,37 @@ public void setBlobMeta(String key, SettableBlobMeta 
meta, Subject who) throws A
 @Override
 public void deleteBlob(String key, Subject who) throws 
AuthorizationException, KeyNotFoundException {
 validateKey(key);
-checkForBlobOrDownload(key);
-SettableBlobMeta meta = getStoredBlobMeta(key);
-_aclHandler.hasPermissions(meta.get_acl(), WRITE, who, key);
+
+if (!_aclHandler.checkForValidUsers(who, WRITE)) {
+// need to get ACL from meta
--- End diff --

@arunmahadevan Will leave log message with debug level since it's useful 
for debugging. Please let me know if you would like to raise level to INFO or 
so.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---