[GitHub] storm issue #2660: STORM-3056: Add a test for quickly rebinding to a port
Github user raghavgautam commented on the issue: https://github.com/apache/storm/pull/2660 @ghajos Ping. ---
[GitHub] storm pull request #2714: STORM-3101: Add filter to StormMetricsRegistry.
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2714#discussion_r195246920
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -73,6 +130,12 @@ private static void
startMetricsReporter(PreparableReporter reporter, Map T register(String name, T metric) {
+if (source != null && !name.startsWith(source)) {
--- End diff --
I was originally thinking so but then I found out there are some other
components not specified as 'daemon' in DaemonType but also using metrics, such
as logviewer and RocksDB. I wasn't sure how to handle the case so internally I
convert them all to String. It's possible to register both with a Daemon and
with a name in String.
---
[GitHub] storm pull request #2714: STORM-3101: Add filter to StormMetricsRegistry.
Github user agresch commented on a diff in the pull request:
https://github.com/apache/storm/pull/2714#discussion_r195243886
--- Diff:
storm-server/src/main/java/org/apache/storm/metric/StormMetricsRegistry.java ---
@@ -73,6 +130,12 @@ private static void
startMetricsReporter(PreparableReporter reporter, Map T register(String name, T metric) {
+if (source != null && !name.startsWith(source)) {
--- End diff --
I think it would be better to register with a Daemon type enum and metric
name. This would allows metrics that are daemon specific and general to work
for a given daemon.
---
[GitHub] storm pull request #2718: STORM-3103 allow nimbus to shutdown properly
GitHub user agresch opened a pull request: https://github.com/apache/storm/pull/2718 STORM-3103 allow nimbus to shutdown properly Nimbus registers exitProcess() for the StormTimer.onKill routine. This does not return once called. This basically locks up the timer with active being set. Then when Nimbus shuts down, it calls timer.close(). Since the timer is stuck in the onKill routine forever with active set on, timer close is deadlocked waiting for the join() to occur here: https://github.com/apache/storm/blob/master/storm-client/src/jvm/org/apache/storm/StormTimer.java#L173 The proposed fix is to just set active to false before calling the onKill() for the timer. You can merge this pull request into a Git repository by running: $ git pull https://github.com/agresch/storm agresch_timer Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/2718.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2718 commit 5c5d071305785fb322413b0a39d3fb6d19a83a9d Author: Aaron Gresch Date: 2018-06-13T20:31:15Z STORM-3103 allow nimbus to shutdown properly ---
[GitHub] storm issue #2715: STORM-3102 Remove check for partition offset before every...
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2715 +1 ---
[GitHub] storm issue #2717: Bugfix/storm 3102 kafka client performance storm 1.x
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2717 +1. Please squash to one commit. ---
[GitHub] storm issue #2716: STORM-3102 Remove check for partition offset before every...
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2716 +1 ---
[GitHub] storm pull request #2716: STORM-3102 Remove check for partition offset befor...
GitHub user acseidel opened a pull request: https://github.com/apache/storm/pull/2716 STORM-3102 Remove check for partition offset before every emit. In kafka >0.10.2 this check became expensive, causing large performance decreases. You can merge this pull request into a Git repository by running: $ git pull https://github.com/acseidel/storm bugfix/STORM-3102-kafka-client-performance-storm-2.0.0 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/2716.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2716 commit 0eb6cd72c07a12499eb12f5830a80c1da1bdfaa0 Author: Andy Seidel Date: 2018-06-13T18:29:07Z STORM-3102 Remove check for partition offset before every emit. IN kafka >0.10.2 this check became expensive, causing large performance decreases. ---
[GitHub] storm pull request #2717: Bugfix/storm 3102 kafka client performance storm 1...
GitHub user acseidel opened a pull request: https://github.com/apache/storm/pull/2717 Bugfix/storm 3102 kafka client performance storm 1.x In kafka >0.10.2 this check became expensive, causing large performance decreases. You can merge this pull request into a Git repository by running: $ git pull https://github.com/acseidel/storm bugfix/STORM-3102-kafka-client-performance-storm-1.x Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/2717.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2717 commit f84e89ea50bd7ab1a5464d247c1d5f45916e5734 Author: Andy Seidel Date: 2018-06-13T18:29:07Z STORM-3102 Remove check for partition offset before every emit. IN kafka >0.10.2 this check became expensive, causing large performance decreases. commit 614cfb44e03daef6ec93b1367ee5447bba5a08a7 Author: Andy Seidel Date: 2018-06-13T19:00:12Z Remove merge conflict. ---
[GitHub] storm pull request #2715: STORM-3102 Remove check for partition offset befor...
GitHub user acseidel opened a pull request: https://github.com/apache/storm/pull/2715 STORM-3102 Remove check for partition offset before every emit. IN kafka >0.10.2 this check became expensive, causing large performance decreases. You can merge this pull request into a Git repository by running: $ git pull https://github.com/acseidel/storm bugfix/STORM-3102-kafka-client-performance-storm-1.1.x Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/2715.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2715 commit a3859f759a7592a9db5e6bf0a8f97aa932320bf8 Author: Andy Seidel Date: 2018-06-13T18:29:07Z STORM-3102 Remove check for partition offset before every emit. IN kafka >0.10.2 this check became expensive, causing large performance decreases. ---
[GitHub] storm pull request #2712: Update Multilang-protocol.md
Github user MaurGi commented on a diff in the pull request: https://github.com/apache/storm/pull/2712#discussion_r195140675 --- Diff: docs/Multilang-protocol.md --- @@ -7,6 +7,18 @@ This page explains the multilang protocol as of Storm 0.7.1. Versions prior to 0 # Storm Multi-Language Protocol +## Supported Lanugages + +Storm Multi-Language has implementation in the following languages: + +- [JavaScript](../storm-multilang/javascript) --- End diff -- got it - fixed, thanks ---
[GitHub] storm issue #2712: Update Multilang-protocol.md
Github user MaurGi commented on the issue: https://github.com/apache/storm/pull/2712 thanks for the feedback, modified and resubmitted - ---
[GitHub] storm issue #2714: STORM-3101: Add filter to StormMetricsRegistry.
Github user zd-project commented on the issue: https://github.com/apache/storm/pull/2714 Some questions: 1. Currently, by rejecting a metric, StormMetricsRegistry simply discard it and log the warning without throwing any errors to the calling method/classes. Is this an appropriate practice? 2. Should we instead use a secondary registry for filtering and reporting only, apart from the primary which does include all registrations? 3. Not sure how to handle RocksDB metrics as it isn't technically a daemon. ---
[GitHub] storm pull request #2714: STORM-3101: Add filter to StormMetricsRegistry.
GitHub user zd-project opened a pull request: https://github.com/apache/storm/pull/2714 STORM-3101: Add filter to StormMetricsRegistry. The current implementation is based on the idea to set a source for a certain process. All the metrics not belonging to the source (e.g., supervisor) will be removed or rejected. This implementation also adds in the utility method for naming a metric. You can merge this pull request into a Git repository by running: $ git pull https://github.com/zd-project/storm STORM-3101 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/2714.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2714 ---
[GitHub] storm pull request #2713: [STORM-3094] : Added topology name validation at c...
GitHub user ManoharVanam opened a pull request: https://github.com/apache/storm/pull/2713 [STORM-3094] : Added topology name validation at client side Current Behavior : Execute topology with invalid topology name is throwing exception after uploading the jar. Improvement : Validating topology name at client side before uploading the jar. Note : Back porting STORM-3094-fix from master to 1.x-branch You can merge this pull request into a Git repository by running: $ git pull https://github.com/ManoharVanam/storm storm-3094-1x Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/2713.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2713 commit 20333545ca256b90bc3dbb9a0c3ee321d8e9d086 Author: Manohar Vanam Date: 2018-06-13T14:08:04Z [STORM-3094] : Added topology name validation at client side ---
[GitHub] storm pull request #2712: Update Multilang-protocol.md
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2712#discussion_r195078534 --- Diff: docs/Multilang-protocol.md --- @@ -7,6 +7,18 @@ This page explains the multilang protocol as of Storm 0.7.1. Versions prior to 0 # Storm Multi-Language Protocol +## Supported Lanugages + +Storm Multi-Language has implementation in the following languages: + +- [JavaScript](../storm-multilang/javascript) --- End diff -- The docs will be compiled as html and placed to website, so docs should not refer outside of docs directory. You can describe maven artifacts instead, like * Javascript: org.apache.storm / multilang-javascript * Python: org.apache.storm / multilang-python * Ruby: org.apache.storm / multilang-ruby ---
[GitHub] storm pull request #2703: [STORM-3094] : Added topology name validation at c...
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2703 ---
[GitHub] storm issue #2636: 1.1.x branch - Add SSL functionality
Github user danny0405 commented on the issue: https://github.com/apache/storm/pull/2636 @cfriaszapater Ok, look forward to your master branch patch. ---
[GitHub] storm issue #2636: 1.1.x branch - Add SSL functionality
Github user cfriaszapater commented on the issue: https://github.com/apache/storm/pull/2636 Hi danny0405, In response to HeartSaVioR, I said: > I'll try to do that pull request in the future to master branch. > I did this to 1.1.x branch because we use it in our organization. So, I understand I should close this pull request to 1.1.x branch, and do one to master branch. Anyway, we use 1.1 branch version of storm-cassandra with the changes, and they work fine. I don't know why other storm modules build fails. I will try on master branch if I have time... Regards. ---
[GitHub] storm pull request #2636: 1.1.x branch - Add SSL functionality
Github user cfriaszapater closed the pull request at: https://github.com/apache/storm/pull/2636 ---
