[GitHub] storm pull request: STORM-822: Kafka Spout New Consumer API
Github user connieyang commented on the pull request: https://github.com/apache/storm/pull/1131#issuecomment-78362 Following the Trident API support for the new KafkaSpout implementation... Is anyone working on this? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-822: Kafka Spout New Consumer API
Github user connieyang commented on the pull request: https://github.com/apache/storm/pull/1131#issuecomment-204615040 +1 for merging and thanks for work @hmcl. @hmcl The previous KafkaSpout implementation publishes a kafkaOffset metrics to track spout lag, latest time offset and earliest time offset. I can't seem to find the same or the equivalent metrics in the new implementation. Am I missing something. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-822: Kafka Spout New Consumer API
Github user connieyang commented on the pull request: https://github.com/apache/storm/pull/1131#issuecomment-202527934 @harshach @revans2 @abhishekagarwal87 Any comments? @hmcl Thanks for the work. I assume that this does not have the required changes for Trident. So, would it come in a separate patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-822: Kafka Spout New Consumer API
Github user connieyang commented on the pull request: https://github.com/apache/storm/pull/1131#issuecomment-190326611 @revans2 @tgravescs , comments? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-822: Kafka Spout New Consumer API
Github user connieyang commented on the pull request: https://github.com/apache/storm/pull/1131#issuecomment-187287074 +1 on Trident support. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-822 Implement Kafka 0.9 consumer API
Github user connieyang commented on the pull request: https://github.com/apache/storm/pull/986#issuecomment-181711832 @hmcl, any update to your patch? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-822 Implement Kafka 0.9 consumer API
Github user connieyang commented on the pull request: https://github.com/apache/storm/pull/986#issuecomment-173744934 I too agree that STORM-1015 is beyond the scope of Kafka 0.9 uprev related changes. So, I think it makes sense to keep them separate. @hmcl, any ETA on the rewrite or uprev effort? Thanks much! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-822 Implement Kafka 0.9 consumer API
Github user connieyang commented on the pull request: https://github.com/apache/storm/pull/986#issuecomment-173354953 @hmcl Will your PR include the rev for Trident API to work with Kafka 0.9? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-822 Implement Kafka 0.9 consumer API
Github user connieyang commented on the pull request: https://github.com/apache/storm/pull/986#issuecomment-169437497 That's great! When will this pull request be merged to master? We need it as well. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-822 Implement Kafka 0.9 consumer API
Github user connieyang commented on the pull request: https://github.com/apache/storm/pull/986#issuecomment-169458814 Excellent! I will follow @hmcl for his PR. Thanks for the update! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
