[GitHub] storm pull request #1781: STORM-1369: Add MapState implementation to storm-c...
GitHub user mkoch1 opened a pull request: https://github.com/apache/storm/pull/1781 STORM-1369: Add MapState implementation to storm-cassandra. STORM-1369: Add MapState implementation to storm-cassandra. https://issues.apache.org/jira/browse/STORM-1369 You can merge this pull request into a Git repository by running: $ git pull https://github.com/ef-labs/storm master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/1781.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1781 commit 18014c3212b23f1d91b22d0717700574d4b75e05 Author: Magnus Koch Date: 2016-11-16T20:13:31Z Feature/storm 1369 on master (#1) STORM-1369: Add MapState implementation to storm-cassandra. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request #1782: Feature/storm 1369 (#2)
GitHub user mkoch1 opened a pull request: https://github.com/apache/storm/pull/1782 Feature/storm 1369 (#2) STORM-1369: Add MapState implementation to storm-cassandra. https://github.com/apache/storm/pull/1781 You can merge this pull request into a Git repository by running: $ git pull https://github.com/ef-labs/storm 1.0.x-branch Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/1782.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1782 commit 48c446810ac7dd8b6cc361bf1469b6bf5f9e96a7 Author: Magnus Koch Date: 2016-11-16T20:18:58Z Feature/storm 1369 (#2) STORM-1369: Add MapState implementation to storm-cassandra. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1781: STORM-1369: Add MapState implementation to storm-cassandr...
Github user mkoch1 commented on the issue: https://github.com/apache/storm/pull/1781 Pls note that mutliPut needs an update - will push commit today or tomorrow. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1781: STORM-1369: Add MapState implementation to storm-cassandr...
Github user mkoch1 commented on the issue: https://github.com/apache/storm/pull/1781 That should do it - the batching option has been removed from MapState, in favor of parallel processing with existing opaque and transactional logic to handle consistency. Cassandra batch statements are more trouble than they're worth. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1781: STORM-1369: Add MapState implementation to storm-cassandr...
Github user mkoch1 commented on the issue: https://github.com/apache/storm/pull/1781 Did not notice that, sorry. Replaced now with an external resource implementation. The code is not all that complex so it's not a big deal. One thing I should point out: I borrowed the base implementation from a different project, also under Apache 2.0 license. I've included their copyright line in the file: https://github.com/apache/storm/pull/1781/commits/e46496337af84a610ef742c8cf5988d8dab19e47#diff-a8ce0c2f5e3ce0193d3ebc49f54301fa Original code: https://github.com/spring-projects/spring-insight-plugins/blob/master/collection-plugins/cassandra12/src/test/java/com/springsource/insight/plugin/cassandra/embeded/EmbeddedCassandraService.java Please let me know if there are any issues with this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1781: STORM-1369: Add MapState implementation to storm-cassandr...
Github user mkoch1 commented on the issue: https://github.com/apache/storm/pull/1781 Rebase is done, sorry for the delay. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1781: STORM-1369: Add MapState implementation to storm-cassandr...
Github user mkoch1 commented on the issue: https://github.com/apache/storm/pull/1781 Squashed. I don't really see how this should cause any conflicts though. The only changes in existing code are a couple of namespace corrections (to avoid wildcard imports, as suggested earlier) and documentation. Other than that, it's all new code in new classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request #1782: Feature/storm 1369 (#2)
Github user mkoch1 closed the pull request at: https://github.com/apache/storm/pull/1782 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
