[GitHub] storm issue #2661: [STORM-3055] 1.1.x remove conext connection cache
Github user pczb commented on the issue: https://github.com/apache/storm/pull/2661 port corresponding change #2669 to 1.1.x ---
[GitHub] storm issue #2669: [STORM-3055] remove conext connection cache
Github user pczb commented on the issue: https://github.com/apache/storm/pull/2669 @srdo @revans2 thanks for your review, i just squash all commit in one ---
[GitHub] storm pull request #2669: [STORM-3055] remove conext connection cache
Github user pczb commented on a diff in the pull request: https://github.com/apache/storm/pull/2669#discussion_r18812 --- Diff: storm-client/src/jvm/org/apache/storm/messaging/IContext.java --- @@ -38,6 +38,7 @@ /** * This method establishes a server side connection + * implementation should return a new connection every call --- End diff -- remove bind specification, since the new and old netty context never cache server connections, server connections is add to array or map just for cleanup ---
[GitHub] storm issue #2669: [STORM-3055] remove conext connection cache
Github user pczb commented on the issue: https://github.com/apache/storm/pull/2669 @srdo add doc specification, i was wonder if we need remove synchronized when bind port @revans2 just as srdo says the connection will be closed by the worker before worker shutdown. i will squash all commit after review ---
[GitHub] storm pull request #2669: [STORM-3055] remove conext connection cache
Github user pczb commented on a diff in the pull request:
https://github.com/apache/storm/pull/2669#discussion_r188355473
--- Diff: storm-client/src/jvm/org/apache/storm/messaging/netty/Client.java
---
@@ -451,7 +451,6 @@ public int getPort() {
public void close() {
if (!closing) {
LOG.info("closing Netty Client {}", dstAddressPrefixedName);
-context.removeClient(dstHost, dstAddress.getPort());
--- End diff --
done
---
[GitHub] storm issue #2669: [STORM-3055] remove conext connection cache
Github user pczb commented on the issue: https://github.com/apache/storm/pull/2669 @revans2 could you help review this, i see your pull request #2436 is related to connection cache . and the travis fail is not related to this pr. ---
[GitHub] storm pull request #2669: [STORM-3055] remove conext connection cache
GitHub user pczb opened a pull request: https://github.com/apache/storm/pull/2669 [STORM-3055] remove conext connection cache workerState has already cache connection use supervisor_id + port and if context and worker both cache connection, there can be some problem describe in jira jira link: https://issues.apache.org/jira/browse/STORM-3055 You can merge this pull request into a Git repository by running: $ git pull https://github.com/pczb/storm dev Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/2669.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2669 commit 62f66cd3f1e39953391f36e2b01197a6bade4e5c Author: pczb Date: 2018-05-09T17:41:18Z remove context connection Signed-off-by: pczb ---
[GitHub] storm pull request #2661: [STORM-3055] remove conext connection cache
GitHub user pczb opened a pull request: https://github.com/apache/storm/pull/2661 [STORM-3055] remove conext connection cache worker has already cache connection use supervisor_id + port and if context and worker both cache the can be some problem describe in jira You can merge this pull request into a Git repository by running: $ git pull https://github.com/pczb/storm fix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/2661.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2661 commit 1167cf8dac670ab31f6159a68005cc65f393ddc1 Author: pczb Date: 2018-05-05T02:59:56Z remove conext connection cache ---
[GitHub] storm pull request #2286: STORM-2696: fix not poll bug when use manual commi...
Github user pczb closed the pull request at: https://github.com/apache/storm/pull/2286 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2286: STORM-2696: fix not poll bug when use manual commit
Github user pczb commented on the issue: https://github.com/apache/storm/pull/2286 duplicate with #2156 closed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request #2286: fix not poll bug when use manual commit
GitHub user pczb opened a pull request: https://github.com/apache/storm/pull/2286 fix not poll bug when use manual commit You can merge this pull request into a Git repository by running: $ git pull https://github.com/pczb/storm master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/2286.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2286 commit a5d333954cade20fe2ee3345e1c27c29528d72e6 Author: pczb Date: 2017-08-19T04:01:46Z fix not poll bug when use manual commit --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request #1934: STORM-2333: CGroup memory and CPU metrics
Github user pczb commented on a diff in the pull request:
https://github.com/apache/storm/pull/1934#discussion_r100485119
--- Diff: storm-core/src/jvm/org/apache/storm/metric/SystemBolt.java ---
@@ -85,14 +87,15 @@ public Object getValueAndReset() {
}
}
+@SuppressWarnings({ "unchecked", "rawtypes" })
@Override
-public void prepare(final Map stormConf, TopologyContext context,
OutputCollector collector) {
-if(_prepareWasCalled &&
!"local".equals(stormConf.get(Config.STORM_CLUSTER_MODE))) {
+public void prepare(final Map topoConf, TopologyContext context,
OutputCollector collector) {
+if(_prepareWasCalled &&
!"local".equals(topoConf.get(Config.STORM_CLUSTER_MODE))) {
throw new RuntimeException("A single worker should have 1
SystemBolt instance.");
}
_prepareWasCalled = true;
--- End diff --
is storm prepare method thread safe?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1892: remove unused import in module kafkaclient
GitHub user pczb opened a pull request: https://github.com/apache/storm/pull/1892 remove unused import in module kafkaclient just remove some unused import and all tests passed You can merge this pull request into a Git repository by running: $ git pull https://github.com/pczb/storm master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/1892.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1892 commit 8ab4fd05ed5ed95c7a5bb7356fe228c14a8d86d7 Author: zhangbiao3 Date: 2017-01-24T12:49:17Z remove unused import --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
