Re: [GitHub] [storm] rzo1 commented on pull request #3556: Missing dependency prevents Storm from being built, fixes #3940
I think it may be safe to exclude this dependency. However, we know that currently storm builds with github actions. On 2023/08/01 16:14:08 "rzo1 (via GitHub)" wrote: > > rzo1 commented on PR #3556: > URL: https://github.com/apache/storm/pull/3556#issuecomment-1660648311 > >> This artifact is available on maven central. Is there a need to exclude > it? > https://mvnrepository.com/artifact/org.pentaho/pentaho-aggdesigner-algorithm/5.1.5-jhyde > >I think, that the actual problem is, that hive 2.3.9 declares the (dead) > conjars repo in > https://github.com/apache/hive/blob/rel/release-2.3.9/pom.xml#L225 > >Thus, Maven tries to use this repository (because it is declared on a > transient dependency) to download the repo and fails. Given that it is > already excluded in `storm-sql-runtime`, `storm-hive` and in > `storm-autocreds`, the changes by @jnioche just apply the excludes > systematically. If we run the GH actions, we will see, if the dependency is > required at runtime. > > > -- > This is an automated message from the Apache Git Service. > To respond to the message, please log on to GitHub and use the > URL above to go to the specific comment. > > To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org > > For queries about this service, please contact Infrastructure at: > us...@infra.apache.org > >
[GitHub] [storm] rzo1 commented on pull request #3556: Missing dependency prevents Storm from being built, fixes #3940
rzo1 commented on PR #3556: URL: https://github.com/apache/storm/pull/3556#issuecomment-1660648311 > This artifact is available on maven central. Is there a need to exclude it? https://mvnrepository.com/artifact/org.pentaho/pentaho-aggdesigner-algorithm/5.1.5-jhyde I think, that the actual problem is, that hive 2.3.9 declares the (dead) conjars repo in https://github.com/apache/hive/blob/rel/release-2.3.9/pom.xml#L225 Thus, Maven tries to use this repository (because it is declared on a transient dependency) to download the repo and fails. Given that it is already excluded in `storm-sql-runtime`, `storm-hive` and in `storm-autocreds`, the changes by @jnioche just apply the excludes systematically. If we run the GH actions, we will see, if the dependency is required at runtime. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
