[GitHub] storm issue #1337: STORM-1475: Add storm-elasticsearch2 module

2016-10-04 Thread knusbaum 
Github user knusbaum commented on the issue:

https://github.com/apache/storm/pull/1337
  
#1676 is a no-go. We need guava in storm-core.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1337: STORM-1475: Add storm-elasticsearch2 module

2016-09-20 Thread HeartSaVioR 
Github user HeartSaVioR commented on the issue:

https://github.com/apache/storm/pull/1337
  
@dossett 
ES2 doesn't shade their Guava dependency? I guess ES1 is doing that.
I'm not sure we're OK to upgrade Guava version only for this, but there's 
another PR which gets rid of Guava from storm-core, so it might be OK. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---