[GitHub] storm issue #1445: [STORM-1277] port backtype.storm.daemon.executor to java
Github user abhishekagarwal87 commented on the issue: https://github.com/apache/storm/pull/1445 Hi @unsleepy22 . Going through the code, I still think sendUnanchored and sendToEventsLogger should be moved to superclass. ackSpoutMsg/failSpoutMsg should move to SpoutExecutor class. ExecutorData can be merged with BaseExecutor class since executor data is common to both spout and bolt. Once that happens, executor object can be passed around e.g. ``` public SpoutOutputCollectorImpl(ISpout spout, SpoutExecutor executorData ``` Other than that, translation looks good (done with first pass). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1445: [STORM-1277] port backtype.storm.daemon.executor to java
Github user unsleepy22 commented on the issue: https://github.com/apache/storm/pull/1445 @abhishekagarwal87 thanks again for your review, all comments addressed except for ones explained inline above. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1445: [STORM-1277] port backtype.storm.daemon.executor to java
Github user unsleepy22 commented on the issue: https://github.com/apache/storm/pull/1445 @abhishekagarwal87 could you help review again? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1445: [STORM-1277] port backtype.storm.daemon.executor to java
Github user abhishekagarwal87 commented on the issue: https://github.com/apache/storm/pull/1445 @unsleepy22 - I wasn't able to get time. I will try to do it by today. Thank you for your patience. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1445: [STORM-1277] port backtype.storm.daemon.executor to java
Github user unsleepy22 commented on the issue: https://github.com/apache/storm/pull/1445 @abhishekagarwal87 no hurry, please take your time~ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1445: [STORM-1277] port backtype.storm.daemon.executor to java
Github user satishd commented on the issue: https://github.com/apache/storm/pull/1445 @unsleepy22 Can you resolve the conflicts by upmerging latest sources? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1445: [STORM-1277] port backtype.storm.daemon.executor to java
Github user unsleepy22 commented on the issue: https://github.com/apache/storm/pull/1445 @satishd upmerged. Strange that `org.apache.storm.messaging.netty-unit-test` fails while all tests including ut & integration tests pass on my mac. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1445: [STORM-1277] port backtype.storm.daemon.executor to java
Github user unsleepy22 commented on the issue: https://github.com/apache/storm/pull/1445 @hustfxj could you take a look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1445: [STORM-1277] port backtype.storm.daemon.executor to java
Github user unsleepy22 commented on the issue: https://github.com/apache/storm/pull/1445 @harshach thanks for your comments, all updated. I also made some changes to code format/styles in StormCommon.java, if that's ok. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1445: [STORM-1277] port backtype.storm.daemon.executor to java
Github user unsleepy22 commented on the issue: https://github.com/apache/storm/pull/1445 @HeartSaVioR thanks for the review, addressed, please help review again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1445: [STORM-1277] port backtype.storm.daemon.executor to java
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1445 @unsleepy22 Sure. I'll level another comment when I finish review for the first pass. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1445: [STORM-1277] port backtype.storm.daemon.executor to java
Github user unsleepy22 commented on the issue: https://github.com/apache/storm/pull/1445 @HeartSaVioR your comments are addressed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1445: [STORM-1277] port backtype.storm.daemon.executor to java
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1445 I've done reviewing with first pass. Great work. This is rather huge diff so the more reviewers the better reviewing. Please go on reviewing everybody. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1445: [STORM-1277] port backtype.storm.daemon.executor to java
Github user unsleepy22 commented on the issue: https://github.com/apache/storm/pull/1445 @HeartSaVioR thanks for your careful review, all comments addressed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1445: [STORM-1277] port backtype.storm.daemon.executor to java
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1445 I'd be +1 once behavior for spout-transfer-fn and bolt-transfer-fn are translated to same. Reviewers, please let me know if you think it is better to keep it as it is. @abhishekagarwal87 @satishd @harshach Do you plan to continue reviewing this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1445: [STORM-1277] port backtype.storm.daemon.executor to java
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1445 Builds are failing because of linq4j on calcite-core on storm-hive. ``` [ERROR] Failed to execute goal org.apache.maven.plugins:maven-remote-resources-plugin:1.2.1:process (default) on project storm-hive: Error resolving project artifact: Could not transfer artifact net.hydromatic:linq4j:pom:0.4 from/to sonatype-apache (https://repository.apache.org/releases/): Connect to repository.apache.org:443 [repository.apache.org/207.244.88.143] failed: Connection timed out for project net.hydromatic:linq4j:jar:0.4 ``` linq4j is not available on search.maven.org so it seems not intermittent issue, and seems like calcite has artifact `calcite-linq4j` starting from 1.0.0. So we might need to update version of calcite. @harshach Would I file an issue for this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1445: [STORM-1277] port backtype.storm.daemon.executor to java
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1445 This is open for over 2 months. I have one issue regarding this, but it's not that huge so I can file an issue and go on submitting pull request. Moreover, porting worker depends on this so it shouldn't be blocked too long. +1 for me, and I will merge this now. @unsleepy22 Thanks for your amazing work! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
