[GitHub] storm issue #1565: STORM-1970: external project examples refator
Github user vesense commented on the issue: https://github.com/apache/storm/pull/1565 I will add new external project examples (such as `storm-druid`, `storm-kinesis`) to the `examples` directory in a following up jira after this PR being merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1565: STORM-1970: external project examples refator
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1565 @vesense Thanks for the update. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1565: STORM-1970: external project examples refator
Github user vesense commented on the issue: https://github.com/apache/storm/pull/1565 @HeartSaVioR Could you take a look again? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1565: STORM-1970: external project examples refator
Github user vesense commented on the issue: https://github.com/apache/storm/pull/1565 Updated. the travis-ci build error is because that `Network is unreachable` for https://clojars.org. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1565: STORM-1970: external project examples refator
Github user vesense commented on the issue: https://github.com/apache/storm/pull/1565 Thanks @HeartSaVioR I see. Will update. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1565: STORM-1970: external project examples refator
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1565 @vesense You can refer pom.xml of storm-starter to see the trick. It determines whether we apply 'provided' or 'compile' via property and profile. https://github.com/apache/storm/blob/master/examples/storm-starter/pom.xml#L35 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1565: STORM-1970: external project examples refator
Github user vesense commented on the issue: https://github.com/apache/storm/pull/1565 hi @HeartSaVioR Of course, we should make sure that all examples are 'runnable'. >profile trick to change scope of 'storm-core' : other modules use 'intellij' profile Actually, I can't see what you mean.. >create fat jar for each project : change scope of external module to 'compile' Yes, I will change the scope to `compile` and add `maven-shade-plugin` for building a fat jar. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1565: STORM-1970: external project examples refator
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1565 I think we have to make sure that users can run example topologies with local and also remote. (Yes these modules are just examples but 'runnable' examples.) So it might be better to apply two things: - profile trick to change scope of 'storm-core' : other modules use 'intellij' profile - create fat jar for each project : change scope of external module to 'compile'. Is there a reason to set this to 'provided'? Other things look good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1565: STORM-1970: external project examples refator
Github user abhishekagarwal87 commented on the issue: https://github.com/apache/storm/pull/1565 +1 Post the conflicts merge. @HeartSaVioR - can you also take a look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1565: STORM-1970: external project examples refator
Github user vesense commented on the issue: https://github.com/apache/storm/pull/1565 @abhishekagarwal87 is this should be continue? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1565: STORM-1970: external project examples refator
Github user vesense commented on the issue: https://github.com/apache/storm/pull/1565 @abhishekagarwal87 Upmerged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1565: STORM-1970: external project examples refator
Github user abhishekagarwal87 commented on the issue: https://github.com/apache/storm/pull/1565 @vesense Thanks for your efforts. can you upmerge this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1565: STORM-1970: external project examples refator
Github user vesense commented on the issue: https://github.com/apache/storm/pull/1565 @abhishekagarwal87 Could you take a look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1565: STORM-1970: external project examples refator
Github user vesense commented on the issue: https://github.com/apache/storm/pull/1565 hi @darionyaphet sorry for the less information. this PR address @abhishekagarwal87 's topic from dev@ mailing list. >Right now the example topologies/classes for some external modules are being put up in the test folder itself. The problem I see is that, -> the example code isn't really test code so test folder isn't the right fit. -> people, who are looking for example code, may not find the example code. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1565: STORM-1970: external project examples refator
Github user darionyaphet commented on the issue: https://github.com/apache/storm/pull/1565 What is it doing ? Do you add more desc ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
