[GitHub] storm issue #1666: STORM-1459: allow not specifying producer properties in r...

2016-08-31 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue:

https://github.com/apache/storm/pull/1666
  
Great. Thanks for the quick update. +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] storm issue #1666: STORM-1459: allow not specifying producer properties in r...

2016-08-31 Thread manuzhang
Github user manuzhang commented on the issue:

https://github.com/apache/storm/pull/1666
  
@HeartSaVioR Updated.  I use "Kafka sink table" instead of "consumer" to 
avoid confusing with kafka consumer.  And I don't think `TBLPROPERTIES` is an 
option for "table as a producer" so I leave it out.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] storm issue #1666: STORM-1459: allow not specifying producer properties in r...

2016-08-31 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue:

https://github.com/apache/storm/pull/1666
  
+1 except minor documentation issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---