[GitHub] storm issue #2151: STORM-2542: Remove KafkaConsumer.subscribe API option, ma...
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2151 @harshach Yes, sorry I thought I'd make a separate JIRA for that so we could list the deprecation in 1.2.0 and the removal of these classes in 2.0.0. The PR is here https://github.com/apache/storm/pull/2224 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2151: STORM-2542: Remove KafkaConsumer.subscribe API option, ma...
Github user harshach commented on the issue: https://github.com/apache/storm/pull/2151 @srdo are we not planning on pushing this into 1.x-branch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2151: STORM-2542: Remove KafkaConsumer.subscribe API option, ma...
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2151 Thanks for the reviews. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2151: STORM-2542: Remove KafkaConsumer.subscribe API option, ma...
Github user harshach commented on the issue: https://github.com/apache/storm/pull/2151 +1. Thanks @srdo this looks great. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2151: STORM-2542: Remove KafkaConsumer.subscribe API option, ma...
Github user hmcl commented on the issue: https://github.com/apache/storm/pull/2151 @srdo Thanks for your diligence and awesome work refactoring this code. It just made it much better. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2151: STORM-2542: Remove KafkaConsumer.subscribe API option, ma...
Github user hmcl commented on the issue: https://github.com/apache/storm/pull/2151 @srdo I am +1 on this PR. Let's just clean the commits that that make it such that we this PR consist of three commits only. The first commit should be [STORM-2548 PR](https://github.com/apache/storm/pull/2155), the 2nd commit [STORM-2541 PR](https://github.com/apache/storm/pull/2150), plus its own commit moving classes into the appropriate packages. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2151: STORM-2542: Remove KafkaConsumer.subscribe API option, ma...
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2151 @hmcl No. I got no response on the mailing list, so now I'm trying here. I figure if anyone objects they'll be able to do so on this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2151: STORM-2542: Remove KafkaConsumer.subscribe API option, ma...
Github user hmcl commented on the issue: https://github.com/apache/storm/pull/2151 @srdo was this agreed upon ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2151: STORM-2542: Remove KafkaConsumer.subscribe API option, ma...
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2151 If this goes in I'll follow up with a PR against 1.x to deprecate the classes using `KafkaConsumer.subscribe` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
