[GitHub] storm issue #2239: [STORM-2655] fix: log users cannot view worker.log on Sto...

2017-07-26 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue:

https://github.com/apache/storm/pull/2239
  
@revans2 You're right. Let's postpone until someone raises an issue once 
more.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] storm issue #2239: [STORM-2655] fix: log users cannot view worker.log on Sto...

2017-07-26 Thread revans2
Github user revans2 commented on the issue:

https://github.com/apache/storm/pull/2239
  
@HeartSaVioR the biggest issue with addressing this on the 1.x branch is 
that the patch uses both a JDK8 specific feature (a default method in an 
interface) and breaks backwards compatibility with other IPrincipalToLocal 
plugins.

We could address this by having a static method that will create a 
principal that wraps the user name instead and passes that into the original 
PrincipalToLocal instance.  But it is not a clean port.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] storm issue #2239: [STORM-2655] fix: log users cannot view worker.log on Sto...

2017-07-26 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue:

https://github.com/apache/storm/pull/2239
  
+1

Maybe better to address this also for 1.x branch as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] storm issue #2239: [STORM-2655] fix: log users cannot view worker.log on Sto...

2017-07-24 Thread Ethanlm
Github user Ethanlm commented on the issue:

https://github.com/apache/storm/pull/2239
  
Tested it manually.

![image](https://user-images.githubusercontent.com/14900612/28543136-63cd9718-7084-11e7-9ba5-a3509cc8b13b.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---