[GitHub] storm issue #2309: (1.x) STORM-2724 Shutdown ExecutorService in WaterMarkEve...

2017-09-08 Thread HeartSaVioR 
Github user HeartSaVioR commented on the issue:

https://github.com/apache/storm/pull/2309
  
@srdo No problem :)


---

[GitHub] storm issue #2309: (1.x) STORM-2724 Shutdown ExecutorService in WaterMarkEve...

2017-09-08 Thread srdo 
Github user srdo commented on the issue:

https://github.com/apache/storm/pull/2309
  
+1 again. @HeartSaVioR I missed the master PR somehow, sorry about that.


---

[GitHub] storm issue #2309: (1.x) STORM-2724 Shutdown ExecutorService in WaterMarkEve...

2017-09-08 Thread arunmahadevan 
Github user arunmahadevan commented on the issue:

https://github.com/apache/storm/pull/2309
  
+1


---

[GitHub] storm issue #2309: (1.x) STORM-2724 Shutdown ExecutorService in WaterMarkEve...

2017-09-07 Thread HeartSaVioR 
Github user HeartSaVioR commented on the issue:

https://github.com/apache/storm/pull/2309
  
@srdo Addressed review comments.


---

[GitHub] storm issue #2309: (1.x) STORM-2724 Shutdown ExecutorService in WaterMarkEve...

2017-09-07 Thread HeartSaVioR 
Github user HeartSaVioR commented on the issue:

https://github.com/apache/storm/pull/2309
  
@srdo 
Unfortunately we should always have two PRs for fixing storm-client or 
storm-server or storm-core because master and 1.x version lines are diverged.


---