[GitHub] storm issue #2385: STORM-2727: Generic Resource Aware Scheduling
Github user govind-menon commented on the issue: https://github.com/apache/storm/pull/2385 @HeartSaVioR Thank you - I will change the commit and PR titles. ---
[GitHub] storm issue #2385: STORM-2727: Generic Resource Aware Scheduling
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2385 @govind-menon I'm not familiar with RAS and I think +1 from @revans2 is sufficient. Two suggestions: * Please remove starting 'Y' from commit title, as you're submitting patch to Apache Storm project. * Please change both the commit title and the title of PR to STORM-2725 if the PR covers STORM-2725 and STORM-2725 can be closed after the patch is merged. ---
[GitHub] storm issue #2385: STORM-2727: Generic Resource Aware Scheduling
Github user govind-menon commented on the issue: https://github.com/apache/storm/pull/2385 Thanks @revans2 ! @HeartSaVioR could you take a look? ---
[GitHub] storm issue #2385: STORM-2727: Generic Resource Aware Scheduling
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2385 @govind-menon could you please squash all of the commits? ---
[GitHub] storm issue #2385: STORM-2727: Generic Resource Aware Scheduling
Github user govind-menon commented on the issue: https://github.com/apache/storm/pull/2385 @HeartSaVioR this PR should cover STORM-2725 (which covers STORM-2727). I apologize for the confusion - I was planning this as several PRs and it snowballed into one big PR. ---
[GitHub] storm issue #2385: STORM-2727: Generic Resource Aware Scheduling
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2385 Just a curious: Does this patch address only STORM-2727, or all the things in STORM-2725? The prefix of title of PR is STORM-2727, but the content is STORM-2725 (more clear, just a epic name). ---