[GitHub] storm issue #2419: STORM-2805: Clean up confs in TopologyBuilders

2017-11-17 Thread srdo 
Github user srdo commented on the issue:

https://github.com/apache/storm/pull/2419
  
Thanks, happy to help :)


---

[GitHub] storm issue #2419: STORM-2805: Clean up confs in TopologyBuilders

2017-11-17 Thread revans2 
Github user revans2 commented on the issue:

https://github.com/apache/storm/pull/2419
  
@srdo thanks for the review you found a lot of bugs and made this a lot 
better.


---

[GitHub] storm issue #2419: STORM-2805: Clean up confs in TopologyBuilders

2017-11-17 Thread srdo 
Github user srdo commented on the issue:

https://github.com/apache/storm/pull/2419
  
Thanks, +1


---

[GitHub] storm issue #2419: STORM-2805: Clean up confs in TopologyBuilders

2017-11-17 Thread revans2 
Github user revans2 commented on the issue:

https://github.com/apache/storm/pull/2419
  
@srdo I have fixed the issues you called out

@Ethanlm I fixed the issue you saw.


---

[GitHub] storm issue #2419: STORM-2805: Clean up confs in TopologyBuilders

2017-11-16 Thread revans2 
Github user revans2 commented on the issue:

https://github.com/apache/storm/pull/2419
  
@srdo I think I have addressed all of your comments.  I also found a few 
places were an NPE could happen, and one where the TopologyBuilder was not 
setting the resource configs correctly.  I fixed it and the corresponding test 
failures.


---