[GitHub] storm issue #2495: STORM-2867: Add consumer lag metrics to KafkaSpout

2018-01-03 Thread srdo 
Github user srdo commented on the issue:

https://github.com/apache/storm/pull/2495
  
I believe we don't need to wait 24 hours since this is just port work. Will 
merge shortly.


---

[GitHub] storm issue #2495: STORM-2867: Add consumer lag metrics to KafkaSpout

2018-01-03 Thread arunmahadevan 
Github user arunmahadevan commented on the issue:

https://github.com/apache/storm/pull/2495
  
@omkreddy , thanks for the patch. +1


---

[GitHub] storm issue #2495: STORM-2867: Add consumer lag metrics to KafkaSpout

2018-01-03 Thread omkreddy 
Github user omkreddy commented on the issue:

https://github.com/apache/storm/pull/2495
  
@srdo  squashed the  commits.


---

[GitHub] storm issue #2495: STORM-2867: Add consumer lag metrics to KafkaSpout

2018-01-03 Thread srdo 
Github user srdo commented on the issue:

https://github.com/apache/storm/pull/2495
  
Thanks, this looks good. 

+1, if you squash to one commit we should be able to merge soon. Please 
also squash the 1.x version.


---

[GitHub] storm issue #2495: STORM-2867: Add consumer lag metrics to KafkaSpout

2018-01-03 Thread omkreddy 
Github user omkreddy commented on the issue:

https://github.com/apache/storm/pull/2495
  
@srdo  Thanks for the review. Fixed the checkstyle issues.


---

[GitHub] storm issue #2495: STORM-2867: Add consumer lag metrics to KafkaSpout

2018-01-03 Thread srdo 
Github user srdo commented on the issue:

https://github.com/apache/storm/pull/2495
  
There are checkstyle violations, you can find the list in 
storm-kafka-client/target/checkstyle-violations.xml. Other than that this looks 
good.


---