[GitHub] storm issue #2634: [STORM-3021] Fix wrong usages of Config.TOPOLOGY_WORKERS ...

2018-04-29 Thread Ethanlm
Github user Ethanlm commented on the issue:

https://github.com/apache/storm/pull/2634
  
Not sure why the build failed. The build succeeded on my repo: 
https://travis-ci.org/Ethanlm/storm/builds/372073451


---


[GitHub] storm issue #2634: [STORM-3021] Fix wrong usages of Config.TOPOLOGY_WORKERS ...

2018-04-27 Thread Ethanlm
Github user Ethanlm commented on the issue:

https://github.com/apache/storm/pull/2634
  
rebased.


---


[GitHub] storm issue #2634: [STORM-3021] Fix wrong usages of Config.TOPOLOGY_WORKERS ...

2018-04-23 Thread Ethanlm
Github user Ethanlm commented on the issue:

https://github.com/apache/storm/pull/2634
  
@roshannaik I addressed your comments. Thanks for review. If it looks good, 
I will squash the commits and wait for merge


---


[GitHub] storm issue #2634: [STORM-3021] Fix wrong usages of Config.TOPOLOGY_WORKERS ...

2018-04-20 Thread Ethanlm
Github user Ethanlm commented on the issue:

https://github.com/apache/storm/pull/2634
  
The failed test should be unrelated


---


[GitHub] storm issue #2634: [STORM-3021] Fix wrong usages of Config.TOPOLOGY_WORKERS ...

2018-04-18 Thread Ethanlm
Github user Ethanlm commented on the issue:

https://github.com/apache/storm/pull/2634
  
@revans2  @roshannaik  Could you please take a look if you get a chance as 
we discussed about this in https://issues.apache.org/jira/browse/STORM-3021


---