[GitHub] storm issue #2637: STORM-3060: Map of Spout configurations from storm-kafka ...
Github user srishtyagrawal commented on the issue: https://github.com/apache/storm/pull/2637 @srdo thanks for taking care of this! ---
[GitHub] storm issue #2637: STORM-3060: Map of Spout configurations from storm-kafka ...
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2637 @srishtyagrawal I noticed that too, I think we can fix it by copying a bit of CSS from Github https://github.com/apache/storm-site/pull/5 ---
[GitHub] storm issue #2637: STORM-3060: Map of Spout configurations from storm-kafka ...
Github user srishtyagrawal commented on the issue: https://github.com/apache/storm/pull/2637 @srdo thanks a lot for publishing the docs, I see the changes but unfortunately the table is badly formatted. I will look into how to make this better whenever I have time next. ---
[GitHub] storm issue #2637: STORM-3060: Map of Spout configurations from storm-kafka ...
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2637 @srishtyagrawal We need to publish to https://github.com/apache/storm-site in order to update the live site. I'll try to get it done soon ---
[GitHub] storm issue #2637: STORM-3060: Map of Spout configurations from storm-kafka ...
Github user srishtyagrawal commented on the issue: https://github.com/apache/storm/pull/2637 @hmcl @srdo how often do we publish the docs for `2.0.0-SNAPSHOT`? Is it every time a document update is made to this repo? How do I request for this PR to be published in the 2.0.0 Storm docs? Also currently the [2.0.0-SNAPSHOT storm-kafka-client documentation link](http://storm.apache.org/releases/2.0.0-SNAPSHOT/storm-kafka-client.html) is broken. ---
[GitHub] storm issue #2637: STORM-3060: Map of Spout configurations from storm-kafka ...
Github user hmcl commented on the issue: https://github.com/apache/storm/pull/2637 +1 @srishtyagrawal thank you for your nice and helpful contribution. It will benefit a lot of users. ---
[GitHub] storm issue #2637: STORM-3060: Map of Spout configurations from storm-kafka ...
Github user srishtyagrawal commented on the issue: https://github.com/apache/storm/pull/2637 @hmcl thanks for the comments. I have edited the Kafka property links to point to the [Kafka New Consumer Configs table](http://kafka.apache.org/10/documentation.html#newconsumerconfigs), and have removed the description and defaults for those configs (included in the new link). I have created a JIRA ticket, [STORM-3060](https://issues.apache.org/jira/browse/STORM-3060), and added it to the PR and the commit title. The commits have been squashed and the PR is ready to be merged. ---
