[GitHub] storm issue #2710: STORM-3099: Extend metrics on supervisor, workers and DRP...
Github user Ethanlm commented on the issue: https://github.com/apache/storm/pull/2710 @zd-project Could you squash all the commits? Will merge this in. ---
[GitHub] storm issue #2710: STORM-3099: Extend metrics on supervisor, workers and DRP...
Github user Ethanlm commented on the issue: https://github.com/apache/storm/pull/2710 @HeartSaVioR @danny0405 Do you want to take a look again? Otherwise I think it's good to merge it. ---
[GitHub] storm issue #2710: STORM-3099: Extend metrics on supervisor, workers and DRP...
Github user zd-project commented on the issue: https://github.com/apache/storm/pull/2710 Should I squash to one per daemon? ---
[GitHub] storm issue #2710: STORM-3099: Extend metrics on supervisor, workers and DRP...
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2710 Also could we squash the commits some? ---
[GitHub] storm issue #2710: STORM-3099: Extend metrics on supervisor, workers and DRP...
Github user zd-project commented on the issue: https://github.com/apache/storm/pull/2710 Two more metrics for Supervisor - [x] Worker exceptions count for clean-up, kill and force-kill. - [x] Internal Error/Exception Cnt. on running external process/linux commands ---
[GitHub] storm issue #2710: STORM-3099: Extend metrics on supervisor, workers and DRP...
Github user zd-project commented on the issue: https://github.com/apache/storm/pull/2710 I'm kind of wondering whether decorator pattern is better than subclassing or not, for TimedPortAndAssignment, because itself is already a wrapper. ---
[GitHub] storm issue #2710: STORM-3099: Extend metrics on supervisor, workers and DRP...
Github user zd-project commented on the issue: https://github.com/apache/storm/pull/2710 Rebase completed with one new commit added. The new TimerDecoratedAssignment is incorporated. ---
[GitHub] storm issue #2710: STORM-3099: Extend metrics on supervisor, workers and DRP...
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2710 Could you please rebase? I'm expecting the code diff would be reduced after that. ---
[GitHub] storm issue #2710: STORM-3099: Extend metrics on supervisor, workers and DRP...
Github user zd-project commented on the issue: https://github.com/apache/storm/pull/2710 #2739 ---
[GitHub] storm issue #2710: STORM-3099: Extend metrics on supervisor, workers and DRP...
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2710 @zd-project Just 2 cents: I can see couple of other changes than the issue itself: please try to avoid side-effect on the patch. Let's file issues and raise pull requests if they're real issues. It's OK to just raise a pull request if you think the patch is minor. ---
[GitHub] storm issue #2710: STORM-3099: Extend metrics on supervisor, workers and DRP...
Github user zd-project commented on the issue: https://github.com/apache/storm/pull/2710 DRPC metrics: - [x] Avg/Max Time to respond to Http Request ---
