[GitHub] storm pull request: [STORM-1420] solr CountBasedCommit should rese...
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/978 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: [STORM-1420] solr CountBasedCommit should rese...
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/978#issuecomment-171244000 Thanks @revans2 @hmcl for your explaining. These changes are not necessary. I will close this issue as 'Not A Problem'. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: [STORM-1420] solr CountBasedCommit should rese...
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/978#issuecomment-170588179 @hmcl and @vesense these changes are not necessary. I pointed out here https://github.com/apache/storm/pull/977#issuecomment-169101930 that the commit API should probably be changed, because if we force a commit, things can get off from each other. Somehow that turned into this. I am -1 on this unless we also get changes to the Committer API too. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: [STORM-1420] solr CountBasedCommit should rese...
Github user hmcl commented on the pull request: https://github.com/apache/storm/pull/978#issuecomment-169828477 @vesense why is this change necessary? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: [STORM-1420] solr CountBasedCommit should rese...
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/978 [STORM-1420] solr CountBasedCommit should reset count=0 after commited https://issues.apache.org/jira/browse/STORM-1420 You can merge this pull request into a Git repository by running: $ git pull https://github.com/vesense/storm STORM-1420 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/978.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #978 commit 92b816f6c25d879c8a3239018955ac08682a6b3b Author: Xin Wang Date: 2015-12-25T11:07:34Z reset count=0 when committing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
