[GitHub] storm pull request: [STORM-975] Storm-Kafka trident topology examp...

2015-08-09 Thread arunmahadevan
Github user arunmahadevan commented on the pull request:

https://github.com/apache/storm/pull/666#issuecomment-129299716
  
@harshach added a new jira issue STORM-975



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] storm pull request: [STORM-975] Storm-Kafka trident topology examp...

2015-08-10 Thread harshach
Github user harshach commented on the pull request:

https://github.com/apache/storm/pull/666#issuecomment-129559848
  
@arunmahadevan can you upmerge this with master


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] storm pull request: [STORM-975] Storm-Kafka trident topology examp...

2015-08-10 Thread arunmahadevan
Github user arunmahadevan commented on the pull request:

https://github.com/apache/storm/pull/666#issuecomment-129708021
  
@harshach done


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] storm pull request: [STORM-975] Storm-Kafka trident topology examp...

2015-08-12 Thread harshach
Github user harshach commented on the pull request:

https://github.com/apache/storm/pull/666#issuecomment-130404466
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] storm pull request: [STORM-975] Storm-Kafka trident topology examp...

2015-08-14 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request:

https://github.com/apache/storm/pull/666#discussion_r37130096
  
--- Diff: 
examples/storm-starter/src/jvm/storm/starter/trident/TridentKafkaWordCount.java 
---
@@ -0,0 +1,208 @@
+package storm.starter.trident;
--- End diff --

@arunmahadevan Please add Apache License comments here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] storm pull request: [STORM-975] Storm-Kafka trident topology examp...

2015-08-14 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request:

https://github.com/apache/storm/pull/666#issuecomment-131276460
  
Other things look fine.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] storm pull request: [STORM-975] Storm-Kafka trident topology examp...

2015-08-14 Thread arunmahadevan
Github user arunmahadevan commented on a diff in the pull request:

https://github.com/apache/storm/pull/666#discussion_r37133083
  
--- Diff: 
examples/storm-starter/src/jvm/storm/starter/trident/TridentKafkaWordCount.java 
---
@@ -0,0 +1,208 @@
+package storm.starter.trident;
--- End diff --

@HeartSaVioR done.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] storm pull request: [STORM-975] Storm-Kafka trident topology examp...

2015-08-17 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request:

https://github.com/apache/storm/pull/666#issuecomment-131786154
  
+1. Tested on local machine.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] storm pull request: [STORM-975] Storm-Kafka trident topology examp...

2015-08-17 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/storm/pull/666


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---