[GitHub] storm pull request: STORM-535:setup 'java.library.path' for native...
Github user caofangkun closed the pull request at: https://github.com/apache/storm/pull/298 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-535:setup 'java.library.path' for native...
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/298#issuecomment-61857797 -1 The storm platform itself does not require any native libraries, and the config option should be sufficient. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-535:setup 'java.library.path' for native...
Github user caofangkun commented on the pull request: https://github.com/apache/storm/pull/298#issuecomment-61609994 @clockfly the storm platform itself may need some native lib or common native lib may be provided by storm server side --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-535:setup 'java.library.path' for native...
Github user Parth-Brahmbhatt commented on the pull request: https://github.com/apache/storm/pull/298#issuecomment-61685448 -1 on this. I don't see why the config option is not sufficient. The code seem to make an assumption that STORM_DIR\lib\nativ exists which is not true for windows. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-535:setup 'java.library.path' for native...
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/298#issuecomment-61713139 Just 2 cents. extrajars consists of jar, ~/.storm, storm dir/bin, which may not fit for linking dll or so (for JNI) which is already installed for other places. (Btw, is ~/.storm used for storing native library?) AFAIK we could link it without modifying storm, LD_LIBRARY_PATH (Linux) and PATH (Windows) so we already have option. Since I agree it's not sufficient to support both platforms (though it can fixed easily), I also think new path shouldn't in storm distribute directory. If we really need this, path should be fully flexible, not relative to storm dir. Because it can be harder for users to deploy their own library with Storm. (@caofangkun Did you think how you deploy your so file to Storm?) Regarding to PLATFORM distribution, it could be up to users to deploy their library which fit machine's architecture and OS. tl;dr. It seems to not convenient after applying PR, though current may be not convenient, but we can use OS environment to cover this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-535:setup 'java.library.path' for native...
GitHub user caofangkun opened a pull request: https://github.com/apache/storm/pull/298 STORM-535:setup 'java.library.path' for native-storm code if necessary You can merge this pull request into a Git repository by running: $ git pull https://github.com/caofangkun/apache-storm storm-535 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/298.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #298 commit a47223b763ce9b3cf54cd8f7e014159951ad8099 Author: caofangkun caofang...@gmail.com Date: 2014-10-17T04:04:44Z STORM-535:setup 'java.library.path' for native-storm code if necessary commit fb85c6cce20c761ef79656437f9d3e933bf54e00 Author: caofangkun caofang...@gmail.com Date: 2014-10-17T04:11:43Z STORM-535:setup 'java.library.path' for native-storm code if necessary --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
