[GitHub] storm pull request: STORM-786: KafkaBolt should ack tick tuples

2015-04-20 Thread revans2
Github user revans2 commented on the pull request:

https://github.com/apache/storm/pull/522#issuecomment-94575511
  
+1 looks good to me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] storm pull request: STORM-786: KafkaBolt should ack tick tuples

2015-04-20 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/storm/pull/522


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] storm pull request: STORM-786: KafkaBolt should ack tick tuples

2015-04-16 Thread miguno
GitHub user miguno opened a pull request:

https://github.com/apache/storm/pull/522

STORM-786: KafkaBolt should ack tick tuples

[STORM-512](https://issues.apache.org/jira/browse/STORM-512) (KafkaBolt 
doesn't handle ticks properly) adds special-casing of tick tuples. What is 
missing in the patch is that the input tuple, when it is a tick tuple, should 
be properly acked like normal tuples.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/miguno/storm STORM-786

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/storm/pull/522.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #522


commit dfe3fbe144ed6398c2d2cc6210454d4c561e042e
Author: Michael G. Noll mich...@michael-noll.com
Date:   2015-04-16T09:44:40Z

STORM-786: KafkaBolt should ack tick tuples




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---