[GitHub] storm pull request: STORM-913:Use Curator's delete().deletingChild...
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/615 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-913:Use Curator's delete().deletingChild...
Github user caofangkun commented on the pull request: https://github.com/apache/storm/pull/615#issuecomment-127095071 @revans2 Please don't forget check this PR in :ï¼ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-913:Use Curator's delete().deletingChild...
Github user caofangkun commented on the pull request: https://github.com/apache/storm/pull/615#issuecomment-122156319 @revans2 The whole usages call delete-node with ```:force true```, that is the ```:force ``` parameter is unneeded at all. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-913:Use Curator's delete().deletingChild...
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/615#issuecomment-122147057 -0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-913:Use Curator's delete().deletingChild...
Github user caofangkun commented on a diff in the pull request: https://github.com/apache/storm/pull/605#discussion_r33326733 --- Diff: pom.xml --- @@ -211,7 +211,7 @@ guava.version16.0.1/guava.version netty.version3.9.0.Final/netty.version log4j-over-slf4j.version1.6.6/log4j-over-slf4j.version -log4j.version2.1/log4j.version +log4j.version2.3/log4j.version --- End diff -- Thank you @HeartSaVioR I have removed this unnessary change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-913:Use Curator's delete().deletingChild...
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/605#discussion_r33326599 --- Diff: pom.xml --- @@ -211,7 +211,7 @@ guava.version16.0.1/guava.version netty.version3.9.0.Final/netty.version log4j-over-slf4j.version1.6.6/log4j-over-slf4j.version -log4j.version2.1/log4j.version +log4j.version2.3/log4j.version --- End diff -- Seems like it is unneeded change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-913:Use Curator's delete().deletingChild...
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/605#discussion_r33326992 --- Diff: storm-core/src/clj/backtype/storm/zookeeper.clj --- @@ -103,11 +103,14 @@ (catch Exception e (throw (wrap-in-runtime e)) (defnk delete-node --- End diff -- It silently does nothing when path is not exist, but it was throwing NoNodeException when force is false, and default is false. Only delete-recursive calls delete-node with force = true, and any other usages are using default. In short, it doesn't show same behavior between two. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-913:Use Curator's delete().deletingChild...
GitHub user caofangkun opened a pull request: https://github.com/apache/storm/pull/605 STORM-913:Use Curator's delete().deletingChildrenIfNeeded() instead of zk/delete-recursive You can merge this pull request into a Git repository by running: $ git pull https://github.com/caofangkun/apache-storm storm-913 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/605.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #605 commit 5d26820167e83358efbb4c05a03976d9c7ea Author: caofangkun caofang...@gmail.com Date: 2015-05-25T03:27:01Z Merge pull request #22 from apache/master Merge from apache/storm to caofangkun/apache-storm commit 5122dea1216c9b6125e8fd5364f90236c84ae196 Author: caofangkun caofang...@gmail.com Date: 2015-06-01T06:30:22Z Merge pull request #23 from apache/master Merge from apache/storm to caofangkun/apache-storm commit 0f71a7db32b47208ff7373e8b1c75f9f5ebaf9b4 Author: caofangkun caofang...@gmail.com Date: 2015-06-12T03:34:44Z Merge pull request #24 from apache/master Merge from apache/storm to caofangkun/apache-storm commit 03d276069797cc993c7078f7ece513802960d40d Author: caofangkun caofang...@gmail.com Date: 2015-06-17T02:22:13Z Merge pull request #25 from apache/master Merge from apache/storm to caofangkun/apache-storm commit 469b7f56f910bc9f9b8d3af7670f86fbdb5c53ed Author: caofangkun caofang...@gmail.com Date: 2015-06-23T03:22:20Z Merge pull request #26 from apache/master Merge from apache/storm to caofangkun/apache-storm commit dddaacbf51d37f97e072df0eed4d14c09cdda453 Author: caofangkun caofang...@gmail.com Date: 2015-06-26T02:28:32Z Merge pull request #27 from apache/master Merge from apache/storm to caofangkun/apache-storm commit 2a7cd49145edec776320c1f519fae6e9cf0a891c Author: caofangkun caofang...@gmail.com Date: 2015-06-26T03:12:27Z STORM-913:Use Curator's delete().deletingChildrenIfNeeded() instead of zk/delete-recursive --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-913:Use Curator's delete().deletingChild...
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/605#issuecomment-115492700 There're many unrelated commits. Could you get rid of these things? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-913:Use Curator's delete().deletingChild...
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/605#discussion_r33327176 --- Diff: storm-core/src/clj/backtype/storm/zookeeper.clj --- @@ -103,11 +103,14 @@ (catch Exception e (throw (wrap-in-runtime e)) (defnk delete-node --- End diff -- Oh, I got it. Whole usages are calling zk/delete-recursive so your changeset makes sense. My mistake. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
