[GitHub] storm pull request: STORM-945:DefaultRolloverStrategy element is...

2015-07-30 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request:

https://github.com/apache/storm/pull/638#issuecomment-126351254
  
+1. I confirmed that works with 0.11.x-SNAPSHOT. 
Since it is misconfiguration of log4j2 and it's introduced to 0.10.0-beta, 
we'd be better to apply it to 0.10.x-branch, too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] storm pull request: STORM-945:DefaultRolloverStrategy element is...

2015-07-30 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/storm/pull/638


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] storm pull request: STORM-945:DefaultRolloverStrategy element is...

2015-07-16 Thread caofangkun
GitHub user caofangkun opened a pull request:

https://github.com/apache/storm/pull/638

STORM-945:DefaultRolloverStrategy element is not a policy,and should not 
be putted in the Policies element

```
- storm-current  bin/storm nimbus
Running: /usr/share/jdk-current/bin/java -server -Ddaemon.name=nimbus ... 
...
2015-07-17 10:23:36,776 ERROR Policies has no parameter that matches 
element DefaultRolloverStrategy
2015-07-17 10:23:36,787 ERROR Policies has no parameter that matches 
element DefaultRolloverStrategy
2015-07-17 10:23:36,795 ERROR Policies has no parameter that matches 
element DefaultRolloverStrategy
```

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/caofangkun/apache-storm storm-945

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/storm/pull/638.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #638


commit 740f02ee0025cc0307a1422205f9612ce18d3652
Author: caofangkun caofang...@gmail.com
Date:   2015-07-17T03:35:11Z

STORM-945:DefaultRolloverStrategy element is not a policy,and should not 
be putted in the Policies element




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---