[GitHub] storm pull request: Storm 1379 Removed Redundant Structure

[darionyaphet]

Github user darionyaphet commented on the pull request:

https://github.com/apache/storm/pull/932#issuecomment-175084269
  
This issue have merged 
[STORM-1379](https://issues.apache.org/jira/browse/STORM-1379)  and close this 
pull request :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: Storm 1379 Removed Redundant Structure

[darionyaphet]

Github user darionyaphet closed the pull request at:

https://github.com/apache/storm/pull/932


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: Storm 1379 Removed Redundant Structure

[darionyaphet]

Github user darionyaphet commented on the pull request:

https://github.com/apache/storm/pull/932#issuecomment-171148741
  
hi @kishorvpatil I think I don't know how to resolve `merge conflicts`  and 
what should I do . 

Could you support some help? thanks 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: Storm 1379 Removed Redundant Structure

[kishorvpatil]

Github user kishorvpatil commented on the pull request:

https://github.com/apache/storm/pull/932#issuecomment-170591998
  
@darionyaphet Could you please take care of merge conflicts? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: Storm 1379 Removed Redundant Structure

[wuchong]

Github user wuchong commented on the pull request:

https://github.com/apache/storm/pull/932#issuecomment-167676628
  
The commits is  unimportant .  That's fine to  merge  It.

发自我的 iPhone

> 在 2015年12月29日，04:49，Derek Dagit  
写道：
> 
> @wuchong Is it OK to merge it in even with the minor commits?
> 
> —
> Reply to this email directly or view it on GitHub.
> 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: Storm 1379 Removed Redundant Structure

[d2r]

Github user d2r commented on the pull request:

https://github.com/apache/storm/pull/932#issuecomment-167652138
  
@wuchong Is it OK to merge it in even with the minor commits?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: Storm 1379 Removed Redundant Structure

[ptgoetz]

Github user ptgoetz commented on the pull request:

https://github.com/apache/storm/pull/932#issuecomment-163380100
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: Storm 1379 Removed Redundant Structure

[wuchong]

Github user wuchong commented on the pull request:

https://github.com/apache/storm/pull/932#issuecomment-163461026
  
+1
Could you rebase your commits into one? the last two commits change only 
one/two lines.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: Storm 1379 Removed Redundant Structure

[darionyaphet]

GitHub user darionyaphet opened a pull request:

https://github.com/apache/storm/pull/932

Storm 1379 Removed Redundant Structure

Storm KafkaSpout have a static class `MessageAndRealOffset` which is same 
with Kafka API 's `kafka.message.MessageAndOffset` . 

So I hava remove MessageAndRealOffset and replace with MessageAndOffset  :)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/darionyaphet/storm STORM-1379

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/storm/pull/932.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #932


commit fadf54f6e6e74e2b6ea1c297c6cd5124252c7fcd
Author: darionyaphet 
Date:   2015-10-15T03:34:07Z

upgrade kafka version 0.8.2.1 --> 0.8.2.2

commit 53a8cc0682170f7f455bdb1226a3e1999825c9ba
Author: yaphet 
Date:   2015-12-03T07:45:54Z

Merge pull request #1 from apache/master

merge request

commit 04338b09b1cb21ed5a3d5fc404e07b1e6a42bb56
Author: darionyaphet 
Date:   2015-12-08T10:53:07Z

Removed Redundant Structure

commit 523c845cd190b394e57fef67e1d2c21c8bd51424
Author: darionyaphet 
Date:   2015-12-08T11:08:36Z

remove import

commit fb360e2771431124144505f9972eee2cee97d375
Author: darionyaphet 
Date:   2015-12-08T11:20:18Z

recover to last version




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: Storm 1379 Removed Redundant Structure

[unsleepy22]

Github user unsleepy22 commented on the pull request:

https://github.com/apache/storm/pull/932#issuecomment-162923615
  
LGTM +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: Storm 1379 Removed Redundant Structure

[zhuoliu]

Github user zhuoliu commented on the pull request:

https://github.com/apache/storm/pull/932#issuecomment-163125770
  
Looks good. +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---