[GitHub] storm pull request: Update pom.xml
Github user vesense commented on the pull request: https://github.com/apache/storm/pull/599#issuecomment-169224710 Sorry I took so long to respond. It is convenient for multi-lang user to use FLUX just in one jar. As a minor issue, now, It is OK for me. In the past, I wanted to change the flux-wrappers scope because users using java did not need flux-wrappers. I will close this PR. Thanks @d2r @ptgoetz --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: Update pom.xml
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/599#issuecomment-168829281 -1 flux-wrappers add convenience multi-lang spout/bolt implementations. Arguably, they could be included in flux-core. I'd rather go that route than set flux-wrappers to test scope, which will make them unavailable for people who want them. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: Update pom.xml
Github user d2r commented on the pull request: https://github.com/apache/storm/pull/599#issuecomment-167627569 @vesense, could you create a Jira issue for this change and add it to the title of this pull request? What problem is the current scope causing here that needs to be fixed? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: Update pom.xml
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/599 Update pom.xml add flux-wrappers scope You can merge this pull request into a Git repository by running: $ git pull https://github.com/vesense/storm patch-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/599.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #599 commit 0d313587b34bfe3d55cf48e16f10abcbd6084b9f Author: Xin Wang best.wang...@163.com Date: 2015-06-19T06:57:13Z Update pom.xml add flux-wrappers scope --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
