[GitHub] storm pull request #1575: STORM-1600: Do not report exceptions after jvm shu...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/storm/pull/1575


---

[GitHub] storm pull request #1575: STORM-1600: Do not report exceptions after jvm shu...

[abellina]

Github user abellina commented on a diff in the pull request:

https://github.com/apache/storm/pull/1575#discussion_r71644658
  
--- Diff: storm-core/src/clj/org/apache/storm/daemon/executor.clj ---
@@ -205,15 +205,17 @@
  :report-error-and-die (reify
  Thread$UncaughtExceptionHandler
  (uncaughtException [this _ error]
-   (try
- ((:report-error <>) error)
- (catch Exception e
-   (log-error e "Error while reporting 
error to cluster, proceeding with shutdown")))
-   (if (or
-(Utils/exceptionCauseIsInstanceOf 
InterruptedException error)
-(Utils/exceptionCauseIsInstanceOf 
java.io.InterruptedIOException error))
- (log-message "Got interrupted excpetion 
shutting thread down...")
- ((:suicide-fn <>)
+   (if (Utils/isShutdownUnderProgress)
+ (log-warn error "Uncaught exception in 
thread after jvm shutdown")
+ ((try
+((:report-error <>) error)
+(catch Exception e
+  (log-error e "Error while reporting 
error to cluster, proceeding with shutdown")))
+   (if (or
+ (Utils/exceptionCauseIsInstanceOf 
InterruptedException error)
+ (Utils/exceptionCauseIsInstanceOf 
java.io.InterruptedIOException error))
+ (log-message "Got interrupted 
excpetion shutting thread down...")
--- End diff --

nitpick: fix spelling of exception.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1575: STORM-1600: Do not report exceptions after jvm shu...

[HeartSaVioR]

Github user HeartSaVioR commented on a diff in the pull request:

https://github.com/apache/storm/pull/1575#discussion_r71470446
  
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1772,6 +1783,7 @@ public static String uuid() {
 public static void exitProcess (int val, String msg) {
 String combinedErrorMessage = "Halting process: " + msg;
 LOG.error(combinedErrorMessage, new 
RuntimeException(combinedErrorMessage));
+isJVMShutdownInitiated.set(Boolean.TRUE);
--- End diff --

ShellSpout and ShellBolt just call System.exit() directly from their die() 
method. You may want to change those too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---