[GitHub] storm pull request #1940: STORM-2361 Kafka spout - after leader change, it s...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/storm/pull/1940


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1940: STORM-2361 Kafka spout - after leader change, it s...

[ernisv]

Github user ernisv commented on a diff in the pull request:

https://github.com/apache/storm/pull/1940#discussion_r105104946
  
--- Diff: 
external/storm-kafka/src/jvm/org/apache/storm/kafka/KafkaSpout.java ---
@@ -172,6 +187,12 @@ public void fail(Object msgId) {
 PartitionManager m = _coordinator.getManager(id.partition);
 if (m != null) {
 m.fail(id.offset);
+} {
--- End diff --

Right - fixed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1940: STORM-2361 Kafka spout - after leader change, it s...

[HeartSaVioR]

Github user HeartSaVioR commented on a diff in the pull request:

https://github.com/apache/storm/pull/1940#discussion_r105013260
  
--- Diff: 
external/storm-kafka/src/jvm/org/apache/storm/kafka/KafkaSpout.java ---
@@ -172,6 +187,12 @@ public void fail(Object msgId) {
 PartitionManager m = _coordinator.getManager(id.partition);
 if (m != null) {
 m.fail(id.offset);
+} {
--- End diff --

missing `else` between `} {`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1940: STORM-2361 Kafka spout - after leader change, it s...

[ernisv]

GitHub user ernisv opened a pull request:

https://github.com/apache/storm/pull/1940

STORM-2361 Kafka spout - after leader change, it stops committing offsets 
to ZK

Try to route acks/fails to recreated partition managers if manager is not 
found by exact (broker, partition, topic) combination

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ernisv/storm 
kafka-spout-leader-change-bug-2361

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/storm/pull/1940.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1940


commit fe141fd79a0c7f1ec9a191359f9ccd6eb7a34f4b
Author: Ernestas Vaiciukevicius 
Date:   2017-02-14T15:41:02Z

Try to route acks/fails to recreated partition managers if manager is not 
found by exact (broker, partition, topic) combination




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---