[GitHub] storm pull request #2029: STORM-2379: update for Elasticsearch 2.
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2029 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request #2029: STORM-2379: update for Elasticsearch 2.
Github user hmcc commented on a diff in the pull request:
https://github.com/apache/storm/pull/2029#discussion_r110770061
--- Diff: examples/storm-elasticsearch-examples/pom.xml ---
@@ -53,6 +54,11 @@
storm-elasticsearch
${project.version}
+
+org.elasticsearch
+elasticsearch
+${elasticsearch.test.version}
--- End diff --
@harshach I've added the provided scope, also rebased and squashed the
commits.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2029: STORM-2379: update for Elasticsearch 2.
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/2029#discussion_r110038799
--- Diff: examples/storm-elasticsearch-examples/pom.xml ---
@@ -53,6 +54,11 @@
storm-elasticsearch
${project.version}
+
+org.elasticsearch
+elasticsearch
+${elasticsearch.test.version}
--- End diff --
can you add the scope to provided. This will allow users to pick their own
version of elasticsearch2 while packaging the topology
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2029: STORM-2379: update for Elasticsearch 2.
GitHub user hmcc opened a pull request: https://github.com/apache/storm/pull/2029 STORM-2379: update for Elasticsearch 2. You can merge this pull request into a Git repository by running: $ git pull https://github.com/hmcc/storm STORM-2379 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/2029.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2029 commit 99e7670e17b514141f688a5fcb312e3f018bdab0 Author: Heather McCartney Date: 2017-03-13T13:16:27Z STORM-2379: update for Elasticsearch 2. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
