[GitHub] storm pull request #2215: STORM-2548: Simplify KafkaSpoutConfig (1.x)

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/storm/pull/2215


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #2215: STORM-2548: Simplify KafkaSpoutConfig (1.x)

[harshach]

Github user harshach commented on a diff in the pull request:

https://github.com/apache/storm/pull/2215#discussion_r127821694
  
--- Diff: 
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/SerializableDeserializer.java
 ---
@@ -16,10 +16,14 @@
 package org.apache.storm.kafka.spout;
 
 import java.io.Serializable;
+import org.apache.kafka.clients.consumer.ConsumerConfig;
 import org.apache.kafka.common.serialization.Deserializer;
 
 /**
  * @param  The type this deserializer deserializes to.
+ * @deprecated Avoid using this class. Use {@link 
KafkaSpoutConfig.Builder#setProp(java.lang.String, java.lang.Object) } with
+ * {@link ConsumerConfig#KEY_DESERIALIZER_CLASS_CONFIG} and {@link 
ConsumerConfig#VALUE_DESERIALIZER_CLASS_CONFIG} instead
  */
-public interface SerializableDeserializer extends Deserializer, 
Serializable { 
+@Deprecated
--- End diff --

why are we adding this back?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #2215: STORM-2548: Simplify KafkaSpoutConfig (1.x)

[srdo]

GitHub user srdo opened a pull request:

https://github.com/apache/storm/pull/2215

STORM-2548: Simplify KafkaSpoutConfig (1.x)

This should contain the same changes as 
https://github.com/apache/storm/pull/2155, but deprecates methods instead of 
removing them.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/srdo/storm STORM-2548-1.x

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/storm/pull/2215.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2215


commit 05e92683ec8907d3978298647fac16cae5e5b1f1
Author: Stig Rohde Døssing 
Date:   2017-06-28T20:28:04Z

STORM-2548: Simplify KafkaSpoutConfig to avoid duplicating KafkaConsumer 
configuration parameters




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---