[GitHub] storm pull request #2667: STORM-3063: Fix minor pom issues

2018-05-10 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/storm/pull/2667


---

[GitHub] storm pull request #2667: STORM-3063: Fix minor pom issues

2018-05-09 Thread srdo 
Github user srdo commented on a diff in the pull request:

https://github.com/apache/storm/pull/2667#discussion_r187100434
  
--- Diff: pom.xml ---
@@ -1275,6 +1270,25 @@
 
true
 
 
+
+org.apache.maven.plugins
+maven-enforcer-plugin
+
+
+enforce-maven
--- End diff --

Yes, that's better. Will change.


---

[GitHub] storm pull request #2667: STORM-3063: Fix minor pom issues

2018-05-09 Thread hmcl 
Github user hmcl commented on a diff in the pull request:

https://github.com/apache/storm/pull/2667#discussion_r187100160
  
--- Diff: pom.xml ---
@@ -1275,6 +1270,25 @@
 
true
 
 
+
+org.apache.maven.plugins
+maven-enforcer-plugin
+
+
+enforce-maven
--- End diff --

Agree. Would 'enforce-maven-version' be more descriptive?


---

[GitHub] storm pull request #2667: STORM-3063: Fix minor pom issues

2018-05-08 Thread srdo 
Github user srdo commented on a diff in the pull request:

https://github.com/apache/storm/pull/2667#discussion_r186888587
  
--- Diff: pom.xml ---
@@ -1275,6 +1270,25 @@
 
true
 
 
+
+org.apache.maven.plugins
+maven-enforcer-plugin
+
+
+enforce-maven
--- End diff --

No, it could be left out. However I think since this plugin is so generic, 
it's helpful to have a descriptive name for the execution.


---

[GitHub] storm pull request #2667: STORM-3063: Fix minor pom issues

2018-05-08 Thread hmcl 
Github user hmcl commented on a diff in the pull request:

https://github.com/apache/storm/pull/2667#discussion_r186887493
  
--- Diff: pom.xml ---
@@ -1275,6 +1270,25 @@
 
true
 
 
+
+org.apache.maven.plugins
+maven-enforcer-plugin
+
+
+enforce-maven
--- End diff --

since there is only one execution, is 'id' really necessary ?


---

[GitHub] storm pull request #2667: STORM-3063: Fix minor pom issues

2018-05-08 Thread srdo 
GitHub user srdo opened a pull request:

https://github.com/apache/storm/pull/2667

STORM-3063: Fix minor pom issues

https://issues.apache.org/jira/browse/STORM-3063

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/srdo/storm STORM-3063

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/storm/pull/2667.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2667


commit 51b1faa93cd29248e85dd76cd73e226b7b58eeed
Author: Stig Rohde Døssing 
Date:   2018-05-06T11:54:06Z

STORM-3063: Fix minor pom issues




---