[GitHub] storm pull request #2675: STORM-3061: Upgrade lots of dependencies

[revans2]

Github user revans2 closed the pull request at:

https://github.com/apache/storm/pull/2675


---

[GitHub] storm pull request #2675: STORM-3061: Upgrade lots of dependencies

[srdo]

Github user srdo commented on a diff in the pull request:

https://github.com/apache/storm/pull/2675#discussion_r189455082
  
--- Diff: 
examples/storm-rocketmq-examples/src/main/java/org/apache/storm/rocketmq/trident/WordCountTrident.java
 ---
@@ -76,19 +74,16 @@ public static StormTopology buildTopology(String 
nameserverAddr, String topic){
 public static void main(String[] args) throws Exception {
 Config conf = new Config();
 conf.setMaxSpoutPending(5);
-if (args.length == 2) {
-try (LocalCluster cluster = new LocalCluster();
- LocalTopology topo = 
cluster.submitTopology("wordCounter", conf, buildTopology(args[0], args[1]));) {
-Thread.sleep(60 * 1000);
+conf.setNumWorkers(3);
+
+String topologyName = "wordCounter";
+if (args.length < 2) {
+System.out.println("Usage: WordCountTopology  
 [topology name]");
--- End diff --

Nit: Should be WordCountTrident


---

[GitHub] storm pull request #2675: STORM-3061: Upgrade lots of dependencies

[srdo]

Github user srdo commented on a diff in the pull request:

https://github.com/apache/storm/pull/2675#discussion_r189456044
  
--- Diff: external/storm-jms/pom.xml ---
@@ -62,8 +62,7 @@
 
 
 org.apache.activemq
-activemq-core
-5.5.1
+activemq-all
--- End diff --

Nit: Not sure we need everything in this jar, maybe activemq-client and 
activemq-broker would be enough?


---

[GitHub] storm pull request #2675: STORM-3061: Upgrade lots of dependencies

[revans2]

GitHub user revans2 opened a pull request:

https://github.com/apache/storm/pull/2675

STORM-3061: Upgrade lots of dependencies

This upgrades lots of dependencies, including thrift.  The thrift changes 
are based off of an earlier patch done by @arunmahadevan 

Please skip over the generated files and look mostly at the other files.

I have only tested that the unit tests pass and that a single node cluster 
comes up and runs, with similar performance.

I did make a few minor changes in some places to be able to remove 
dependencies that are not used/needed any more (hbase-server from storm-hbase 
just to get some string functions).

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/revans2/incubator-storm STORM-3061

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/storm/pull/2675.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2675


commit b2428e9d672dc0c8b94a6f7acc7e87ca239070f1
Author: Robert (Bobby) Evans 
Date:   2018-05-08T17:30:40Z

STORM-3061: Upgrade lots of dependencies




---