[GitHub] storm pull request #2688: STORM-3061: Remove unused core dependencies

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/storm/pull/2688


---

[GitHub] storm pull request #2688: STORM-3061: Remove unused core dependencies

[HeartSaVioR]

Github user HeartSaVioR commented on a diff in the pull request:

https://github.com/apache/storm/pull/2688#discussion_r190405202
  
--- Diff: bin/storm.py ---
@@ -705,7 +705,6 @@ def 
nimbus(klass="org.apache.storm.daemon.nimbus.Nimbus"):
 cppaths = [CLUSTER_CONF_DIR]
 jvmopts = parse_args(confvalue("nimbus.childopts", cppaths)) + [
 "-Dlogfile.name=nimbus.log",
-
"-DLog4jContextSelector=org.apache.logging.log4j.core.async.AsyncLoggerContextSelector",
--- End diff --

Thanks for the kind explanation. Makes totally sense.


---

[GitHub] storm pull request #2688: STORM-3061: Remove unused core dependencies

[revans2]

Github user revans2 commented on a diff in the pull request:

https://github.com/apache/storm/pull/2688#discussion_r190401760
  
--- Diff: bin/storm.py ---
@@ -705,7 +705,6 @@ def 
nimbus(klass="org.apache.storm.daemon.nimbus.Nimbus"):
 cppaths = [CLUSTER_CONF_DIR]
 jvmopts = parse_args(confvalue("nimbus.childopts", cppaths)) + [
 "-Dlogfile.name=nimbus.log",
-
"-DLog4jContextSelector=org.apache.logging.log4j.core.async.AsyncLoggerContextSelector",
--- End diff --

So a long time ago we tried out async logging for log4j.  It kind of 
helped, but also caused some issues.  It puts the log messages into a disruptor 
queue and has a background thread handles writing them out.  In my big patch 
after upgrading the version of log4j and removing disruptor from the classpath 
async logging started to get errors about disruptor not being on the classpath. 
 I don't know which caused it, or if it was a combination of things, but I 
thought if I was removing disruptor from the classpath this would be the right 
place to remove the async logging too.


---

[GitHub] storm pull request #2688: STORM-3061: Remove unused core dependencies

[HeartSaVioR]

Github user HeartSaVioR commented on a diff in the pull request:

https://github.com/apache/storm/pull/2688#discussion_r190396554
  
--- Diff: bin/storm.py ---
@@ -705,7 +705,6 @@ def 
nimbus(klass="org.apache.storm.daemon.nimbus.Nimbus"):
 cppaths = [CLUSTER_CONF_DIR]
 jvmopts = parse_args(confvalue("nimbus.childopts", cppaths)) + [
 "-Dlogfile.name=nimbus.log",
-
"-DLog4jContextSelector=org.apache.logging.log4j.core.async.AsyncLoggerContextSelector",
--- End diff --

Just curious, we don't touch log4j2 dependency, so can I treat it as 
removing unnecessary option?


---

[GitHub] storm pull request #2688: STORM-3061: Remove unused core dependencies

[revans2]

GitHub user revans2 opened a pull request:

https://github.com/apache/storm/pull/2688

STORM-3061: Remove unused core dependencies

This is for disruptor and java.jmx

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/revans2/incubator-storm 
STORM-3061-remove-core-deps

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/storm/pull/2688.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2688


commit 100a4daf060a851a247c954cbe2c03d39ea4d8d8
Author: Robert (Bobby) Evans 
Date:   2018-05-23T15:12:06Z

STORM-3061: Remove unused core dependencies




---