[jira] [Commented] (STORM-1379) Removed Redundant Structure
[ https://issues.apache.org/jira/browse/STORM-1379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15117415#comment-15117415 ] darion yaphet commented on STORM-1379: -- Hi Rebert Actually I have create a pull request at github https://github.com/apache/storm/pull/932 but maybe not very successfully . Thank you for you great work :) > Removed Redundant Structure > --- > > Key: STORM-1379 > URL: https://issues.apache.org/jira/browse/STORM-1379 > Project: Apache Storm > Issue Type: Improvement > Components: storm-kafka >Affects Versions: 0.10.0, 0.9.4, 0.9.5, 0.9.6 > Environment: CentOS 6 JDK1.7.0_75 >Reporter: darion yaphet >Assignee: darion yaphet >Priority: Minor > Fix For: 1.0.0 > > Attachments: STORM-1379.patch > > > Storm KafkaSpout have a static class MessageAndRealOffset which is same with > Kafka API 's kafka.message.MessageAndOffset . So I have remove > MessageAndRealOffset and replace with MessageAndOffset :) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (STORM-1379) Removed Redundant Structure
[ https://issues.apache.org/jira/browse/STORM-1379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15117419#comment-15117419 ] ASF GitHub Bot commented on STORM-1379: --- Github user darionyaphet commented on the pull request: https://github.com/apache/storm/pull/932#issuecomment-175084269 This issue have merged [STORM-1379](https://issues.apache.org/jira/browse/STORM-1379) and close this pull request :) > Removed Redundant Structure > --- > > Key: STORM-1379 > URL: https://issues.apache.org/jira/browse/STORM-1379 > Project: Apache Storm > Issue Type: Improvement > Components: storm-kafka >Affects Versions: 0.10.0, 0.9.4, 0.9.5, 0.9.6 > Environment: CentOS 6 JDK1.7.0_75 >Reporter: darion yaphet >Assignee: darion yaphet >Priority: Minor > Fix For: 1.0.0 > > Attachments: STORM-1379.patch > > > Storm KafkaSpout have a static class MessageAndRealOffset which is same with > Kafka API 's kafka.message.MessageAndOffset . So I have remove > MessageAndRealOffset and replace with MessageAndOffset :) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (STORM-1379) Removed Redundant Structure
[ https://issues.apache.org/jira/browse/STORM-1379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15089455#comment-15089455 ] Robert Joseph Evans commented on STORM-1379: [~darion], This kind of fell off my radar. Sorry about it. The code change looks good. There was a minor merge conflict, but it looks like it was just white space changes in partition manger. I am +1 on this. In the future putting a pull request against http://github.com/apache/storm is a lot simpler and triggers our CI process, so I don't have to run things manually. > Removed Redundant Structure > --- > > Key: STORM-1379 > URL: https://issues.apache.org/jira/browse/STORM-1379 > Project: Apache Storm > Issue Type: Improvement > Components: storm-kafka >Affects Versions: 0.10.0, 0.9.4, 0.9.5, 0.9.6 > Environment: CentOS 6 JDK1.7.0_75 >Reporter: darion yaphets >Priority: Minor > Attachments: STORM-1379.patch > > > Storm KafkaSpout have a static class MessageAndRealOffset which is same with > Kafka API 's kafka.message.MessageAndOffset . So I hava remove > MessageAndRealOffset and replace with MessageAndOffset :) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
