[jira] [Commented] (STORM-1467) Switch apache-rat plugin off by default, but enable for Travis-CI

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/STORM-1467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15096561#comment-15096561
 ] 

ASF GitHub Bot commented on STORM-1467:
---

Github user ptgoetz commented on the pull request:

https://github.com/apache/storm/pull/1006#issuecomment-171366113
  
+1


> Switch apache-rat plugin off by default, but enable for Travis-CI
> -
>
> Key: STORM-1467
> URL: https://issues.apache.org/jira/browse/STORM-1467
> Project: Apache Storm
>  Issue Type: Bug
>Reporter: Kyle Nusbaum
>
> apache-rat is super annoying when developing. We should change it so that it 
> doesn't run all the time, but can be manually triggered and runs in CI.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (STORM-1467) Switch apache-rat plugin off by default, but enable for Travis-CI

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/STORM-1467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15094960#comment-15094960
 ] 

ASF GitHub Bot commented on STORM-1467:
---

Github user revans2 commented on the pull request:

https://github.com/apache/storm/pull/1006#issuecomment-171056928
  
I really would prefer to see this be a part of a profile.  So we can turn 
it on with something like `-Prat`


> Switch apache-rat plugin off by default, but enable for Travis-CI
> -
>
> Key: STORM-1467
> URL: https://issues.apache.org/jira/browse/STORM-1467
> Project: Apache Storm
>  Issue Type: Bug
>Reporter: Kyle Nusbaum
>
> apache-rat is super annoying when developing. We should change it so that it 
> doesn't run all the time, but can be manually triggered and runs in CI.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (STORM-1467) Switch apache-rat plugin off by default, but enable for Travis-CI

[P. Taylor Goetz (JIRA)]

[ 
https://issues.apache.org/jira/browse/STORM-1467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15094651#comment-15094651
 ] 

P. Taylor Goetz commented on STORM-1467:


If we could allow it to be enabled with a profile switch, that would be nice. I 
use it a lot when I'm prepping for a release and/or merging patches.

> Switch apache-rat plugin off by default, but enable for Travis-CI
> -
>
> Key: STORM-1467
> URL: https://issues.apache.org/jira/browse/STORM-1467
> Project: Apache Storm
>  Issue Type: Bug
>Reporter: Kyle Nusbaum
>
> apache-rat is super annoying when developing. We should change it so that it 
> doesn't run all the time, but can be manually triggered and runs in CI.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (STORM-1467) Switch apache-rat plugin off by default, but enable for Travis-CI

[Robert Joseph Evans (JIRA)]

[ 
https://issues.apache.org/jira/browse/STORM-1467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15094714#comment-15094714
 ] 

Robert Joseph Evans commented on STORM-1467:


I agree a profile switch would be best.  I use it to when merging patches.

> Switch apache-rat plugin off by default, but enable for Travis-CI
> -
>
> Key: STORM-1467
> URL: https://issues.apache.org/jira/browse/STORM-1467
> Project: Apache Storm
>  Issue Type: Bug
>Reporter: Kyle Nusbaum
>
> apache-rat is super annoying when developing. We should change it so that it 
> doesn't run all the time, but can be manually triggered and runs in CI.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (STORM-1467) Switch apache-rat plugin off by default, but enable for Travis-CI

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/STORM-1467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15094901#comment-15094901
 ] 

ASF GitHub Bot commented on STORM-1467:
---

GitHub user knusbaum opened a pull request:

https://github.com/apache/storm/pull/1006

STORM-1467: Switch apache-rat plugin off by default, but enable for 
Travis-CI

I added an un-licensed file in to show that the CI will fail. I'll remove 
it before merge.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/knusbaum/incubator-storm STORM-1467

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/storm/pull/1006.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1006


commit 4c2b17c0a4fef0d91a3bc661f8af748ceb527d2b
Author: Kyle Nusbaum 
Date:   2016-01-12T17:58:07Z

Testing.

commit a723485272ff689abd4305d17bc46fe32a6490e0
Author: Kyle Nusbaum 
Date:   2016-01-12T18:00:28Z

Testing.

commit d43b64cf7aaeb37867f425d973170e4fa8c92244
Author: Kyle Nusbaum 
Date:   2016-01-12T18:17:18Z

Adding dumb file for the rat to find.

commit e34db41cc93be24dee41bf2e66937d4031ab4ccc
Author: Kyle Nusbaum 
Date:   2016-01-12T20:29:32Z

Testing.

commit 99ea06fb1e9b1b2114d860198368c31775b4344e
Author: Kyle Nusbaum 
Date:   2016-01-12T20:40:57Z

Fix & Test.




> Switch apache-rat plugin off by default, but enable for Travis-CI
> -
>
> Key: STORM-1467
> URL: https://issues.apache.org/jira/browse/STORM-1467
> Project: Apache Storm
>  Issue Type: Bug
>Reporter: Kyle Nusbaum
>
> apache-rat is super annoying when developing. We should change it so that it 
> doesn't run all the time, but can be manually triggered and runs in CI.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)