[jira] [Commented] (STORM-638) UI should show up process-id of the Worker to which an Executor is assigned
[ https://issues.apache.org/jira/browse/STORM-638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15183909#comment-15183909 ] ASF GitHub Bot commented on STORM-638: -- Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/396 > UI should show up process-id of the Worker to which an Executor is assigned > > > Key: STORM-638 > URL: https://issues.apache.org/jira/browse/STORM-638 > Project: Apache Storm > Issue Type: Bug > Components: storm-core >Affects Versions: 0.10.0 >Reporter: caofangkun >Assignee: caofangkun >Priority: Minor > Attachments: with process id.png > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (STORM-638) UI should show up process-id of the Worker to which an Executor is assigned
[ https://issues.apache.org/jira/browse/STORM-638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15183907#comment-15183907 ] ASF GitHub Bot commented on STORM-638: -- Github user knusbaum commented on the pull request: https://github.com/apache/storm/pull/396#issuecomment-193489321 Closing this. > UI should show up process-id of the Worker to which an Executor is assigned > > > Key: STORM-638 > URL: https://issues.apache.org/jira/browse/STORM-638 > Project: Apache Storm > Issue Type: Bug > Components: storm-core >Affects Versions: 0.10.0 >Reporter: caofangkun >Assignee: caofangkun >Priority: Minor > Attachments: with process id.png > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (STORM-638) UI should show up process-id of the Worker to which an Executor is assigned
[ https://issues.apache.org/jira/browse/STORM-638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14957799#comment-14957799 ] ASF GitHub Bot commented on STORM-638: -- Github user knusbaum commented on the pull request: https://github.com/apache/storm/pull/396#issuecomment-148204828 -0 I don't really think this is a useful thing to add to the UI. If we want to add it to the JSON API, I'm okay with that, but let's not display it on the UI. > UI should show up process-id of the Worker to which an Executor is assigned > > > Key: STORM-638 > URL: https://issues.apache.org/jira/browse/STORM-638 > Project: Apache Storm > Issue Type: Bug > Components: storm-core >Affects Versions: 0.10.0 >Reporter: caofangkun >Assignee: caofangkun >Priority: Minor > Attachments: with process id.png > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (STORM-638) UI should show up process-id of the Worker to which an Executor is assigned
[ https://issues.apache.org/jira/browse/STORM-638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14957845#comment-14957845 ] ASF GitHub Bot commented on STORM-638: -- Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/396#issuecomment-148209473 Agreed on @knusbaum. It can reduce one ps command for actual users to operate (ps, kill, etc.) specific worker by hand, but I'm curious that there're other benefits. I also think that since we're already defining "port", we would be better to encapsulate worker process into "port" and provide a way to operate such things via "port". Or we can think about providing workers' information (usage of CPU, MEM, etc. but except secure things) into UI. Maybe we could provide a way to kill specific worker from UI, but I wonder there's such use cases. > UI should show up process-id of the Worker to which an Executor is assigned > > > Key: STORM-638 > URL: https://issues.apache.org/jira/browse/STORM-638 > Project: Apache Storm > Issue Type: Bug > Components: storm-core >Affects Versions: 0.10.0 >Reporter: caofangkun >Assignee: caofangkun >Priority: Minor > Attachments: with process id.png > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (STORM-638) UI should show up process-id of the Worker to which an Executor is assigned
[ https://issues.apache.org/jira/browse/STORM-638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14370781#comment-14370781 ] ASF GitHub Bot commented on STORM-638: -- Github user vesense commented on the pull request: https://github.com/apache/storm/pull/396#issuecomment-83920789 unnecessary UI should show up process-id of the Worker to which an Executor is assigned Key: STORM-638 URL: https://issues.apache.org/jira/browse/STORM-638 Project: Apache Storm Issue Type: Bug Affects Versions: 0.10.0 Reporter: caofangkun Assignee: caofangkun Priority: Minor Attachments: with process id.png -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (STORM-638) UI should show up process-id of the Worker to which an Executor is assigned
[ https://issues.apache.org/jira/browse/STORM-638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14365297#comment-14365297 ] ASF GitHub Bot commented on STORM-638: -- Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/396#issuecomment-82399938 Sorry it is not the code generation after all. Although the comment in the generated code with a 0.7.0 is off putting, and I would prefer it to be generated with 0.9.2. by making the field optional it changes the constructor, so now backtype/storm/daemon/nimbus.clj:1325:47 is failing to compile, because the constructor is different. UI should show up process-id of the Worker to which an Executor is assigned Key: STORM-638 URL: https://issues.apache.org/jira/browse/STORM-638 Project: Apache Storm Issue Type: Bug Affects Versions: 0.10.0 Reporter: caofangkun Assignee: caofangkun Priority: Minor Attachments: with process id.png -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (STORM-638) UI should show up process-id of the Worker to which an Executor is assigned
[ https://issues.apache.org/jira/browse/STORM-638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14365272#comment-14365272 ] ASF GitHub Bot commented on STORM-638: -- Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/396#issuecomment-82397663 @harshach, If you are running the UI without a filter I would not consider that secure. There is other more damaging information exposed on the UI already. Also what is having the pid of the process going to let me do as an attacher? If I cannot log onto the box the pid is really rather useless. If I can log onto the box I can already get the pid by running ```ps -aef | grep 'topology-id-port-number'```. Granted I am not a malicious individual so perhaps I am missing something or perhaps an attach will show up in the future that is somehow related to the pid. It is totally possible, but I don't see it as being that likely. @caofangkun, The generated thrift code no longer compiles. It looks like you regenerated with thrift7, and we have moved on to thrift 0.9.2. Please regenerate the code again. UI should show up process-id of the Worker to which an Executor is assigned Key: STORM-638 URL: https://issues.apache.org/jira/browse/STORM-638 Project: Apache Storm Issue Type: Bug Affects Versions: 0.10.0 Reporter: caofangkun Assignee: caofangkun Priority: Minor Attachments: with process id.png -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (STORM-638) UI should show up process-id of the Worker to which an Executor is assigned
[
https://issues.apache.org/jira/browse/STORM-638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357376#comment-14357376
]
ASF GitHub Bot commented on STORM-638:
--
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/396#discussion_r26242766
--- Diff: storm-core/src/ui/public/templates/component-page-template.html
---
@@ -211,6 +216,7 @@
td{{uptime}}/td
td{{host}}/td
tda href={{workerLogLink}}{{port}}/a/td
+td{{processId}}
--- End diff --
Can we close the td tag? I know it is not required but all the other ones
are closed.
UI should show up process-id of the Worker to which an Executor is assigned
Key: STORM-638
URL: https://issues.apache.org/jira/browse/STORM-638
Project: Apache Storm
Issue Type: Bug
Affects Versions: 0.10.0
Reporter: caofangkun
Assignee: caofangkun
Priority: Minor
Attachments: with process id.png
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (STORM-638) UI should show up process-id of the Worker to which an Executor is assigned
[
https://issues.apache.org/jira/browse/STORM-638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14359852#comment-14359852
]
ASF GitHub Bot commented on STORM-638:
--
Github user caofangkun commented on a diff in the pull request:
https://github.com/apache/storm/pull/396#discussion_r26362269
--- Diff: storm-core/src/storm.thrift ---
@@ -205,7 +205,8 @@ struct ExecutorSummary {
2: required string component_id;
3: required string host;
4: required i32 port;
- 5: required i32 uptime_secs;
+ 5: required i32 process_id;
--- End diff --
Fixed. Thank you. Please review this again.
UI should show up process-id of the Worker to which an Executor is assigned
Key: STORM-638
URL: https://issues.apache.org/jira/browse/STORM-638
Project: Apache Storm
Issue Type: Bug
Affects Versions: 0.10.0
Reporter: caofangkun
Assignee: caofangkun
Priority: Minor
Attachments: with process id.png
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (STORM-638) UI should show up process-id of the Worker to which an Executor is assigned
[ https://issues.apache.org/jira/browse/STORM-638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357381#comment-14357381 ] ASF GitHub Bot commented on STORM-638: -- Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/396#issuecomment-78343992 I'm not convinced having the PID on the UI is really that helpful, but it does provide more information for possible automation or monitoring, so I am OK with it. UI should show up process-id of the Worker to which an Executor is assigned Key: STORM-638 URL: https://issues.apache.org/jira/browse/STORM-638 Project: Apache Storm Issue Type: Bug Affects Versions: 0.10.0 Reporter: caofangkun Assignee: caofangkun Priority: Minor Attachments: with process id.png -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (STORM-638) UI should show up process-id of the Worker to which an Executor is assigned
[
https://issues.apache.org/jira/browse/STORM-638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357375#comment-14357375
]
ASF GitHub Bot commented on STORM-638:
--
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/396#discussion_r26242669
--- Diff: storm-core/src/storm.thrift ---
@@ -205,7 +205,8 @@ struct ExecutorSummary {
2: required string component_id;
3: required string host;
4: required i32 port;
- 5: required i32 uptime_secs;
+ 5: required i32 process_id;
--- End diff --
You cannot change a thrift ID like this. It breaks backwards compatibility
too much. Please make sure that you add new tags instead of changing existing
ones. It is also usually preferable to make the new tag optional, so you can
have forward and backwards compatibility.
UI should show up process-id of the Worker to which an Executor is assigned
Key: STORM-638
URL: https://issues.apache.org/jira/browse/STORM-638
Project: Apache Storm
Issue Type: Bug
Affects Versions: 0.10.0
Reporter: caofangkun
Assignee: caofangkun
Priority: Minor
Attachments: with process id.png
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (STORM-638) UI should show up process-id of the Worker to which an Executor is assigned
[ https://issues.apache.org/jira/browse/STORM-638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357442#comment-14357442 ] ASF GitHub Bot commented on STORM-638: -- Github user harshach commented on the pull request: https://github.com/apache/storm/pull/396#issuecomment-78354003 @revans2 not quite comfortable with exposing pid on UI. UI is supposed to be available for all the users. In non-secure env it can be run without any filter so I am against exposing pid on the UI. UI should show up process-id of the Worker to which an Executor is assigned Key: STORM-638 URL: https://issues.apache.org/jira/browse/STORM-638 Project: Apache Storm Issue Type: Bug Affects Versions: 0.10.0 Reporter: caofangkun Assignee: caofangkun Priority: Minor Attachments: with process id.png -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (STORM-638) UI should show up process-id of the Worker to which an Executor is assigned
[ https://issues.apache.org/jira/browse/STORM-638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14293172#comment-14293172 ] ASF GitHub Bot commented on STORM-638: -- Github user caofangkun commented on the pull request: https://github.com/apache/storm/pull/396#issuecomment-71607591 Pay Attention: conflicts with https://github.com/apache/storm/pull/296 UI should show up process-id of the Worker to which an Executor is assigned Key: STORM-638 URL: https://issues.apache.org/jira/browse/STORM-638 Project: Apache Storm Issue Type: Bug Affects Versions: 0.10.0 Reporter: caofangkun Assignee: caofangkun Priority: Minor Attachments: with process id.png -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (STORM-638) UI should show up process-id of the Worker to which an Executor is assigned
[ https://issues.apache.org/jira/browse/STORM-638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14293167#comment-14293167 ] ASF GitHub Bot commented on STORM-638: -- GitHub user caofangkun opened a pull request: https://github.com/apache/storm/pull/396 STORM-638:UI should show up process-id of the Worker to which an Executor is assigned  You can merge this pull request into a Git repository by running: $ git pull https://github.com/caofangkun/apache-storm storm-638 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/396.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #396 commit 6c04e1bea802d28ae92a234ddbaad2c1ed0a6835 Author: caofangkun caofang...@gmail.com Date: 2015-01-23T01:28:46Z Merge pull request #4 from apache/master Merger from apache/storm to caofangkun/apache-storm commit 6eedd8dccd2a3405d68de611c5da0645678645ac Author: caofangkun caofang...@gmail.com Date: 2015-01-27T08:13:26Z STORM-638:UI should show up process-id of the Worker to which an Executor is assigned UI should show up process-id of the Worker to which an Executor is assigned Key: STORM-638 URL: https://issues.apache.org/jira/browse/STORM-638 Project: Apache Storm Issue Type: Bug Affects Versions: 0.10.0 Reporter: caofangkun Assignee: caofangkun Priority: Minor Attachments: with process id.png -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (STORM-638) UI should show up process-id of the Worker to which an Executor is assigned
[ https://issues.apache.org/jira/browse/STORM-638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14293103#comment-14293103 ] caofangkun commented on STORM-638: -- STORM-532 added :process-id in worker-data UI should show up process-id of the Worker to which an Executor is assigned Key: STORM-638 URL: https://issues.apache.org/jira/browse/STORM-638 Project: Apache Storm Issue Type: Bug Affects Versions: 0.10.0 Reporter: caofangkun Assignee: caofangkun Priority: Minor Attachments: with process id.png -- This message was sent by Atlassian JIRA (v6.3.4#6332)
