[jira] [Commented] (STORM-691) [storm-redis] Add basic lookup / persist bolts
[ https://issues.apache.org/jira/browse/STORM-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14378781#comment-14378781 ] Jungtaek Lim commented on STORM-691: [~revans2] Let me expose my opinion about issue version (including STORM-703, and further issues). Storm-redis will be released on 0.10.0 first, and seems like it's not scheduled yet. Since cause users can have first impression for storm-redis on 0.10.0, and we have more time to improve, what do you think about applying improvements to 0.10.0 and release first version of storm-redis with whole improvements as many as possible? Surely it shouldn't block to release 0.10.0. [storm-redis] Add basic lookup / persist bolts -- Key: STORM-691 URL: https://issues.apache.org/jira/browse/STORM-691 Project: Apache Storm Issue Type: Improvement Affects Versions: 0.10.0 Reporter: Jungtaek Lim Assignee: Jungtaek Lim Priority: Minor Fix For: 0.11.0 Currently storm-redis provides AbstractRedisBolt for normal (not Trident) Bolt. Jedis is easy to use so it may be enough, but we can also provide implementations of AbstractRedisBolt for simple usage. eg. store (key, value) pair, get key's value Since Redis has various data types and commands, we can't cover whole things, but seems like below things could be considered. || Type || Read || Write || | STRING | GET (key) | SET (key, value) | | HASH | HGET (key, field) | HSET (key, field, value) | | LIST | LPOP (key) | RPUSH (key, value) | | SET | SCARD (key) | SADD (key, member) | | SORTED SET | ZSCORE (key, member) | ZADD (key, score, member) | | HLL (HyperLogLog) | PFCOUNT (key) | PFADD (key, element) | Btw, since we will normally get key value from tuple (as most external module did), HASH, SET, SORTED SET needs additional key to process. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (STORM-691) [storm-redis] Add basic lookup / persist bolts
[ https://issues.apache.org/jira/browse/STORM-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14377973#comment-14377973 ] ASF GitHub Bot commented on STORM-691: -- Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/451#issuecomment-85539101 +1, again sorry about this taking so long, I'll merge it in. [storm-redis] Add basic lookup / persist bolts -- Key: STORM-691 URL: https://issues.apache.org/jira/browse/STORM-691 Project: Apache Storm Issue Type: Improvement Affects Versions: 0.10.0 Reporter: Jungtaek Lim Assignee: Jungtaek Lim Priority: Minor Currently storm-redis provides AbstractRedisBolt for normal (not Trident) Bolt. Jedis is easy to use so it may be enough, but we can also provide implementations of AbstractRedisBolt for simple usage. eg. store (key, value) pair, get key's value Since Redis has various data types and commands, we can't cover whole things, but seems like below things could be considered. || Type || Read || Write || | STRING | GET (key) | SET (key, value) | | HASH | HGET (key, field) | HSET (key, field, value) | | LIST | LPOP (key) | RPUSH (key, value) | | SET | SCARD (key) | SADD (key, member) | | SORTED SET | ZSCORE (key, member) | ZADD (key, score, member) | | HLL (HyperLogLog) | PFCOUNT (key) | PFADD (key, element) | Btw, since we will normally get key value from tuple (as most external module did), HASH, SET, SORTED SET needs additional key to process. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (STORM-691) [storm-redis] Add basic lookup / persist bolts
[ https://issues.apache.org/jira/browse/STORM-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14377978#comment-14377978 ] ASF GitHub Bot commented on STORM-691: -- Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/451 [storm-redis] Add basic lookup / persist bolts -- Key: STORM-691 URL: https://issues.apache.org/jira/browse/STORM-691 Project: Apache Storm Issue Type: Improvement Affects Versions: 0.10.0 Reporter: Jungtaek Lim Assignee: Jungtaek Lim Priority: Minor Currently storm-redis provides AbstractRedisBolt for normal (not Trident) Bolt. Jedis is easy to use so it may be enough, but we can also provide implementations of AbstractRedisBolt for simple usage. eg. store (key, value) pair, get key's value Since Redis has various data types and commands, we can't cover whole things, but seems like below things could be considered. || Type || Read || Write || | STRING | GET (key) | SET (key, value) | | HASH | HGET (key, field) | HSET (key, field, value) | | LIST | LPOP (key) | RPUSH (key, value) | | SET | SCARD (key) | SADD (key, member) | | SORTED SET | ZSCORE (key, member) | ZADD (key, score, member) | | HLL (HyperLogLog) | PFCOUNT (key) | PFADD (key, element) | Btw, since we will normally get key value from tuple (as most external module did), HASH, SET, SORTED SET needs additional key to process. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (STORM-691) [storm-redis] Add basic lookup / persist bolts
[ https://issues.apache.org/jira/browse/STORM-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14369969#comment-14369969 ] ASF GitHub Bot commented on STORM-691: -- Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/451#issuecomment-83732719 +1 [storm-redis] Add basic lookup / persist bolts -- Key: STORM-691 URL: https://issues.apache.org/jira/browse/STORM-691 Project: Apache Storm Issue Type: Improvement Affects Versions: 0.10.0 Reporter: Jungtaek Lim Assignee: Jungtaek Lim Priority: Minor Currently storm-redis provides AbstractRedisBolt for normal (not Trident) Bolt. Jedis is easy to use so it may be enough, but we can also provide implementations of AbstractRedisBolt for simple usage. eg. store (key, value) pair, get key's value Since Redis has various data types and commands, we can't cover whole things, but seems like below things could be considered. || Type || Read || Write || | STRING | GET (key) | SET (key, value) | | HASH | HGET (key, field) | HSET (key, field, value) | | LIST | LPOP (key) | RPUSH (key, value) | | SET | SCARD (key) | SADD (key, member) | | SORTED SET | ZSCORE (key, member) | ZADD (key, score, member) | | HLL (HyperLogLog) | PFCOUNT (key) | PFADD (key, element) | Btw, since we will normally get key value from tuple (as most external module did), HASH, SET, SORTED SET needs additional key to process. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (STORM-691) [storm-redis] Add basic lookup / persist bolts
[ https://issues.apache.org/jira/browse/STORM-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357778#comment-14357778 ] ASF GitHub Bot commented on STORM-691: -- Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/451#issuecomment-78393165 The code looks fine to me. My only comment is that it would be nice to have a default in most of the case statements, mostly as defensive programming so if something gets off we wold get an error instead of falling through and ignoring the tuples. [storm-redis] Add basic lookup / persist bolts -- Key: STORM-691 URL: https://issues.apache.org/jira/browse/STORM-691 Project: Apache Storm Issue Type: Improvement Affects Versions: 0.10.0 Reporter: Jungtaek Lim Assignee: Jungtaek Lim Priority: Minor Currently storm-redis provides AbstractRedisBolt for normal (not Trident) Bolt. Jedis is easy to use so it may be enough, but we can also provide implementations of AbstractRedisBolt for simple usage. eg. store (key, value) pair, get key's value Since Redis has various data types and commands, we can't cover whole things, but seems like below things could be considered. || Type || Read || Write || | STRING | GET (key) | SET (key, value) | | HASH | HGET (key, field) | HSET (key, field, value) | | LIST | LPOP (key) | RPUSH (key, value) | | SET | SCARD (key) | SADD (key, member) | | SORTED SET | ZSCORE (key, member) | ZADD (key, score, member) | | HLL (HyperLogLog) | PFCOUNT (key) | PFADD (key, element) | Btw, since we will normally get key value from tuple (as most external module did), HASH, SET, SORTED SET needs additional key to process. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (STORM-691) [storm-redis] Add basic lookup / persist bolts
[ https://issues.apache.org/jira/browse/STORM-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357817#comment-14357817 ] ASF GitHub Bot commented on STORM-691: -- Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/451#issuecomment-78396550 @revans2 Thanks for reviewing! It's updated. Could you please check again? [storm-redis] Add basic lookup / persist bolts -- Key: STORM-691 URL: https://issues.apache.org/jira/browse/STORM-691 Project: Apache Storm Issue Type: Improvement Affects Versions: 0.10.0 Reporter: Jungtaek Lim Assignee: Jungtaek Lim Priority: Minor Currently storm-redis provides AbstractRedisBolt for normal (not Trident) Bolt. Jedis is easy to use so it may be enough, but we can also provide implementations of AbstractRedisBolt for simple usage. eg. store (key, value) pair, get key's value Since Redis has various data types and commands, we can't cover whole things, but seems like below things could be considered. || Type || Read || Write || | STRING | GET (key) | SET (key, value) | | HASH | HGET (key, field) | HSET (key, field, value) | | LIST | LPOP (key) | RPUSH (key, value) | | SET | SCARD (key) | SADD (key, member) | | SORTED SET | ZSCORE (key, member) | ZADD (key, score, member) | | HLL (HyperLogLog) | PFCOUNT (key) | PFADD (key, element) | Btw, since we will normally get key value from tuple (as most external module did), HASH, SET, SORTED SET needs additional key to process. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (STORM-691) [storm-redis] Add basic lookup / persist bolts
[ https://issues.apache.org/jira/browse/STORM-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14341528#comment-14341528 ] ASF GitHub Bot commented on STORM-691: -- GitHub user HeartSaVioR opened a pull request: https://github.com/apache/storm/pull/451 STORM-691 Add basic lookup / persist bolts * Add Basic lookup / persist Bolts * support data types : string, list, hash, set, sorted set, hyperloglog * rename util package to common Type | Read | Write | --- | -- STRING | GET (key) | SET (key, value) HASH | HGET (key, field) | HSET (key, field, value) LIST | LPOP (key) | RPUSH (key, value) SET | SCARD (key) | SADD (key, member) SORTED SET | ZSCORE (key, member) | ZADD (key, score, member) HLL (HyperLogLog) | PFCOUNT (key) | PFADD (key, element) You can merge this pull request into a Git repository by running: $ git pull https://github.com/HeartSaVioR/storm STORM-691 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/451.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #451 commit f7c0bf8a7c843c6e555ee982a85e3952d1c28b33 Author: Jungtaek Lim kabh...@gmail.com Date: 2015-02-28T13:29:32Z STORM-691 Add basic lookup / persist bolts * Add Basic lookup / persist Bolts ** support data types : string, list, hash, set, sorted set, hyperloglog * rename util package to common [storm-redis] Add basic lookup / persist bolts -- Key: STORM-691 URL: https://issues.apache.org/jira/browse/STORM-691 Project: Apache Storm Issue Type: Improvement Affects Versions: 0.10.0 Reporter: Jungtaek Lim Assignee: Jungtaek Lim Priority: Minor Currently storm-redis provides AbstractRedisBolt for normal (not Trident) Bolt. Jedis is easy to use so it may be enough, but we can also provide implementations of AbstractRedisBolt for simple usage. eg. store (key, value) pair, get key's value Since Redis has various data types and commands, we can't cover whole things, but seems like below things could be considered. || Type || Read || Write || | STRING | GET (key) | SET (key, value) | | HASH | HGET (key, field) | HSET (key, field, value) | | LIST | LPOP (key) | RPUSH (key, value) | | SET | SCARD (key) | SADD (key, member) | | SORTED SET | ZSCORE (key, member) | ZADD (key, score, member) | | HLL (HyperLogLog) | PFCOUNT (key) | PFADD (key, element) | Btw, since we will normally get key value from tuple (as most external module did), HASH, SET, SORTED SET needs additional key to process. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (STORM-691) [storm-redis] Add basic lookup / persist bolts
[ https://issues.apache.org/jira/browse/STORM-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14341530#comment-14341530 ] ASF GitHub Bot commented on STORM-691: -- Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/451#issuecomment-76526842 When this PR will be merged to master, we can apply RedisDataTypeDescription to Trident in order to support more data types. [storm-redis] Add basic lookup / persist bolts -- Key: STORM-691 URL: https://issues.apache.org/jira/browse/STORM-691 Project: Apache Storm Issue Type: Improvement Affects Versions: 0.10.0 Reporter: Jungtaek Lim Assignee: Jungtaek Lim Priority: Minor Currently storm-redis provides AbstractRedisBolt for normal (not Trident) Bolt. Jedis is easy to use so it may be enough, but we can also provide implementations of AbstractRedisBolt for simple usage. eg. store (key, value) pair, get key's value Since Redis has various data types and commands, we can't cover whole things, but seems like below things could be considered. || Type || Read || Write || | STRING | GET (key) | SET (key, value) | | HASH | HGET (key, field) | HSET (key, field, value) | | LIST | LPOP (key) | RPUSH (key, value) | | SET | SCARD (key) | SADD (key, member) | | SORTED SET | ZSCORE (key, member) | ZADD (key, score, member) | | HLL (HyperLogLog) | PFCOUNT (key) | PFADD (key, element) | Btw, since we will normally get key value from tuple (as most external module did), HASH, SET, SORTED SET needs additional key to process. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
