[jira] [Commented] (STORM-841) Thread-safeness of OutputCollector has documented contrary to two official doc.

2016-08-11 Thread Jungtaek Lim (JIRA) 

[ 
https://issues.apache.org/jira/browse/STORM-841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15418273#comment-15418273
 ] 

Jungtaek Lim commented on STORM-841:


Merged to codebase, now building the docs to publish...

> Thread-safeness of OutputCollector has documented contrary to two official 
> doc.
> ---
>
> Key: STORM-841
> URL: https://issues.apache.org/jira/browse/STORM-841
> Project: Apache Storm
>  Issue Type: Documentation
>  Components: documentation
>Affects Versions: 0.10.0, 0.9.6
>Reporter: Jungtaek Lim
>Assignee: Jungtaek Lim
>Priority: Critical
>
> There're some issues with documentation.
> http://storm.apache.org/documentation/Concepts.html says
> {quote}
> Its perfectly fine to launch new threads in bolts that do processing 
> asynchronously. OutputCollector is thread-safe and can be called at any time.
> {quote}
> and http://storm.apache.org/documentation/Troubleshooting.html says
> {quote}
> This is caused by having multiple threads issue methods on the 
> OutputCollector. All emits, acks, and fails must happen on the same thread. 
> One subtle way this can happen is if you make a IBasicBolt that emits on a 
> separate thread. IBasicBolt's automatically ack after execute is called, so 
> this would cause multiple threads to use the OutputCollector leading to this 
> exception. When using a basic bolt, all emits must happen in the same thread 
> that runs execute.
> {quote}
> It is a contradiction, and at least for now OutputCollector is not 
> thread-safe.
> https://www.mail-archive.com/dev@storm.incubator.apache.org/msg00939.html
> Since newbie of Storm users may think Concepts page as "should read and keep 
> it mind", it is some kind of critical that that such important documentation 
> page has wrong content.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (STORM-841) Thread-safeness of OutputCollector has documented contrary to two official doc.

2016-08-11 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/STORM-841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15418266#comment-15418266
 ] 

ASF GitHub Bot commented on STORM-841:
--

Github user asfgit closed the pull request at:

https://github.com/apache/storm/pull/1623


> Thread-safeness of OutputCollector has documented contrary to two official 
> doc.
> ---
>
> Key: STORM-841
> URL: https://issues.apache.org/jira/browse/STORM-841
> Project: Apache Storm
>  Issue Type: Documentation
>  Components: documentation
>Affects Versions: 0.10.0, 0.9.6
>Reporter: Jungtaek Lim
>Assignee: Jungtaek Lim
>Priority: Critical
>
> There're some issues with documentation.
> http://storm.apache.org/documentation/Concepts.html says
> {quote}
> Its perfectly fine to launch new threads in bolts that do processing 
> asynchronously. OutputCollector is thread-safe and can be called at any time.
> {quote}
> and http://storm.apache.org/documentation/Troubleshooting.html says
> {quote}
> This is caused by having multiple threads issue methods on the 
> OutputCollector. All emits, acks, and fails must happen on the same thread. 
> One subtle way this can happen is if you make a IBasicBolt that emits on a 
> separate thread. IBasicBolt's automatically ack after execute is called, so 
> this would cause multiple threads to use the OutputCollector leading to this 
> exception. When using a basic bolt, all emits must happen in the same thread 
> that runs execute.
> {quote}
> It is a contradiction, and at least for now OutputCollector is not 
> thread-safe.
> https://www.mail-archive.com/dev@storm.incubator.apache.org/msg00939.html
> Since newbie of Storm users may think Concepts page as "should read and keep 
> it mind", it is some kind of critical that that such important documentation 
> page has wrong content.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (STORM-841) Thread-safeness of OutputCollector has documented contrary to two official doc.

2016-08-11 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/STORM-841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15418236#comment-15418236
 ] 

ASF GitHub Bot commented on STORM-841:
--

Github user satishd commented on the issue:

https://github.com/apache/storm/pull/1623
  
+1


> Thread-safeness of OutputCollector has documented contrary to two official 
> doc.
> ---
>
> Key: STORM-841
> URL: https://issues.apache.org/jira/browse/STORM-841
> Project: Apache Storm
>  Issue Type: Documentation
>  Components: documentation
>Affects Versions: 0.10.0, 0.9.6
>Reporter: Jungtaek Lim
>Assignee: Jungtaek Lim
>Priority: Critical
>
> There're some issues with documentation.
> http://storm.apache.org/documentation/Concepts.html says
> {quote}
> Its perfectly fine to launch new threads in bolts that do processing 
> asynchronously. OutputCollector is thread-safe and can be called at any time.
> {quote}
> and http://storm.apache.org/documentation/Troubleshooting.html says
> {quote}
> This is caused by having multiple threads issue methods on the 
> OutputCollector. All emits, acks, and fails must happen on the same thread. 
> One subtle way this can happen is if you make a IBasicBolt that emits on a 
> separate thread. IBasicBolt's automatically ack after execute is called, so 
> this would cause multiple threads to use the OutputCollector leading to this 
> exception. When using a basic bolt, all emits must happen in the same thread 
> that runs execute.
> {quote}
> It is a contradiction, and at least for now OutputCollector is not 
> thread-safe.
> https://www.mail-archive.com/dev@storm.incubator.apache.org/msg00939.html
> Since newbie of Storm users may think Concepts page as "should read and keep 
> it mind", it is some kind of critical that that such important documentation 
> page has wrong content.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (STORM-841) Thread-safeness of OutputCollector has documented contrary to two official doc.

2016-08-11 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/STORM-841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15418135#comment-15418135
 ] 

ASF GitHub Bot commented on STORM-841:
--

GitHub user HeartSaVioR opened a pull request:

https://github.com/apache/storm/pull/1623

STORM-841 Thread-safeness of OutputCollector has documented contrary to two 
official doc (0.10.x)

* Fix for 0.10.x

This should be also downmerged to 0.9.x branch, and applied to docs of 
0.10.0, 0.10.1, 0.9.6.

NOTE: This is non-code change so lazy consensus is applied. (don't need to 
wait for +1 and also 24 hrs)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/HeartSaVioR/storm STORM-841-0.10.x

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/storm/pull/1623.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1623


commit baacc0c032f4086c902005c5684bb9093b11d1ff
Author: Jungtaek Lim 
Date:   2016-08-11T23:41:22Z

STORM-841 Thread-safeness of OutputCollector has documented contrary to two 
official doc.

* Fix for 0.10.x




> Thread-safeness of OutputCollector has documented contrary to two official 
> doc.
> ---
>
> Key: STORM-841
> URL: https://issues.apache.org/jira/browse/STORM-841
> Project: Apache Storm
>  Issue Type: Documentation
>  Components: documentation
>Affects Versions: 0.10.0, 0.9.6
>Reporter: Jungtaek Lim
>Assignee: Jungtaek Lim
>Priority: Critical
>
> There're some issues with documentation.
> http://storm.apache.org/documentation/Concepts.html says
> {quote}
> Its perfectly fine to launch new threads in bolts that do processing 
> asynchronously. OutputCollector is thread-safe and can be called at any time.
> {quote}
> and http://storm.apache.org/documentation/Troubleshooting.html says
> {quote}
> This is caused by having multiple threads issue methods on the 
> OutputCollector. All emits, acks, and fails must happen on the same thread. 
> One subtle way this can happen is if you make a IBasicBolt that emits on a 
> separate thread. IBasicBolt's automatically ack after execute is called, so 
> this would cause multiple threads to use the OutputCollector leading to this 
> exception. When using a basic bolt, all emits must happen in the same thread 
> that runs execute.
> {quote}
> It is a contradiction, and at least for now OutputCollector is not 
> thread-safe.
> https://www.mail-archive.com/dev@storm.incubator.apache.org/msg00939.html
> Since newbie of Storm users may think Concepts page as "should read and keep 
> it mind", it is some kind of critical that that such important documentation 
> page has wrong content.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (STORM-841) Thread-safeness of OutputCollector has documented contrary to two official doc.

2016-04-28 Thread P. Taylor Goetz (JIRA) 

[ 
https://issues.apache.org/jira/browse/STORM-841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15262459#comment-15262459
 ] 

P. Taylor Goetz commented on STORM-841:
---

Okay, cool. I didn't realize the old shuffle grouping was replaced as part of 
the load-aware shuffle grouping.

We should still fix the pre-1.0 docs though.

> Thread-safeness of OutputCollector has documented contrary to two official 
> doc.
> ---
>
> Key: STORM-841
> URL: https://issues.apache.org/jira/browse/STORM-841
> Project: Apache Storm
>  Issue Type: Documentation
>  Components: documentation
>Affects Versions: 0.10.0, 0.9.6
>Reporter: Jungtaek Lim
>Assignee: Jungtaek Lim
>Priority: Critical
>
> There're some issues with documentation.
> http://storm.apache.org/documentation/Concepts.html says
> {quote}
> Its perfectly fine to launch new threads in bolts that do processing 
> asynchronously. OutputCollector is thread-safe and can be called at any time.
> {quote}
> and http://storm.apache.org/documentation/Troubleshooting.html says
> {quote}
> This is caused by having multiple threads issue methods on the 
> OutputCollector. All emits, acks, and fails must happen on the same thread. 
> One subtle way this can happen is if you make a IBasicBolt that emits on a 
> separate thread. IBasicBolt's automatically ack after execute is called, so 
> this would cause multiple threads to use the OutputCollector leading to this 
> exception. When using a basic bolt, all emits must happen in the same thread 
> that runs execute.
> {quote}
> It is a contradiction, and at least for now OutputCollector is not 
> thread-safe.
> https://www.mail-archive.com/dev@storm.incubator.apache.org/msg00939.html
> Since newbie of Storm users may think Concepts page as "should read and keep 
> it mind", it is some kind of critical that that such important documentation 
> page has wrong content.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (STORM-841) Thread-safeness of OutputCollector has documented contrary to two official doc.

2016-04-28 Thread Robert Joseph Evans (JIRA) 

[ 
https://issues.apache.org/jira/browse/STORM-841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15262275#comment-15262275
 ] 

Robert Joseph Evans commented on STORM-841:
---

When is it not thread safe any more?

I thought the only thing that made it not thread safe was the shuffle grouping, 
which was fixed when the load aware shuffle grouping code went in.

https://github.com/apache/storm/blob/v1.0.1/storm-core/src/jvm/org/apache/storm/grouping/ShuffleGrouping.java#L61

that went into the 1.0 release STORM-162.

For 0.10 and 9.6 it is not thread safe but from 1.0 on-wards I think it is.

> Thread-safeness of OutputCollector has documented contrary to two official 
> doc.
> ---
>
> Key: STORM-841
> URL: https://issues.apache.org/jira/browse/STORM-841
> Project: Apache Storm
>  Issue Type: Documentation
>  Components: documentation
>Affects Versions: 0.10.0, 1.0.0, 0.9.6, 2.0.0
>Reporter: Jungtaek Lim
>Assignee: Jungtaek Lim
>Priority: Critical
>
> There're some issues with documentation.
> http://storm.apache.org/documentation/Concepts.html says
> {quote}
> Its perfectly fine to launch new threads in bolts that do processing 
> asynchronously. OutputCollector is thread-safe and can be called at any time.
> {quote}
> and http://storm.apache.org/documentation/Troubleshooting.html says
> {quote}
> This is caused by having multiple threads issue methods on the 
> OutputCollector. All emits, acks, and fails must happen on the same thread. 
> One subtle way this can happen is if you make a IBasicBolt that emits on a 
> separate thread. IBasicBolt's automatically ack after execute is called, so 
> this would cause multiple threads to use the OutputCollector leading to this 
> exception. When using a basic bolt, all emits must happen in the same thread 
> that runs execute.
> {quote}
> It is a contradiction, and at least for now OutputCollector is not 
> thread-safe.
> https://www.mail-archive.com/dev@storm.incubator.apache.org/msg00939.html
> Since newbie of Storm users may think Concepts page as "should read and keep 
> it mind", it is some kind of critical that that such important documentation 
> page has wrong content.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (STORM-841) Thread-safeness of OutputCollector has documented contrary to two official doc.

2015-06-21 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/STORM-841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14595329#comment-14595329
 ] 

ASF GitHub Bot commented on STORM-841:
--

Github user harshach commented on the pull request:

https://github.com/apache/storm/pull/569#issuecomment-113995740
  
+1


 Thread-safeness of OutputCollector has documented contrary to two official 
 doc.
 ---

 Key: STORM-841
 URL: https://issues.apache.org/jira/browse/STORM-841
 Project: Apache Storm
  Issue Type: Documentation
Reporter: Jungtaek Lim
Priority: Critical

 There're some issues with documentation.
 http://storm.apache.org/documentation/Concepts.html says
 {quote}
 Its perfectly fine to launch new threads in bolts that do processing 
 asynchronously. OutputCollector is thread-safe and can be called at any time.
 {quote}
 and http://storm.apache.org/documentation/Troubleshooting.html says
 {quote}
 This is caused by having multiple threads issue methods on the 
 OutputCollector. All emits, acks, and fails must happen on the same thread. 
 One subtle way this can happen is if you make a IBasicBolt that emits on a 
 separate thread. IBasicBolt's automatically ack after execute is called, so 
 this would cause multiple threads to use the OutputCollector leading to this 
 exception. When using a basic bolt, all emits must happen in the same thread 
 that runs execute.
 {quote}
 It is a contradiction, and at least for now OutputCollector is not 
 thread-safe.
 https://www.mail-archive.com/dev@storm.incubator.apache.org/msg00939.html
 Since newbie of Storm users may think Concepts page as should read and keep 
 it mind, it is some kind of critical that that such important documentation 
 page has wrong content.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (STORM-841) Thread-safeness of OutputCollector has documented contrary to two official doc.

2015-06-21 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/STORM-841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14595330#comment-14595330
 ] 

ASF GitHub Bot commented on STORM-841:
--

Github user asfgit closed the pull request at:

https://github.com/apache/storm/pull/569


 Thread-safeness of OutputCollector has documented contrary to two official 
 doc.
 ---

 Key: STORM-841
 URL: https://issues.apache.org/jira/browse/STORM-841
 Project: Apache Storm
  Issue Type: Documentation
Reporter: Jungtaek Lim
Priority: Critical

 There're some issues with documentation.
 http://storm.apache.org/documentation/Concepts.html says
 {quote}
 Its perfectly fine to launch new threads in bolts that do processing 
 asynchronously. OutputCollector is thread-safe and can be called at any time.
 {quote}
 and http://storm.apache.org/documentation/Troubleshooting.html says
 {quote}
 This is caused by having multiple threads issue methods on the 
 OutputCollector. All emits, acks, and fails must happen on the same thread. 
 One subtle way this can happen is if you make a IBasicBolt that emits on a 
 separate thread. IBasicBolt's automatically ack after execute is called, so 
 this would cause multiple threads to use the OutputCollector leading to this 
 exception. When using a basic bolt, all emits must happen in the same thread 
 that runs execute.
 {quote}
 It is a contradiction, and at least for now OutputCollector is not 
 thread-safe.
 https://www.mail-archive.com/dev@storm.incubator.apache.org/msg00939.html
 Since newbie of Storm users may think Concepts page as should read and keep 
 it mind, it is some kind of critical that that such important documentation 
 page has wrong content.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (STORM-841) Thread-safeness of OutputCollector has documented contrary to two official doc.

2015-06-01 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/STORM-841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14566965#comment-14566965
 ] 

ASF GitHub Bot commented on STORM-841:
--

GitHub user HeartSaVioR opened a pull request:

https://github.com/apache/storm/pull/569

STORM-841 Correct doc that OutputCollector is not thread-safe

* Concepts.md: Correct document
* Troubleshooting.md: Add stack trace for other NPE case caused by same 
issue
** Related to STORM-770

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/HeartSaVioR/storm STORM-841

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/storm/pull/569.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #569


commit a6c46aec31095fee6396ce8ffd4a0fd5783a
Author: Jungtaek Lim kabh...@gmail.com
Date:   2015-06-01T06:03:31Z

STORM-841 Correct doc that OutputCollector is not thread-safe




 Thread-safeness of OutputCollector has documented contrary to two official 
 doc.
 ---

 Key: STORM-841
 URL: https://issues.apache.org/jira/browse/STORM-841
 Project: Apache Storm
  Issue Type: Documentation
Reporter: Jungtaek Lim
Priority: Critical

 There're some issues with documentation.
 http://storm.apache.org/documentation/Concepts.html says
 {quote}
 Its perfectly fine to launch new threads in bolts that do processing 
 asynchronously. OutputCollector is thread-safe and can be called at any time.
 {quote}
 and http://storm.apache.org/documentation/Troubleshooting.html says
 {quote}
 This is caused by having multiple threads issue methods on the 
 OutputCollector. All emits, acks, and fails must happen on the same thread. 
 One subtle way this can happen is if you make a IBasicBolt that emits on a 
 separate thread. IBasicBolt's automatically ack after execute is called, so 
 this would cause multiple threads to use the OutputCollector leading to this 
 exception. When using a basic bolt, all emits must happen in the same thread 
 that runs execute.
 {quote}
 It is a contradiction, and at least for now OutputCollector is not 
 thread-safe.
 https://www.mail-archive.com/dev@storm.incubator.apache.org/msg00939.html
 Since newbie of Storm users may think Concepts page as should read and keep 
 it mind, it is some kind of critical that that such important documentation 
 page has wrong content.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (STORM-841) Thread-safeness of OutputCollector has documented contrary to two official doc.

2015-06-01 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/STORM-841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14567622#comment-14567622
 ] 

ASF GitHub Bot commented on STORM-841:
--

Github user ptgoetz commented on the pull request:

https://github.com/apache/storm/pull/569#issuecomment-107650355
  
+1


 Thread-safeness of OutputCollector has documented contrary to two official 
 doc.
 ---

 Key: STORM-841
 URL: https://issues.apache.org/jira/browse/STORM-841
 Project: Apache Storm
  Issue Type: Documentation
Reporter: Jungtaek Lim
Priority: Critical

 There're some issues with documentation.
 http://storm.apache.org/documentation/Concepts.html says
 {quote}
 Its perfectly fine to launch new threads in bolts that do processing 
 asynchronously. OutputCollector is thread-safe and can be called at any time.
 {quote}
 and http://storm.apache.org/documentation/Troubleshooting.html says
 {quote}
 This is caused by having multiple threads issue methods on the 
 OutputCollector. All emits, acks, and fails must happen on the same thread. 
 One subtle way this can happen is if you make a IBasicBolt that emits on a 
 separate thread. IBasicBolt's automatically ack after execute is called, so 
 this would cause multiple threads to use the OutputCollector leading to this 
 exception. When using a basic bolt, all emits must happen in the same thread 
 that runs execute.
 {quote}
 It is a contradiction, and at least for now OutputCollector is not 
 thread-safe.
 https://www.mail-archive.com/dev@storm.incubator.apache.org/msg00939.html
 Since newbie of Storm users may think Concepts page as should read and keep 
 it mind, it is some kind of critical that that such important documentation 
 page has wrong content.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)