[jira] [Commented] (STORM-980) Re-include storm-kafka tests from Travis CI build
[ https://issues.apache.org/jira/browse/STORM-980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14693924#comment-14693924 ] ASF GitHub Bot commented on STORM-980: -- Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/674 Re-include storm-kafka tests from Travis CI build - Key: STORM-980 URL: https://issues.apache.org/jira/browse/STORM-980 Project: Apache Storm Issue Type: Sub-task Components: storm-kafka Reporter: Jungtaek Lim Assignee: Jungtaek Lim Recently [~zhuoliu] reported that randome unit tests failures on storm-kafka may be resolved with STORM-826. I rebuilt test-kafka-test branch 5 times in a row (tested with jdk7, jdk8, so storm-kafka unit tests were run 10 times), and I can see there's no longer storm-kafka's random failure. It is broken at 6th trial, but I've met random failure of storm-core first, so we're leaving decision whether we ignore low probabilities of random failures or not. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (STORM-980) Re-include storm-kafka tests from Travis CI build
[ https://issues.apache.org/jira/browse/STORM-980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14693922#comment-14693922 ] ASF GitHub Bot commented on STORM-980: -- Github user d2r commented on the pull request: https://github.com/apache/storm/pull/674#issuecomment-130387500 +1 on your testing of this. We can revert if it does not work. Re-include storm-kafka tests from Travis CI build - Key: STORM-980 URL: https://issues.apache.org/jira/browse/STORM-980 Project: Apache Storm Issue Type: Sub-task Components: storm-kafka Reporter: Jungtaek Lim Assignee: Jungtaek Lim Recently [~zhuoliu] reported that randome unit tests failures on storm-kafka may be resolved with STORM-826. I rebuilt test-kafka-test branch 5 times in a row (tested with jdk7, jdk8, so storm-kafka unit tests were run 10 times), and I can see there's no longer storm-kafka's random failure. It is broken at 6th trial, but I've met random failure of storm-core first, so we're leaving decision whether we ignore low probabilities of random failures or not. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (STORM-980) Re-include storm-kafka tests from Travis CI build
[ https://issues.apache.org/jira/browse/STORM-980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14681678#comment-14681678 ] ASF GitHub Bot commented on STORM-980: -- GitHub user HeartSaVioR opened a pull request: https://github.com/apache/storm/pull/674 STORM-980 Re-include storm-kafka to Travis CI build Please refer https://issues.apache.org/jira/browse/STORM-980 to more details. We should resolve storm-hive build issue first (#609 may help to resolve), so that Travis CI has a chance to run unit tests on storm-kafka. For confirmation, I merged #609 and current PR into another branch on my fork and built it from Travis CI. https://travis-ci.org/HeartSaVioR/storm/builds/75071270 You can merge this pull request into a Git repository by running: $ git pull https://github.com/HeartSaVioR/storm STORM-980 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/674.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #674 commit 73a165639ada07b470f0a0cf39d1c27f15f0d98e Author: Jungtaek Lim kabh...@gmail.com Date: 2015-08-11T11:17:15Z re-include storm-kafka to Travis CI build Re-include storm-kafka tests from Travis CI build - Key: STORM-980 URL: https://issues.apache.org/jira/browse/STORM-980 Project: Apache Storm Issue Type: Sub-task Components: storm-kafka Reporter: Jungtaek Lim Assignee: Jungtaek Lim Recently [~zhuoliu] reported that randome unit tests failures on storm-kafka may be resolved with STORM-826. I rebuilt test-kafka-test branch 5 times in a row (tested with jdk7, jdk8, so storm-kafka unit tests were run 10 times), and I can see there's no longer storm-kafka's random failure. It is broken at 6th trial, but I've met random failure of storm-core first, so we're leaving decision whether we ignore low probabilities of random failures or not. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (STORM-980) Re-include storm-kafka tests from Travis CI build
[ https://issues.apache.org/jira/browse/STORM-980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14692372#comment-14692372 ] ASF GitHub Bot commented on STORM-980: -- Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/674#issuecomment-130095189 Upmerged master to check build also works well with apache repo. Re-include storm-kafka tests from Travis CI build - Key: STORM-980 URL: https://issues.apache.org/jira/browse/STORM-980 Project: Apache Storm Issue Type: Sub-task Components: storm-kafka Reporter: Jungtaek Lim Assignee: Jungtaek Lim Recently [~zhuoliu] reported that randome unit tests failures on storm-kafka may be resolved with STORM-826. I rebuilt test-kafka-test branch 5 times in a row (tested with jdk7, jdk8, so storm-kafka unit tests were run 10 times), and I can see there's no longer storm-kafka's random failure. It is broken at 6th trial, but I've met random failure of storm-core first, so we're leaving decision whether we ignore low probabilities of random failures or not. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (STORM-980) Re-include storm-kafka tests from Travis CI build
[ https://issues.apache.org/jira/browse/STORM-980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14692907#comment-14692907 ] ASF GitHub Bot commented on STORM-980: -- Github user zhuoliu commented on the pull request: https://github.com/apache/storm/pull/674#issuecomment-130159398 LGTM +1 Re-include storm-kafka tests from Travis CI build - Key: STORM-980 URL: https://issues.apache.org/jira/browse/STORM-980 Project: Apache Storm Issue Type: Sub-task Components: storm-kafka Reporter: Jungtaek Lim Assignee: Jungtaek Lim Recently [~zhuoliu] reported that randome unit tests failures on storm-kafka may be resolved with STORM-826. I rebuilt test-kafka-test branch 5 times in a row (tested with jdk7, jdk8, so storm-kafka unit tests were run 10 times), and I can see there's no longer storm-kafka's random failure. It is broken at 6th trial, but I've met random failure of storm-core first, so we're leaving decision whether we ignore low probabilities of random failures or not. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
