DO NOT REPLY [Bug 14071] - Need clear info on which Struts attributes produce specific HTML attributes

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=14071


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2005-04-27 08:33 ---
Strange, I thought I closed this...

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 31023] - Action Grouping

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31023


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2005-04-27 08:29 ---
I believe this can also be resolved since config inheritence is in trunk.  

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 22600] - Defining inheritance for dynamic action forms in struts-config

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=22600





--- Additional Comments From [EMAIL PROTECTED]  2005-04-27 08:27 ---
Is this ticket resolved with the new config inheritence in 1.3?

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 19780] - does not seem to support java.util.Set, contrary to documentation

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=19780


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||INVALID




--- Additional Comments From [EMAIL PROTECTED]  2005-04-27 08:16 ---
Marking as invalid as it seems that was the intention scanning the comments.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 22935] - "Cannot find bean * in scope null" ==> increase error specificness

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=22935


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID




--- Additional Comments From [EMAIL PROTECTED]  2005-04-27 08:13 ---
Unfortunately, this is a limitation with JSP in general.  In this specific case,
the code has been changed to provide a marginally more useful error message,
however, it isn't possible, other than scanning the stack trace, to determine
what tag produced this error or where.  If you have a code example of how to
workaround this issue, please reopen and post the snippet.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r164950 - in /struts/tiles/trunk/src/java/org/apache/struts/tiles: TilesUtil.java TilesUtilImpl.java taglib/InsertTag.java

[mrdon]

Author: mrdon
Date: Tue Apr 26 22:56:52 2005
New Revision: 164950

URL: http://svn.apache.org/viewcvs?rev=164950&view=rev
Log:
Added ability to pass flush attribute of insert tag down to the JSP
include, using reflection to call the JSP 2.0 method if found.
PR: 21972

Modified:
struts/tiles/trunk/src/java/org/apache/struts/tiles/TilesUtil.java
struts/tiles/trunk/src/java/org/apache/struts/tiles/TilesUtilImpl.java
struts/tiles/trunk/src/java/org/apache/struts/tiles/taglib/InsertTag.java

Modified: struts/tiles/trunk/src/java/org/apache/struts/tiles/TilesUtil.java
URL: 
http://svn.apache.org/viewcvs/struts/tiles/trunk/src/java/org/apache/struts/tiles/TilesUtil.java?rev=164950&r1=164949&r2=164950&view=diff
==
--- struts/tiles/trunk/src/java/org/apache/struts/tiles/TilesUtil.java 
(original)
+++ struts/tiles/trunk/src/java/org/apache/struts/tiles/TilesUtil.java Tue Apr 
26 22:56:52 2005
@@ -132,7 +132,21 @@
  */
 public static void doInclude(String uri, PageContext pageContext)
 throws IOException, ServletException {
-tilesUtilImpl.doInclude(uri, pageContext);
+doInclude(uri, pageContext, true);
+}
+
+/**
+ * Do an include using PageContext.include().
+ *
+ * This method is used by the Tiles package when an include is required.
+ * The Tiles package can use indifferently any form of this method.
+ * @param uri Uri or Definition name to forward.
+ * @param flush If the writer should be flushed before the include
+ * @param pageContext Current page context.
+ */
+public static void doInclude(String uri, PageContext pageContext, boolean 
flush)
+throws IOException, ServletException {
+tilesUtilImpl.doInclude(uri, pageContext, flush);
 }
 
 /**

Modified: struts/tiles/trunk/src/java/org/apache/struts/tiles/TilesUtilImpl.java
URL: 
http://svn.apache.org/viewcvs/struts/tiles/trunk/src/java/org/apache/struts/tiles/TilesUtilImpl.java?rev=164950&r1=164949&r2=164950&view=diff
==
--- struts/tiles/trunk/src/java/org/apache/struts/tiles/TilesUtilImpl.java 
(original)
+++ struts/tiles/trunk/src/java/org/apache/struts/tiles/TilesUtilImpl.java Tue 
Apr 26 22:56:52 2005
@@ -21,6 +21,9 @@
 import java.io.IOException;
 import java.io.Serializable;
 
+import java.lang.reflect.Method;
+import java.lang.reflect.InvocationTargetException;
+
 import javax.servlet.ServletContext;
 import javax.servlet.ServletException;
 import javax.servlet.ServletRequest;
@@ -41,11 +44,32 @@
 public class TilesUtilImpl implements Serializable {
 
 /** Commons Logging instance.*/
-protected Log log = LogFactory.getLog(TilesUtil.class);
+protected static final Log log = LogFactory.getLog(TilesUtil.class);
 
 /** Constant name used to store factory in servlet context */
 public static final String DEFINITIONS_FACTORY =
 "org.apache.struts.tiles.DEFINITIONS_FACTORY";
+
+/**
+ * JSP 2.0 include method to use which supports configurable flushing.
+ */
+private static Method include = null;
+
+/**
+ * Initialize the include variable with the
+ * JSP 2.0 method if available.
+ */
+static {
+
+try {
+// get version of include method with flush argument
+Class[] args = new Class[]{String.class, boolean.class};
+include = PageContext.class.getMethod("include", args);
+} catch (NoSuchMethodException e) {
+log.debug("Could not find JSP 2.0 include method.  Using old one 
that doesn't support " +
+  "configurable flushing.", e);
+}
+}
 
 /**
  * Do a forward using request dispatcher.
@@ -92,9 +116,21 @@
  * The Tiles package can use indifferently any form of this method.
  * @param uri Uri or Definition name to forward.
  * @param pageContext Current page context.
+ * @param flush If the writer should be flushed before the include
  */
-public void doInclude(String uri, PageContext pageContext)
+public void doInclude(String uri, PageContext pageContext, boolean flush)
 throws IOException, ServletException {
+try {
+// perform include with new JSP 2.0 method that supports flushing
+if (include != null) {
+include.invoke(pageContext, new Object[]{uri, 
Boolean.valueOf(flush)});
+return;
+} 
+} catch (IllegalAccessException e) {
+log.debug("Could not find JSP 2.0 include method.  Using old 
one.", e);
+} catch (InvocationTargetException e) {
+log.debug("Unable to execute JSP 2.0 include method.  Trying old 
one.", e);
+}
 
 pageContext.include(uri);
 }

Modified: 
struts/tiles/trunk/src/java/org/apache/struts/tiles/taglib/InsertTag.java
UR

[Struts Wiki] Update of "StrutsRememberMeCookie" by MichaelJouravlev

[Apache Wiki]

Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Struts Wiki" for change 
notification.

The following page has been changed by MichaelJouravlev:
http://wiki.apache.org/struts/StrutsRememberMeCookie

--
  
  (2) Action was called after postback. In this case cookie should be set 
according to checkbox value.
  
+ These two cases can be distinguished one of the following way:
- These two cases can be distinguished using hidden field. Submitted field 
identifies postback.
+  * using hidden field. Submitted field identifies postback.
+  * by differentiating between POST and GET request. POST should be used for 
input and model update, GET should be used to load page only.
  
  First, a simple login page:
  
@@ -19, +21 @@

  
Log In

- 
+ 
  
  

@@ -35, +38 @@

  
  }}}
  
- Now the corresponding struts-config.xml. It has two  sections: for 
redirect and for forward. Which one to choose depends on personal taste, but I 
prefer redirection, especially if form bean has session scope. Redirection 
allows to reload page without POSTDATA situation.
+ Now the corresponding struts-config.xml. Notice redirection to itself, this 
trick allows to access the same action using GET method. Redirection allows to 
reload page without POSTDATA situation.
  
  {{{

-   


-   
-   


  }}}
@@ -73, +73 @@

  public void setRememberMe(String rememberMe){ this.rememberMe = 
rememberMe;}
  
  // This property indicates that input was submitted from a client.
- // In this case  the checkbox value should be consulted
+ // In this case  the checkbox value should be consulted instead of
- // instead of stored cookie value.
+ // stored cookie value. 
+ // This property is NOT needed if POST/GET differentiation is used.
  private String usersubmit;
  public String getUsersubmit() {return usersubmit;}
  public void setUsersubmit(String usersubmit) {this.usersubmit = 
usersubmit;}
@@ -111, +112 @@

  
  LoginForm login = (LoginForm) form;
  
+ // Model should be updated via POST only
+ boolean isInput = "POST".equalsIgnoreCase(request.getMethod());
+ 
+ // Can also use hidden field, if for some reason 
+ // model can be updated by GET as well
+ // isInput = login.getUsersubmit() != null;
+ 
- // Page is navigated from external location; displayed first time
+ // Page is navigated from external location
- if (login.getUsersubmit() == null) {
+ // or after cookie was set appropriately
+ if (!isInput) {

// If cookie is set...
if (isCookieSet(request)) {
@@ -123, +132 @@

} else {
  // ...there is nothing to do, field was cleared in reset()
}
+ 
+   // Display the page. Checkbox is set according to the cookie,
+   // other fields are pulled from the form, it has session scope.
+   return mapping.findForward("showpage");
  
  // Page is [re]-submitted
  } else {
@@ -139, +152 @@

  cookie.setMaxAge(COOKIE_REMOVE);
  response.addCookie(cookie);
}
+ 
+   // Redirect to itself to prepare and display the page.
+   // Redirect allows to reload a page safely.
+   //
+   // Browser is redirected to the same /Login.do action
+   // and loads page with empty GET request. Because request has 
+   // no parameters, getUsersubmit() == null and checkbox 
+   // is shown correctly, because cookie was already set.
+   return mapping.findForward("getview");
  }
- 
- // Jumps to success page. Can do either forward or redirect.
- // I prefer redirect, since it allows to reload a page safely.   
- //
- // In this sample browser is redirected to the same /Login.do action
- // and loads page with empty GET request, thus getUsersubmit()==null
- // and checkbox is shown correctly, because cookie was already set.
- //
- // Other fields are pulled directly from form, since it has
- // session scope.
- if ("POST".equalsIgnoreCase(request.getMethod())) {
-   return mapping.findForward("getview");
- } else {
-   return mapping.findForward("showpage");
- }
- 
- // Classic forward to the login.jsp. Does not allow to reload page, yuck.
- // return mapping.findForward("success");
}
  
private boolean isCookieSet(HttpServletRequest request) {

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[Struts Wiki] Update of "StrutsRememberMeCookie" by MichaelJouravlev

[Apache Wiki]

Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Struts Wiki" for change 
notification.

The following page has been changed by MichaelJouravlev:
http://wiki.apache.org/struts/StrutsRememberMeCookie

New page:
It is often needed to set/unset/show "Remeber Me" checkbox. The shown method 
works together with the cookie, stored on user's machine. When a user navigates 
to the page, action must set "Remember Me" checkbox if cookie is supplied by 
browser. 

Cookie/checkbox thing has one small issue: when cookie was set before, and no 
checkbox value is submitted by browser. Application must distinguish between 
two cases:

(1) Action was called directly from browser location bar, or from other page. 
In other words, action was called for the first time, and it should display the 
checkbox based on saved cookie.

(2) Action was called after postback. In this case cookie should be set 
according to checkbox value.

These two cases can be distinguished using hidden field. Submitted field 
identifies postback.

First, a simple login page:

{{{
<%@ page contentType="text/html; charset=UTF-8" %>
<%@ taglib uri="http://jakarta.apache.org/struts/tags-html"; prefix="html"%>


  Log In
  



  

Remember me

  
  
  

  


}}}

Now the corresponding struts-config.xml. It has two  sections: for 
redirect and for forward. Which one to choose depends on personal taste, but I 
prefer redirection, especially if form bean has session scope. Redirection 
allows to reload page without POSTDATA situation.

{{{
  

  
  
  
  
  
  
  
  
  
}}}

Now the form bean:

{{{
package org.acme;

import javax.servlet.http.HttpServletRequest;
import org.apache.struts.action.ActionForm;
import org.apache.struts.action.ActionMapping;

public class LoginForm extends ActionForm
{
// "Remeber me" checkbox
private String rememberMe;
public String getRememberMe() {return rememberMe;}
public void setRememberMe(String rememberMe){ this.rememberMe = rememberMe;}

// This property indicates that input was submitted from a client.
// In this case  the checkbox value should be consulted
// instead of stored cookie value.
private String usersubmit;
public String getUsersubmit() {return usersubmit;}
public void setUsersubmit(String usersubmit) {this.usersubmit = usersubmit;}

public void reset(ActionMapping mapping, HttpServletRequest request) {
  rememberMe = null;
  usersubmit = null;
}
}
}}}

And finally the action class:

{{{
package org.acme;

import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
import javax.servlet.http.Cookie;

import org.apache.struts.action.Action;
import org.apache.struts.action.ActionForm;
import org.apache.struts.action.ActionForward;
import org.apache.struts.action.ActionMapping;

public class LoginAction extends Action
{   
  public static final String COOKIE_NAME = "COOKIE_REMEMBER_ME";
  public static final int COOKIE_REMOVE = 0;
  public static final int COOKIE_ONEHOUR = 3600;

  public ActionForward execute(ActionMapping mapping, ActionForm form,
HttpServletRequest request, HttpServletResponse response) {

LoginForm login = (LoginForm) form;

// Page is navigated from external location; displayed first time
if (login.getUsersubmit() == null) {
  
  // If cookie is set...
  if (isCookieSet(request)) {
// ...turn on checkbox
login.setRememberMe("on");

  // If cookie is not set...
  } else {
// ...there is nothing to do, field was cleared in reset()
  }

// Page is [re]-submitted
} else {

  // Must [re]-set cookie
  if (login.getRememberMe() != null) {
Cookie cookie = new Cookie(COOKIE_NAME, "");
cookie.setMaxAge(COOKIE_ONEHOUR);
response.addCookie(cookie);

  // Must clean cookie
  } else if (login.getRememberMe() == null && isCookieSet(request)) {
Cookie cookie = new Cookie(COOKIE_NAME, "");
cookie.setMaxAge(COOKIE_REMOVE);
response.addCookie(cookie);
  }
}

// Jumps to success page. Can do either forward or redirect.
// I prefer redirect, since it allows to reload a page safely.   
//
// In this sample browser is redirected to the same /Login.do action
// and loads page with empty GET request, thus getUsersubmit()==null
// and checkbox is shown correctly, because cookie was already set.
//
// Other fields are pulled directly from form, since it has
// session scope.
if ("POST".equalsIgnoreCase(request.getMethod())) {
  return mapping.findForward("getview");
} else {
  return mapping.findForward("showpage");
}

// Classic forward to the login.jsp. Does not allow to reload page, yuck.
// return mapping.findForward("success");
  }

  private boolean isCookieSet(HttpServletRequest requ

[Struts Wiki] Update of "StrutsCatalog" by MichaelJouravlev

[Apache Wiki]

Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Struts Wiki" for change 
notification.

The following page has been changed by MichaelJouravlev:
http://wiki.apache.org/struts/StrutsCatalog

--
   *  StrutsFileUpload
   *  StrutsFileDownload
   *  ApplicationSecurity
+  *  StrutsRememberMeCookie
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[Struts Wiki] Update of "StrutsRelease127" by NiallPemberton

[Apache Wiki]

Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Struts Wiki" for change 
notification.

The following page has been changed by NiallPemberton:
http://wiki.apache.org/struts/StrutsRelease127

--
  || 32595 || Scaffold !BaseAction.executeLogic() calls removed 
!ActionServlet.log(String, Integer) || sandbox || N/A ||
  || 32624 || Scaffold !BaseAction.getMessageResources calls removed 
!ActionServlet.getResources() || sandbox || N/A ||
  || 33132 || org.apache.struts.upload.!MultipartRequestWrapper doesn't 
implement servlet 2.4 api fully || upload || FIXED in 1.2.x ||
+ || 33355 || computeURLWithCharEncoding doesn't encodes the & created by the 
response.encudeURL call || taglibs || ? ||
  || 33254 || unable to specify maximum file size attribute greater than 1GB in 
struts-config.xml || upload || WORKSFORME ||
  || 33989 || ant test.tomcat.40 fails: taskdef class 
org.apache.cactus.ant.!RunServerTestsTask cannot be found, task name 
runservertests || test || ? ||
  || 33996 || !ChainAction does not support non-default catalogs || sandbox || 
? ||

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[Struts Wiki] Update of "StrutsRelease127" by NiallPemberton

[Apache Wiki]

Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Struts Wiki" for change 
notification.

The following page has been changed by NiallPemberton:
http://wiki.apache.org/struts/StrutsRelease127

--
  || 34445 || use charsets given by browser for form field encodings || upload 
|| ? ||
  || 34495 || Add Java Doc to may source files and add more Tapestry  like 
support || shale || N/A ||
  || 34496 || Add Java Doc to may source files and add more Tapestry  like 
support || shale || N/A ||
- || 34628 || html:multibox does not mark input status as checked when HTML 
sensitive characters are present in value. || taglibs || ? ||
+ || 34628 || html:multibox does not mark input status as checked when HTML 
sensitive characters are present in value. || taglibs || INVALID ||
  
  == Preparation Checklist ==
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 34628] - html:multibox does not mark input status as checked when HTML sensitive characters are present in value.

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34628


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID




--- Additional Comments From [EMAIL PROTECTED]  2005-04-27 03:24 ---
Multibox doesn't do what you say - it only "filters" the value rendered - not 
the one compared.

The problem here is how you are using the tags. You're using a  tag 
in the  tag's body to specify the value. The  tag's 
default behaviour is to filter HTML sensitive values, but you can change this 
using its filter attribute.

The following should work:








Please could you ask questions on the user list first when you're having 
problems, rather than openning a bugzilla ticket.

Closing this as INVALID.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r164928 - /struts/core/branches/STRUTS_1_2_BRANCH/doc/userGuide/release-notes.xml

[niallp]

Author: niallp
Date: Tue Apr 26 17:59:25 2005
New Revision: 164928

URL: http://svn.apache.org/viewcvs?rev=164928&view=rev
Log:
Update 1.2.7 Release Notes

Modified:
struts/core/branches/STRUTS_1_2_BRANCH/doc/userGuide/release-notes.xml

Modified: struts/core/branches/STRUTS_1_2_BRANCH/doc/userGuide/release-notes.xml
URL: 
http://svn.apache.org/viewcvs/struts/core/branches/STRUTS_1_2_BRANCH/doc/userGuide/release-notes.xml?rev=164928&r1=164927&r2=164928&view=diff
==
--- struts/core/branches/STRUTS_1_2_BRANCH/doc/userGuide/release-notes.xml 
(original)
+++ struts/core/branches/STRUTS_1_2_BRANCH/doc/userGuide/release-notes.xml Tue 
Apr 26 17:59:25 2005
@@ -172,16 +172,31 @@
   
   Version 1.2.7
 
+  
+  After http://svn.apache.org/viewcvs.cgi/struts/core/tags/STRUTS_1_2_6/";>Version 
1.2.6 was tagged
+  the http://svn.apache.org/viewcvs.cgi/struts/core/branches/STRUTS_1_2_BRANCH/";>1.2
 Branch
+  was created and work started on the next version (1.3.x 
series). Work has continued on
+  both versions and Revision numbers shown in brackets are 
where a change has been ported
+  from the current development version into the 1.2 Branch.
+  
+
  
  
  
ModificationRevisionBugzillaDescription
  
  
+ 2005-04-27
+ http://svn.apache.org/viewcvs?rev=164922&view=rev";>164922
+ (http://svn.apache.org/viewcvs.cgi?rev=164927&view=rev";>164927)
+ http://issues.apache.org/bugzilla/show_bug.cgi?id=23127";>23127
+ Page attribute of img and image tags doesn't use 
pagePattern setting.
+ 
+ 
  2005-04-26
  http://svn.apache.org/viewcvs?rev=164814&view=rev";>164814
  (http://svn.apache.org/viewcvs.cgi?rev=164831&view=rev";>164831)
  http://issues.apache.org/bugzilla/show_bug.cgi?id=34624";>34624
- BeanValidatorForm's getValidationKey method should call 
mapping.getAttribute() .
+ BeanValidatorForm's getValidationKey method should call 
mapping.getAttribute().
  
  
  2005-04-26
@@ -397,6 +412,12 @@
 (http://svn.apache.org/viewcvs.cgi?rev=159674&view=rev";>159674)
  n/a
  Remove use of "enum" as its a keyword in Java 5.
+ 
+ 
+ 2004-11-20
+ http://svn.apache.org/viewcvs.cgi?rev=106043&view=rev";>106043
+ n/a
+ http://svn.apache.org/viewcvs.cgi/struts/core/branches/STRUTS_1_2_BRANCH/";>1.2.x
 Branch created
  
  
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[Struts Wiki] Update of "StrutsRelease127" by NiallPemberton

[Apache Wiki]

Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Struts Wiki" for change 
notification.

The following page has been changed by NiallPemberton:
http://wiki.apache.org/struts/StrutsRelease127

--
  
  || '''ID''' || '''Summary''' || '''Component''' || '''Status''' ||
  || 20034 || Invalid cache in !InsertTag || taglibs || ? ||
- || 23127 || Page attribute of img and image tags doesn't use pagePattern 
setting || taglibs || ? ||
+ || 23127 || Page attribute of img and image tags doesn't use pagePattern 
setting || taglibs || FIXED ||
  || 31230 || Multiple classes using deprecated !DefinitionsUtil class || Tiles 
|| Remove deprecations in 1.3.x ||
  || 31658 || !LogonAction does not check errors in appropriate place || 
!MailReader || FIXED ||
  || 32165 || !FacesRequestProcessor bug when using prefix mapped Struts ... || 
struts-faces || N/A ||
@@ -37, +37 @@

  || 34445 || use charsets given by browser for form field encodings || upload 
|| ? ||
  || 34495 || Add Java Doc to may source files and add more Tapestry  like 
support || shale || N/A ||
  || 34496 || Add Java Doc to may source files and add more Tapestry  like 
support || shale || N/A ||
+ || 34628 || html:multibox does not mark input status as checked when HTML 
sensitive characters are present in value. || taglibs || ? ||
  
  == Preparation Checklist ==
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 23127] - Page attribute of img and image tags doesn't use pagePattern setting

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=23127


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2005-04-27 02:46 ---
I have fixed this in both the current development version and the 1.2.x branch.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 20178] - html:img doesn't respect module pagePattern settings

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=20178


Bug 20178 depends on bug 23127, which changed state.

Bug 23127 Summary: Page attribute of img and image tags doesn't use pagePattern 
setting
http://issues.apache.org/bugzilla/show_bug.cgi?id=23127

   What|Old Value   |New Value

 Status|NEW |RESOLVED
 Resolution||FIXED



-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r164927 - /struts/core/branches/STRUTS_1_2_BRANCH/src/share/org/apache/struts/taglib/html/ImageTag.java /struts/core/branches/STRUTS_1_2_BRANCH/src/share/org/apache/struts/taglib/html/ImgTag.java

[niallp]

Author: niallp
Date: Tue Apr 26 17:41:05 2005
New Revision: 164927

URL: http://svn.apache.org/viewcvs?rev=164927&view=rev
Log:
Port Bug #23127 to 1.2.x branch - Page attribute of img and image tags doesn't 
use pagePattern setting reported by Julian Mitchel

Modified:

struts/core/branches/STRUTS_1_2_BRANCH/src/share/org/apache/struts/taglib/html/ImageTag.java

struts/core/branches/STRUTS_1_2_BRANCH/src/share/org/apache/struts/taglib/html/ImgTag.java

Modified: 
struts/core/branches/STRUTS_1_2_BRANCH/src/share/org/apache/struts/taglib/html/ImageTag.java
URL: 
http://svn.apache.org/viewcvs/struts/core/branches/STRUTS_1_2_BRANCH/src/share/org/apache/struts/taglib/html/ImageTag.java?rev=164927&r1=164926&r2=164927&view=diff
==
--- 
struts/core/branches/STRUTS_1_2_BRANCH/src/share/org/apache/struts/taglib/html/ImageTag.java
 (original)
+++ 
struts/core/branches/STRUTS_1_2_BRANCH/src/share/org/apache/struts/taglib/html/ImageTag.java
 Tue Apr 26 17:41:05 2005
@@ -1,7 +1,7 @@
 /*
  * $Id$ 
  *
- * Copyright 1999-2004 The Apache Software Foundation.
+ * Copyright 1999-2005 The Apache Software Foundation.
  * 
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -211,11 +211,13 @@
 HttpServletRequest request =
 (HttpServletRequest) pageContext.getRequest();
 
-if (config == null) {
-return (request.getContextPath() + this.page);
-} else {
-return (request.getContextPath() + config.getPrefix() + 
this.page);
+String pageValue = this.page;
+if (config != null) {
+pageValue = TagUtils.getInstance().pageURL(request,
+   this.page,
+   config);
 }
+return (request.getContextPath() + pageValue);
 }
 
 // Deal with an indirect context-relative page that has been specified
@@ -233,24 +235,17 @@
 HttpServletRequest request =
 (HttpServletRequest) pageContext.getRequest();
 
-if (config == null) {
-return (
-request.getContextPath()
-+ TagUtils.getInstance().message(
-pageContext,
-getBundle(),
-getLocale(),
-this.pageKey));
-} else {
-return (
-request.getContextPath()
-+ config.getPrefix()
-+ TagUtils.getInstance().message(
-pageContext,
-getBundle(),
-getLocale(),
-this.pageKey));
+String pageValue = TagUtils.getInstance().message(
+  pageContext,
+  getBundle(),
+  getLocale(),
+  this.pageKey);
+if (config != null) {
+pageValue = TagUtils.getInstance().pageURL(request,
+   pageValue,
+   config);
 }
+return (request.getContextPath() + pageValue);
 }
 
 // Deal with an absolute source that has been specified

Modified: 
struts/core/branches/STRUTS_1_2_BRANCH/src/share/org/apache/struts/taglib/html/ImgTag.java
URL: 
http://svn.apache.org/viewcvs/struts/core/branches/STRUTS_1_2_BRANCH/src/share/org/apache/struts/taglib/html/ImgTag.java?rev=164927&r1=164926&r2=164927&view=diff
==
--- 
struts/core/branches/STRUTS_1_2_BRANCH/src/share/org/apache/struts/taglib/html/ImgTag.java
 (original)
+++ 
struts/core/branches/STRUTS_1_2_BRANCH/src/share/org/apache/struts/taglib/html/ImgTag.java
 Tue Apr 26 17:41:05 2005
@@ -542,11 +542,13 @@
 pageContext.getServletContext());
 
 HttpServletRequest request = (HttpServletRequest) 
pageContext.getRequest();
-if (srcDefaultReference(config)) {
-return (request.getContextPath() + this.page);
-} else {
-return (request.getContextPath() + config.getPrefix() + 
this.page);
+String pageValue = this.page;
+if (!srcDefaultReference(config)) {
+pageValue = TagUtils.getInstance().pageURL(request,
+   this.page,
+   config);
 }
+ 

svn commit: r164922 - /struts/taglib/trunk/src/java/org/apache/struts/taglib/html/ImageTag.java /struts/taglib/trunk/src/java/org/apache/struts/taglib/html/ImgTag.java

[niallp]

Author: niallp
Date: Tue Apr 26 17:11:47 2005
New Revision: 164922

URL: http://svn.apache.org/viewcvs?rev=164922&view=rev
Log:
Resolve Bug #23127 - Page attribute of img and image tags doesn't use 
pagePattern setting reported by Julian Mitchel

Modified:
struts/taglib/trunk/src/java/org/apache/struts/taglib/html/ImageTag.java
struts/taglib/trunk/src/java/org/apache/struts/taglib/html/ImgTag.java

Modified: 
struts/taglib/trunk/src/java/org/apache/struts/taglib/html/ImageTag.java
URL: 
http://svn.apache.org/viewcvs/struts/taglib/trunk/src/java/org/apache/struts/taglib/html/ImageTag.java?rev=164922&r1=164921&r2=164922&view=diff
==
--- struts/taglib/trunk/src/java/org/apache/struts/taglib/html/ImageTag.java 
(original)
+++ struts/taglib/trunk/src/java/org/apache/struts/taglib/html/ImageTag.java 
Tue Apr 26 17:11:47 2005
@@ -1,7 +1,7 @@
 /*
  * $Id$ 
  *
- * Copyright 1999-2004 The Apache Software Foundation.
+ * Copyright 1999-2005 The Apache Software Foundation.
  * 
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -211,11 +211,13 @@
 HttpServletRequest request =
 (HttpServletRequest) pageContext.getRequest();
 
-if (config == null) {
-return (request.getContextPath() + this.page);
-} else {
-return (request.getContextPath() + config.getPrefix() + 
this.page);
+String pageValue = this.page;
+if (config != null) {
+pageValue = TagUtils.getInstance().pageURL(request,
+   this.page,
+   config);
 }
+return (request.getContextPath() + pageValue);
 }
 
 // Deal with an indirect context-relative page that has been specified
@@ -233,24 +235,17 @@
 HttpServletRequest request =
 (HttpServletRequest) pageContext.getRequest();
 
-if (config == null) {
-return (
-request.getContextPath()
-+ TagUtils.getInstance().message(
-pageContext,
-getBundle(),
-getLocale(),
-this.pageKey));
-} else {
-return (
-request.getContextPath()
-+ config.getPrefix()
-+ TagUtils.getInstance().message(
-pageContext,
-getBundle(),
-getLocale(),
-this.pageKey));
+String pageValue = TagUtils.getInstance().message(
+  pageContext,
+  getBundle(),
+  getLocale(),
+  this.pageKey);
+if (config != null) {
+pageValue = TagUtils.getInstance().pageURL(request,
+   pageValue,
+   config);
 }
+return (request.getContextPath() + pageValue);
 }
 
 // Deal with an absolute source that has been specified

Modified: struts/taglib/trunk/src/java/org/apache/struts/taglib/html/ImgTag.java
URL: 
http://svn.apache.org/viewcvs/struts/taglib/trunk/src/java/org/apache/struts/taglib/html/ImgTag.java?rev=164922&r1=164921&r2=164922&view=diff
==
--- struts/taglib/trunk/src/java/org/apache/struts/taglib/html/ImgTag.java 
(original)
+++ struts/taglib/trunk/src/java/org/apache/struts/taglib/html/ImgTag.java Tue 
Apr 26 17:11:47 2005
@@ -1,7 +1,7 @@
 /*
  * $Id$ 
  *
- * Copyright 1999-2004 The Apache Software Foundation.
+ * Copyright 1999-2005 The Apache Software Foundation.
  * 
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -541,11 +541,13 @@
 pageContext.getServletContext());
 
 HttpServletRequest request = (HttpServletRequest) 
pageContext.getRequest();
-if (srcDefaultReference(config)) {
-return (request.getContextPath() + this.page);
-} else {
-return (request.getContextPath() + config.getPrefix() + 
this.page);
+String pageValue = this.page;
+if (!srcDefaultReference(config)) {
+pageValue = TagUtils.getInstance().pageURL(request,
+   this.page,
+ 

DO NOT REPLY [Bug 34612] - Handling Remember-Me Checkboxes

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34612





--- Additional Comments From [EMAIL PROTECTED]  2005-04-26 23:20 ---
So are you fellas gonna fix this or not?  I propose a VERY simple (imho) 
solution:

1)  Create a CheckBox class.

2)  During a request, we will check (via reflection) if the class has any
setXXX(Checkbox cb), and if it does, we parse out the "XXX" part, and see if it
was in the request.  If it was, we call setXXX(param.XXX), if it wasn't we call
setXXX(null).

That's it.  A 5-minute task to implement, that would solve this problem.

Of course you'd probably want to cache that XXX method so you don't have to do
the reflection on every request, but it's still very simple.



-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r164882 - in /struts/core/branches/STRUTS_1_2_BRANCH/doc/userGuide: index.xml release-notes.xml

[niallp]

Author: niallp
Date: Tue Apr 26 14:10:49 2005
New Revision: 164882

URL: http://svn.apache.org/viewcvs?rev=164882&view=rev
Log:
Update 1.2.7 Release Notes

Modified:
struts/core/branches/STRUTS_1_2_BRANCH/doc/userGuide/index.xml
struts/core/branches/STRUTS_1_2_BRANCH/doc/userGuide/release-notes.xml

Modified: struts/core/branches/STRUTS_1_2_BRANCH/doc/userGuide/index.xml
URL: 
http://svn.apache.org/viewcvs/struts/core/branches/STRUTS_1_2_BRANCH/doc/userGuide/index.xml?rev=164882&r1=164881&r2=164882&view=diff
==
--- struts/core/branches/STRUTS_1_2_BRANCH/doc/userGuide/index.xml (original)
+++ struts/core/branches/STRUTS_1_2_BRANCH/doc/userGuide/index.xml Tue Apr 26 
14:10:49 2005
@@ -165,6 +165,7 @@
 
 6.1 Release Notes
 
+Release Notes 
1.2.4
 Release Notes 1.1
 Release Notes 
1.1-rc2
 Release Notes 
1.1-rc1

Modified: struts/core/branches/STRUTS_1_2_BRANCH/doc/userGuide/release-notes.xml
URL: 
http://svn.apache.org/viewcvs/struts/core/branches/STRUTS_1_2_BRANCH/doc/userGuide/release-notes.xml?rev=164882&r1=164881&r2=164882&view=diff
==
--- struts/core/branches/STRUTS_1_2_BRANCH/doc/userGuide/release-notes.xml 
(original)
+++ struts/core/branches/STRUTS_1_2_BRANCH/doc/userGuide/release-notes.xml Tue 
Apr 26 14:10:49 2005
@@ -4,8 +4,8 @@
 Struts Release Notes (since 1.2.4)
   
  
- 
-  
+ 
+  
   
   This section contains release notes for changes that have taken
   place since
@@ -26,7 +26,7 @@
  
   
 
-  
+  
   
   The purpose of this section is to highlight the new features 
since the
   Version 1.2.4 release. For detailed information concerning 
changes 
@@ -44,7 +44,7 @@
Dependency on Commons Lang has been removed
   
 
-  2.2 Core Struts
+  Core Struts
   Saving Messages in the Session
   
   A new method to store errors in the Session 
[saveErrors(HttpSession, ActionMessages)]
@@ -75,7 +75,7 @@
   Lazy Validator Form
   
   A DynaBean flavour ActionForm which doesn't need its 
properties to be
-  defined and provdies Lazy List and Lazy Map 
behaviours.
+  defined and provides Lazy List and Lazy Map 
behaviours.
   
Config Files in jars
   
@@ -83,7 +83,7 @@
   Struts checks the servlet context, as before but if not found 
Struts now tries the classloader to try
   and get them.
   
-  2.3 Tag Libray Changes
+  Tag Library Changes
   Highlighting Errors
   
   Struts can now automatically highlight error fields using the 
new errorKey,
@@ -129,7 +129,7 @@
   See the User Guide for 
details of these attributes.
   
 
-  2.4 Validator
+  Validator
   Resource Bundle Support
   
   The bundle attribute for the  and  
elements in the Validator
@@ -141,14 +141,14 @@
   Resource Bundle Support and a page for validwhen 
examples.
   
 
-  2.5 Subversion
+  Subversion
   
   Struts has migrated it's source repository from CVS to 
Subversion, following which the
   repository has been refactored into subprojects. The subproject 
re-factoring does not
   however affect the 1.2.x series which is released from the
   http://svn.apache.org/viewcvs.cgi/struts/core/branches/STRUTS_1_2_BRANCH/";>STRUTS_1_2
 branch.
   
-  2.6 People
+  People
   
   On the people front, in 
addition to Martin Cooper  being 
   appointed the new PMC 
chair, one new committer, 
@@ -158,13 +158,19 @@
   
   
 
-  
+  
   
   This section contains the details of changes since version 1.2.4 
with links to
-  bugzilla tickets and Subersion Revision details.
+  bugzilla tickets and Subversion Revision details. It is split 
into the following
+  sub-sections.
   
+  
+  Version 1.2.7 Changes
+  Version 1.2.6 Changes
+  Version 1.2.5 Changes
+  
   
-  3.1 Version 1.2.7
+  Version 1.2.7
 
  
  
@@ -394,7 +400,7 @@
  
  
 
- 3.2 Version 1.2.6
+ Version 1.2.6
 
  
  
@@ -566,7 +572,7 @@
  
  
 
- 3.3 Version 1.2.5
+ Version 1.2.5
 
  
  



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL

DO NOT REPLY [Bug 34612] - Handling Remember-Me Checkboxes

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34612


[EMAIL PROTECTED] changed:

   What|Removed |Added

Summary|Unchecked checkboxes aren't |Handling Remember-Me
   |set in Forms..  |Checkboxes




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: DO NOT REPLY [Bug 34612] - Unchecked checkboxes aren't set in Forms..

[Ted Husted]

> --- Additional Comments From [EMAIL PROTECTED]  2005-04-26 08:27 ---
> It's not really a problem figuring out STruts...  I really do think you (we)
> should figure out a way to deal with this.
> 
> If nothing is sent from the browser regarding the checkbox - shouldn't we 
> assume
> that it's in off position?  And therefore set it to off?
> 
> I can't go your way - I'm working on the "Remember Me" feature for the account
> system - and if the user goes onto the login page, and he has the right 
> cookies
> set, I want that checkbox to be checked right away.
> 
> In other words, having all checkboxes "off" by default sound like a pretty 
> dumb
> solution.  Really, it's not a solution at all.

Thanks for volunteering, Ivan. 

We'd all love to see a slick way to handle checkboxes. 

When your patch is ready for review, you can attach it to this ticket.

Following Joe's suggestion, I'll rename it "Handling Remember-Me
checkboxes", but the number will remain the same.

-Ted.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[Struts Wiki] Update of "StrutsRelease127" by NiallPemberton

[Apache Wiki]

Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Struts Wiki" for change 
notification.

The following page has been changed by NiallPemberton:
http://wiki.apache.org/struts/StrutsRelease127

The comment on the change is:
Update some Bug Status on Release Plan

--
  || 20034 || Invalid cache in !InsertTag || taglibs || ? ||
  || 23127 || Page attribute of img and image tags doesn't use pagePattern 
setting || taglibs || ? ||
  || 31230 || Multiple classes using deprecated !DefinitionsUtil class || Tiles 
|| Remove deprecations in 1.3.x ||
- || 31658 || !LogonAction does not check errors in appropriate place || 
!MailReader || Will change in 1.3.x when Apps is a subproject ||
+ || 31658 || !LogonAction does not check errors in appropriate place || 
!MailReader || FIXED ||
  || 32165 || !FacesRequestProcessor bug when using prefix mapped Struts ... || 
struts-faces || N/A ||
  || 32341 || [Shale] org.apache.shale.Constants breaks OOP || shale || N/A ||
  || 32595 || Scaffold !BaseAction.executeLogic() calls removed 
!ActionServlet.log(String, Integer) || sandbox || N/A ||
  || 32624 || Scaffold !BaseAction.getMessageResources calls removed 
!ActionServlet.getResources() || sandbox || N/A ||
- || 33132 || org.apache.struts.upload.!MultipartRequestWrapper doesn't 
implement servlet 2.4 api fully || upload || ? ||
+ || 33132 || org.apache.struts.upload.!MultipartRequestWrapper doesn't 
implement servlet 2.4 api fully || upload || FIXED in 1.2.x ||
- || 33254 || unable to specify maximum file size attribute greater than 1GB in 
struts-config.xml || upload || ? ||
+ || 33254 || unable to specify maximum file size attribute greater than 1GB in 
struts-config.xml || upload || WORKSFORME ||
  || 33989 || ant test.tomcat.40 fails: taskdef class 
org.apache.cactus.ant.!RunServerTestsTask cannot be found, task name 
runservertests || test || ? ||
  || 33996 || !ChainAction does not support non-default catalogs || sandbox || 
? ||
- || 34314 || Tiles Request Processor Does Not Catch !NoSuchDefinitionException 
|| tiles || ? ||
+ || 34314 || Tiles Request Processor Does Not Catch !NoSuchDefinitionException 
|| tiles || FIXED ||
  || 34445 || use charsets given by browser for form field encodings || upload 
|| ? ||
  || 34495 || Add Java Doc to may source files and add more Tapestry  like 
support || shale || N/A ||
  || 34496 || Add Java Doc to may source files and add more Tapestry  like 
support || shale || N/A ||

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r164867 - /struts/core/branches/STRUTS_1_2_BRANCH/doc/userGuide/release-notes.xml

[niallp]

Author: niallp
Date: Tue Apr 26 12:58:36 2005
New Revision: 164867

URL: http://svn.apache.org/viewcvs?rev=164867&view=rev
Log:
Update 1.2.7 Release Notes

Modified:
struts/core/branches/STRUTS_1_2_BRANCH/doc/userGuide/release-notes.xml

Modified: struts/core/branches/STRUTS_1_2_BRANCH/doc/userGuide/release-notes.xml
URL: 
http://svn.apache.org/viewcvs/struts/core/branches/STRUTS_1_2_BRANCH/doc/userGuide/release-notes.xml?rev=164867&r1=164866&r2=164867&view=diff
==
--- struts/core/branches/STRUTS_1_2_BRANCH/doc/userGuide/release-notes.xml 
(original)
+++ struts/core/branches/STRUTS_1_2_BRANCH/doc/userGuide/release-notes.xml Tue 
Apr 26 12:58:36 2005
@@ -4,6 +4,7 @@
 Struts Release Notes (since 1.2.4)
   
  
+ 
   
   
   This section contains release notes for changes that have taken
@@ -52,10 +53,23 @@
   release.
   
 
+  Re-directing ActionForward
+  
+  ActionRedirect is a subclass of ActionForward which is 
designed for use in redirecting requests, 
+with support for adding parameters at runtime. See 
the javadoc for more details.
+  
+
   Download Action
   
-  An abstract action that provides the nuts and bolts for 
downloading files. See the javadocs
-  and http://wiki.apache.org/struts/StrutsFileDownload";>Wiki for further 
information.
+  DownloadAction is an abstract action that provides the 
nuts and bolts for downloading 
+  files. See the javadocs and http://wiki.apache.org/struts/StrutsFileDownload";>Wiki
+  for further information.
+  
+
+  Dispatch Helper
+  
+  ActionDispatcher is a helper class for providing 
DispatchAction type behaviour
+  without having to inherit from DispatchAction. See the 
javadoc for more details.
   
 
   Lazy Validator Form
@@ -158,12 +172,40 @@
  
  
  2005-04-26
+ http://svn.apache.org/viewcvs?rev=164814&view=rev";>164814
+ (http://svn.apache.org/viewcvs.cgi?rev=164831&view=rev";>164831)
+ http://issues.apache.org/bugzilla/show_bug.cgi?id=34624";>34624
+ BeanValidatorForm's getValidationKey method should call 
mapping.getAttribute() .
+ 
+ 
+ 2005-04-26
  http://svn.apache.org/viewcvs?rev=164745&view=rev";>164745
  (http://svn.apache.org/viewcvs.cgi?rev=164746&view=rev";>164746)
  http://issues.apache.org/bugzilla/show_bug.cgi?id=31270";>31270
  Add ActionDispatcher to provide dispatch behavior to 
classes that do not extend DispatchAction.
  
  
+ 2005-04-26
+ http://svn.apache.org/viewcvs?rev=164729&view=rev";>164729
+ (http://svn.apache.org/viewcvs.cgi?rev=164862&view=rev";>164862)
+ http://issues.apache.org/bugzilla/show_bug.cgi?id=19901";>19901
+ Add a check for null page value and throwing more 
informative exception.
+ 
+ 
+ 2005-04-26
+ http://svn.apache.org/viewcvs?rev=164723&view=rev";>164723
+ (http://svn.apache.org/viewcvs.cgi?rev=164860&view=rev";>164860)
+ http://issues.apache.org/bugzilla/show_bug.cgi?id=16653";>16653
+ Add a check for missing Validator Resources and throw a 
more useful error message.
+ 
+ 
+ 2005-04-26
+ http://svn.apache.org/viewcvs?rev=164718&view=rev";>164718
+ (http://svn.apache.org/viewcvs.cgi?rev=164858&view=rev";>164858)
+ http://issues.apache.org/bugzilla/show_bug.cgi?id=31658";>31658
+ LogonAction does not check errors in appropriate 
place.
+ 
+ 
  2005-04-25
  http://svn.apache.org/viewcvs?rev=164734&view=rev";>164734
  (http://svn.apache.org/viewcvs.cgi?rev=164703&view=rev";>164703)
@@ -178,6 +220,16 @@
  Implement Servlet 2.3/2.4 methods using reflection in 
MultipartRequestWrapper.
  
  
+ 2005-04-25
+ http://svn.apache.org/viewcvs.cgi?rev=164591&view=rev";>164591
+ (http://svn.apache.org/viewcvs.cgi?rev=164590&view=rev";>164590)
+ n/a
+ Synchronize the Nested tag attributes for changes 
made in 
+ http://issues.apache.org/bugzilla/show_bug.cgi?id=17708";>Bug #17708 
and
+ http://issues.apache.org/bugzilla/show_bug.cgi?id=21603";>Bug #21603.
+   
+ 
+ 
  2005-04-23
 

DO NOT REPLY [Bug 34612] - Unchecked checkboxes aren't set in Forms..

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34612





--- Additional Comments From [EMAIL PROTECTED]  2005-04-26 21:17 ---
Um, I guess I was too fast with "easy" part. There is quite a bunch of tags,
which would need to be updated, if thing to be done properly.

What I had in mind is simply to create a special type like RadioButton and
CheckBox and use it instead of booleans and strings. When form bean is
processed, fields of this type could be cleaned up automatically before reset()
is called (or in Action.reset() itself, but this would require people to call
super.reset(), which is rarely done).

This behaviour is documented, so I would abstain of making the changes right
now. Maybe someone will return to this later. Please, excuse me for jumping in.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 34635] New: - Action.getErrors(request) should put new errors ActionMessages in the request scope

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34635

   Summary: Action.getErrors(request) should put new errors
ActionMessages in the request scope
   Product: Struts
   Version: Nightly Build
  Platform: All
OS/Version: All
Status: NEW
  Severity: enhancement
  Priority: P5
 Component: Controller
AssignedTo: dev@struts.apache.org
ReportedBy: [EMAIL PROTECTED]


would like to see something like this:

protected ActionMessages getErrors(HttpServletRequest request) {
ActionMessages errors =
(ActionMessages) request.getAttribute(Globals.ERROR_KEY);
if (errors == null) {
errors = new ActionMessages();
request.setAttribute(Globals.ERROR_KEY, errors);
}
return errors;
}

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r164862 - /struts/core/branches/STRUTS_1_2_BRANCH/src/share/org/apache/struts/validator/DynaValidatorForm.java

[niallp]

Author: niallp
Date: Tue Apr 26 12:08:32 2005
New Revision: 164862

URL: http://svn.apache.org/viewcvs?rev=164862&view=rev
Log:
Port fix for PR #19901 to 1.2.x branch - Adding check for null page value and 
throwing more informative exception

Modified:

struts/core/branches/STRUTS_1_2_BRANCH/src/share/org/apache/struts/validator/DynaValidatorForm.java

Modified: 
struts/core/branches/STRUTS_1_2_BRANCH/src/share/org/apache/struts/validator/DynaValidatorForm.java
URL: 
http://svn.apache.org/viewcvs/struts/core/branches/STRUTS_1_2_BRANCH/src/share/org/apache/struts/validator/DynaValidatorForm.java?rev=164862&r1=164861&r2=164862&view=diff
==
--- 
struts/core/branches/STRUTS_1_2_BRANCH/src/share/org/apache/struts/validator/DynaValidatorForm.java
 (original)
+++ 
struts/core/branches/STRUTS_1_2_BRANCH/src/share/org/apache/struts/validator/DynaValidatorForm.java
 Tue Apr 26 12:08:32 2005
@@ -1,7 +1,7 @@
 /*
  * $Id$ 
  *
- * Copyright 2000-2004 The Apache Software Foundation.
+ * Copyright 2000-2005 The Apache Software Foundation.
  * 
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -136,13 +136,18 @@
 protected void setPageFromDynaProperty() {
 Map props = this.getMap();
 if (props.containsKey("page")) {
+Integer p = null;
 try {
-this.page = ((Integer) props.get("page")).intValue();
-
+p = (Integer)props.get("page");
 } catch (ClassCastException e) {
 log.error("Dyna 'page' property must be of type 
java.lang.Integer.", e);
 throw e;
 }
+if (p == null) {
+throw new NullPointerException("Dyna 'page' property must not 
be null. " +
+" Either provide an initial value or set 'convertNull' to 
false. ");
+}  
+this.page = p.intValue();
 }
 }
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r164860 - /struts/core/branches/STRUTS_1_2_BRANCH/src/share/org/apache/struts/taglib/html/JavascriptValidatorTag.java

[niallp]

Author: niallp
Date: Tue Apr 26 12:06:27 2005
New Revision: 164860

URL: http://svn.apache.org/viewcvs?rev=164860&view=rev
Log:
Port fix for PR #16653 to 1.2.x branch - Add a check for missing 
ValidatorResources and throw more informative exception

Modified:

struts/core/branches/STRUTS_1_2_BRANCH/src/share/org/apache/struts/taglib/html/JavascriptValidatorTag.java

Modified: 
struts/core/branches/STRUTS_1_2_BRANCH/src/share/org/apache/struts/taglib/html/JavascriptValidatorTag.java
URL: 
http://svn.apache.org/viewcvs/struts/core/branches/STRUTS_1_2_BRANCH/src/share/org/apache/struts/taglib/html/JavascriptValidatorTag.java?rev=164860&r1=164859&r2=164860&view=diff
==
--- 
struts/core/branches/STRUTS_1_2_BRANCH/src/share/org/apache/struts/taglib/html/JavascriptValidatorTag.java
 (original)
+++ 
struts/core/branches/STRUTS_1_2_BRANCH/src/share/org/apache/struts/taglib/html/JavascriptValidatorTag.java
 Tue Apr 26 12:06:27 2005
@@ -369,6 +369,12 @@
 ValidatorPlugIn.VALIDATOR_KEY + config.getPrefix(),
 PageContext.APPLICATION_SCOPE);
 
+if (resources == null) {
+throw new JspException(
+"ValidatorResources not found in application scope under key 
\"" 
++ ValidatorPlugIn.VALIDATOR_KEY + config.getPrefix() + "\"");
+}
+
 Locale locale = TagUtils.getInstance().getUserLocale(this.pageContext, 
null);
 
 Form form = resources.getForm(locale, formName);



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r164858 - /struts/core/branches/STRUTS_1_2_BRANCH/src/example/org/apache/struts/webapp/example/LogonAction.java

[niallp]

Author: niallp
Date: Tue Apr 26 12:03:35 2005
New Revision: 164858

URL: http://svn.apache.org/viewcvs?rev=164858&view=rev
Log:
Port fix for PR #31658 to 1.2.x branch - LogonAction does not check errors in 
appropriate place

Modified:

struts/core/branches/STRUTS_1_2_BRANCH/src/example/org/apache/struts/webapp/example/LogonAction.java

Modified: 
struts/core/branches/STRUTS_1_2_BRANCH/src/example/org/apache/struts/webapp/example/LogonAction.java
URL: 
http://svn.apache.org/viewcvs/struts/core/branches/STRUTS_1_2_BRANCH/src/example/org/apache/struts/webapp/example/LogonAction.java?rev=164858&r1=164857&r2=164858&view=diff
==
--- 
struts/core/branches/STRUTS_1_2_BRANCH/src/example/org/apache/struts/webapp/example/LogonAction.java
 (original)
+++ 
struts/core/branches/STRUTS_1_2_BRANCH/src/example/org/apache/struts/webapp/example/LogonAction.java
 Tue Apr 26 12:03:35 2005
@@ -1,7 +1,7 @@
 /*
  * $Id$ 
  *
- * Copyright 2000-2004 Apache Software Foundation
+ * Copyright 2000-2005 Apache Software Foundation
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -140,18 +140,19 @@
 // Retrieve user
 User user = getUser(database,username,password,errors);
 
-// Save (or clear) user object
-SaveUser(request,user);
-
 // Report back any errors, and exit if any
 if (!errors.isEmpty()) {
 this.saveErrors(request, errors);
 return (mapping.getInputForward());
 }
 
+// Save user object
+SaveUser(request,user);
+
+
 // Otherwise, return "success"
 return (findSuccess(mapping));
 
 }
 
-}
\ No newline at end of file
+}



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 14749] - Action "input" not starting with '/' and not a valid forward will cause an internal server error

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=14749


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2005-04-26 20:07 ---
Closing as ModuleConfigVerifier addresses this issue.  If you find it lacking,
please reopen with an explaination what more you'd like to see done.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 14749] - Action "input" not starting with '/' and not a valid forward will cause an internal server error

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=14749





--- Additional Comments From [EMAIL PROTECTED]  2005-04-26 20:04 ---
+1 for closing it.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 34624] - getValidationKey in BeanValidatorForm should call mapping.getAttribute()

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34624


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2005-04-26 18:49 ---
I've fixed this in the current development version and the 1.2.x branch. Thanks 
for pointing this out.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r164831 - /struts/core/branches/STRUTS_1_2_BRANCH/src/share/org/apache/struts/validator/BeanValidatorForm.java

[niallp]

Author: niallp
Date: Tue Apr 26 09:48:38 2005
New Revision: 164831

URL: http://svn.apache.org/viewcvs?rev=164831&view=rev
Log:
Port change for Bug #34624 to 1.2.x branch - getValidationKey in 
BeanValidatorForm should call mapping.getAttribute() reported by Marino Jonsson

Modified:

struts/core/branches/STRUTS_1_2_BRANCH/src/share/org/apache/struts/validator/BeanValidatorForm.java

Modified: 
struts/core/branches/STRUTS_1_2_BRANCH/src/share/org/apache/struts/validator/BeanValidatorForm.java
URL: 
http://svn.apache.org/viewcvs/struts/core/branches/STRUTS_1_2_BRANCH/src/share/org/apache/struts/validator/BeanValidatorForm.java?rev=164831&r1=164830&r2=164831&view=diff
==
--- 
struts/core/branches/STRUTS_1_2_BRANCH/src/share/org/apache/struts/validator/BeanValidatorForm.java
 (original)
+++ 
struts/core/branches/STRUTS_1_2_BRANCH/src/share/org/apache/struts/validator/BeanValidatorForm.java
 Tue Apr 26 09:48:38 2005
@@ -1,5 +1,5 @@
 /*
- * Copyright 2004 The Apache Software Foundation.
+ * Copyright 2004-2005 The Apache Software Foundation.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -177,7 +177,7 @@
 
 } else {
 
-validationKey = mapping.getName();
+validationKey = mapping.getAttribute();
 
 }
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r164825 - /struts/core/trunk/src/share/org/apache/struts/validator/BeanValidatorForm.java

[niallp]

Author: niallp
Date: Tue Apr 26 09:45:31 2005
New Revision: 164825

URL: http://svn.apache.org/viewcvs?rev=164825&view=rev
Log:
Update copright notice - add 2005

Modified:

struts/core/trunk/src/share/org/apache/struts/validator/BeanValidatorForm.java

Modified: 
struts/core/trunk/src/share/org/apache/struts/validator/BeanValidatorForm.java
URL: 
http://svn.apache.org/viewcvs/struts/core/trunk/src/share/org/apache/struts/validator/BeanValidatorForm.java?rev=164825&r1=164824&r2=164825&view=diff
==
--- 
struts/core/trunk/src/share/org/apache/struts/validator/BeanValidatorForm.java 
(original)
+++ 
struts/core/trunk/src/share/org/apache/struts/validator/BeanValidatorForm.java 
Tue Apr 26 09:45:31 2005
@@ -1,5 +1,5 @@
 /*
- * Copyright 2004 The Apache Software Foundation.
+ * Copyright 2004-2005 The Apache Software Foundation.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r164814 - /struts/core/trunk/src/share/org/apache/struts/validator/BeanValidatorForm.java

[niallp]

Author: niallp
Date: Tue Apr 26 09:42:48 2005
New Revision: 164814

URL: http://svn.apache.org/viewcvs?rev=164814&view=rev
Log:
Resolve Bug #34624 getValidationKey in BeanValidatorForm should call 
mapping.getAttribute() reported by Marino Jonsson

Modified:

struts/core/trunk/src/share/org/apache/struts/validator/BeanValidatorForm.java

Modified: 
struts/core/trunk/src/share/org/apache/struts/validator/BeanValidatorForm.java
URL: 
http://svn.apache.org/viewcvs/struts/core/trunk/src/share/org/apache/struts/validator/BeanValidatorForm.java?rev=164814&r1=164813&r2=164814&view=diff
==
--- 
struts/core/trunk/src/share/org/apache/struts/validator/BeanValidatorForm.java 
(original)
+++ 
struts/core/trunk/src/share/org/apache/struts/validator/BeanValidatorForm.java 
Tue Apr 26 09:42:48 2005
@@ -177,7 +177,7 @@
 
 } else {
 
-validationKey = mapping.getName();
+validationKey = mapping.getAttribute();
 
 }
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 34625] - RequestProcessor.processRoles() broken on Orion 2.0.6

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34625


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|normal  |enhancement
  Component|Controller  |Documentation




--- Additional Comments From [EMAIL PROTECTED]  2005-04-26 18:30 ---
The user guide does have an "installation" section for Orion (although I'm not 
sure that these installtion pages have been kept up to date):

http://struts.apache.org/userGuide/installation-oas.html

Alternatively theres always the Wiki:

http://wiki.apache.org/struts/

For now I'll change it to a documentation enhancement, but leave it open as a 
reminder.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 34625] - RequestProcessor.processRoles() broken on Orion 2.0.6

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34625





--- Additional Comments From [EMAIL PROTECTED]  2005-04-26 18:12 ---
I don't mind if this issue is resolved as INVALID, it's easy to work around it
with a servlet filter and a request wrapper. It might be worth documenting this
issue if there is a "Server compatibility" page somewhere though.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 34625] - RequestProcessor.processRoles() broken on Orion 2.0.6

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34625





--- Additional Comments From [EMAIL PROTECTED]  2005-04-26 18:00 ---
If we made this change, then to be consistent we would need to do this 
everywhere Struts calls the Request's isUserInRole() method. From memory the 
logic tags and tiles are the other places that roles are checked but I'm 
wondering if there are any others.

Having said that I am -1 to having Struts "swallow" all exceptions to cater for 
a bug in Orion. If a "genuine" exception occurs in that method then its going 
to make it more difficult for someone to debug whats going on if all they keep 
getting is the "Not Authorised" message - rather than seeing the exception. 
Seems like it would be best fixed in Orion.

As a workaround, you can easily plug in your own custom RequestProcessor and 
override the processRoles() method to implement this behaviour for yourself.

In Struts 1.3 then this gets easier since all you need to do is create a 
concrete implementation of o.a.s.c.c.AbstractAuthorizeAction and configure 
Struts to use it through the chain-config.xml. I wouldn't mind us having an 
alternative "OrionAuthorizeAction" command implementation for this.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 34628] New: - html:multibox does not mark input status as checked when HTML sensitive characters are present in value.

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34628

   Summary: html:multibox does not mark input status as checked when
HTML sensitive characters are present in value.
   Product: Struts
   Version: 1.2.4
  Platform: PC
OS/Version: Windows XP
Status: NEW
  Severity: normal
  Priority: P3
 Component: Custom Tags
AssignedTo: dev@struts.apache.org
ReportedBy: [EMAIL PROTECTED]


I set two attributes in reqeuest from my Struts Action, one is called
"allEventTypes" which contains a String array.  Each element is a value for an
event type in my application.

The other is called "selectedEventTypes" which is again a String array.  Each
element is a value representing what event types in my application has been
checked by the user.

I use the following in my JSP to display all the events and which ones have been
checked by a user.








This however fails to check any of the event values that contain HTML sensitive
characters like ' < > & or even leading and trailing white space.

It appears that the constant member in org.apache.struts.taglib.html.MultiboxTag
has been initialised with all HTML sensitive characters filterd to be for
example & to &.  And all leading and trailing white space has been removed.

When the comparison is done though on line 214 to see if the input box should be
checked the values local varivale that contain all the selected values still
have HTML sensitive characters in.

Two ways to fix this are not filtering the HTML characters in the constant
member or also filtering the values array that contains all the selected values
to remove all HTML senstive characters.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[Shale] Clay ViewHandler discussion

[gvanmatre]

Sorry for the double post <> this time
I wanted to try to start a discussion on the topic of creating a custom 
ViewHandler for the Clay component that would allow entire HTML documents to 
act as a template/ layout manager (Tapestry like support).
Currently the clay plug-in allows defining fragments of the JSP page in a HTML 
fragment where JSF components are bound to HTML elements using a jsfid 
attribute.  The rest of the component metadata is defined in a XML 
configuration file.
I was thinking that it might be pretty simple to create a view handler to do 
this.  It seemed too simple and so I figured that I was missing something.  
1.  Extend the abstract ViewHandler class providing an overloaded 
constructor to decorate the base implementation.
2.  Delegate to the base view handler for all signatures in the super 
except for the renderView method.
1. Look to see if the suffix of the URI matches a clay template (.clay, 
.html).  If not, delegate to the base view implementation. 
2. Create a clay component add assign it as a child of the UIViewRoot. 
3. Use the Shale ViewControllerMapper to derive the managedBeanName 
property 
4. Set the Clay component jsfid to the viewId
5. Set the jsfid to the request context path.  
6. The “java.faces.DEFAULT_SUFIX” would need to include the clay 
template suffix. 
7. Invoke the encodeBegin method of the viewRoot.  
 
Any thoughts?

Gary

[Shale] Clay ViewHandler discussion

[gvanmatre]

I wanted to try to start a discussion on the topic of creating a custom 
ViewHandler for the Clay component that would allow entire HTML documents to 
act as a template/ layout manager (Tapestry like support).
 
Currently the clay plug-in allows defining fragments of the JSP page in a HTML 
fragment where JSF components are bound to HTML elements using a jsfid 
attribute.  The rest of the component metadata is defined in a XML 
configuration file.
 
I was thinking that it might be pretty simple to create a view handler to do 
this.  It seemed too simple and so I figured that I was missing something.  
 
1.  Extend the abstract ViewHandler class providing an overloaded 
constructor to decorate the base implementation.
 
2.  Delegate to the base view handler for all signatures in the super 
except for the renderView method.
 
Look to see if the suffix of the URI matches a clay template (.clay, .html).  
If not, delegate to the base view implementation.
Create a clay component add assign it as a child of the UIViewRoot.
Use the Shale ViewControllerMapper to derive the managedBeanName property
Set the jsfid to the request context path.  The “java.faces.DEFAULT_SUFIX” 
would need to include the clay template suffix.
Invoke the encodeBegin method of the viewRoot.  
 
Any thoughts?

Gary

DO NOT REPLY [Bug 34625] - RequestProcessor.processRoles() broken on Orion 2.0.6

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34625


[EMAIL PROTECTED] changed:

   What|Removed |Added

Version|Unknown |1.2.4




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 34625] New: - RequestProcessor.processRoles() broken on Orion 2.0.6

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34625

   Summary: RequestProcessor.processRoles() broken on Orion 2.0.6
   Product: Struts
   Version: Unknown
  Platform: Other
   URL: http://bugs.orionserver.com/issue/view.jsp?id=1323
OS/Version: other
Status: NEW
  Severity: normal
  Priority: P2
 Component: Controller
AssignedTo: dev@struts.apache.org
ReportedBy: [EMAIL PROTECTED]


The implementation of HttpServletRequest.isUserInRole() in Orion 2.0.6 throws an
IllegalArgumentException if the role doesn't exist, it breaks the processRoles
method in the RequestProcessor class. I suggest adding a try/catch block inside
the loop iterating over the roles to prevent such an exception from breaking the
processing:

// Check the current user against the list of required roles
for (int i = 0; i < roles.length; i++) {
try {
if (request.isUserInRole(roles[i])) {
if (log.isDebugEnabled()) {
log.debug(" User '" + request.getRemoteUser() +
"' has role '" + roles[i] + "', granting access");
}
return (true);
}
} catch (Exception e) {
if (log.isDebugEnabled()) {
log.debug(e.getMessage(), e);
}
}
}

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 34624] New: - getValidationKey in BeanValidatorForm should call mapping.getAttribute()

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34624

   Summary: getValidationKey in BeanValidatorForm should call
mapping.getAttribute()
   Product: Struts
   Version: 1.2.6 Beta
  Platform: All
OS/Version: All
Status: NEW
  Severity: normal
  Priority: P2
 Component: Validator Framework
AssignedTo: dev@struts.apache.org
ReportedBy: [EMAIL PROTECTED]


Currently the getValidationKey method in BeanValidatorForm calls
mapping.getName() directly if isPathValidation is false ... imo it should,
however, call mapping.getAttribute() as getAttribute returns the
mapping-attribute if it's not null but otherwize returns the mapping-name.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 34612] - Unchecked checkboxes aren't set in Forms..

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34612





--- Additional Comments From [EMAIL PROTECTED]  2005-04-26 15:13 ---
(In reply to comment #1)
> So many people stumble on this... Should Struts have a special class for
> checkboxes and radiobuttons? This would be really easy to do.

I agree that it would be nice if Struts made this easier for people.  Michael,
would you care to elaborate on the solution you have in mind?  

If some suggested implementations were attached and the title changed, I'd be ok
with re-opening this as an enhancement request. 

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 33254] - unable to specify maximum file size attribute greater than 1GB in struts-config.xml

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33254


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WORKSFORME




--- Additional Comments From [EMAIL PROTECTED]  2005-04-26 11:00 ---
This was fixed in January 2004 for Bug 26305 and was released in Version 1.2.4 
of Struts. I tested it out to make sure and had no problems uploading a file 
when the maxFileSize was set to "3G".

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 33132] - org.apache.struts.upload.MultipartRequestWrapper doesn't implement servlet 2.4 api fully

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33132





--- Additional Comments From [EMAIL PROTECTED]  2005-04-26 09:24 ---
Created an attachment (id=14840)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=14840&action=view)
Patch for changes to "Tiles" subproject


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 33132] - org.apache.struts.upload.MultipartRequestWrapper doesn't implement servlet 2.4 api fully

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33132





--- Additional Comments From [EMAIL PROTECTED]  2005-04-26 09:23 ---
Created an attachment (id=14839)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=14839&action=view)
Patch for changes to "Core" subproject

I have fixed this in the Struts 1.2.x branch (using reflection to execute the
Servlet 2.3/2.4 methods) and am attaching a patch of proposed changes for the
current (1.3) development version for review.

Changes for 1.3 basically involve making MultipartRequestWrapper extend
HttpServletRequestWrapper which would resolve this issue and the issue in Bug
17583. One slight problem with this is that the origianl getRequest() method in
MultipartRequestWrapper returned a HttpServletRequest - but the getRequest()
method now inherited from HttpServletRequestWrapper returns a ServletRequest,
which could cause slight compatibility problems.

The reason for attaching the 1.3 changes for review, rather than committing
them directly is that I understand Martin has some changes underway for file
uploading and these changes either may not be required or may be inappropriate.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]