svn commit: r369704 - in /struts/shale/trunk/core-library/src/java/org/apache/shale/util: ConverterHelper.java PropertyHelper.java

[craigmcc]

Author: craigmcc
Date: Mon Jan 16 23:12:46 2006
New Revision: 369704

URL: http://svn.apache.org/viewcvs?rev=369704&view=rev
Log:
Add JSF-friendly helper beans to access property values and converters, so that
Shale code does not need to depend on commons-beanutils directly for these
purposes (although it currently inherits a transitive dependency by virtue
of the fact that it uses Commons Digester to parse configuration files).

Added:

struts/shale/trunk/core-library/src/java/org/apache/shale/util/ConverterHelper.java
   (with props)

struts/shale/trunk/core-library/src/java/org/apache/shale/util/PropertyHelper.java
   (with props)

Added: 
struts/shale/trunk/core-library/src/java/org/apache/shale/util/ConverterHelper.java
URL: 
http://svn.apache.org/viewcvs/struts/shale/trunk/core-library/src/java/org/apache/shale/util/ConverterHelper.java?rev=369704&view=auto
==
--- 
struts/shale/trunk/core-library/src/java/org/apache/shale/util/ConverterHelper.java
 (added)
+++ 
struts/shale/trunk/core-library/src/java/org/apache/shale/util/ConverterHelper.java
 Mon Jan 16 23:12:46 2006
@@ -0,0 +1,100 @@
+/*
+ * Copyright 2006 The Apache Software Foundation.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shale.util;
+
+import javax.faces.FacesException;
+import javax.faces.context.FacesContext;
+import javax.faces.convert.Converter;
+import javax.faces.convert.ConverterException;
+
+/**
+ * Helper class to provide access to by-type JavaServer Faces
+ * Converter capabilities.  This implementation is stateless
+ * and maintains no cached information, so instances may be freely created
+ * and destroyed with no side effects.
+ *
+ * $Id$
+ *
+ * @since 1.0.1
+ */
+public class ConverterHelper {
+
+
+// -- Public 
Methods
+
+
+/**
+ * Use the registered by-type Converter to convert the
+ * specified String value to a corresponding Object value.
+ *
+ * @param context FacesContext for the current request
+ * @param type Type to which this value should be converted
+ *  (used to select the appropriate by-type converter)
+ * @param value Value to be converted
+ *
+ * @exception ConverterException if a conversion error occurs
+ */
+public Object asObject(FacesContext context, Class type, String value) {
+
+return converter(context, type).getAsObject(context, 
context.getViewRoot(), value);
+
+}
+
+
+/**
+ * Use the registered by-type Converter to convert the
+ * specified Object value to a corresponding String value.
+ *
+ * @param context FacesContext for the current request
+ * @param type Type from which this value should be converted
+ *  (used to select the appropriate by-type converter)
+ * @param value Value to be converted
+ *
+ * @exception ConverterException if a conversion error occurs
+ */
+public String asString(FacesContext context, Class type, Object value) {
+
+return converter(context, type).getAsString(context, 
context.getViewRoot(), value);
+
+}
+
+
+// - Private 
Methods
+
+
+/**
+ * Return an appropriate Converter instance for the
+ * specified type.
+ *
+ * @param context FacesContext for the current request
+ * @param type Type for which to retrieve a Converter
+ *
+ * @exception ConverterException if no Converter has been
+ *  registered for the specified type
+ */
+private Converter converter(FacesContext context, Class type) {
+
+try {
+return context.getApplication().createConverter(type);
+} catch (FacesException e) {
+throw new ConverterException(e);
+}
+
+}
+
+
+}

Propchange: 
struts/shale/trunk/core-library/src/java/org/apache/shale/util/ConverterHelper.java
--
svn:eol-style = native

Propchange: 
struts/shale/trunk/core-library/src/java/org/apache/shale/util/ConverterHelper.java
--
svn:keywords = Date Author Id Revision HeadURL

Added: 
struts/shale/trunk/core-library/src/java/org/apache/shale/util/PropertyHelper.java
URL: 
http://svn.apache.org/viewcvs/struts/shale/trunk/core-l

svn commit: r369703 - /struts/shale/trunk/test-framework/src/java/org/apache/shale/test/mock/MockApplication.java

[craigmcc]

Author: craigmcc
Date: Mon Jan 16 23:07:46 2006
New Revision: 369703

URL: http://svn.apache.org/viewcvs?rev=369703&view=rev
Log:
Implement support for by-type converters (as well as by-id).

Preregister all the standard by-type and by-id converters that a standard
JSF implementation does.

Modified:

struts/shale/trunk/test-framework/src/java/org/apache/shale/test/mock/MockApplication.java

Modified: 
struts/shale/trunk/test-framework/src/java/org/apache/shale/test/mock/MockApplication.java
URL: 
http://svn.apache.org/viewcvs/struts/shale/trunk/test-framework/src/java/org/apache/shale/test/mock/MockApplication.java?rev=369703&r1=369702&r2=369703&view=diff
==
--- 
struts/shale/trunk/test-framework/src/java/org/apache/shale/test/mock/MockApplication.java
 (original)
+++ 
struts/shale/trunk/test-framework/src/java/org/apache/shale/test/mock/MockApplication.java
 Mon Jan 16 23:07:46 2006
@@ -58,6 +58,7 @@
 setActionListener(new MockActionListener());
 components = new HashMap();
 converters = new HashMap();
+converters1 = new HashMap();
 setDefaultLocale(Locale.getDefault());
 setDefaultRenderKitId(RenderKitFactory.HTML_BASIC_RENDER_KIT);
 setNavigationHandler(new MockNavigationHandler());
@@ -68,6 +69,37 @@
 setVariableResolver(new MockVariableResolver());
 setViewHandler(new MockViewHandler());
 
+// Register the standard by-id converters
+addConverter("javax.faces.BigDecimal", 
"javax.faces.convert.BigDecimalConverter");
+addConverter("javax.faces.BigInteger", 
"javax.faces.convert.BigIntegerConverter");
+addConverter("javax.faces.Boolean",
"javax.faces.convert.BooleanConverter");
+addConverter("javax.faces.Byte",   
"javax.faces.convert.ByteConverter");
+addConverter("javax.faces.Character",  
"javax.faces.convert.CharacterConverter");
+addConverter("javax.faces.DateTime",   
"javax.faces.convert.DateTimeConverter");
+addConverter("javax.faces.Double", 
"javax.faces.convert.DoubleConverter");
+addConverter("javax.faces.Float",  
"javax.faces.convert.FloatConverter");
+addConverter("javax.faces.Integer",
"javax.faces.Convert.IntegerConverter");
+addConverter("javax.faces.Long",   
"javax.faces.convert.LongConverter");
+addConverter("javax.faces.Number", 
"javax.faces.convert.NumberConverter");
+addConverter("javax.faces.Short",  
"javax.faces.convert.ShortConverter");
+
+// Register the standard by-type converters
+addConverter(Boolean.class,
"javax.faces.convert.BooleanConverter");
+addConverter(Boolean.TYPE, 
"javax.faces.convert.BooleanConverter");
+addConverter(Byte.class,   
"javax.faces.convert.ByteConverter");
+addConverter(Byte.TYPE,
"javax.faces.convert.ByteConverter");
+addConverter(Character.class,  
"javax.faces.convert.CharacterConverter");
+addConverter(Character.TYPE,   
"javax.faces.convert.CharacterConverter");
+addConverter(Double.class, 
"javax.faces.convert.DoubleConverter");
+addConverter(Double.TYPE,  
"javax.faces.convert.DoubleConverter");
+addConverter(Float.class,  
"javax.faces.convert.FloatConverter");
+addConverter(Float.TYPE,   
"javax.faces.convert.FloatConverter");
+addConverter(Integer.class,
"javax.faces.convert.IntegerConverter");
+addConverter(Integer.TYPE, 
"javax.faces.convert.IntegerConverter");
+addConverter(Long.class,   
"javax.faces.convert.LongConverter");
+addConverter(Long.TYPE,
"javax.faces.convert.LongConverter");
+addConverter(Short.class,  
"javax.faces.convert.ShortConverter");
+addConverter(Short.TYPE,   
"javax.faces.convert.ShortConverter");
 }
 
 
@@ -79,7 +111,8 @@
 
 private ActionListener actionListener = null;
 private Map components = null;
-private Map converters = null;
+private Map converters = null; // By id
+private Map converters1 = null; // By type
 private Locale defaultLocale = null;
 private String defaultRenderKitId = null;
 private String messageBundle = null;
@@ -275,7 +308,7 @@
 
 public void addConverter(Class targetClass, String converterClass) {
 
-throw new UnsupportedOperationException();
+converters1.put(targetClass, converterClass);
 
 }
 
@@ -295,7 +328,13 @@
 
 public Converter createConverter(Class targetClass) {
 
-throw new UnsupportedOperationException();
+String converterClass = (String) converters1.get(targetClass);
+try {
+Class clazz = Class.forName(converterClass);
+return ((Converter) clazz.newInstanc

Re: Removing CGLIB enhancement from struts-action

[Laurie Harper]

I only saw Ted's message on this in my personal inbox, not here on the 
list, so in case my reply to that doesn't get through to here:


+1 -- I unfortunately wont have time to address #37730 in the 1.3.0 
timeframe :-( I'll revisit the feature when I have some spare cycles [I 
get away with using this feature as-is because I don't put form beans in 
session scope, but that's clearly not a reasonable restriction for the 
release].


L.

Wendy Smoak wrote:

I really don't like doing this. :(  I'm happy to hear alternatives.

This is a proposal to remove CGLIB enhancement from Struts Action. 
Bug# 37730 "Enhanced DynaActionForms cannot be correctly deserialized"

[0] remains unresolved and is holding up the 1.3.0 release plan.  I'd
like to remove this in order to allow us to move forward with the
release.

The proposed patch is here:
   http://people.apache.org/~wsmoak/struts-action/cglib/remove-cglib.diff

I left the 'enhanced' attribute in the DTD with the comment 'Reserved
for future use' so that if a solution is found it can still be part of
1.3.

Ted suggested moving this to the sandbox extras project but as it
involves changes to core classes I can't really "move" it like I did
with the commons-resources dependency.  With Subversion, though,
nothing is ever really gone.

Thoughts?

[0] http://issues.apache.org/bugzilla/show_bug.cgi?id=37730

--
Wendy



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r369668 - /struts/shale/trunk/use-cases/src/web/symbols/businessPerson.html

[gvanmatre]

Author: gvanmatre
Date: Mon Jan 16 20:02:52 2006
New Revision: 369668

URL: http://svn.apache.org/viewcvs?rev=369668&view=rev
Log:
Fixed cut-and-paste error.

Modified:
struts/shale/trunk/use-cases/src/web/symbols/businessPerson.html

Modified: struts/shale/trunk/use-cases/src/web/symbols/businessPerson.html
URL: 
http://svn.apache.org/viewcvs/struts/shale/trunk/use-cases/src/web/symbols/businessPerson.html?rev=369668&r1=369667&r2=369668&view=diff
==
--- struts/shale/trunk/use-cases/src/web/symbols/businessPerson.html (original)
+++ struts/shale/trunk/use-cases/src/web/symbols/businessPerson.html Mon Jan 16 
20:02:52 2006
@@ -18,7 +18,7 @@
 property="lastName" size="30" maxlength="40" 
 required="true" immediate="false"/>
 
  
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r369652 - in /struts/shale/trunk/use-cases/src: java/org/apache/shale/usecases/symbols/ java/org/apache/shale/usecases/view/ web/ web/WEB-INF/ web/symbols/

[gvanmatre]

Author: gvanmatre
Date: Mon Jan 16 19:16:48 2006
New Revision: 369652

URL: http://svn.apache.org/viewcvs?rev=369652&view=rev
Log:
Added use case for demonstrating Clay's symbol replacement feature.

Added:
struts/shale/trunk/use-cases/src/java/org/apache/shale/usecases/symbols/

struts/shale/trunk/use-cases/src/java/org/apache/shale/usecases/symbols/BasicPerson.java
   (with props)

struts/shale/trunk/use-cases/src/java/org/apache/shale/usecases/symbols/BusinessPerson.java
   (with props)

struts/shale/trunk/use-cases/src/java/org/apache/shale/usecases/symbols/FullPerson.java
   (with props)

struts/shale/trunk/use-cases/src/java/org/apache/shale/usecases/symbols/RegistrationForm.java
   (with props)

struts/shale/trunk/use-cases/src/java/org/apache/shale/usecases/symbols/clay-tiles-config.xml
   (with props)

struts/shale/trunk/use-cases/src/java/org/apache/shale/usecases/symbols/inputTextWidget.html
   (with props)
struts/shale/trunk/use-cases/src/web/WEB-INF/clay-symbols-config.xml   
(with props)
struts/shale/trunk/use-cases/src/web/symbols/
struts/shale/trunk/use-cases/src/web/symbols/businessPerson.html   (with 
props)
struts/shale/trunk/use-cases/src/web/symbols/fullperson.html   (with props)
struts/shale/trunk/use-cases/src/web/symbols/header.html   (with props)
struts/shale/trunk/use-cases/src/web/symbols/home.jsp   (with props)
struts/shale/trunk/use-cases/src/web/symbols/layout.html   (with props)
struts/shale/trunk/use-cases/src/web/symbols/nameReuse.jsp   (with props)
struts/shale/trunk/use-cases/src/web/symbols/page3.html   (with props)
struts/shale/trunk/use-cases/src/web/symbols/viewsource.html   (with props)
Modified:

struts/shale/trunk/use-cases/src/java/org/apache/shale/usecases/view/Bundle.properties
struts/shale/trunk/use-cases/src/web/WEB-INF/faces-config.xml
struts/shale/trunk/use-cases/src/web/WEB-INF/web.xml
struts/shale/trunk/use-cases/src/web/usecases.jsp

Added: 
struts/shale/trunk/use-cases/src/java/org/apache/shale/usecases/symbols/BasicPerson.java
URL: 
http://svn.apache.org/viewcvs/struts/shale/trunk/use-cases/src/java/org/apache/shale/usecases/symbols/BasicPerson.java?rev=369652&view=auto
==
--- 
struts/shale/trunk/use-cases/src/java/org/apache/shale/usecases/symbols/BasicPerson.java
 (added)
+++ 
struts/shale/trunk/use-cases/src/java/org/apache/shale/usecases/symbols/BasicPerson.java
 Mon Jan 16 19:16:48 2006
@@ -0,0 +1,57 @@
+/*
+ * Copyright 2006 The Apache Software Foundation.
+ * 
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * 
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.shale.usecases.symbols;
+
+import org.apache.shale.view.AbstractFacesBean;
+
+/**
+ * This class describes the very minimum about a person.
+ */
+public class BasicPerson extends AbstractFacesBean {
+
+private String firstName = null;
+
+private String lastName = null;
+
+/**
+ * @return Person's first name.
+ */
+public String getFirstName() {
+return firstName;
+}
+
+/**
+ * @param firstName Person's first name.
+ */
+public void setFirstName(String firstName) {
+this.firstName = firstName;
+}
+
+/**
+ * @return Person's last name.
+ */
+public String getLastName() {
+return lastName;
+}
+
+/**
+ * @param lastName Person's last name.
+ */
+public void setLastName(String lastName) {
+this.lastName = lastName;
+}
+
+}

Propchange: 
struts/shale/trunk/use-cases/src/java/org/apache/shale/usecases/symbols/BasicPerson.java
--
svn:eol-style = native

Propchange: 
struts/shale/trunk/use-cases/src/java/org/apache/shale/usecases/symbols/BasicPerson.java
--
svn:keywords = date author id rev

Added: 
struts/shale/trunk/use-cases/src/java/org/apache/shale/usecases/symbols/BusinessPerson.java
URL: 
http://svn.apache.org/viewcvs/struts/shale/trunk/use-cases/src/java/org/apache/shale/usecases/symbols/BusinessPerson.java?rev=369652&view=auto
==
--- 
struts/shale/trunk/use-cases/src/java/org/apache/shale/usecases/symbols/BusinessPerson.java
 (added)
+++ 
struts/shale/trunk/use-cases/src/jav

svn commit: r369651 - /struts/shale/trunk/clay-plugin/src/java/org/apache/shale/clay/faces/ClayViewHandler.java

[gvanmatre]

Author: gvanmatre
Date: Mon Jan 16 19:12:41 2006
New Revision: 369651

URL: http://svn.apache.org/viewcvs?rev=369651&view=rev
Log:
Small fix making Clay full HTML and XML views better supported under myfaces.

Modified:

struts/shale/trunk/clay-plugin/src/java/org/apache/shale/clay/faces/ClayViewHandler.java

Modified: 
struts/shale/trunk/clay-plugin/src/java/org/apache/shale/clay/faces/ClayViewHandler.java
URL: 
http://svn.apache.org/viewcvs/struts/shale/trunk/clay-plugin/src/java/org/apache/shale/clay/faces/ClayViewHandler.java?rev=369651&r1=369650&r2=369651&view=diff
==
--- 
struts/shale/trunk/clay-plugin/src/java/org/apache/shale/clay/faces/ClayViewHandler.java
 (original)
+++ 
struts/shale/trunk/clay-plugin/src/java/org/apache/shale/clay/faces/ClayViewHandler.java
 Mon Jan 16 19:12:41 2006
@@ -35,7 +35,6 @@
 import org.apache.commons.logging.LogFactory;
 import org.apache.shale.clay.component.Clay;
 import org.apache.shale.clay.config.Globals;
-import org.apache.shale.faces.ShaleConstants;
 import org.apache.shale.view.Constants;
 import org.apache.shale.view.ViewController;
 import org.apache.shale.view.ViewControllerMapper;
@@ -321,6 +320,7 @@
 if (component == null) {
 
   String viewId = normalizeViewId(view.getViewId(), index); 
+ view.setViewId(viewId);
   component = 
context.getApplication().createComponent(CLAY_COMPONENT_TYPE);
   ((Clay) component).setId(CLAY_VIEW_ID);
   ((Clay) component).setJsfid(viewId);



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r369641 - in /struts/shale/trunk/tiger/src: java/org/apache/shale/tiger/faces/ test/org/apache/shale/tiger/config/ test/org/apache/shale/tiger/faces/

[craigmcc]

Author: craigmcc
Date: Mon Jan 16 18:50:54 2006
New Revision: 369641

URL: http://svn.apache.org/viewcvs?rev=369641&view=rev
Log:
Add support for  elements as well.  Now just need to finish
up on array support for  and do a bit of cleanup.

Added:

struts/shale/trunk/tiger/src/test/org/apache/shale/tiger/config/TestBean5.java  
 (with props)

struts/shale/trunk/tiger/src/test/org/apache/shale/tiger/config/test-config-5.xml
   (with props)

struts/shale/trunk/tiger/src/test/org/apache/shale/tiger/faces/VariableResolverImpl5TestCase.java
   (with props)
Modified:

struts/shale/trunk/tiger/src/java/org/apache/shale/tiger/faces/Bundle.properties

struts/shale/trunk/tiger/src/java/org/apache/shale/tiger/faces/VariableResolverImpl.java

struts/shale/trunk/tiger/src/test/org/apache/shale/tiger/config/FacesConfigParserTestCase.java

Modified: 
struts/shale/trunk/tiger/src/java/org/apache/shale/tiger/faces/Bundle.properties
URL: 
http://svn.apache.org/viewcvs/struts/shale/trunk/tiger/src/java/org/apache/shale/tiger/faces/Bundle.properties?rev=369641&r1=369640&r2=369641&view=diff
==
--- 
struts/shale/trunk/tiger/src/java/org/apache/shale/tiger/faces/Bundle.properties
 (original)
+++ 
struts/shale/trunk/tiger/src/java/org/apache/shale/tiger/faces/Bundle.properties
 Mon Jan 16 18:50:54 2006
@@ -28,7 +28,13 @@
 list.instantiate=A list entries definition specified a value type class {0}  
that was successfully loaded, but no instance can be created
 list.list=A list entries definition specifies a type class {0} that is not an 
implementation of java.util.List
 list.listProperty=A property named {0} on a managed bean named {1} has type 
{2} that does not implement java.util.List
-list.get=An attempt to set a property named {0} on a managed bean named {1} 
has resulted in an exception
+list.set=An attempt to set a property named {0} on a managed bean named {1} 
has resulted in an exception
+map.get=An attempt to retrieve a property named {0} from a managed bean named 
{1} has resulted in an exception
+map.keyClass=A map entries definition specifies a key type class {0} that 
cannot be found
+map.map=A map entries definition specifies a type class {0} that is not an 
implementation of java.util.Map
+map.mapProperty=A property named {0} on a managed bean named {1} has type {2} 
that does not implement java.util.Map
+map.set=An attempt to set a property named {0} on a managed bean named {1} has 
resulted in an exception
+map.valueClass=A map entries definition specifies a value type class {0} that 
cannot be found
 variable.access=Managed bean definition {0} specifies a managed bean class {1} 
that does not have a public zero-arguments constructor
 variable.class=Managed bean definition {0} specifies a managed bean class {1} 
that cannot be found
 variable.evaluate=Managed bean definition {0} specifies a managed property {1} 
whose value expression {2} threw an exception when evaluated

Modified: 
struts/shale/trunk/tiger/src/java/org/apache/shale/tiger/faces/VariableResolverImpl.java
URL: 
http://svn.apache.org/viewcvs/struts/shale/trunk/tiger/src/java/org/apache/shale/tiger/faces/VariableResolverImpl.java?rev=369641&r1=369640&r2=369641&view=diff
==
--- 
struts/shale/trunk/tiger/src/java/org/apache/shale/tiger/faces/VariableResolverImpl.java
 (original)
+++ 
struts/shale/trunk/tiger/src/java/org/apache/shale/tiger/faces/VariableResolverImpl.java
 Mon Jan 16 18:50:54 2006
@@ -17,7 +17,9 @@
 package org.apache.shale.tiger.faces;
 
 import java.util.ArrayList;
+import java.util.HashMap;
 import java.util.List;
+import java.util.Map;
 import javax.faces.context.ExternalContext;
 import javax.faces.context.FacesContext;
 import javax.faces.el.EvaluationException;
@@ -37,6 +39,7 @@
 import org.apache.shale.tiger.managed.config.ManagedBeanConfig;
 import org.apache.shale.tiger.managed.config.ManagedPropertyConfig;
 import org.apache.shale.tiger.managed.config.MapEntriesConfig;
+import org.apache.shale.tiger.managed.config.MapEntryConfig;
 import org.apache.shale.util.Messages;
 
 /**
@@ -72,7 +75,6 @@
  * 
  * Partial support for list entries on managed beans and managed 
properties.
  * It currently works for lists, but not for arrays.
- * Support for map entries on managed beans and managed properties.
  * 
  *
  * IMPLEMENTATION NOTE - There is no 
faces-config.xml
@@ -265,7 +267,6 @@
 Object instance = instance(context, mb);
 
 // Configure properties as necessary
-// FIXME - map entries are not supported on beans
 for (ManagedPropertyConfig mp : mb.getProperties().values()) {
 property(context, mb, mp, instance);
 }
@@ -284,7 +285,16 @@
 }
 
 // Configure map entries as necessary
-// FIXME
+MapEntriesConfig mapEntries = mb.getMapEntries();
+if (mapEntries != 

svn commit: r369622 - /struts/sandbox/trunk/tiles/project.xml

[wsmoak]

Author: wsmoak
Date: Mon Jan 16 17:42:31 2006
New Revision: 369622

URL: http://svn.apache.org/viewcvs?rev=369622&view=rev
Log:
Stay on version 1.4.1 of the artifact plugin; jar:install doesn't work with 
1.5.1 or 1.5.2.
Set up siteAddress and siteDirectory to publish the project website with Maven.

Modified:
struts/sandbox/trunk/tiles/project.xml

Modified: struts/sandbox/trunk/tiles/project.xml
URL: 
http://svn.apache.org/viewcvs/struts/sandbox/trunk/tiles/project.xml?rev=369622&r1=369621&r2=369622&view=diff
==
--- struts/sandbox/trunk/tiles/project.xml (original)
+++ struts/sandbox/trunk/tiles/project.xml Mon Jan 16 17:42:31 2006
@@ -1,5 +1,6 @@
 
-
+http://maven.apache.org/POM/3.0.0"; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+  xsi:schemaLocation="http://maven.apache.org/POM/3.0.0 
http://maven.apache.org/maven-v3_0_0.xsd";>
 

Non-discussion emails

[Patrick Lightbody]

I just realzied that the non-discussion emails (bugs, wiki, and commits) are 
going in to the forums. The account that is subscribed is [EMAIL PROTECTED] Is 
there any way we can disable those other emails to that account?

-
Posted via Jive Forums
http://forums.opensymphony.com/thread.jspa?threadID=14616&messageID=28683#28683


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Removing CGLIB enhancement from struts-action

[Wendy Smoak]

I really don't like doing this. :(  I'm happy to hear alternatives.

This is a proposal to remove CGLIB enhancement from Struts Action. 
Bug# 37730 "Enhanced DynaActionForms cannot be correctly deserialized"
[0] remains unresolved and is holding up the 1.3.0 release plan.  I'd
like to remove this in order to allow us to move forward with the
release.

The proposed patch is here:
   http://people.apache.org/~wsmoak/struts-action/cglib/remove-cglib.diff

I left the 'enhanced' attribute in the DTD with the comment 'Reserved
for future use' so that if a solution is found it can still be part of
1.3.

Ted suggested moving this to the sandbox extras project but as it
involves changes to core classes I can't really "move" it like I did
with the commons-resources dependency.  With Subversion, though,
nothing is ever really gone.

Thoughts?

[0] http://issues.apache.org/bugzilla/show_bug.cgi?id=37730

--
Wendy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: 1.3.0 Release - Next Steps

[Ted Husted]

Any new input on #37730?

If we are not ready to resolve the serialization issue, then we should
table this new feature for a subsequent release.

-Ted.

On 1/13/06, Wendy Smoak <[EMAIL PROTECTED]> wrote:
> Bug# 37301 looks like an enhancement request to me... I don't think it
> should prevent a release.  So we just need to resolve Bug #37730
> (serialization) one way or the other.  Laurie, any comments on all
> this?

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 37730] - Enhanced DynaActionForms cannot be correct deserialized

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37730





--- Additional Comments From [EMAIL PROTECTED]  2006-01-17 01:28 ---
Any new input on #37730?

If we are not ready to resolve the serialization issue, then we should table
this new feature for a subsequent release. 

-Ted.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: WebWork Merger Forum

[Ted Husted]

Yes, I never got around to posting to that forum, and now I would
agree that the window has passed.

> > On 1/15/06, Patrick Lightbody <[EMAIL PROTECTED]>
> > wrote:
> >>
> >> There was originally some discussion about setting up a WebWork-
> >> Struts
> >> merger forum (with a mailing list) for us to talk about the
> >> details. Do we
> >> still need that, or is the Struts Dev forum a suitable place?
> >
> >
> > I believe Struts Dev is the right place for this to happen now.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r369613 - in /struts/shale/trunk/tiger/src: java/org/apache/shale/tiger/faces/ test/org/apache/shale/tiger/config/ test/org/apache/shale/tiger/faces/

[craigmcc]

Author: craigmcc
Date: Mon Jan 16 16:19:49 2006
New Revision: 369613

URL: http://svn.apache.org/viewcvs?rev=369613&view=rev
Log:
Improve the annotated managed beans implementation by adding partial support
for  elements.  Currently, this works only for lists, but not
(as the JSF spec requires) for arrays.  Still no support for 
elements yet.

Added:

struts/shale/trunk/tiger/src/test/org/apache/shale/tiger/config/TestBean4.java  
 (with props)

struts/shale/trunk/tiger/src/test/org/apache/shale/tiger/config/test-config-4.xml
   (with props)

struts/shale/trunk/tiger/src/test/org/apache/shale/tiger/faces/VariableResolverImpl4TestCase.java
   (with props)
Modified:

struts/shale/trunk/tiger/src/java/org/apache/shale/tiger/faces/Bundle.properties

struts/shale/trunk/tiger/src/java/org/apache/shale/tiger/faces/VariableResolverImpl.java

struts/shale/trunk/tiger/src/test/org/apache/shale/tiger/config/FacesConfigParserTestCase.java

Modified: 
struts/shale/trunk/tiger/src/java/org/apache/shale/tiger/faces/Bundle.properties
URL: 
http://svn.apache.org/viewcvs/struts/shale/trunk/tiger/src/java/org/apache/shale/tiger/faces/Bundle.properties?rev=369613&r1=369612&r2=369613&view=diff
==
--- 
struts/shale/trunk/tiger/src/java/org/apache/shale/tiger/faces/Bundle.properties
 (original)
+++ 
struts/shale/trunk/tiger/src/java/org/apache/shale/tiger/faces/Bundle.properties
 Mon Jan 16 16:19:49 2006
@@ -19,6 +19,16 @@
 lifecycle.initialized=Starting up Shale Tiger extensions
 
 # VariableHandlerImpl
+convert.exception=Attempting to convert a value of {0} to type {1} has 
resulted in a ConversionException
+convert.format=Attempting to convert a value of {0} to type {1} has resultined 
in a NumberFormatException
+list.access=A list entries definition specifies a value type class {0} that 
does not have a public zero-arguments constructor
+list.array=A list entries definition specifies a value type class {0} that is 
an array, which is not currently supported
+list.class=A list entries definition specifies a value type class {0} that 
cannot be found
+list.get=An attempt to retrieve a property named {0} from a managed bean named 
{1} has resulted in an exception
+list.instantiate=A list entries definition specified a value type class {0}  
that was successfully loaded, but no instance can be created
+list.list=A list entries definition specifies a type class {0} that is not an 
implementation of java.util.List
+list.listProperty=A property named {0} on a managed bean named {1} has type 
{2} that does not implement java.util.List
+list.get=An attempt to set a property named {0} on a managed bean named {1} 
has resulted in an exception
 variable.access=Managed bean definition {0} specifies a managed bean class {1} 
that does not have a public zero-arguments constructor
 variable.class=Managed bean definition {0} specifies a managed bean class {1} 
that cannot be found
 variable.evaluate=Managed bean definition {0} specifies a managed property {1} 
whose value expression {2} threw an exception when evaluated

Modified: 
struts/shale/trunk/tiger/src/java/org/apache/shale/tiger/faces/VariableResolverImpl.java
URL: 
http://svn.apache.org/viewcvs/struts/shale/trunk/tiger/src/java/org/apache/shale/tiger/faces/VariableResolverImpl.java?rev=369613&r1=369612&r2=369613&view=diff
==
--- 
struts/shale/trunk/tiger/src/java/org/apache/shale/tiger/faces/VariableResolverImpl.java
 (original)
+++ 
struts/shale/trunk/tiger/src/java/org/apache/shale/tiger/faces/VariableResolverImpl.java
 Mon Jan 16 16:19:49 2006
@@ -16,19 +16,27 @@
 
 package org.apache.shale.tiger.faces;
 
+import java.util.ArrayList;
+import java.util.List;
 import javax.faces.context.ExternalContext;
 import javax.faces.context.FacesContext;
 import javax.faces.el.EvaluationException;
 import javax.faces.el.ValueBinding;
 import javax.faces.el.VariableResolver;
 import org.apache.commons.beanutils.BeanUtils;
+import org.apache.commons.beanutils.ConversionException;
+import org.apache.commons.beanutils.ConvertUtils;
+import org.apache.commons.beanutils.PropertyUtils;
 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
 import org.apache.shale.tiger.config.FacesConfigConfig;
 import org.apache.shale.tiger.managed.Bean;
 import org.apache.shale.tiger.managed.Value;
+import org.apache.shale.tiger.managed.config.ListEntriesConfig;
+import org.apache.shale.tiger.managed.config.ListEntryConfig;
 import org.apache.shale.tiger.managed.config.ManagedBeanConfig;
 import org.apache.shale.tiger.managed.config.ManagedPropertyConfig;
+import org.apache.shale.tiger.managed.config.MapEntriesConfig;
 import org.apache.shale.util.Messages;
 
 /**
@@ -62,11 +70,9 @@
  * FIXME - Incomplete implemetnation of standard managed beans
  * functionality in the following areas:
  * 
- * Support for

svn commit: r369584 - /struts/action/trunk/pom.xml

[wsmoak]

Author: wsmoak
Date: Mon Jan 16 14:04:47 2006
New Revision: 369584

URL: http://svn.apache.org/viewcvs?rev=369584&view=rev
Log:
Marked the JUnit dependency as optional.  JUnit would normally be in test 
scope, but it is required to compile oas.mock.TestMockBase.

Modified:
struts/action/trunk/pom.xml

Modified: struts/action/trunk/pom.xml
URL: 
http://svn.apache.org/viewcvs/struts/action/trunk/pom.xml?rev=369584&r1=369583&r2=369584&view=diff
==
--- struts/action/trunk/pom.xml (original)
+++ struts/action/trunk/pom.xml Mon Jan 16 14:04:47 2006
@@ -174,6 +174,7 @@
  junit
  junit
  3.8.1
+ true
   
   
  oro



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[Struts Wiki] Update of "FortuneCookies" by GeorgeDinwiddie

[Apache Wiki]

Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Struts Wiki" for change 
notification.

The following page has been changed by GeorgeDinwiddie:
http://wiki.apache.org/struts/FortuneCookies

--
-  * Edit the FortuneCookies page to display randomly selected wisdom here.
+  * ''An ActionForward should represent a '''logical outcome''' of an Action, 
not a '''menu choice'. - Craig !McClanahan
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 38168] - [shale] Add spring like syntax for loading clay configs from classpath

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38168


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2006-01-16 21:26 ---
This patch only focuses on Clay's configuration file loading.  We should 
consider more of a global strategy as a product of the WebWork merger.  The 
fix will be in the 20060117 shale nightly build.

Besides XML configuration files, HTML templates can be loaded from the class 
path using the same notation.




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r369562 - in /struts/shale/trunk/use-cases/src: java/org/apache/shale/usecases/rolodex/address.html web/rolodex/address.html web/rolodex/hrolodex.html web/rolodex/rolodex.jsp web/rolodex/x

[gvanmatre]

Author: gvanmatre
Date: Mon Jan 16 12:16:22 2006
New Revision: 369562

URL: http://svn.apache.org/viewcvs?rev=369562&view=rev
Log:
Fix for Bug#: 38168

Added:

struts/shale/trunk/use-cases/src/java/org/apache/shale/usecases/rolodex/address.html
   (with props)
Removed:
struts/shale/trunk/use-cases/src/web/rolodex/address.html
Modified:
struts/shale/trunk/use-cases/src/web/rolodex/hrolodex.html   (contents, 
props changed)
struts/shale/trunk/use-cases/src/web/rolodex/rolodex.jsp   (contents, props 
changed)
struts/shale/trunk/use-cases/src/web/rolodex/xhrolodex.html   (contents, 
props changed)

Added: 
struts/shale/trunk/use-cases/src/java/org/apache/shale/usecases/rolodex/address.html
URL: 
http://svn.apache.org/viewcvs/struts/shale/trunk/use-cases/src/java/org/apache/shale/usecases/rolodex/address.html?rev=369562&view=auto
==
--- 
struts/shale/trunk/use-cases/src/java/org/apache/shale/usecases/rolodex/address.html
 (added)
+++ 
struts/shale/trunk/use-cases/src/java/org/apache/shale/usecases/rolodex/address.html
 Mon Jan 16 12:16:22 2006
@@ -0,0 +1,34 @@
+
+   
+  HTML
+   
+   
+Mock Address 1:
+
+Mock Error Address 1
+   
+   
+Mock Address 2:
+
+Mock Error Address 2
+   
+   
+Mock City:
+
+Mock Error City
+   
+   
+Mock State:
+
+   Mock State 1
+   Mock State 2
+
+
+Mock Error State
+   
+   
+Mock Zip:
+
+Mock Error Zip
+   
+

Propchange: 
struts/shale/trunk/use-cases/src/java/org/apache/shale/usecases/rolodex/address.html
--
svn:eol-style = native

Modified: struts/shale/trunk/use-cases/src/web/rolodex/hrolodex.html
URL: 
http://svn.apache.org/viewcvs/struts/shale/trunk/use-cases/src/web/rolodex/hrolodex.html?rev=369562&r1=369561&r2=369562&view=diff
==
--- struts/shale/trunk/use-cases/src/web/rolodex/hrolodex.html (original)
+++ struts/shale/trunk/use-cases/src/web/rolodex/hrolodex.html Mon Jan 16 
12:16:22 2006
@@ -4,27 +4,27 @@
 #{messages['usecases.rolodex2']}
 
 
-
-
-.linkPrev {
-   text-align: left; 
-   color: black; 
-   font-family: arial; font-size: 8pt
-}
-.linkNext {
-   text-align: right; 
-   color: black; 
-   font-family: arial; font-size: 8pt
-}
-.links {
-   text-align: center; 
-   color: black; 
-   font-family: arial; font-size: 8pt
-}
-.caption {
-   text-align: center; 
-   color: #99CC66; 
-   font-family: arial; font-size: 8pt
+