[EMAIL PROTECTED]: Project struts-taglib (in module struts) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project struts-taglib has an issue affecting its community integration. This issue affects 9 projects, and has been outstanding for 6 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - jakarta-tomcat-5 : Servlet 2.4 and JSP 2.0 Reference Implementation - jakarta-velocity-tools : Velocity-Tools project - portals-bridges-frameworks : Support for JSR168 compliant Portlet development - portals-bridges-struts : Support for JSR168 compliant Portlet development - portals-bridges-velocity : Support for JSR168 compliant Portlet development - smartfrog-tomcat : Smartfrog: Application Deployment from HP Laboratories - struts-el : Model 2 Model-View-Controller framework for Servlets and JSP - struts-sslext : The Struts SSL Extension for HTTP/HTTPS switching - struts-taglib : Model 2 Model-View-Controller framework for Servlets and JSP Full details are available at: http://vmgump.apache.org/gump/public/struts/struts-taglib/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Sole output [struts-taglib-07022006.jar] identifier set to project name -DEBUG- Dependency on xdoclet exists, no need to add for property maven.jar.xdoclet. -DEBUG- Dependency on xdoclet exists, no need to add for property maven.jar.xdoclet-web-module. -DEBUG- Dependency on xdoclet exists, no need to add for property maven.jar.xdoclet-ejb-module. -DEBUG- Dependency on xdoclet exists, no need to add for property maven.jar.xdoclet-apache-module. -DEBUG- Dependency on xdoclet exists, no need to add for property maven.jar.xdoclet-xdoclet-module. -DEBUG- Dependency on jakarta-servletapi-4 exists, no need to add for property maven.jar.servlet-api. -DEBUG- Dependency on xdoclet exists, no need to add for property maven.jar.xdoclet-hibernate-module. -DEBUG- Dependency on xdoclet exists, no need to add for property maven.jar.xdoclet-jdo-module. -DEBUG- Dependency on xdoclet exists, no need to add for property maven.jar.xdoclet-jmx-module. -DEBUG- Dependency on xdoclet exists, no need to add for property maven.jar.xdoclet-portlet-module. -DEBUG- (Gump generated) Maven Properties in: /usr/local/gump/public/workspace/struts/taglib/build.properties -INFO- Failed with reason build failed -DEBUG- Maven POM in: /usr/local/gump/public/workspace/struts/taglib/project.xml -DEBUG- Maven project properties in: /usr/local/gump/public/workspace/struts/taglib/project.properties -INFO- Failed to extract fallback artifacts from Gump Repository The following work was performed: http://vmgump.apache.org/gump/public/struts/struts-taglib/gump_work/build_struts_struts-taglib.html Work Name: build_struts_struts-taglib (Type: Build) Work ended in a state of : Failed Elapsed: 7 secs Command Line: maven --offline jar [Working Directory: /usr/local/gump/public/workspace/struts/taglib] CLASSPATH:
[EMAIL PROTECTED]: Project struts-taglib (in module struts) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project struts-taglib has an issue affecting its community integration. This issue affects 9 projects, and has been outstanding for 6 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - jakarta-tomcat-5 : Servlet 2.4 and JSP 2.0 Reference Implementation - jakarta-velocity-tools : Velocity-Tools project - portals-bridges-frameworks : Support for JSR168 compliant Portlet development - portals-bridges-struts : Support for JSR168 compliant Portlet development - portals-bridges-velocity : Support for JSR168 compliant Portlet development - smartfrog-tomcat : Smartfrog: Application Deployment from HP Laboratories - struts-el : Model 2 Model-View-Controller framework for Servlets and JSP - struts-sslext : The Struts SSL Extension for HTTP/HTTPS switching - struts-taglib : Model 2 Model-View-Controller framework for Servlets and JSP Full details are available at: http://vmgump.apache.org/gump/public/struts/struts-taglib/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Sole output [struts-taglib-07022006.jar] identifier set to project name -DEBUG- Dependency on xdoclet exists, no need to add for property maven.jar.xdoclet. -DEBUG- Dependency on xdoclet exists, no need to add for property maven.jar.xdoclet-web-module. -DEBUG- Dependency on xdoclet exists, no need to add for property maven.jar.xdoclet-ejb-module. -DEBUG- Dependency on xdoclet exists, no need to add for property maven.jar.xdoclet-apache-module. -DEBUG- Dependency on xdoclet exists, no need to add for property maven.jar.xdoclet-xdoclet-module. -DEBUG- Dependency on jakarta-servletapi-4 exists, no need to add for property maven.jar.servlet-api. -DEBUG- Dependency on xdoclet exists, no need to add for property maven.jar.xdoclet-hibernate-module. -DEBUG- Dependency on xdoclet exists, no need to add for property maven.jar.xdoclet-jdo-module. -DEBUG- Dependency on xdoclet exists, no need to add for property maven.jar.xdoclet-jmx-module. -DEBUG- Dependency on xdoclet exists, no need to add for property maven.jar.xdoclet-portlet-module. -DEBUG- (Gump generated) Maven Properties in: /usr/local/gump/public/workspace/struts/taglib/build.properties -INFO- Failed with reason build failed -DEBUG- Maven POM in: /usr/local/gump/public/workspace/struts/taglib/project.xml -DEBUG- Maven project properties in: /usr/local/gump/public/workspace/struts/taglib/project.properties -INFO- Failed to extract fallback artifacts from Gump Repository The following work was performed: http://vmgump.apache.org/gump/public/struts/struts-taglib/gump_work/build_struts_struts-taglib.html Work Name: build_struts_struts-taglib (Type: Build) Work ended in a state of : Failed Elapsed: 7 secs Command Line: maven --offline jar [Working Directory: /usr/local/gump/public/workspace/struts/taglib] CLASSPATH:
svn commit: r375627 [3/3] - /struts/action/trunk/src/java/org/apache/struts/action/
Modified:
struts/action/trunk/src/java/org/apache/struts/action/DynaActionFormClass.java
URL:
http://svn.apache.org/viewcvs/struts/action/trunk/src/java/org/apache/struts/action/DynaActionFormClass.java?rev=375627r1=375626r2=375627view=diff
==
---
struts/action/trunk/src/java/org/apache/struts/action/DynaActionFormClass.java
(original)
+++
struts/action/trunk/src/java/org/apache/struts/action/DynaActionFormClass.java
Tue Feb 7 07:25:16 2006
@@ -25,6 +25,7 @@
import org.apache.struts.util.RequestUtils;
import java.io.Serializable;
+
import java.util.HashMap;
/**
@@ -39,7 +40,6 @@
* @since Struts 1.1
*/
public class DynaActionFormClass implements DynaClass, Serializable {
-
// - Instance Variables
/**
@@ -76,8 +76,9 @@
/**
* pConstruct a new codeDynaActionFormClass/code for the specified
* form bean configuration. This constructor is private;
- * codeDynaActionFormClass/code instances will be created as needed via
- * calls to the static codecreateDynaActionFormClass()/code method./p
+ * codeDynaActionFormClass/code instances will be created as needed
+ * via calls to the static codecreateDynaActionFormClass()/code
+ * method./p
*
* @param config The FormBeanConfig instance describing the properties of
* the bean to be created
@@ -105,8 +106,8 @@
}
/**
- * pReturn a property descriptor for the specified property, if it
exists;
- * otherwise, return codenull/code./p
+ * pReturn a property descriptor for the specified property, if it
+ * exists; otherwise, return codenull/code./p
*
* @param name Name of the dynamic property for which a descriptor is
* requested
@@ -138,9 +139,10 @@
/**
* pInstantiate and return a new [EMAIL PROTECTED] DynaActionForm}
instance,
- * associated with this codeDynaActionFormClass/code. The properties
of
- * the returned [EMAIL PROTECTED] DynaActionForm} will have been
initialized to the
- * default values specified in the form bean configuration information./p
+ * associated with this codeDynaActionFormClass/code. The properties
+ * of the returned [EMAIL PROTECTED] DynaActionForm} will have been
initialized to
+ * the default values specified in the form bean configuration
+ * information./p
*
* @return A new [EMAIL PROTECTED] DynaActionForm} instance.
* @throws IllegalAccessException if the Class or the appropriate
@@ -151,9 +153,8 @@
*some other reason
*/
public DynaBean newInstance()
-throws IllegalAccessException, InstantiationException {
-DynaActionForm dynaBean =
-(DynaActionForm) getBeanClass().newInstance();
+throws IllegalAccessException, InstantiationException {
+DynaActionForm dynaBean = (DynaActionForm)
getBeanClass().newInstance();
dynaBean.setDynaActionFormClass(this);
@@ -206,7 +207,7 @@
* @return The instance for the specified form bean config.
*/
public static DynaActionFormClass createDynaActionFormClass(
-FormBeanConfig config) {
+FormBeanConfig config) {
return config.getDynaActionFormClass();
}
@@ -214,9 +215,9 @@
/**
* pReturn the implementation class we are using to construct new
- * instances, re-introspecting our [EMAIL PROTECTED] FormBeanConfig} if
necessary (that
- * is, after being deserialized, since codebeanClass/code is marked
- * transient)./p
+ * instances, re-introspecting our [EMAIL PROTECTED] FormBeanConfig} if
necessary
+ * (that is, after being deserialized, since codebeanClass/code is
+ * marked transient)./p
*
* @return The implementation class used to construct new instances.
*/
@@ -245,17 +246,17 @@
// Validate the ActionFormBean implementation class
try {
beanClass = RequestUtils.applicationClass(config.getType());
-} catch (Throwable t) {
+}
+catch (Throwable t) {
throw new IllegalArgumentException(
-Cannot instantiate ActionFormBean class '
-+ config.getType()
-+ ': + t);
+Cannot instantiate ActionFormBean class ' + config.getType()
++ ': + t);
}
if (!DynaActionForm.class.isAssignableFrom(beanClass)) {
throw new IllegalArgumentException(Class ' + config.getType()
-+ ' is not a subclass of
-+ 'org.apache.struts.action.DynaActionForm');
++ ' is not a subclass of
++ 'org.apache.struts.action.DynaActionForm');
}
// Set the name we will know ourselves by from the form bean
svn commit: r375627 [1/3] - /struts/action/trunk/src/java/org/apache/struts/action/
Author: husted Date: Tue Feb 7 07:25:16 2006 New Revision: 375627 URL: http://svn.apache.org/viewcvs?rev=375627view=rev Log: CheckStyle Issues * Conform JavaDoc so that automatic reformatting will not collapse unordered lists * Apply Jalopy prior to check-in Modified: struts/action/trunk/src/java/org/apache/struts/action/Action.java struts/action/trunk/src/java/org/apache/struts/action/ActionErrors.java struts/action/trunk/src/java/org/apache/struts/action/ActionForm.java struts/action/trunk/src/java/org/apache/struts/action/ActionFormBean.java struts/action/trunk/src/java/org/apache/struts/action/ActionForward.java struts/action/trunk/src/java/org/apache/struts/action/ActionMapping.java struts/action/trunk/src/java/org/apache/struts/action/ActionMessage.java struts/action/trunk/src/java/org/apache/struts/action/ActionMessages.java struts/action/trunk/src/java/org/apache/struts/action/ActionRedirect.java struts/action/trunk/src/java/org/apache/struts/action/ActionServlet.java struts/action/trunk/src/java/org/apache/struts/action/DynaActionForm.java struts/action/trunk/src/java/org/apache/struts/action/DynaActionFormClass.java struts/action/trunk/src/java/org/apache/struts/action/ExceptionHandler.java struts/action/trunk/src/java/org/apache/struts/action/PlugIn.java struts/action/trunk/src/java/org/apache/struts/action/RequestProcessor.java Modified: struts/action/trunk/src/java/org/apache/struts/action/Action.java URL: http://svn.apache.org/viewcvs/struts/action/trunk/src/java/org/apache/struts/action/Action.java?rev=375627r1=375626r2=375627view=diff == --- struts/action/trunk/src/java/org/apache/struts/action/Action.java (original) +++ struts/action/trunk/src/java/org/apache/struts/action/Action.java Tue Feb 7 07:25:16 2006 @@ -30,6 +30,7 @@ import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletResponse; import javax.servlet.http.HttpSession; + import java.util.Locale; /** @@ -39,22 +40,29 @@ * select an appropriate Action for each request, create an instance (if * necessary), and call the codeexecute/code method./p * - * pActions must be programmed in a thread-safe manner, because the controller - * will share the same instance for multiple simultaneous requests. This means - * you should design with the following items in mind: /p ul liInstance - * and static variables MUST NOT be used to store information related to the - * state of a particular request. They MAY be used to share global resources - * across requests for the same action./li liAccess to other resources - * (JavaBeans, session variables, etc.) MUST be synchronized if those resources - * require protection. (Generally, however, resource classes should be designed - * to provide their own protection where necessary./li /ul + * pActions must be programmed in a thread-safe manner, because the + * controller will share the same instance for multiple simultaneous requests. + * This means you should design with the following items in mind: /p + * + * ul + * + * liInstance and static variables MUST NOT be used to store information + * related to the state of a particular request. They MAY be used to share + * global resources across requests for the same action./li + * + * liAccess to other resources (JavaBeans, session variables, etc.) MUST be + * synchronized if those resources require protection. (Generally, however, + * resource classes should be designed to provide their own protection where + * necessary./li * - * pWhen an codeAction/code instance is first created, the controller will - * call codesetServlet/code with a non-null argument to identify the servlet - * instance to which this Action is attached. When the servlet is to be shut - * down (or restarted), the codesetServlet/code method will be called with a - * codenull/code argument, which can be used to clean up any allocated - * resources in use by this Action./p + * /ul + * + * pWhen an codeAction/code instance is first created, the controller + * will call codesetServlet/code with a non-null argument to identify the + * servlet instance to which this Action is attached. When the servlet is to + * be shut down (or restarted), the codesetServlet/code method will be + * called with a codenull/code argument, which can be used to clean up any + * allocated resources in use by this Action./p * * @version $Rev$ $Date: 2005-08-26 21:58:39 -0400 (Fri, 26 Aug 2005) * $ @@ -89,8 +97,8 @@ /** * pSet the servlet instance to which we are attached (if - * codeservlet/code is non-null), or release any allocated resources (if - * codeservlet/code is null)./p + * codeservlet/code is non-null), or release any allocated resources + * (if codeservlet/code is null)./p * * @param servlet The new controller servlet, if any */ @@ -105,13 +113,13 @@
svn commit: r375628 - in /struts/build/trunk: project.properties struts_checks.xml
Author: husted
Date: Tue Feb 7 07:26:59 2006
New Revision: 375628
URL: http://svn.apache.org/viewcvs?rev=375628view=rev
Log:
Checkstyle Issues
* Adjust checkstyle configuration to avoid unnecessary conflicts with Jalopy
Modified:
struts/build/trunk/project.properties
struts/build/trunk/struts_checks.xml
Modified: struts/build/trunk/project.properties
URL:
http://svn.apache.org/viewcvs/struts/build/trunk/project.properties?rev=375628r1=375627r2=375628view=diff
==
--- struts/build/trunk/project.properties (original)
+++ struts/build/trunk/project.properties Tue Feb 7 07:26:59 2006
@@ -8,6 +8,7 @@
maven.checkstyle.properties = ${basedir}/build/struts_checks.xml
maven.checkstyle.header.file = ${basedir}/build/LICENSE.txt
+maven.checkstyle.format = jalopy
checkstyle.regexp.header=${basedir}/build/LICENSE.CheckStyle
Modified: struts/build/trunk/struts_checks.xml
URL:
http://svn.apache.org/viewcvs/struts/build/trunk/struts_checks.xml?rev=375628r1=375627r2=375628view=diff
==
--- struts/build/trunk/struts_checks.xml (original)
+++ struts/build/trunk/struts_checks.xml Tue Feb 7 07:26:59 2006
@@ -38,6 +38,19 @@
- Disable the FinalParameters module, since fixing those complaints
would result in backwards incompatible API changes.
+
+- Disable the InlineConditions modules, since Struts has always used
+ this construct.
+
+- Increase LineLength max to 120 since Jalopy is set to format lines at
+ column 80. Some lines are difficult to both indent and wrap at 80.
+
+- Disable LeftCurly and RightCurly modules to avoid conflicts with Jalopy.
+
+- Disable NoWhitespaceAfter module to avoid conflicts wit Jalopy.
+
+- Disable WhitespaceAround module to avoid conflicts with Jalopy.
+
--
!--
@@ -141,6 +154,7 @@
module name=FileLength/
!-- Begin Custom for Struts --
module name=LineLength
+ property name=max value=120/
property name=ignorePattern value=^ \* @version .*$/
/module
!-- End Custom for Struts --
@@ -151,14 +165,14 @@
!-- Checks for whitespace --
!-- See http://checkstyle.sf.net/config_whitespace.html --
module name=EmptyForIteratorPad/
-module name=NoWhitespaceAfter/
+!-- Disabled for Struts: module name=NoWhitespaceAfter/ --
module name=NoWhitespaceBefore/
module name=OperatorWrap/
module name=ParenPad/
module name=TypecastParenPad/
module name=TabCharacter/
module name=WhitespaceAfter/
-module name=WhitespaceAround/
+!-- Disabled for Struts: module name=WhitespaceAround/ --
!-- Modifier Checks--
@@ -171,14 +185,14 @@
!-- See http://checkstyle.sf.net/config_blocks.html --
module name=AvoidNestedBlocks/
module name=EmptyBlock/
-module name=LeftCurly/
+!-- Disabled for Struts: module name=LeftCurly/ --
module name=NeedBraces/
-module name=RightCurly/
+!-- Disabled for Struts: module name=RightCurly/ --
!-- Checks for common coding problems --
!-- See http://checkstyle.sf.net/config_coding.html --
-module name=AvoidInlineConditionals/
+!-- Disabled for Struts: module name=AvoidInlineConditionals/ --
module name=DoubleCheckedLocking/
!-- MY FAVOURITE --
module name=EmptyStatement/
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 38374] - Validation always skipped with Globals.CANCEL_KEY
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=38374. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=38374 --- Additional Comments From [EMAIL PROTECTED] 2006-02-07 16:29 --- I think we're coming down the home stretch on the checkstyle issues for 1.3.x. Then, we can focus on fixing this for 1.3.x, as well as 1.2.x. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: svn commit: r375627 [3/3] - /struts/action/trunk/src/java/org/apache/struts/action/
On 2/7/06, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote:
Modified:
struts/action/trunk/src/java/org/apache/struts/action/DynaActionFormClass.java
URL:
http://svn.apache.org/viewcvs/struts/action/trunk/src/java/org/apache/struts/action/DynaActionFormClass.java?rev=375627r1=375626r2=375627view=diff
@@ -138,7 +141,8 @@
if (ex instanceof ModuleException) {
error = ((ModuleException) ex).getActionMessage();
property = ((ModuleException) ex).getProperty();
-} else {
+}
+else {
error = new ActionMessage(ae.getKey(), ex.getMessage());
property = error.getKey();
}
Is this change correct, or should the Jalopy config be changed?
--
Wendy
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: Checkstyle (was svn commit: r360442 [1/3] )
If we are going to use code reformatting tools like Jalopy, then
perhaps we do not need Checkstyle to vet mechanical problems, like
line-length. If we set Jalopy to seek an 80 character line length, we
could set CheckStyle for, say, 120, to give us some leeway for lines
that are hard for Jalopy to wrap.
As to the styles like
} else {
versus
}
else {
personally, I can't say I very much care. If Jalopy wants to wrap it
that way, that's fine with me. So long as the style is reasonable and
consistent, I'm a happy camper.
If we take LineLength, Whitespace, and the Curlies out of the
equation, then we are down to 1603 checkstyles errors in Action, that
seem to describe errors we actually deserve!
* http://people.apache.org/~husted/checkstyle/checkstyle-report.html
There are a couple of missing headers, but the rest seem to be true
bad practices, like magic numbers and missing Javadocs.
I would suggest that a reasonable goal would be to use Jalopy to
correct mechanical errors, like line length, and let CheckStyle focus
on eeper coding problems that something like Jalopy can't fix.
I've updated the default checkstyle configuraton to match what I used
to achieve the referenced report and the current state of the
Action/Action package. If this seems all right, I could conform the
JavaDocs on the rest of the Acton subproject, and move on to the
others.
One note: In the checkstyle configuration, I also disabled the check
for Inline conditions. I myself don't find this construct hard to
read, and some of us have tended to use Inline Conditionals over the
years.
-Ted.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
RE: Checkstyle (was svn commit: r360442 [1/3] )
Which version of Jalopy are you using?
I notice in http://www.triemax.com/products/jalopy/manual/braces.html it
says:
Sun Java style
Activates the Sun brace style. Sometimes called KR style.
Example 3.32. Sun style
if (!isDone) {
doSomething();
} else {
System.err.println(Finished);
}
I also notice on
http://www.eclipseplugincentral.com/printarticle193.html it says:
Changes/Enhancements since 1.1
...
* Print if/else brace blocks on one line
-Original Message-
From: Ted Husted [mailto:[EMAIL PROTECTED]
Sent: Tuesday, February 07, 2006 10:40 AM
To: Struts Developers List
Subject: Re: Checkstyle (was svn commit: r360442 [1/3] )
If we are going to use code reformatting tools like Jalopy,
then perhaps we do not need Checkstyle to vet mechanical
problems, like line-length. If we set Jalopy to seek an 80
character line length, we could set CheckStyle for, say, 120,
to give us some leeway for lines that are hard for Jalopy to wrap.
As to the styles like
} else {
versus
}
else {
personally, I can't say I very much care. If Jalopy wants to
wrap it that way, that's fine with me. So long as the style
is reasonable and consistent, I'm a happy camper.
If we take LineLength, Whitespace, and the Curlies out of the
equation, then we are down to 1603 checkstyles errors in
Action, that seem to describe errors we actually deserve!
* http://people.apache.org/~husted/checkstyle/checkstyle-report.html
There are a couple of missing headers, but the rest seem to
be true bad practices, like magic numbers and missing Javadocs.
I would suggest that a reasonable goal would be to use Jalopy
to correct mechanical errors, like line length, and let
CheckStyle focus on eeper coding problems that something like
Jalopy can't fix.
I've updated the default checkstyle configuraton to match
what I used to achieve the referenced report and the current
state of the Action/Action package. If this seems all right,
I could conform the JavaDocs on the rest of the Acton
subproject, and move on to the others.
One note: In the checkstyle configuration, I also disabled
the check for Inline conditions. I myself don't find this
construct hard to read, and some of us have tended to use
Inline Conditionals over the years.
-Ted.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: Checkstyle (was svn commit: r360442 [1/3] )
On 2/7/06, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: Which version of Jalopy are you using? Right now, we're using version 1.3.1 of the plugin, so as to be compatible with Maven 1.0.2. -Ted. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[Struts Wiki] Update of StrutsWidgets by MichaelJouravlev
Dear Wiki user,
You have subscribed to a wiki page or wiki category on Struts Wiki for change
notification.
The following page has been changed by MichaelJouravlev:
http://wiki.apache.org/struts/StrutsWidgets
--
- === HTML SELECT element ===
+ == Dropdown box ==
- Use html:select tag to create HTML SELECT widget.
+ Use html:select tag to create HTML SELECT element that can be rendered
either as dropdown box or a listbox. To create a dropdown box set ''size'' less
than 2 or do not specify ''size'' at all.
{{{
html:select name=addressForm property=currentStateCode size=1
@@ -10, +10 @@
/html:select
}}}
- HTML SELECT can be rendered either as dropdown box or as a listbox. To create
a dropdown box set ''size'' less than 2 or do not specify ''size'' at all. To
create a listbox specify ''size'' larger than 1.
+ HTML SELECT can be rendered either as dropdown box or as a listbox. To
create a listbox specify ''size'' larger than 1.
html:select tag specifies current value:
* ''name'' is the name of plain java bean or an action form; optional
@@ -33, +33 @@
You still need to use ''property'' attribute to store value submitted by user.
+ == Listbox ==
+
+ Use html:select tag to create HTML SELECT element. Specify number of rows
in the lisbox using ''size'' attribute. You must set size larger than 1,
otherwise SELECT element will be rendered as a dropdownbox.
+
+ {{{
+ html:select name=addressForm property=currentStateCode size=3
+ html:optionsCollection name=stateList value=stateCode
label=stateName/
+ /html:select
+ }}}
+
+ See previous section (dropdown box) for usage details.
+
+ == Radio Button ==
+
+ Use html:radio tag to create HTML INPUT element having type radio.
+
+ {{{
+ html:radio name=addressForm property=currentStateCode value=CA/
California
+ }}}
+
+ html:radio tag uses following attributes:
+* ''name'' is the name of plain java bean or an action form; optional
+* ''property'' is the property in the java bean that holds current value
+* ''value'' is the static value assigned to a particular radio button
+
+ inline:radiobuttonwidget.gif
+
+ Radio button is checked if actual value stored of the ''property'' equals to
''value'' attribute. In the above example, the checkbox is checked if
addressForm.currentStateCode.equals(CA).
+
+ Radio button does not have a label. You need to print it yourself beside the
input element, like California is printed above.
+
+ == Radio Group ==
+
+ Use logic:iterate and html:radio tags to create series of HTML INPUT
elements having type radio.
+
+ {{{
+ logic:iterate id=choice name=stateList
+ html:radio name=addressForm property=currentStateCode idName=choice
value=stateCode/
+ bean:write name=choice property=stateName/
+ br
+ /logic:iterate
+ }}}
+
+ inline:radiogroup.gif
+
+ logic:iterate tag uses following attributes:
+* ''name'' is the name of a collection that holds possible values and
labels of radio buttons
+* ''id'' is the name to use for current collection element while iterating
over the collection
+
+ html:radio tag uses following attributes:
+* ''name'' is the name of plain java bean or an action form; optional
+* ''property'' is the property in the java bean that holds current value
+* ''idName'' corresponds to ''id'' attribute from logic:iterate tag; id
identifies a collection element that is being processed
+* ''value'' is the name of collection property that contains radio button
value
+
+ html:radio tag uses following attributes:
+* ''name'' identifies a collection element that is being processed
+* ''property'' is the name of collection property that contains radio
button label
+
+ In the above example a radio button is checked if
addressForm.currentStateCode.equals(choice.stateCode).
+
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[Struts Wiki] Trivial Update of StrutsWidgets by MichaelJouravlev
Dear Wiki user, You have subscribed to a wiki page or wiki category on Struts Wiki for change notification. The following page has been changed by MichaelJouravlev: http://wiki.apache.org/struts/StrutsWidgets -- /logic:iterate }}} - inline:radiogroup.gif + file:radiogroup.gif logic:iterate tag uses following attributes: * ''name'' is the name of a collection that holds possible values and labels of radio buttons - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[Struts Wiki] Trivial Update of StrutsWidgets by MichaelJouravlev
Dear Wiki user, You have subscribed to a wiki page or wiki category on Struts Wiki for change notification. The following page has been changed by MichaelJouravlev: http://wiki.apache.org/struts/StrutsWidgets -- /logic:iterate }}} - file:radiogroup.gif + inline:radiogroup.gif logic:iterate tag uses following attributes: * ''name'' is the name of a collection that holds possible values and labels of radio buttons - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[Struts Wiki] Update of StrutsWidgets by MichaelJouravlev
Dear Wiki user, You have subscribed to a wiki page or wiki category on Struts Wiki for change notification. The following page has been changed by MichaelJouravlev: http://wiki.apache.org/struts/StrutsWidgets -- In the above example a radio button is checked if addressForm.currentStateCode.equals(choice.stateCode). + == References == + + For more elaborate explanation see [http://javaboutique.internet.com/tutorials/strutsform/index.html Advanced Forms Handling in Struts 1.1] + - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Checkstyle (was svn commit: r360442 [1/3] )
On 2/7/06, [EMAIL PROTECTED]
[EMAIL PROTECTED] wrote:
Which version of Jalopy are you using?
The Maven plugin depends on Jalopy 1.0b11.
I'd like to get } else { to stay on one line before we run Jalopy
against the other sub-projects. That's our convention, inherited
from Sun, and it should be a simple change to the configuration file.
I'll post to the sf.net forum and see if anyone can help with the xml
config.
--
Wendy
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 38560] New: - [shale] include local copies of dtds
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=38560. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=38560 Summary: [shale] include local copies of dtds Product: Struts Version: Nightly Build Platform: All OS/Version: All Status: NEW Severity: normal Priority: P2 Component: Shale AssignedTo: dev@struts.apache.org ReportedBy: [EMAIL PROTECTED] The xml parser is trying to download web-facesconfig_1_1.dtd from the internet but cannot due to firewall settings. I would be nice if the dtd was included locally so an internet connection was not required. This would apply to all the shale jars with faces-config.xml in the META-INF directory. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Feedback on ParameterMappingDispatchAction (ID=38343)
I'd like to hear some feedback on an enhancement of MappingDispatchAction (ParameterMappingDispatchAction) which I have contributed. It merges the flexibility of choosing the dispatch through the request plus the static configuration of which methods can be invoked. I've used this very successfully myself -- mainly for forms with many buttons like a wizard form. This was inspired by Tapestry because not only does Tapestry allow certain buttons to dictate which method to be called, but sometimes no button is submitted at all (the enter key in IE) and a default is selected. http://issues.apache.org/bugzilla/show_bug.cgi?id=38343 My testing was in Struts 1.2.8 and is targeting 1.2.x branch. If someone needs be to write a test case, I will -- but please explain how I should do it. I am use to non-http junit testing. If you want something more complex, I will require some direction. Paul - Brings words and photos together (easily) with PhotoMail - it's free and works with Yahoo! Mail.
Re: Feedback on ParameterMappingDispatchAction (ID=38343)
On 2/7/06, Paul Benedict [EMAIL PROTECTED] wrote: I'd like to hear some feedback on an enhancement of MappingDispatchAction (ParameterMappingDispatchAction) which I have contributed. It merges the flexibility of choosing the dispatch through the request plus the static configuration of which methods can be invoked. I've used this very successfully myself -- mainly for forms with many buttons like a wizard form. This was inspired by Tapestry because not only does Tapestry allow certain buttons to dictate which method to be called, but sometimes no button is submitted at all (the enter key in IE) and a default is selected. http://issues.apache.org/bugzilla/show_bug.cgi?id=38343 My testing was in Struts 1.2.8 and is targeting 1.2.x branch. If someone needs be to write a test case, I will -- but please explain how I should do it. I am use to non-http junit testing. If you want something more complex, I will require some direction. Hi Paul, I am going to try it today, but I already like it! Here is why: * one mapping can be used for several/all events for a particular action; * easy obfuscating; * Less stuff to iterate over, only method names in the mapping. The request values are verified directly, without iterating over all request parameters. * It is compact for what it does. * No changes to config file. Good job! Michael. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r375839 - /struts/shale/trunk/clay-plugin/src/java/org/apache/shale/clay/component/chain/CreateComponentCommand.java
Author: gvanmatre
Date: Tue Feb 7 19:35:05 2006
New Revision: 375839
URL: http://svn.apache.org/viewcvs?rev=375839view=rev
Log:
Fix for Bug#: 38542 - [shale] clay not handling binding attribute correctly.
Modified:
struts/shale/trunk/clay-plugin/src/java/org/apache/shale/clay/component/chain/CreateComponentCommand.java
Modified:
struts/shale/trunk/clay-plugin/src/java/org/apache/shale/clay/component/chain/CreateComponentCommand.java
URL:
http://svn.apache.org/viewcvs/struts/shale/trunk/clay-plugin/src/java/org/apache/shale/clay/component/chain/CreateComponentCommand.java?rev=375839r1=375838r2=375839view=diff
==
---
struts/shale/trunk/clay-plugin/src/java/org/apache/shale/clay/component/chain/CreateComponentCommand.java
(original)
+++
struts/shale/trunk/clay-plugin/src/java/org/apache/shale/clay/component/chain/CreateComponentCommand.java
Tue Feb 7 19:35:05 2006
@@ -23,13 +23,17 @@
import javax.faces.component.UIComponent;
import javax.faces.context.FacesContext;
+import javax.faces.el.ValueBinding;
import org.apache.commons.chain.Context;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
import org.apache.shale.clay.component.Clay;
import org.apache.shale.clay.config.Globals;
+import org.apache.shale.clay.config.beans.AttributeBean;
import org.apache.shale.clay.config.beans.ComponentBean;
+import org.apache.shale.faces.ShaleConstants;
+import org.apache.shale.util.Tags;
/**
* p
@@ -78,7 +82,7 @@
if (facesContext == null)
throw new NullPointerException(messages
.getMessage(clay.null.facesContext));
-
+
// create a new scoped symbol table
Map symbolTable = new TreeMap();
// inherit the parents symbols
@@ -115,8 +119,23 @@
if (child == null) {
try {
-child = facesContext.getApplication().createComponent(
+AttributeBean attr = null;
+if ((attr = displayElement.getAttribute(binding)) != null
+ attr.getValue() != null) {
+
+ clayContext.setAttribute(attr);
+ String expr = replaceMnemonic(clayContext);
+ ValueBinding vb =
facesContext.getApplication().createValueBinding(expr);
+ child = facesContext.getApplication().createComponent(vb,
facesContext,
+
displayElement.getComponentType());
+ child.setValueBinding(binding, vb);
+
+} else {
+
+ child = facesContext.getApplication().createComponent(
displayElement.getComponentType());
+}
+
} catch (Exception e) {
log.error(messages.getMessage(create.component.error,
new Object[] { displayElement }), e);
@@ -147,8 +166,8 @@
child.getAttributes().put(Globals.CLAY_RESERVED_ATTRIBUTE,
displayElement);
}
-// continue with the addComponent chain
-isFinal = false;
+// continue with the addComponent chain if not a bound component
+isFinal = (child.getValueBinding(binding) != null);
} else {
if (log.isDebugEnabled())
log.debug(messages.getMessage(create.component.exists,
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 38542] - [shale] clay not handling binding attribute correctly
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=38542. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=38542 --- Additional Comments From [EMAIL PROTECTED] 2006-02-08 04:38 --- Fix for this one is in the 20060208 shale nightly. I'll keep this one open until Ryan verifies for correctness. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r375843 - /struts/build/trunk/jalopy_struts.xml
Author: wsmoak
Date: Tue Feb 7 20:02:11 2006
New Revision: 375843
URL: http://svn.apache.org/viewcvs?rev=375843view=rev
Log:
Conform to Struts coding conventions. This should keep } else { on a single
line.
Modified:
struts/build/trunk/jalopy_struts.xml
Modified: struts/build/trunk/jalopy_struts.xml
URL:
http://svn.apache.org/viewcvs/struts/build/trunk/jalopy_struts.xml?rev=375843r1=375842r2=375843view=diff
==
--- struts/build/trunk/jalopy_struts.xml (original)
+++ struts/build/trunk/jalopy_struts.xml Tue Feb 7 20:02:11 2006
@@ -125,6 +125,7 @@
braceLeft1/braceLeft
deep30/deep
braceRight0/braceRight
+braceRightAfter1/braceRightAfter
useMethodCallParamsfalse/useMethodCallParams
continuation4/continuation
braceCuddled1/braceCuddled
@@ -210,7 +211,7 @@
insertBracesFortrue/insertBracesFor
removeBracesIfElsefalse/removeBracesIfElse
removeBracesWhilefalse/removeBracesWhile
-rightBraceNewLinetrue/rightBraceNewLine
+rightBraceNewLinefalse/rightBraceNewLine
leftBraceNewLinefalse/leftBraceNewLine
emptyCuddlefalse/emptyCuddle
insertBracesDoWhiletrue/insertBracesDoWhile
@@ -238,8 +239,8 @@
/misc
/transform
general
-styleNameSun/styleName
-styleDescriptionSun Java Coding Convention/styleDescription
+styleNameStruts/styleName
+styleDescriptionApache Struts Coding Convention/styleDescription
backupLevel0/backupLevel
backupDirectorybak/backupDirectory
threadCount1/threadCount
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: Checkstyle (was svn commit: r360442 [1/3] )
On 2/7/06, Wendy Smoak [EMAIL PROTECTED] wrote:
I'd like to get } else { to stay on one line before we run Jalopy
against the other sub-projects. That's our convention, inherited
from Sun, and it should be a simple change to the configuration file.
I *think* r375843 fixes this. I'm not certain, because the laptop has
inexplicably started reporting the same error I mentioned earlier. It
looks like Maven isn't setting the classpath before running the Jalopy
Ant task. I'll try it tomorrow at work, but I'm running out of
computers!
--
Wendy
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[EMAIL PROTECTED]: Project struts-taglib (in module struts) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project struts-taglib has an issue affecting its community integration. This issue affects 9 projects. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - jakarta-tomcat-5 : Servlet 2.4 and JSP 2.0 Reference Implementation - jakarta-velocity-tools : Velocity-Tools project - portals-bridges-frameworks : Support for JSR168 compliant Portlet development - portals-bridges-struts : Support for JSR168 compliant Portlet development - portals-bridges-velocity : Support for JSR168 compliant Portlet development - smartfrog-tomcat : Smartfrog: Application Deployment from HP Laboratories - struts-el : Model 2 Model-View-Controller framework for Servlets and JSP - struts-sslext : The Struts SSL Extension for HTTP/HTTPS switching - struts-taglib : Model 2 Model-View-Controller framework for Servlets and JSP Full details are available at: http://vmgump.apache.org/gump/public/struts/struts-taglib/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Sole output [struts-taglib-07022006.jar] identifier set to project name -DEBUG- Dependency on xdoclet exists, no need to add for property maven.jar.xdoclet. -DEBUG- Dependency on xdoclet exists, no need to add for property maven.jar.xdoclet-web-module. -DEBUG- Dependency on xdoclet exists, no need to add for property maven.jar.xdoclet-ejb-module. -DEBUG- Dependency on xdoclet exists, no need to add for property maven.jar.xdoclet-apache-module. -DEBUG- Dependency on xdoclet exists, no need to add for property maven.jar.xdoclet-xdoclet-module. -DEBUG- Dependency on jakarta-servletapi-4 exists, no need to add for property maven.jar.servlet-api. -DEBUG- Dependency on xdoclet exists, no need to add for property maven.jar.xdoclet-hibernate-module. -DEBUG- Dependency on xdoclet exists, no need to add for property maven.jar.xdoclet-jdo-module. -DEBUG- Dependency on xdoclet exists, no need to add for property maven.jar.xdoclet-jmx-module. -DEBUG- Dependency on xdoclet exists, no need to add for property maven.jar.xdoclet-portlet-module. -DEBUG- (Gump generated) Maven Properties in: /usr/local/gump/public/workspace/struts/taglib/build.properties -INFO- Failed with reason build failed -DEBUG- Maven POM in: /usr/local/gump/public/workspace/struts/taglib/project.xml -DEBUG- Maven project properties in: /usr/local/gump/public/workspace/struts/taglib/project.properties -INFO- Failed to extract fallback artifacts from Gump Repository The following work was performed: http://vmgump.apache.org/gump/public/struts/struts-taglib/gump_work/build_struts_struts-taglib.html Work Name: build_struts_struts-taglib (Type: Build) Work ended in a state of : Failed Elapsed: 7 secs Command Line: maven --offline jar [Working Directory: /usr/local/gump/public/workspace/struts/taglib] CLASSPATH:
