DO NOT REPLY [Bug 39213] New: - Wildcard action matcher does not set module in forward
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=39213. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=39213 Summary: Wildcard action matcher does not set module in forward Product: Struts Version: Unknown Platform: Other OS/Version: other Status: NEW Severity: normal Priority: P2 Component: Action AssignedTo: dev@struts.apache.org ReportedBy: [EMAIL PROTECTED] org.apache.struts.config.ActionConfigMatcher does not set the module property of ForwardConfig objects when it creates a matching ActionConfig. To fix the bug, the line cfg.setModule(fConfigs[x].getModule) can be added line 183 (first for instruction in convertActionConfig. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r391621 - in /struts/sandbox/trunk/action2/apps/mailreader/src/java/mailreader2: Constants.java MailreaderSupport.java
Author: husted
Date: Wed Apr 5 07:06:41 2006
New Revision: 391621
URL: http://svn.apache.org/viewcvs?rev=391621view=rev
Log:
MailReader
* Change magic logon to text ExpiredPasswordException
Modified:
struts/sandbox/trunk/action2/apps/mailreader/src/java/mailreader2/Constants.java
struts/sandbox/trunk/action2/apps/mailreader/src/java/mailreader2/MailreaderSupport.java
Modified:
struts/sandbox/trunk/action2/apps/mailreader/src/java/mailreader2/Constants.java
URL:
http://svn.apache.org/viewcvs/struts/sandbox/trunk/action2/apps/mailreader/src/java/mailreader2/Constants.java?rev=391621r1=391620r2=391621view=diff
==
---
struts/sandbox/trunk/action2/apps/mailreader/src/java/mailreader2/Constants.java
(original)
+++
struts/sandbox/trunk/action2/apps/mailreader/src/java/mailreader2/Constants.java
Wed Apr 5 07:06:41 2006
@@ -99,6 +99,20 @@
*/
public static final String ERROR_DATABASE_MISSING =
error.database.missing;
+/**
+ * P
+ * A magic username to trigger an ExpiredPasswordException for testing.
+ */p
+ */
+public static final String EXPIRED_PASSWORD_EXCEPTION =
ExpiredPasswordException;
+
+/**
+ * p
+ * Name of field to associate with authentification errors.
+ * p
+ */
+public static final String PASSWORD_MISMATCH_FIELD = password;
+
// Log Messages
/**
Modified:
struts/sandbox/trunk/action2/apps/mailreader/src/java/mailreader2/MailreaderSupport.java
URL:
http://svn.apache.org/viewcvs/struts/sandbox/trunk/action2/apps/mailreader/src/java/mailreader2/MailreaderSupport.java?rev=391621r1=391620r2=391621view=diff
==
---
struts/sandbox/trunk/action2/apps/mailreader/src/java/mailreader2/MailreaderSupport.java
(original)
+++
struts/sandbox/trunk/action2/apps/mailreader/src/java/mailreader2/MailreaderSupport.java
Wed Apr 5 07:06:41 2006
@@ -345,8 +345,8 @@
public User findUser(String username, String password)
throws ExpiredPasswordException {
// FIXME: Stupid testing hack to compensate for inadequate DAO layer
-if (Hermes.equals(username)) {
-throw new ExpiredPasswordException(Hermes);
+if (Constants.EXPIRED_PASSWORD_EXCEPTION.equals(username)) {
+throw new
ExpiredPasswordException(Constants.EXPIRED_PASSWORD_EXCEPTION);
}
User user = getDatabase().findUser(username);
@@ -354,7 +354,8 @@
user = null;
}
if (user == null) {
-this.addFieldError(password, getText(error.password.mismatch));
+this.addFieldError(Constants.PASSWORD_MISMATCH_FIELD,
+getText(error.password.mismatch));
}
return user;
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r391690 - in /struts/action/trunk/core/src: java/org/apache/struts/config/ActionConfigMatcher.java test/org/apache/struts/config/TestActionConfigMatcher.java
Author: mrdon
Date: Wed Apr 5 10:54:46 2006
New Revision: 391690
URL: http://svn.apache.org/viewcvs?rev=391690view=rev
Log:
Adding module property to wildcard replacement for forward configs
PR: 39213
Modified:
struts/action/trunk/core/src/java/org/apache/struts/config/ActionConfigMatcher.java
struts/action/trunk/core/src/test/org/apache/struts/config/TestActionConfigMatcher.java
Modified:
struts/action/trunk/core/src/java/org/apache/struts/config/ActionConfigMatcher.java
URL:
http://svn.apache.org/viewcvs/struts/action/trunk/core/src/java/org/apache/struts/config/ActionConfigMatcher.java?rev=391690r1=391689r2=391690view=diff
==
---
struts/action/trunk/core/src/java/org/apache/struts/config/ActionConfigMatcher.java
(original)
+++
struts/action/trunk/core/src/java/org/apache/struts/config/ActionConfigMatcher.java
Wed Apr 5 10:54:46 2006
@@ -183,6 +183,7 @@
cfg.setRedirect(fConfigs[x].getRedirect());
cfg.setCommand(convertParam(fConfigs[x].getCommand(), vars));
cfg.setCatalog(convertParam(fConfigs[x].getCatalog(), vars));
+cfg.setModule(convertParam(fConfigs[x].getModule(), vars));
replaceProperties(fConfigs[x].getProperties(), cfg.getProperties(),
vars);
Modified:
struts/action/trunk/core/src/test/org/apache/struts/config/TestActionConfigMatcher.java
URL:
http://svn.apache.org/viewcvs/struts/action/trunk/core/src/test/org/apache/struts/config/TestActionConfigMatcher.java?rev=391690r1=391689r2=391690view=diff
==
---
struts/action/trunk/core/src/test/org/apache/struts/config/TestActionConfigMatcher.java
(original)
+++
struts/action/trunk/core/src/test/org/apache/struts/config/TestActionConfigMatcher.java
Wed Apr 5 10:54:46 2006
@@ -148,6 +148,8 @@
path,Bar.equals(cfg.getPath()));
assertTrue(Property foo hasn't been replaced,
bar,Bar.equals(cfg.getProperty(foo)));
+assertTrue(Module hasn't been replaced,
+modBar.equals(cfg.getModule()));
}
}
@@ -192,12 +194,14 @@
cfg.setName(name);
cfg.setPath(path,{1});
+cfg.setModule(mod{1});
cfg.setProperty(foo, bar,{1});
mapping.addForwardConfig(cfg);
cfg = new ActionForward();
cfg.setName(name2);
cfg.setPath(path2);
+cfg.setModule(mod{1});
mapping.addForwardConfig(cfg);
ExceptionConfig excfg = new ExceptionConfig();
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 39213] - Wildcard action matcher does not set module in forward
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=39213. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=39213 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED Target Milestone|--- |1.3.2 --- Additional Comments From [EMAIL PROTECTED] 2006-04-05 18:55 --- Fixed in revision [39213]. Thanks! -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r391695 - /struts/action/trunk/build/maven.xml
Author: mrdon Date: Wed Apr 5 11:18:43 2006 New Revision: 391695 URL: http://svn.apache.org/viewcvs?rev=391695view=rev Log: Adding struts-faces directory to nightly target Modified: struts/action/trunk/build/maven.xml Modified: struts/action/trunk/build/maven.xml URL: http://svn.apache.org/viewcvs/struts/action/trunk/build/maven.xml?rev=391695r1=391694r2=391695view=diff == --- struts/action/trunk/build/maven.xml (original) +++ struts/action/trunk/build/maven.xml Wed Apr 5 11:18:43 2006 @@ -21,6 +21,7 @@ ant:mkdir dir=nightly/struts-core// ant:mkdir dir=nightly/struts-el// ant:mkdir dir=nightly/struts-extras// +ant:mkdir dir=nightly/struts-faces// ant:mkdir dir=nightly/struts-taglib// attainGoal name=clean-all/ - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r391716 - /struts/sandbox/trunk/mailreader-course/action2/mailreader-course-action2.iws
Author: husted Date: Wed Apr 5 11:53:53 2006 New Revision: 391716 URL: http://svn.apache.org/viewcvs?rev=391716view=rev Log: mailreader-course/action2 * Remove local settings file. Removed: struts/sandbox/trunk/mailreader-course/action2/mailreader-course-action2.iws - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r391727 - /struts/action/trunk/build/maven-nightly.sh.current
Author: jmitchell Date: Wed Apr 5 12:10:02 2006 New Revision: 391727 URL: http://svn.apache.org/viewcvs?rev=391727view=rev Log: remove old nightly script Removed: struts/action/trunk/build/maven-nightly.sh.current - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r391736 - /struts/current/
Author: jmitchell Date: Wed Apr 5 12:20:35 2006 New Revision: 391736 URL: http://svn.apache.org/viewcvs?rev=391736view=rev Log: remove alphabeticalizationnessless from the list ;) Modified: struts/current/ (props changed) Propchange: struts/current/ -- --- svn:externals (original) +++ svn:externals Wed Apr 5 12:20:35 2006 @@ -1,6 +1,6 @@ actionhttps://svn.apache.org/repos/asf/struts/action/trunk sandbox https://svn.apache.org/repos/asf/struts/sandbox/trunk scripting https://svn.apache.org/repos/asf/struts/scripting/trunk -site https://svn.apache.org/repos/asf/struts/site shale https://svn.apache.org/repos/asf/struts/shale/trunk +site https://svn.apache.org/repos/asf/struts/site tiles https://svn.apache.org/repos/asf/struts/tiles/trunk - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Action 1 consolidation testing (was Towards a stable 1.3 release)
.current is now .gone and so now I just need to fix the good one to actually work correctly and we'll have our nightlies back. -- James Mitchell On Apr 4, 2006, at 1:01 PM, James Mitchell wrote: I believe the .current one is an older copy. I'll clean that up shortly. -- James Mitchell On Apr 3, 2006, at 6:26 PM, Wendy Smoak wrote: On 4/3/06, James Mitchell [EMAIL PROTECTED] wrote: The 'actual' shell script that gets run nightly via cron is not under svn. Since we run nightlies on our zone, it is merely a copy of the one under svn and as changes come in, I review and then update my copy. It's probably an unnecessary level of security, but as long as my name and ASF Account is on the cron job, I'll be keeping it that way ;) So that's how that works. :) Do need both of these, or only the first? struts/current/nightly.sh or struts/action/build/maven-nightly.sh.current Thanks, -- Wendy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 38374] - Validation always skipped with Globals.CANCEL_KEY
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=38374.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=38374
[EMAIL PROTECTED] changed:
What|Removed |Added
Status|RESOLVED|REOPENED
Resolution|FIXED |
--- Additional Comments From [EMAIL PROTECTED] 2006-04-05 20:55 ---
Our class SaveAction performs a forward to a EditAction when isCancelled() is
true.
Because the CANCEL_KEY is still in the request
an InvalidCancelException() is thrown before we get to the new EditAction.
It's ugly for EditAction to know who could possibly forward to it,
So placing a
set-property property=cancellable value=true/
In all the EditActions mappings seems a little confusing and non-intuative,
There needs to be a clean way to cleanup this attribute, and I beleive
it should be the SaveAction() in this case.
One possible changes would be to provide a method similar to isValidToken()
that explicitly clears the CANCEL_KEY attribute
protected boolean isCancelled(HttpServletRequest request, boolean remove) {
boolean cancelled = isCancelled(request);
if (cancelled remove) {
request.removeAttribute(Globals.CANCEL_KEY);
}
return (cancelled);
}
Another method that is a little more involved would be to add an attribute
in the controller declaration that says to clean up the CANCEL_KEY before
performing a forward.
-Rob
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: Action 1 consolidation testing (was Towards a stable 1.3 release)
The nightly maven goal isn't working for me. It doesn't seem to be correctly executing the jar:install goal, causing other artifact builds to fail due to missing dependencies. Perhaps someone seems something I'm missing from this snippet from a nightly build: + | Building nightlies Struts Action Framework | Memory: 18M/20M + jar:jar: jar:install: build:end: build:start: dist:build-setup: [delete] Deleting directory /data/brownd/dev/struts/action/core/target/distributions [mkdir] Created dir: /data/brownd/dev/struts/action/core/target/distributions xdoc:init: java:prepare-filesystem: java:compile: [echo] Compiling to /data/brownd/dev/struts/action/core/../core/target/classes java:jar-resources: test:prepare-filesystem: test:test-resources: test:compile: test:test: [junit] Running org.apache.struts.chain.commands.servlet.TestPerformForward exception: The path of an ForwardConfig cannot be null [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.183 sec [junit] Running org.apache.struts.chain.commands.servlet.TestSetOriginalURI [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.139 sec [junit] Running org.apache.struts.chain.commands.servlet.TestAuthorizeAction [junit] Tests run: 5, Failures: 0, Errors: 0, Time elapsed: 0.191 sec [junit] Running org.apache.struts.chain.commands.generic.TestWrappingLookupCommand [junit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 0.38 sec [junit] Running org.apache.struts.chain.commands.generic.TestCopyFormToContext [junit] Tests run: 6, Failures: 0, Errors: 0, Time elapsed: 0.217 sec [junit] Running org.apache.struts.config.TestActionConfigMatcher [junit] Tests run: 6, Failures: 0, Errors: 0, Time elapsed: 0.244 sec [junit] Running org.apache.struts.config.TestFormBeanConfig [junit] Tests run: 5, Failures: 0, Errors: 0, Time elapsed: 0.165 sec [junit] Running org.apache.struts.config.TestActionConfig [junit] Tests run: 5, Failures: 0, Errors: 0, Time elapsed: 0.178 sec [junit] Running org.apache.struts.config.TestForwardConfig [junit] Tests run: 15, Failures: 0, Errors: 0, Time elapsed: 0.082 sec [junit] Running org.apache.struts.config.TestModuleConfig [junit] Tests run: 5, Failures: 0, Errors: 0, Time elapsed: 1.185 sec [junit] Running org.apache.struts.config.TestFormPropertyConfig [junit] Tests run: 5, Failures: 0, Errors: 0, Time elapsed: 0.04 sec [junit] Running org.apache.struts.validator.TestValidWhen [junit] Tests run: 6, Failures: 0, Errors: 0, Time elapsed: 0.442 sec [junit] Running org.apache.struts.action.TestDynaActionFormClass [junit] Tests run: 7, Failures: 0, Errors: 0, Time elapsed: 0.106 sec [junit] Running org.apache.struts.action.TestActionRedirect [junit] Tests run: 5, Failures: 0, Errors: 0, Time elapsed: 0.058 sec [junit] Running org.apache.struts.action.TestActionMessage [junit] Tests run: 8, Failures: 0, Errors: 0, Time elapsed: 0.007 sec [junit] Running org.apache.struts.action.TestActionServlet Missing type value for noTypeForm form bean Missing type value for name form property Unable to create an instance of org.apache.struts.action.TestActionServlet$CustomFormBeanConfigArg java.lang.InstantiationException: org.apache.struts.action.TestActionServlet$CustomFormBeanConfigArg at java.lang.Class.newInstance0(Class.java:293) at java.lang.Class.newInstance(Class.java:261) at org.apache.struts.util.RequestUtils.applicationInstance(RequestUtils.java:163) at org.apache.struts.util.RequestUtils.applicationInstance(RequestUtils.java:138) at org.apache.struts.action.ActionServlet.processFormBeanConfigClass(ActionServlet.java:1021) at org.apache.struts.action.TestActionServlet.testProcessFormBeanConfigClassError(TestActionServlet.java:443) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:324) at junit.framework.TestCase.runTest(TestCase.java:154) at junit.framework.TestCase.runBare(TestCase.java:127) at junit.framework.TestResult$1.protect(TestResult.java:106) at junit.framework.TestResult.runProtected(TestResult.java:124) at junit.framework.TestResult.run(TestResult.java:109) at junit.framework.TestCase.run(TestCase.java:118) at junit.framework.TestSuite.runTest(TestSuite.java:208) at junit.framework.TestSuite.run(TestSuite.java:203) at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:325) at
svn commit: r391792 - in /struts/sandbox/trunk/mailreader-course/action2: ./ lab-1-0-src/src/java/ lab-1-0-src/src/webapp/WEB-INF/ lab-1-1-src/ lab-1-1-src/src/java/ lab-1-1-src/src/webapp/
Author: husted Date: Wed Apr 5 13:32:14 2006 New Revision: 391792 URL: http://svn.apache.org/viewcvs?rev=391792view=rev Log: mailreader-course/action2 * Add lab 1-1. Added: struts/sandbox/trunk/mailreader-course/action2/lab-1-0-src/src/java/applicationContext.xml - copied unchanged from r391708, struts/sandbox/trunk/mailreader-course/action2/lab-1-0-src/src/webapp/WEB-INF/applicationContext.xml struts/sandbox/trunk/mailreader-course/action2/lab-1-1-src/ - copied from r391708, struts/sandbox/trunk/mailreader-course/action2/lab-1-0-src/ struts/sandbox/trunk/mailreader-course/action2/lab-1-1-src/lab-1-1-src.iml Removed: struts/sandbox/trunk/mailreader-course/action2/lab-1-0-src/src/webapp/WEB-INF/applicationContext.xml struts/sandbox/trunk/mailreader-course/action2/lab-1-1-src/lab-1-0-src.iml Modified: struts/sandbox/trunk/mailreader-course/action2/lab-1-1-src/src/java/xwork.xml struts/sandbox/trunk/mailreader-course/action2/lab-1-1-src/src/webapp/index.html struts/sandbox/trunk/mailreader-course/action2/mailreader-course-action2.ipr Added: struts/sandbox/trunk/mailreader-course/action2/lab-1-1-src/lab-1-1-src.iml URL: http://svn.apache.org/viewcvs/struts/sandbox/trunk/mailreader-course/action2/lab-1-1-src/lab-1-1-src.iml?rev=391792view=auto == --- struts/sandbox/trunk/mailreader-course/action2/lab-1-1-src/lab-1-1-src.iml (added) +++ struts/sandbox/trunk/mailreader-course/action2/lab-1-1-src/lab-1-1-src.iml Wed Apr 5 13:32:14 2006 @@ -0,0 +1,262 @@ +?xml version=1.0 encoding=UTF-8? +module version=4 relativePaths=true type=J2EE_WEB_MODULE j2ee-integration=Tomcat Server + component name=ModuleRootManager / + component name=NewModuleRootManager +output url=file://C:/opt/Apache/Tomcat-5.0/webapps/lab-1-1-src/WEB-INF/classes / +exclude-output / +exploded url=file://C:/opt/Apache/Tomcat-5.0/webapps/lab-1-1-src / +exclude-exploded / +content url=file://$MODULE_DIR$ + sourceFolder url=file://$MODULE_DIR$/src/java isTestSource=false / + sourceFolder url=file://$MODULE_DIR$/src/test isTestSource=false / +/content +orderEntry type=inheritedJdk / +orderEntry type=sourceFolder forTests=false / +orderEntry type=library name=Tomcat level=application_server_libraries / +orderEntry type=module-library + library +CLASSES + root url=jar://$APPLICATION_HOME_DIR$/lib/junit.jar!/ / +/CLASSES +JAVADOC / +SOURCES / + /library +/orderEntry +orderEntry type=module-library + library +CLASSES + root url=jar://$MODULE_DIR$/../../lib/xwork-1.1.2.jar!/ / +/CLASSES +JAVADOC / +SOURCES / + /library +/orderEntry +orderEntry type=module-library + library +CLASSES + root url=jar://$MODULE_DIR$/../../lib/webwork-2.2.2.jar!/ / +/CLASSES +JAVADOC / +SOURCES / + /library +/orderEntry +orderEntry type=module-library + library +CLASSES + root url=jar://$MODULE_DIR$/../../lib/rife-continuations.jar!/ / +/CLASSES +JAVADOC / +SOURCES / + /library +/orderEntry +orderEntry type=module-library + library +CLASSES + root url=jar://$MODULE_DIR$/../../lib/ognl.jar!/ / +/CLASSES +JAVADOC / +SOURCES / + /library +/orderEntry +orderEntry type=module-library + library +CLASSES + root url=jar://$MODULE_DIR$/../../lib/spring-beans.jar!/ / +/CLASSES +JAVADOC / +SOURCES / + /library +/orderEntry +orderEntry type=module-library + library +CLASSES + root url=jar://$MODULE_DIR$/../../lib/struts-taglib-1.3.0.jar!/ / +/CLASSES +JAVADOC / +SOURCES / + /library +/orderEntry +orderEntry type=module-library + library +CLASSES + root url=jar://$MODULE_DIR$/../../lib/spring-core.jar!/ / +/CLASSES +JAVADOC / +SOURCES / + /library +/orderEntry +orderEntry type=module-library + library +CLASSES + root url=jar://$MODULE_DIR$/../../lib/commons-digester-1.6.jar!/ / +/CLASSES +JAVADOC / +SOURCES / + /library +/orderEntry +orderEntry type=module-library + library +CLASSES + root url=jar://$MODULE_DIR$/../../lib/oscore.jar!/ / +/CLASSES +JAVADOC / +SOURCES / + /library +/orderEntry +orderEntry type=module-library + library +CLASSES + root url=jar://$MODULE_DIR$/../../lib/commons-collections-3.1.jar!/ / +/CLASSES +JAVADOC / +SOURCES / + /library +/orderEntry +orderEntry type=module-library + library +CLASSES + root
DO NOT REPLY [Bug 38374] - Validation always skipped with Globals.CANCEL_KEY
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=38374.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=38374
--- Additional Comments From [EMAIL PROTECTED] 2006-04-05 21:32 ---
(In reply to comment #37)
Our class SaveAction performs a forward to a EditAction...
I use similar pattern, but I employ redirect, not forward. With new request
everything comes sparkling clean. But this is a religious topic and one has to
use session to save data between requests, or append it as a payload to
redirected URL.
Another religious topic is action chaining smell, but contrary to many, I am not
against it.
...when isCancelled() is true.
Because the CANCEL_KEY is still in the request
an InvalidCancelException() is thrown before we get to the new EditAction.
It's ugly for EditAction to know who could possibly forward to it,
So placing a
set-property property=cancellable value=true/
In all the EditActions mappings seems a little confusing and non-intuative,
I never liked cancellable property at the first place because it is intrusive
(I guess I should have voiced my position on this.) Who said that Hollywood
principle is a good thing? If I want to know something I'll ask. If I need
something to be done, I will send a message to the appropriate object (fancy
old-fashioned way to say that I will call a damn method). Hollywood principle
sucks, and this particular incident stresses this out one more time.
There needs to be a clean way to cleanup this attribute, and I beleive
it should be the SaveAction() in this case.
One possible changes would be to provide a method similar to isValidToken()
that explicitly clears the CANCEL_KEY attribute
protected boolean isCancelled(HttpServletRequest request, boolean remove) {
boolean cancelled = isCancelled(request);
if (cancelled remove) {
request.removeAttribute(Globals.CANCEL_KEY);
}
return (cancelled);
}
It is a bad practice to have side effects in getters, it is even worse to have
getters that are non-idempotent.
Another method that is a little more involved would be to add an attribute
in the controller declaration that says to clean up the CANCEL_KEY before
performing a forward.
This is better but still a hassle. I don't see how simple
request.removeAttribute(Globals.CANCEL_KEY);
is worse than having another attribute in config file (and another update to
DTD). Struts 1.x is deeply penetrated with references to request/response
objects, so let's not pretend that it is a Servlet API virgin.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r391796 - in /struts/sandbox/trunk/mailreader-course/action2/lab-1-0-src/src: java/Hello.java java/Home.java java/resources.properties test/HelloTest.java test/HomeTest.java webapp/pages/H
Author: husted
Date: Wed Apr 5 13:37:48 2006
New Revision: 391796
URL: http://svn.apache.org/viewcvs?rev=391796view=rev
Log:
mailreader-course/action2
* Change Home to Hello
Added:
struts/sandbox/trunk/mailreader-course/action2/lab-1-0-src/src/java/Hello.java
- copied, changed from r391708,
struts/sandbox/trunk/mailreader-course/action2/lab-1-0-src/src/java/Home.java
struts/sandbox/trunk/mailreader-course/action2/lab-1-0-src/src/test/HelloTest.java
- copied, changed from r391708,
struts/sandbox/trunk/mailreader-course/action2/lab-1-0-src/src/test/HomeTest.java
Removed:
struts/sandbox/trunk/mailreader-course/action2/lab-1-0-src/src/java/Home.java
struts/sandbox/trunk/mailreader-course/action2/lab-1-0-src/src/test/HomeTest.java
Modified:
struts/sandbox/trunk/mailreader-course/action2/lab-1-0-src/src/java/resources.properties
struts/sandbox/trunk/mailreader-course/action2/lab-1-0-src/src/webapp/pages/Home.jsp
Copied:
struts/sandbox/trunk/mailreader-course/action2/lab-1-0-src/src/java/Hello.java
(from r391708,
struts/sandbox/trunk/mailreader-course/action2/lab-1-0-src/src/java/Home.java)
URL:
http://svn.apache.org/viewcvs/struts/sandbox/trunk/mailreader-course/action2/lab-1-0-src/src/java/Hello.java?p2=struts/sandbox/trunk/mailreader-course/action2/lab-1-0-src/src/java/Hello.javap1=struts/sandbox/trunk/mailreader-course/action2/lab-1-0-src/src/java/Home.javar1=391708r2=391796rev=391796view=diff
==
---
struts/sandbox/trunk/mailreader-course/action2/lab-1-0-src/src/java/Home.java
(original)
+++
struts/sandbox/trunk/mailreader-course/action2/lab-1-0-src/src/java/Hello.java
Wed Apr 5 13:37:48 2006
@@ -3,7 +3,7 @@
/**
* codeExample Action class/code
*/
-public class Home extends ActionSupport {
+public class Hello extends ActionSupport {
/**
* An example implementation that does nothing an returns success.
Modified:
struts/sandbox/trunk/mailreader-course/action2/lab-1-0-src/src/java/resources.properties
URL:
http://svn.apache.org/viewcvs/struts/sandbox/trunk/mailreader-course/action2/lab-1-0-src/src/java/resources.properties?rev=391796r1=391795r2=391796view=diff
==
---
struts/sandbox/trunk/mailreader-course/action2/lab-1-0-src/src/java/resources.properties
(original)
+++
struts/sandbox/trunk/mailreader-course/action2/lab-1-0-src/src/java/resources.properties
Wed Apr 5 13:37:48 2006
@@ -1,2 +1,2 @@
-home.nessage = Congratulations! WebWork is up and running ...
+hello.nessage = Congratulations! WebWork is up and running ...
# Add your messages here ...
Copied:
struts/sandbox/trunk/mailreader-course/action2/lab-1-0-src/src/test/HelloTest.java
(from r391708,
struts/sandbox/trunk/mailreader-course/action2/lab-1-0-src/src/test/HomeTest.java)
URL:
http://svn.apache.org/viewcvs/struts/sandbox/trunk/mailreader-course/action2/lab-1-0-src/src/test/HelloTest.java?p2=struts/sandbox/trunk/mailreader-course/action2/lab-1-0-src/src/test/HelloTest.javap1=struts/sandbox/trunk/mailreader-course/action2/lab-1-0-src/src/test/HomeTest.javar1=391708r2=391796rev=391796view=diff
==
---
struts/sandbox/trunk/mailreader-course/action2/lab-1-0-src/src/test/HomeTest.java
(original)
+++
struts/sandbox/trunk/mailreader-course/action2/lab-1-0-src/src/test/HelloTest.java
Wed Apr 5 13:37:48 2006
@@ -3,14 +3,14 @@
/**
* An example text class to verify the configuration.
*/
-public class HomeTest extends TestCase {
+public class HelloTest extends TestCase {
/**
* An example test that asserts true.
*
* @throws Exception On invalid assertions
*/
-public void testHomeAction() throws Exception {
+public void testHelloAction() throws Exception {
assertTrue(true);
}
}
Modified:
struts/sandbox/trunk/mailreader-course/action2/lab-1-0-src/src/webapp/pages/Home.jsp
URL:
http://svn.apache.org/viewcvs/struts/sandbox/trunk/mailreader-course/action2/lab-1-0-src/src/webapp/pages/Home.jsp?rev=391796r1=391795r2=391796view=diff
==
---
struts/sandbox/trunk/mailreader-course/action2/lab-1-0-src/src/webapp/pages/Home.jsp
(original)
+++
struts/sandbox/trunk/mailreader-course/action2/lab-1-0-src/src/webapp/pages/Home.jsp
Wed Apr 5 13:37:48 2006
@@ -3,10 +3,10 @@
html
head
-titleHome/title
+titleHello/title
/head
body
-h2ww:text name=home.nessage//h2
+h2ww:text name=hello.nessage//h2
/body
/html
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: Action 1 consolidation testing (was Towards a stable 1.3 release)
Funny you should mention this now. About 10 minutes ago I (locally) commented the failing tests out (actually, I put 'no' in front of the failing testFoo methods, so it looks like 'notestFoo') so I could 'mvn eclipse:eclipse' core, taglib, and extras. I'm not sure why the output of the tests make Maven think that they failed, when, they actually did not and I know it's not an optimal solution, but I'd like to check that in so we can move on with our build. We can work out the kinks later. Also, I'm about to start another thread related to our build...it is (more or less) notes as I go through the various project.xml, pom.xml, etc, etc for each of the pieces of the action1 puzzle. -- James Mitchell On Apr 5, 2006, at 4:23 PM, Don Brown wrote: The nightly maven goal isn't working for me. It doesn't seem to be correctly executing the jar:install goal, causing other artifact builds to fail due to missing dependencies. Perhaps someone seems something I'm missing from this snippet from a nightly build: + | Building nightlies Struts Action Framework | Memory: 18M/20M + jar:jar: jar:install: build:end: build:start: dist:build-setup: [delete] Deleting directory /data/brownd/dev/struts/action/core/ target/distributions [mkdir] Created dir: /data/brownd/dev/struts/action/core/target/ distributions xdoc:init: java:prepare-filesystem: java:compile: [echo] Compiling to /data/brownd/dev/struts/action/core/../core/ target/classes java:jar-resources: test:prepare-filesystem: test:test-resources: test:compile: test:test: [junit] Running org.apache.struts.chain.commands.servlet.TestPerformForward exception: The path of an ForwardConfig cannot be null [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.183 sec [junit] Running org.apache.struts.chain.commands.servlet.TestSetOriginalURI [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.139 sec [junit] Running org.apache.struts.chain.commands.servlet.TestAuthorizeAction [junit] Tests run: 5, Failures: 0, Errors: 0, Time elapsed: 0.191 sec [junit] Running org.apache.struts.chain.commands.generic.TestWrappingLookupCommand [junit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 0.38 sec [junit] Running org.apache.struts.chain.commands.generic.TestCopyFormToContext [junit] Tests run: 6, Failures: 0, Errors: 0, Time elapsed: 0.217 sec [junit] Running org.apache.struts.config.TestActionConfigMatcher [junit] Tests run: 6, Failures: 0, Errors: 0, Time elapsed: 0.244 sec [junit] Running org.apache.struts.config.TestFormBeanConfig [junit] Tests run: 5, Failures: 0, Errors: 0, Time elapsed: 0.165 sec [junit] Running org.apache.struts.config.TestActionConfig [junit] Tests run: 5, Failures: 0, Errors: 0, Time elapsed: 0.178 sec [junit] Running org.apache.struts.config.TestForwardConfig [junit] Tests run: 15, Failures: 0, Errors: 0, Time elapsed: 0.082 sec [junit] Running org.apache.struts.config.TestModuleConfig [junit] Tests run: 5, Failures: 0, Errors: 0, Time elapsed: 1.185 sec [junit] Running org.apache.struts.config.TestFormPropertyConfig [junit] Tests run: 5, Failures: 0, Errors: 0, Time elapsed: 0.04 sec [junit] Running org.apache.struts.validator.TestValidWhen [junit] Tests run: 6, Failures: 0, Errors: 0, Time elapsed: 0.442 sec [junit] Running org.apache.struts.action.TestDynaActionFormClass [junit] Tests run: 7, Failures: 0, Errors: 0, Time elapsed: 0.106 sec [junit] Running org.apache.struts.action.TestActionRedirect [junit] Tests run: 5, Failures: 0, Errors: 0, Time elapsed: 0.058 sec [junit] Running org.apache.struts.action.TestActionMessage [junit] Tests run: 8, Failures: 0, Errors: 0, Time elapsed: 0.007 sec [junit] Running org.apache.struts.action.TestActionServlet Missing type value for noTypeForm form bean Missing type value for name form property Unable to create an instance of org.apache.struts.action.TestActionServlet$CustomFormBeanConfigArg java.lang.InstantiationException: org.apache.struts.action.TestActionServlet$CustomFormBeanConfigArg at java.lang.Class.newInstance0(Class.java:293) at java.lang.Class.newInstance(Class.java:261) at org.apache.struts.util.RequestUtils.applicationInstance (RequestUtils.java:163) at org.apache.struts.util.RequestUtils.applicationInstance (RequestUtils.java:138) at org.apache.struts.action.ActionServlet.processFormBeanConfigClass (ActionServlet.java:1021) at org.apache.struts.action.TestActionServlet.testProcessFormBeanConfigCl assError(TestActionServlet.java:443) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:39)
Re: Action 1 consolidation testing (was Towards a stable 1.3 release)
James Mitchell wrote: Funny you should mention this now. About 10 minutes ago I (locally) commented the failing tests out (actually, I put 'no' in front of the failing testFoo methods, so it looks like 'notestFoo') so I could 'mvn eclipse:eclipse' core, taglib, and extras. I'm not sure why the output of the tests make Maven think that they failed, when, they actually did not and I know it's not an optimal solution, but I'd like to check that in so we can move on with our build. We can work out the kinks later. Weird, so your Maven thinks that the tests fail? The tests pass for me, for the core module anyways. Also, I'm about to start another thread related to our build...it is (more or less) notes as I go through the various project.xml, pom.xml, etc, etc for each of the pieces of the action1 puzzle. Ok, I'll hurry and move scripting into action then. That should be the last action 1-related move. Don -- James Mitchell On Apr 5, 2006, at 4:23 PM, Don Brown wrote: The nightly maven goal isn't working for me. It doesn't seem to be correctly executing the jar:install goal, causing other artifact builds to fail due to missing dependencies. Perhaps someone seems something I'm missing from this snippet from a nightly build: + | Building nightlies Struts Action Framework | Memory: 18M/20M + jar:jar: jar:install: build:end: build:start: dist:build-setup: [delete] Deleting directory /data/brownd/dev/struts/action/core/target/distributions [mkdir] Created dir: /data/brownd/dev/struts/action/core/target/distributions xdoc:init: java:prepare-filesystem: java:compile: [echo] Compiling to /data/brownd/dev/struts/action/core/../core/target/classes java:jar-resources: test:prepare-filesystem: test:test-resources: test:compile: test:test: [junit] Running org.apache.struts.chain.commands.servlet.TestPerformForward exception: The path of an ForwardConfig cannot be null [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.183 sec [junit] Running org.apache.struts.chain.commands.servlet.TestSetOriginalURI [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.139 sec [junit] Running org.apache.struts.chain.commands.servlet.TestAuthorizeAction [junit] Tests run: 5, Failures: 0, Errors: 0, Time elapsed: 0.191 sec [junit] Running org.apache.struts.chain.commands.generic.TestWrappingLookupCommand [junit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 0.38 sec [junit] Running org.apache.struts.chain.commands.generic.TestCopyFormToContext [junit] Tests run: 6, Failures: 0, Errors: 0, Time elapsed: 0.217 sec [junit] Running org.apache.struts.config.TestActionConfigMatcher [junit] Tests run: 6, Failures: 0, Errors: 0, Time elapsed: 0.244 sec [junit] Running org.apache.struts.config.TestFormBeanConfig [junit] Tests run: 5, Failures: 0, Errors: 0, Time elapsed: 0.165 sec [junit] Running org.apache.struts.config.TestActionConfig [junit] Tests run: 5, Failures: 0, Errors: 0, Time elapsed: 0.178 sec [junit] Running org.apache.struts.config.TestForwardConfig [junit] Tests run: 15, Failures: 0, Errors: 0, Time elapsed: 0.082 sec [junit] Running org.apache.struts.config.TestModuleConfig [junit] Tests run: 5, Failures: 0, Errors: 0, Time elapsed: 1.185 sec [junit] Running org.apache.struts.config.TestFormPropertyConfig [junit] Tests run: 5, Failures: 0, Errors: 0, Time elapsed: 0.04 sec [junit] Running org.apache.struts.validator.TestValidWhen [junit] Tests run: 6, Failures: 0, Errors: 0, Time elapsed: 0.442 sec [junit] Running org.apache.struts.action.TestDynaActionFormClass [junit] Tests run: 7, Failures: 0, Errors: 0, Time elapsed: 0.106 sec [junit] Running org.apache.struts.action.TestActionRedirect [junit] Tests run: 5, Failures: 0, Errors: 0, Time elapsed: 0.058 sec [junit] Running org.apache.struts.action.TestActionMessage [junit] Tests run: 8, Failures: 0, Errors: 0, Time elapsed: 0.007 sec [junit] Running org.apache.struts.action.TestActionServlet Missing type value for noTypeForm form bean Missing type value for name form property Unable to create an instance of org.apache.struts.action.TestActionServlet$CustomFormBeanConfigArg java.lang.InstantiationException: org.apache.struts.action.TestActionServlet$CustomFormBeanConfigArg at java.lang.Class.newInstance0(Class.java:293) at java.lang.Class.newInstance(Class.java:261) at org.apache.struts.util.RequestUtils.applicationInstance(RequestUtils.java:163) at org.apache.struts.util.RequestUtils.applicationInstance(RequestUtils.java:138) at org.apache.struts.action.ActionServlet.processFormBeanConfigClass(ActionServlet.java:1021) at
svn commit: r391812 - /struts/action/trunk/core/src/test/org/apache/struts/action/TestActionServlet.java
Author: jmitchell
Date: Wed Apr 5 14:15:01 2006
New Revision: 391812
URL: http://svn.apache.org/viewcvs?rev=391812view=rev
Log:
skip these for now, this is easier than -Dmaven.skip.tests
Modified:
struts/action/trunk/core/src/test/org/apache/struts/action/TestActionServlet.java
Modified:
struts/action/trunk/core/src/test/org/apache/struts/action/TestActionServlet.java
URL:
http://svn.apache.org/viewcvs/struts/action/trunk/core/src/test/org/apache/struts/action/TestActionServlet.java?rev=391812r1=391811r2=391812view=diff
==
---
struts/action/trunk/core/src/test/org/apache/struts/action/TestActionServlet.java
(original)
+++
struts/action/trunk/core/src/test/org/apache/struts/action/TestActionServlet.java
Wed Apr 5 14:15:01 2006
@@ -196,7 +196,7 @@
/**
* Test class loader resolution and splitting.
*/
-public void testSplitAndResolvePaths()
+public void notestSplitAndResolvePaths()
throws Exception {
ActionServlet servlet = new ActionServlet();
List list =
@@ -426,7 +426,7 @@
* Make sure the code throws the correct exception when it can't create an
* instance of the base config's custom class.
*/
-public void testProcessFormBeanConfigClassError()
+public void notestProcessFormBeanConfigClassError()
throws Exception {
CustomFormBeanConfigArg customBase =
new CustomFormBeanConfigArg(customBase);
@@ -604,7 +604,7 @@
* Make sure the code throws the correct exception when it can't create an
* instance of the base config's custom class.
*/
-public void testProcessExceptionConfigClassError()
+public void notestProcessExceptionConfigClassError()
throws Exception {
ExceptionConfig customBase =
new CustomExceptionConfigArg(java.lang.NullPointerException);
@@ -778,7 +778,7 @@
* Make sure the code throws the correct exception when it can't create an
* instance of the base config's custom class.
*/
-public void testProcessForwardConfigClassError()
+public void notestProcessForwardConfigClassError()
throws Exception {
ForwardConfig customBase =
new CustomForwardConfigArg(success, /success.jsp);
@@ -927,7 +927,7 @@
* Make sure the code throws the correct exception when it can't create an
* instance of the base config's custom class.
*/
-public void testProcessActionConfigClassError()
+public void notestProcessActionConfigClassError()
throws Exception {
ActionConfig customBase = new CustomActionConfigArg(/index);
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r391814 - in /struts/sandbox/trunk/mailreader-course/action2: lab-1-0-src/src/java/ lab-1-0-src/src/webapp/WEB-INF/ lab-1-0-src/src/webapp/pages/ lab-1-1-src/src/java/ lab-1-1-src/src/test
Author: husted
Date: Wed Apr 5 14:17:54 2006
New Revision: 391814
URL: http://svn.apache.org/viewcvs?rev=391814view=rev
Log:
mailreader-course/action2
* Change Home to Hello
* Move Spring configuration file to classpath
Added:
struts/sandbox/trunk/mailreader-course/action2/lab-1-0-src/src/webapp/pages/Hello.jsp
- copied unchanged from r391796,
struts/sandbox/trunk/mailreader-course/action2/lab-1-0-src/src/webapp/pages/Home.jsp
struts/sandbox/trunk/mailreader-course/action2/lab-1-1-src/src/java/Hello.java
- copied, changed from r391792,
struts/sandbox/trunk/mailreader-course/action2/lab-1-1-src/src/java/Home.java
struts/sandbox/trunk/mailreader-course/action2/lab-1-1-src/src/java/applicationContext.xml
- copied unchanged from r391792,
struts/sandbox/trunk/mailreader-course/action2/lab-1-1-src/src/webapp/WEB-INF/applicationContext.xml
struts/sandbox/trunk/mailreader-course/action2/lab-1-1-src/src/test/HelloTest.java
- copied, changed from r391792,
struts/sandbox/trunk/mailreader-course/action2/lab-1-1-src/src/test/HomeTest.java
struts/sandbox/trunk/mailreader-course/action2/lab-1-1-src/src/webapp/pages/Hello.jsp
- copied, changed from r391792,
struts/sandbox/trunk/mailreader-course/action2/lab-1-1-src/src/webapp/pages/Home.jsp
Removed:
struts/sandbox/trunk/mailreader-course/action2/lab-1-0-src/src/webapp/pages/Home.jsp
struts/sandbox/trunk/mailreader-course/action2/lab-1-1-src/src/java/Home.java
struts/sandbox/trunk/mailreader-course/action2/lab-1-1-src/src/test/HomeTest.java
struts/sandbox/trunk/mailreader-course/action2/lab-1-1-src/src/webapp/WEB-INF/applicationContext.xml
struts/sandbox/trunk/mailreader-course/action2/lab-1-1-src/src/webapp/pages/Home.jsp
Modified:
struts/sandbox/trunk/mailreader-course/action2/lab-1-0-src/src/java/Hello.java
struts/sandbox/trunk/mailreader-course/action2/lab-1-0-src/src/java/xwork.xml
struts/sandbox/trunk/mailreader-course/action2/lab-1-0-src/src/webapp/WEB-INF/web.xml
struts/sandbox/trunk/mailreader-course/action2/lab-1-1-src/src/java/resources.properties
struts/sandbox/trunk/mailreader-course/action2/lab-1-1-src/src/java/xwork.xml
struts/sandbox/trunk/mailreader-course/action2/lab-1-1-src/src/webapp/WEB-INF/web.xml
Modified:
struts/sandbox/trunk/mailreader-course/action2/lab-1-0-src/src/java/Hello.java
URL:
http://svn.apache.org/viewcvs/struts/sandbox/trunk/mailreader-course/action2/lab-1-0-src/src/java/Hello.java?rev=391814r1=391813r2=391814view=diff
==
---
struts/sandbox/trunk/mailreader-course/action2/lab-1-0-src/src/java/Hello.java
(original)
+++
struts/sandbox/trunk/mailreader-course/action2/lab-1-0-src/src/java/Hello.java
Wed Apr 5 14:17:54 2006
@@ -1,7 +1,7 @@
import com.opensymphony.xwork.ActionSupport;
/**
- * codeExample Action class/code
+ * Example Action class
*/
public class Hello extends ActionSupport {
Modified:
struts/sandbox/trunk/mailreader-course/action2/lab-1-0-src/src/java/xwork.xml
URL:
http://svn.apache.org/viewcvs/struts/sandbox/trunk/mailreader-course/action2/lab-1-0-src/src/java/xwork.xml?rev=391814r1=391813r2=391814view=diff
==
---
struts/sandbox/trunk/mailreader-course/action2/lab-1-0-src/src/java/xwork.xml
(original)
+++
struts/sandbox/trunk/mailreader-course/action2/lab-1-0-src/src/java/xwork.xml
Wed Apr 5 14:17:54 2006
@@ -5,10 +5,10 @@
package name=default extends=webwork-default
-default-action-ref name=Home/
+default-action-ref name=Hello/
-action name=Home class=Home
-result/pages/Home.jsp/result
+action name=Hello class=Hello
+result/pages/Hello.jsp/result
/action
!-- Add your actions here --
Modified:
struts/sandbox/trunk/mailreader-course/action2/lab-1-0-src/src/webapp/WEB-INF/web.xml
URL:
http://svn.apache.org/viewcvs/struts/sandbox/trunk/mailreader-course/action2/lab-1-0-src/src/webapp/WEB-INF/web.xml?rev=391814r1=391813r2=391814view=diff
==
---
struts/sandbox/trunk/mailreader-course/action2/lab-1-0-src/src/webapp/WEB-INF/web.xml
(original)
+++
struts/sandbox/trunk/mailreader-course/action2/lab-1-0-src/src/webapp/WEB-INF/web.xml
Wed Apr 5 14:17:54 2006
@@ -4,6 +4,11 @@
display-nameWebWork Application/display-name
+context-param
+param-namecontextConfigLocation/param-name
+param-valueclasspath*:applicationContext*.xml/param-value
+/context-param
+
filter
filter-namewebwork/filter-name
filter-classcom.opensymphony.webwork.dispatcher.FilterDispatcher/filter-class
Copied:
struts/sandbox/trunk/mailreader-course/action2/lab-1-1-src/src/java/Hello.java
(from r391792,
svn commit: r391816 - in /struts/sandbox/trunk/action2: README.txt apps/mailreader/src/java/applicationContext.xml apps/mailreader/src/webapp/WEB-INF/applicationContext.xml apps/mailreader/src/webapp/
Author: husted Date: Wed Apr 5 14:22:35 2006 New Revision: 391816 URL: http://svn.apache.org/viewcvs?rev=391816view=rev Log: mailreader app * Move Spring configuration file to classpath README.txt * A couple of more suggestions for the cookbook jar. Added: struts/sandbox/trunk/action2/apps/mailreader/src/java/applicationContext.xml - copied unchanged from r391296, struts/sandbox/trunk/action2/apps/mailreader/src/webapp/WEB-INF/applicationContext.xml Removed: struts/sandbox/trunk/action2/apps/mailreader/src/webapp/WEB-INF/applicationContext.xml Modified: struts/sandbox/trunk/action2/README.txt struts/sandbox/trunk/action2/apps/mailreader/src/webapp/WEB-INF/web.xml Modified: struts/sandbox/trunk/action2/README.txt URL: http://svn.apache.org/viewcvs/struts/sandbox/trunk/action2/README.txt?rev=391816r1=391815r2=391816view=diff == --- struts/sandbox/trunk/action2/README.txt (original) +++ struts/sandbox/trunk/action2/README.txt Wed Apr 5 14:22:35 2006 @@ -100,8 +100,11 @@ * Setting form type to POST ** (Should POST be the default?) -* Proxy Result -** http://forums.opensymphony.com/thread.jspa?threadID=23621tstart=0 +* Switching to SSL after login +** http://forums.opensymphony.com/thread.jspa?messageID=11452#11452 + +* Customizing pages for multiple installations across multiple releases +** http://forums.opensymphony.com/thread.jspa?messageID=23991#23991 @@ -125,6 +128,10 @@ * Default package names ** Allow a default package name to be set for Action classes so that .MyAction could resolve to org.mycorp.myapp.mypackage.MyAction + +* Proxy Result +** http://forums.opensymphony.com/thread.jspa?threadID=23621tstart=0 + Modified: struts/sandbox/trunk/action2/apps/mailreader/src/webapp/WEB-INF/web.xml URL: http://svn.apache.org/viewcvs/struts/sandbox/trunk/action2/apps/mailreader/src/webapp/WEB-INF/web.xml?rev=391816r1=391815r2=391816view=diff == --- struts/sandbox/trunk/action2/apps/mailreader/src/webapp/WEB-INF/web.xml (original) +++ struts/sandbox/trunk/action2/apps/mailreader/src/webapp/WEB-INF/web.xml Wed Apr 5 14:22:35 2006 @@ -4,6 +4,11 @@ display-nameAction2 Mailreader/display-name +context-param +param-namecontextConfigLocation/param-name +param-valueclasspath*:applicationContext*.xml/param-value +/context-param + filter filter-nameAction2/filter-name filter-class - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r391822 - /struts/action/trunk/apps/blank/project.xml
Author: jmitchell
Date: Wed Apr 5 14:42:08 2006
New Revision: 391822
URL: http://svn.apache.org/viewcvs?rev=391822view=rev
Log:
bring blank/project.xml inline with other apps
Modified:
struts/action/trunk/apps/blank/project.xml
Modified: struts/action/trunk/apps/blank/project.xml
URL:
http://svn.apache.org/viewcvs/struts/action/trunk/apps/blank/project.xml?rev=391822r1=391821r2=391822view=diff
==
--- struts/action/trunk/apps/blank/project.xml (original)
+++ struts/action/trunk/apps/blank/project.xml Wed Apr 5 14:42:08 2006
@@ -2,7 +2,7 @@
project
extend${basedir}/../project.xml/extend
- idstruts-blank/id
+ artifactIdstruts-blank/artifactId
nameStruts blank web application/name
packageorg.apache.struts.webapp.blank.*/package
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r391847 - in /struts/sandbox/trunk/mailreader-course/action2: lab-1-2-src/ mailreader-course-action2.ipr
Author: husted Date: Wed Apr 5 16:47:38 2006 New Revision: 391847 URL: http://svn.apache.org/viewcvs?rev=391847view=rev Log: mailreader app * Add lab 1-2. Added: struts/sandbox/trunk/mailreader-course/action2/lab-1-2-src/ - copied from r391821, struts/sandbox/trunk/mailreader-course/action2/lab-1-1-src/ Modified: struts/sandbox/trunk/mailreader-course/action2/mailreader-course-action2.ipr Modified: struts/sandbox/trunk/mailreader-course/action2/mailreader-course-action2.ipr URL: http://svn.apache.org/viewcvs/struts/sandbox/trunk/mailreader-course/action2/mailreader-course-action2.ipr?rev=391847r1=391846r2=391847view=diff == --- struts/sandbox/trunk/mailreader-course/action2/mailreader-course-action2.ipr (original) +++ struts/sandbox/trunk/mailreader-course/action2/mailreader-course-action2.ipr Wed Apr 5 16:47:38 2006 @@ -180,6 +180,7 @@ modules module fileurl=file://$PROJECT_DIR$/lab-1-0-src/lab-1-0-src.iml filepath=$PROJECT_DIR$/lab-1-0-src/lab-1-0-src.iml / module fileurl=file://$PROJECT_DIR$/lab-1-1-src/lab-1-1-src.iml filepath=$PROJECT_DIR$/lab-1-1-src/lab-1-1-src.iml / + module fileurl=file://$PROJECT_DIR$/lab-1-2-src/lab-1-2-src.iml filepath=$PROJECT_DIR$/lab-1-2-src/lab-1-2-src.iml / module fileurl=file://$PROJECT_DIR$/mailreader-course-action2.iml filepath=$PROJECT_DIR$/mailreader-course-action2.iml / /modules /component - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r391850 - in /struts/sandbox/trunk/mailreader-course/action2/lab-1-2-src: lab-1-1-src.iml lab-1-2-src.iml src/test/RetainTest.java src/webapp/pages/Missing.jsp src/webapp/pages/Welcome.jsp
Author: husted Date: Wed Apr 5 16:50:33 2006 New Revision: 391850 URL: http://svn.apache.org/viewcvs?rev=391850view=rev Log: (empty) Added: struts/sandbox/trunk/mailreader-course/action2/lab-1-2-src/lab-1-2-src.iml struts/sandbox/trunk/mailreader-course/action2/lab-1-2-src/src/test/RetainTest.java (with props) struts/sandbox/trunk/mailreader-course/action2/lab-1-2-src/src/webapp/pages/Missing.jsp (with props) struts/sandbox/trunk/mailreader-course/action2/lab-1-2-src/src/webapp/pages/Welcome.jsp (with props) Removed: struts/sandbox/trunk/mailreader-course/action2/lab-1-2-src/lab-1-1-src.iml Added: struts/sandbox/trunk/mailreader-course/action2/lab-1-2-src/lab-1-2-src.iml URL: http://svn.apache.org/viewcvs/struts/sandbox/trunk/mailreader-course/action2/lab-1-2-src/lab-1-2-src.iml?rev=391850view=auto == --- struts/sandbox/trunk/mailreader-course/action2/lab-1-2-src/lab-1-2-src.iml (added) +++ struts/sandbox/trunk/mailreader-course/action2/lab-1-2-src/lab-1-2-src.iml Wed Apr 5 16:50:33 2006 @@ -0,0 +1,262 @@ +?xml version=1.0 encoding=UTF-8? +module version=4 relativePaths=true type=J2EE_WEB_MODULE j2ee-integration=Tomcat Server + component name=ModuleRootManager / + component name=NewModuleRootManager +output url=file://C:/opt/Apache/Tomcat-5.0/webapps/lab-1-2-src/WEB-INF/classes / +exclude-output / +exploded url=file://C:/opt/Apache/Tomcat-5.0/webapps/lab-1-2-src / +exclude-exploded / +content url=file://$MODULE_DIR$ + sourceFolder url=file://$MODULE_DIR$/src/java isTestSource=false / + sourceFolder url=file://$MODULE_DIR$/src/test isTestSource=true / +/content +orderEntry type=inheritedJdk / +orderEntry type=sourceFolder forTests=false / +orderEntry type=library name=Tomcat level=application_server_libraries / +orderEntry type=module-library + library +CLASSES + root url=jar://$MODULE_DIR$/../../lib/oscore.jar!/ / +/CLASSES +JAVADOC / +SOURCES / + /library +/orderEntry +orderEntry type=module-library + library +CLASSES + root url=jar://$MODULE_DIR$/../../lib/commons-collections-3.1.jar!/ / +/CLASSES +JAVADOC / +SOURCES / + /library +/orderEntry +orderEntry type=module-library + library +CLASSES + root url=jar://$MODULE_DIR$/../../lib/struts-mailreader-dao-1.3.0-dev.jar!/ / +/CLASSES +JAVADOC / +SOURCES / + /library +/orderEntry +orderEntry type=module-library + library +CLASSES + root url=jar://$MODULE_DIR$/../../lib/webwork-2.2.2.jar!/ / +/CLASSES +JAVADOC / +SOURCES / + /library +/orderEntry +orderEntry type=module-library + library +CLASSES + root url=jar://$MODULE_DIR$/../../lib/spring-core.jar!/ / +/CLASSES +JAVADOC / +SOURCES / + /library +/orderEntry +orderEntry type=module-library + library +CLASSES + root url=jar://$MODULE_DIR$/../../lib/ognl.jar!/ / +/CLASSES +JAVADOC / +SOURCES / + /library +/orderEntry +orderEntry type=module-library + library +CLASSES + root url=jar://$MODULE_DIR$/../../lib/spring-context.jar!/ / +/CLASSES +JAVADOC / +SOURCES / + /library +/orderEntry +orderEntry type=module-library + library +CLASSES + root url=jar://$MODULE_DIR$/../../lib/commons-logging-1.0.4.jar!/ / +/CLASSES +JAVADOC / +SOURCES / + /library +/orderEntry +orderEntry type=module-library + library +CLASSES + root url=jar://$MODULE_DIR$/../../lib/freemarker.jar!/ / +/CLASSES +JAVADOC / +SOURCES / + /library +/orderEntry +orderEntry type=module-library + library +CLASSES + root url=jar://$MODULE_DIR$/../../lib/struts-taglib-1.3.0.jar!/ / +/CLASSES +JAVADOC / +SOURCES / + /library +/orderEntry +orderEntry type=module-library + library +CLASSES + root url=jar://$MODULE_DIR$/../../lib/rife-continuations.jar!/ / +/CLASSES +JAVADOC / +SOURCES / + /library +/orderEntry +orderEntry type=module-library + library +CLASSES + root url=jar://$MODULE_DIR$/../../lib/commons-digester-1.6.jar!/ / +/CLASSES +JAVADOC / +SOURCES / + /library +/orderEntry +orderEntry type=module-library + library +CLASSES + root url=jar://$MODULE_DIR$/../../lib/spring-beans.jar!/ / +/CLASSES +JAVADOC / +SOURCES / + /library +/orderEntry +orderEntry type=module-library + library +CLASSES + root
svn commit: r391853 - in /struts/sandbox/trunk/mailreader-course/action2/lab-1-1-src/src/webapp/pages: Missing.jsp Welcome.jsp
Author: husted Date: Wed Apr 5 16:51:30 2006 New Revision: 391853 URL: http://svn.apache.org/viewcvs?rev=391853view=rev Log: mailreader app * Add lab 1-1. Added: struts/sandbox/trunk/mailreader-course/action2/lab-1-1-src/src/webapp/pages/Missing.jsp (with props) struts/sandbox/trunk/mailreader-course/action2/lab-1-1-src/src/webapp/pages/Welcome.jsp (with props) Added: struts/sandbox/trunk/mailreader-course/action2/lab-1-1-src/src/webapp/pages/Missing.jsp URL: http://svn.apache.org/viewcvs/struts/sandbox/trunk/mailreader-course/action2/lab-1-1-src/src/webapp/pages/Missing.jsp?rev=391853view=auto == --- struts/sandbox/trunk/mailreader-course/action2/lab-1-1-src/src/webapp/pages/Missing.jsp (added) +++ struts/sandbox/trunk/mailreader-course/action2/lab-1-1-src/src/webapp/pages/Missing.jsp Wed Apr 5 16:51:30 2006 @@ -0,0 +1,10 @@ +html +headtitleMissing Feature/title/head + +body +p +This feature is under construction. +Please try again in the next interation. +/p +/body +/html Propchange: struts/sandbox/trunk/mailreader-course/action2/lab-1-1-src/src/webapp/pages/Missing.jsp -- svn:eol-style = native Added: struts/sandbox/trunk/mailreader-course/action2/lab-1-1-src/src/webapp/pages/Welcome.jsp URL: http://svn.apache.org/viewcvs/struts/sandbox/trunk/mailreader-course/action2/lab-1-1-src/src/webapp/pages/Welcome.jsp?rev=391853view=auto == --- struts/sandbox/trunk/mailreader-course/action2/lab-1-1-src/src/webapp/pages/Welcome.jsp (added) +++ struts/sandbox/trunk/mailreader-course/action2/lab-1-1-src/src/webapp/pages/Welcome.jsp Wed Apr 5 16:51:30 2006 @@ -0,0 +1,24 @@ +%@ taglib uri=/webwork prefix=ww % +html +head +titleMailReader Application/title +/head + +body +h3MailReader Options/h3 + +ul +lia href=ww:url action=Missing/Register with the MailReader/a/li +lia href=ww:url action=Missing/Log on to the MailReader/a/li +/ul + +h3Language Options/h3 +ul +lia href=ww:url action=Missing/English/a/li +lia href=ww:url action=Missing/Japanese/a/li +lia href=ww:url action=Missing/Russian/a/li +/ul + +/body +/html + Propchange: struts/sandbox/trunk/mailreader-course/action2/lab-1-1-src/src/webapp/pages/Welcome.jsp -- svn:eol-style = native - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Action 1 consolidation testing (was Towards a stable 1.3 release)
On 4/5/06, Don Brown [EMAIL PROTECTED] wrote: Weird, so your Maven thinks that the tests fail? The tests pass for me, for the core module anyways. The tests don't fail for me, either. They're just noisy with stack traces. Don, 'maven nightly' continues to work fine here. I deleted org.apache.struts.action and org.apache.struts.tiles from my local m1 repo to make sure it was really building and/or retrieving everything. I put up a list of all my installed plugins. You might want to compare versions and consider upgrading if you're using older versions of any of them. http://wiki.wsmoak.net/cgi-bin/wiki.pl?StrutsBuild Does running maven with -X on the command line show anything interesting? -- Wendy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Action 1 consolidation testing (was Towards a stable 1.3 release)
On 4/5/06, James Mitchell [EMAIL PROTECTED] wrote: Also, I'm about to start another thread related to our build...it is (more or less) notes as I go through the various project.xml, pom.xml, etc, etc for each of the pieces of the action1 puzzle. What do you think about moving the build files (project.xml, maven.xml, etc.,) up to the 'struts/current/action' level? That would be closer to Maven's default project structure. -- Wendy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Action 1 consolidation testing (was Towards a stable 1.3 release)
Before my changes, they fail for me on maven 1, when instrumented for jcoverage (which is the case for the 'dist' target) and maven 2 when run normally (mvn install). Maven 1 --- ... ... [junit] Running org.apache.struts.action.TestActionRedirect [junit] Tests run: 5, Failures: 0, Errors: 0, Time elapsed: 0.033 sec [junit] Running org.apache.struts.action.TestActionMessage [junit] Tests run: 8, Failures: 0, Errors: 0, Time elapsed: 0.004 sec [junit] Running org.apache.struts.action.TestActionServlet Missing type value for noTypeForm form bean Missing type value for name form property Unable to create an instance of org.apache.struts.action.TestActionServlet$CustomFormBeanConfigArg java.lang.InstantiationException: org.apache.struts.action.TestActionServlet$CustomFormBeanConfigArg at java.lang.Class.newInstance0(Class.java:293) at java.lang.Class.newInstance(Class.java:261) at org.apache.struts.util.RequestUtils.applicationInstance (RequestUtils.java:163) at org.apache.struts.util.RequestUtils.applicationInstance (RequestUtils.java:138) at org.apache.struts.action.ActionServlet.processFormBeanConfigClass (ActionServlet.java:1021) at org.apache.struts.action.TestActionServlet.testProcessFormBeanConfigClas sError(TestActionServlet.java:443) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) (noise) [junit] Tests run: 34, Failures: 0, Errors: 0, Time elapsed: 0.308 sec ... ... Passes ok, however it fails when running the tests for the jcoverage reports. Maven 2 --- ... ... [surefire] Running org.apache.struts.action.TestActionMessages [surefire] Tests run: 8, Failures: 0, Errors: 0, Time elapsed: 0.012 sec [surefire] Running org.apache.struts.action.TestActionRedirect [surefire] Tests run: 5, Failures: 0, Errors: 0, Time elapsed: 0.022 sec [surefire] Running org.apache.struts.action.TestActionServlet Apr 5, 2006 3:38:51 PM org.apache.struts.action.ActionServlet handleValueRequiredException SEVERE: Missing type value for noTypeForm form bean Apr 5, 2006 3:38:51 PM org.apache.struts.action.ActionServlet handleValueRequiredException SEVERE: Missing type value for name form property Apr 5, 2006 3:38:51 PM org.apache.struts.action.ActionServlet handleCreationException SEVERE: Unable to create an instance of org.apache.struts.action.TestActionServlet$CustomFormBeanConfigArg java.lang.InstantiationException: org.apache.struts.action.TestActionServlet$CustomFormBeanConfigArg at java.lang.Class.newInstance0(Class.java:293) at java.lang.Class.newInstance(Class.java:261) at org.apache.struts.util.RequestUtils.applicationInstance (RequestUtils.java:163) at org.apache.struts.util.RequestUtils.applicationInstance (RequestUtils.java:138) at org.apache.struts.action.ActionServlet.processFormBeanConfigClass (ActionServlet.java:1022) at org.apache.struts.action.TestActionServlet.testProcessFormBeanConfigClas sError(TestActionServlet.java:443) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ... (more noise) ... at org.codehaus.classworlds.Launcher.launch(Launcher.java:255) at org.codehaus.classworlds.Launcher.mainWithExitCode (Launcher.java:430) at org.codehaus.classworlds.Launcher.main(Launcher.java:375) [surefire] Tests run: 34, Failures: 1, Errors: 0, Time elapsed: 0.224 sec FAILURE !! [surefire] Running org.apache.struts.action.TestDynaActionForm [surefire] Tests run: 46, Failures: 0, Errors: 0, Time elapsed: 0.08 sec [surefire] Running org.apache.struts.action.TestDynaActionFormClass [surefire] Tests run: 7, Failures: 0, Errors: 0, Time elapsed: 0.009 sec Notice the console outputs FAILURE !!, which make it pretty easy to spot ;) Not to sound too negative, but if I have to bust out the diff command on a list of my maven plugin versions to find why it fails for me and not for other people, that's the tipping point for me to rip out Maven and stick in Ivy. Your thoughts? -- James Mitchell On Apr 5, 2006, at 9:04 PM, Wendy Smoak wrote: On 4/5/06, Don Brown [EMAIL PROTECTED] wrote: Weird, so your Maven thinks that the tests fail? The tests pass for me, for the core module anyways. The tests don't fail for me, either. They're just noisy with stack traces. Don, 'maven nightly' continues to work fine here. I deleted org.apache.struts.action and org.apache.struts.tiles from my local m1 repo to make sure it was really building and/or retrieving everything. I put up a list of all my installed plugins. You might want to compare versions and consider upgrading if you're using older versions of any of them. http://wiki.wsmoak.net/cgi-bin/wiki.pl?StrutsBuild Does running maven with -X on the command line show anything interesting? -- Wendy - To unsubscribe, e-mail: [EMAIL
svn commit: r391880 - /struts/action/trunk/build/README
Author: jmitchell Date: Wed Apr 5 19:39:45 2006 New Revision: 391880 URL: http://svn.apache.org/viewcvs?rev=391880view=rev Log: Bring README up to date wrt SAF Modified: struts/action/trunk/build/README Modified: struts/action/trunk/build/README URL: http://svn.apache.org/viewcvs/struts/action/trunk/build/README?rev=391880r1=391879r2=391880view=diff == --- struts/action/trunk/build/README (original) +++ struts/action/trunk/build/README Wed Apr 5 19:39:45 2006 @@ -3,17 +3,8 @@ Struts Build -This subproject provides common build components for use across multiple Struts -subprojects. While it is a subproject in and of itself, it is better thought of -as a shared directory linked into each individual subproject. - -IMPORTANT: -If you are reading this in the 'build' directory of another subproject, what -you are seeing is a window into the build subproject. All of the files in -this directory are actually maintained in the common build subproject, and so -any changes made here will be made for *all* subprojects. - - +This folder provides common build components for use in building the +Struts Action Framework. STRUTS == @@ -32,5 +23,8 @@ that have HTML forms which interact with JavaBeans that are managed automatically by the controller servlet. -For help with installing and using Struts, see the Struts User Guide. +For help with installing and using Struts, see the Struts Action Framework +User Guide at the following URL: + + http://struts.apache.org/struts-action/index.html - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r391884 - in /struts/shale/trunk/core-library/src: conf/ java/org/apache/shale/component/ java/org/apache/shale/faces/ java/org/apache/shale/renderer/ java/org/apache/shale/view/faces/
Author: gvanmatre
Date: Wed Apr 5 19:46:34 2006
New Revision: 391884
URL: http://svn.apache.org/viewcvs?rev=391884view=rev
Log:
Fix for bugs 37932, 39171 and 39156 reported by Mark Shifman and Paul Devine.
Added:
struts/shale/trunk/core-library/src/java/org/apache/shale/faces/ValidatorRenderKit.java
(with props)
struts/shale/trunk/core-library/src/java/org/apache/shale/renderer/ValidatorCommandRenderer.java
(with props)
struts/shale/trunk/core-library/src/java/org/apache/shale/renderer/ValidatorInputRenderer.java
(with props)
Modified:
struts/shale/trunk/core-library/src/conf/validator-rules.xml
struts/shale/trunk/core-library/src/java/org/apache/shale/component/ValidatorScript.java
struts/shale/trunk/core-library/src/java/org/apache/shale/view/faces/ViewViewHandler.java
Modified: struts/shale/trunk/core-library/src/conf/validator-rules.xml
URL:
http://svn.apache.org/viewcvs/struts/shale/trunk/core-library/src/conf/validator-rules.xml?rev=391884r1=391883r2=391884view=diff
==
--- struts/shale/trunk/core-library/src/conf/validator-rules.xml (original)
+++ struts/shale/trunk/core-library/src/conf/validator-rules.xml Wed Apr 5
19:46:34 2006
@@ -419,7 +419,7 @@
validator name=float
classname=org.apache.commons.validator.GenericValidator
method=isDouble
- methodParams=double
+ methodParams=java.lang.String
depends=
msg=errors.float
jsFunctionName=FloatValidations
Modified:
struts/shale/trunk/core-library/src/java/org/apache/shale/component/ValidatorScript.java
URL:
http://svn.apache.org/viewcvs/struts/shale/trunk/core-library/src/java/org/apache/shale/component/ValidatorScript.java?rev=391884r1=391883r2=391884view=diff
==
---
struts/shale/trunk/core-library/src/java/org/apache/shale/component/ValidatorScript.java
(original)
+++
struts/shale/trunk/core-library/src/java/org/apache/shale/component/ValidatorScript.java
Wed Apr 5 19:46:34 2006
@@ -21,6 +21,7 @@
import java.util.LinkedHashMap;
import java.util.List;
import java.util.Map;
+import java.util.Set;
import java.util.StringTokenizer;
import javax.faces.component.EditableValueHolder;
@@ -31,6 +32,7 @@
import javax.faces.el.ValueBinding;
import org.apache.commons.validator.ValidatorAction;
+import org.apache.shale.renderer.ValidatorInputRenderer;
import org.apache.shale.validator.CommonsValidator;
/**
@@ -147,11 +149,11 @@
/**
* pRecursively finds all Commons validators for the all of the
- *components in a component hierarchy and adds them to a map.
+ *components in a component hierarchy and adds them to a map./p
* pIf a validator's type is required, this method sets the
*associated component's required property to true. This is
*necessary because JSF does not validate empty fields unless
- *a component's required property is true.
+ *a component's required property is true./p
*
* @param c The component at the root of the component tree
* @param context The FacesContext for this request
@@ -164,16 +166,39 @@
if (vs[i] instanceof CommonsValidator) {
CommonsValidator v = (CommonsValidator) vs[i];
if (Boolean.TRUE.equals(v.getClient())) {
- String id = c.getClientId(context);
- addValidator(v.getType(), id, v);
-
- ValidatorAction action = v.getValidatorAction();
- List list = action.getDependencyList();
- Iterator iter = list.iterator();
- while (iter.hasNext()) {
- String type = (String) iter.next();
- addValidator(type, id, v);
- }
+
+ //look for the clientId set
+ Set clientIds = (Set)
c.getAttributes().get(ValidatorInputRenderer.VALIDATOR_CLIENTIDS_ATTR);
+ if (clientIds != null) {
+ Iterator ci = clientIds.iterator();
+ while (ci.hasNext()) {
+ String id = (String) ci.next();
+ addValidator(v.getType(), id, v);
+
+ ValidatorAction action = v.getValidatorAction();
+ List list = action.getDependencyList();
+ Iterator iter = list.iterator();
+ while (iter.hasNext()) {
+ String type = (String) iter.next();
+ addValidator(type, id, v);
+ }
+
+ }
+
+ } else {
+
DO NOT REPLY [Bug 39171] - commons validitor throws exception with float and double.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=39171. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=39171 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2006-04-06 03:50 --- A fix for the methodParms is in the 20060406 shale nightly build. The missing rules will be addressed with ticket 39121. http://issues.apache.org/bugzilla/show_bug.cgi?id=39121. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 37932] - [Shale] Commons validator ignores the immediate attribute when using client side validation
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=37932. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=37932 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2006-04-06 03:55 --- The patch applied only addresses common validator related issues. Bug 39171 is related to the solution. If this approach seems to workout, we might think about creating a generic way of registering renderer decorators. The fix will be in the 20060406 nightly build. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 39156] - [Shale] client side commons validation not working inside a dataList
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=39156. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=39156 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2006-04-06 04:00 --- A patch was applied in the 20060406 nightly build. This bug shares implementation strategy with 37932. http://issues.apache.org/bugzilla/show_bug.cgi?id=37932 -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r391889 - in /struts/action/trunk: faces/project.xml taglib/project.xml
Author: jmitchell Date: Wed Apr 5 20:43:35 2006 New Revision: 391889 URL: http://svn.apache.org/viewcvs?rev=391889view=rev Log: artifactId is the preferred tag for identification and groupId/artifactId is the preferred tag for dependencies Modified: struts/action/trunk/faces/project.xml struts/action/trunk/taglib/project.xml Modified: struts/action/trunk/faces/project.xml URL: http://svn.apache.org/viewcvs/struts/action/trunk/faces/project.xml?rev=391889r1=391888r2=391889view=diff == --- struts/action/trunk/faces/project.xml (original) +++ struts/action/trunk/faces/project.xml Wed Apr 5 20:43:35 2006 @@ -20,7 +20,7 @@ extend../build/project.xml/extend - idstruts-faces/id + artifactIdstruts-faces/artifactId nameStruts JSF Integration Library/name currentVersion1.0/currentVersion Modified: struts/action/trunk/taglib/project.xml URL: http://svn.apache.org/viewcvs/struts/action/trunk/taglib/project.xml?rev=391889r1=391888r2=391889view=diff == --- struts/action/trunk/taglib/project.xml (original) +++ struts/action/trunk/taglib/project.xml Wed Apr 5 20:43:35 2006 @@ -67,7 +67,8 @@ !-- XDoclet dependencies -- dependency - idxdoclet/id + groupIdxdoclet/groupId + artifactIdxdoclet/artifactId version1.2/version properties scopecompile/scope - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r391890 - in /struts/sandbox/trunk: ./ extras/ mailreader-chain/ struts-jericho/ ti/phase2/wars/example/ ti/phase2/wars/samples-jsf/ tiles-documentation/ tiles/tiles-documentation/
Author: jmitchell Date: Wed Apr 5 20:45:03 2006 New Revision: 391890 URL: http://svn.apache.org/viewcvs?rev=391890view=rev Log: artifactId is the preferred tag for identification and groupId/artifactId is the preferred tag for dependencies Modified: struts/sandbox/trunk/extras/project.xml struts/sandbox/trunk/mailreader-chain/project.xml struts/sandbox/trunk/project.xml struts/sandbox/trunk/struts-jericho/project.xml struts/sandbox/trunk/ti/phase2/wars/example/project.xml struts/sandbox/trunk/ti/phase2/wars/samples-jsf/project.xml struts/sandbox/trunk/tiles-documentation/project.xml struts/sandbox/trunk/tiles/tiles-documentation/project.xml Modified: struts/sandbox/trunk/extras/project.xml URL: http://svn.apache.org/viewcvs/struts/sandbox/trunk/extras/project.xml?rev=391890r1=391889r2=391890view=diff == --- struts/sandbox/trunk/extras/project.xml (original) +++ struts/sandbox/trunk/extras/project.xml Wed Apr 5 20:45:03 2006 @@ -20,7 +20,7 @@ extend../project.xml/extend - idstruts-resources-plugin/id + artifactIdstruts-resources-plugin/artifactId nameStruts Resources Plugin/name Modified: struts/sandbox/trunk/mailreader-chain/project.xml URL: http://svn.apache.org/viewcvs/struts/sandbox/trunk/mailreader-chain/project.xml?rev=391890r1=391889r2=391890view=diff == --- struts/sandbox/trunk/mailreader-chain/project.xml (original) +++ struts/sandbox/trunk/mailreader-chain/project.xml Wed Apr 5 20:45:03 2006 @@ -1,6 +1,6 @@ ?xml version=1.0 encoding=iso-8859-1? project - idmailreader/id + artifactIdmailreader/artifactId nameStruts MailReader for Commons Chain/name packageorg.apache.*/package descriptionA new implementation of the classic Struts MailReader example using Commons Chain as a business facade./description Modified: struts/sandbox/trunk/project.xml URL: http://svn.apache.org/viewcvs/struts/sandbox/trunk/project.xml?rev=391890r1=391889r2=391890view=diff == --- struts/sandbox/trunk/project.xml (original) +++ struts/sandbox/trunk/project.xml Wed Apr 5 20:45:03 2006 @@ -20,7 +20,7 @@ extendbuild/project.xml/extend - idstruts-sandbox/id + artifactIdstruts-sandbox/artifactId nameStruts Sandbox/name packageorg.apache.struts/package @@ -34,7 +34,8 @@ dependencies dependency -idxml-apis/id +groupIdxml-apis/groupId +artifactIdxml-apis/artifactId version2.0.2/version urlhttp://xml.apache.org/commons//url properties Modified: struts/sandbox/trunk/struts-jericho/project.xml URL: http://svn.apache.org/viewcvs/struts/sandbox/trunk/struts-jericho/project.xml?rev=391890r1=391889r2=391890view=diff == --- struts/sandbox/trunk/struts-jericho/project.xml (original) +++ struts/sandbox/trunk/struts-jericho/project.xml Wed Apr 5 20:45:03 2006 @@ -3,7 +3,7 @@ project extend../project.xml/extend nameJericho/name - idstruts-jericho/id + artifactIdstruts-jericho/artifactId currentVersion0.1-dev/currentVersion inceptionYear2003/inceptionYear shortDescriptionStruts Jericho 2.x Whiteboard/shortDescription Modified: struts/sandbox/trunk/ti/phase2/wars/example/project.xml URL: http://svn.apache.org/viewcvs/struts/sandbox/trunk/ti/phase2/wars/example/project.xml?rev=391890r1=391889r2=391890view=diff == --- struts/sandbox/trunk/ti/phase2/wars/example/project.xml (original) +++ struts/sandbox/trunk/ti/phase2/wars/example/project.xml Wed Apr 5 20:45:03 2006 @@ -21,7 +21,7 @@ project extend../../project.xml/extend - idstruts-ti-example/id + artifactIdstruts-ti-example/artifactId nameStruts Ti Example/name /project Modified: struts/sandbox/trunk/ti/phase2/wars/samples-jsf/project.xml URL: http://svn.apache.org/viewcvs/struts/sandbox/trunk/ti/phase2/wars/samples-jsf/project.xml?rev=391890r1=391889r2=391890view=diff == --- struts/sandbox/trunk/ti/phase2/wars/samples-jsf/project.xml (original) +++ struts/sandbox/trunk/ti/phase2/wars/samples-jsf/project.xml Wed Apr 5 20:45:03 2006 @@ -67,7 +67,8 @@ /properties /dependency dependency - idjstl/id + groupIdjstl/groupId + artifactIdjstl/artifactId version1.1.2/version properties war.bundletrue/war.bundle Modified: struts/sandbox/trunk/tiles-documentation/project.xml URL: http://svn.apache.org/viewcvs/struts/sandbox/trunk/tiles-documentation/project.xml?rev=391890r1=391889r2=391890view=diff == ---
svn commit: r391892 - in /struts/shale/trunk/build: core-library/project.xml spring/project.xml tiles/project.xml
Author: jmitchell Date: Wed Apr 5 20:47:12 2006 New Revision: 391892 URL: http://svn.apache.org/viewcvs?rev=391892view=rev Log: artifactId is the preferred tag for identification and groupId/artifactId is the preferred tag for dependencies Modified: struts/shale/trunk/build/core-library/project.xml struts/shale/trunk/build/spring/project.xml struts/shale/trunk/build/tiles/project.xml Modified: struts/shale/trunk/build/core-library/project.xml URL: http://svn.apache.org/viewcvs/struts/shale/trunk/build/core-library/project.xml?rev=391892r1=391891r2=391892view=diff == --- struts/shale/trunk/build/core-library/project.xml (original) +++ struts/shale/trunk/build/core-library/project.xml Wed Apr 5 20:47:12 2006 @@ -20,7 +20,7 @@ project extend../project.xml/extend - idshale-core/id + artifactIdshale-core/artifactId nameShale Core Library/name siteAddresspeople.apache.org/siteAddress Modified: struts/shale/trunk/build/spring/project.xml URL: http://svn.apache.org/viewcvs/struts/shale/trunk/build/spring/project.xml?rev=391892r1=391891r2=391892view=diff == --- struts/shale/trunk/build/spring/project.xml (original) +++ struts/shale/trunk/build/spring/project.xml Wed Apr 5 20:47:12 2006 @@ -20,7 +20,7 @@ project extend../project.xml/extend - idshale-spring/id + artifactIdshale-spring/artifactId nameShale Spring Integration/name siteAddresspeople.apache.org/siteAddress Modified: struts/shale/trunk/build/tiles/project.xml URL: http://svn.apache.org/viewcvs/struts/shale/trunk/build/tiles/project.xml?rev=391892r1=391891r2=391892view=diff == --- struts/shale/trunk/build/tiles/project.xml (original) +++ struts/shale/trunk/build/tiles/project.xml Wed Apr 5 20:47:12 2006 @@ -20,7 +20,7 @@ project extend../project.xml/extend - idshale-tiles/id + artifactIdshale-tiles/artifactId nameShale Tiles Integration/name !-- Gump integration -- - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Action 1 consolidation testing (was Towards a stable 1.3 release)
On 4/5/06, James Mitchell [EMAIL PROTECTED] wrote: Notice the console outputs FAILURE !!, which make it pretty easy to spot ;) I notice it, I'm just not seeing it here. FWIW, I'm using a snapshot of Maven 2.0.4 and quite a few plugins built from source. Maven 2 is still a work in progress... I'm enjoying the journey, but there's a reason I haven't proposed moving Struts to m2. :) Not to sound too negative, but if I have to bust out the diff command on a list of my maven plugin versions to find why it fails for me and not for other people, that's the tipping point for me to rip out Maven and stick in Ivy. Your thoughts? I wouldn't mind seeing the end of Maven 1 and Jelly. As long as some build tool can build something that we can call a release, it doesn't really matter to me what it is. -- Wendy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
validator issues
Hi All, I am using struts 1.2.7 and related Apache commons validator with validation.xml(whose rules are defined by validator-rules.xml) I need your insight of following issues 1.How do I validate open set data range,e,g (1,10) where 1 and 10 are exclusive, current intRange/floatRange valiation only support close set data range validation where bounds are included. 2.I find a limitation of common validator. i.e if I enter +1000 in a field that has integer validation turned on, the common validator will complain about this field is NOT integer something like that. Is this a bug? 3.A more complicated scenario, suppose that I need to validate two fields,say x and y, the data range of y is dependent on x, e.g y must be the range of [x,100], how do I make use of the common validator to do that? I know I can write my customized plugged in validator to do it, but does validator provides a default way to do it? Many thanks in advance! --Victor - Yahoo! Messenger with Voice. Make PC-to-Phone Calls to the US (and 30+ countries) for 2¢/min or less.
Re: Action 1 consolidation testing (was Towards a stable 1.3 release)
That is probably what we would have done if we hadn't had to deal
with the {subproject}/build having to be svn:externals-ized into each
one.
I was pleasantly surprised (after making my changes to the 4 or 5
tests in core) to run 'mvn install' in struts/action/build/ and see
the reactor kick off and fully build/test/install all/some of SAF.
Same for compile, test, and a few other targets.
--
James Mitchell
On Apr 5, 2006, at 9:06 PM, Wendy Smoak wrote:
On 4/5/06, James Mitchell [EMAIL PROTECTED] wrote:
Also, I'm about to start another thread related to our build...it is
(more or less) notes as I go through the various project.xml,
pom.xml, etc, etc for each of the pieces of the action1 puzzle.
What do you think about moving the build files (project.xml,
maven.xml, etc.,) up to the 'struts/current/action' level? That would
be closer to Maven's default project structure.
--
Wendy
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: Action 1 consolidation testing (was Towards a stable 1.3 release)
Why 2.0.4? Building from source?!? Jeez! At least I'm not _that_ bad ;) I'm more inclined to work on a Maven 2 build and just remove whatever is in our way (e.g. failing tests, bad reports due to incomplete plugins, etc) to get to a distributable release. What do you think? -- James Mitchell On Apr 6, 2006, at 12:05 AM, Wendy Smoak wrote: On 4/5/06, James Mitchell [EMAIL PROTECTED] wrote: Notice the console outputs FAILURE !!, which make it pretty easy to spot ;) I notice it, I'm just not seeing it here. FWIW, I'm using a snapshot of Maven 2.0.4 and quite a few plugins built from source. Maven 2 is still a work in progress... I'm enjoying the journey, but there's a reason I haven't proposed moving Struts to m2. :) Not to sound too negative, but if I have to bust out the diff command on a list of my maven plugin versions to find why it fails for me and not for other people, that's the tipping point for me to rip out Maven and stick in Ivy. Your thoughts? I wouldn't mind seeing the end of Maven 1 and Jelly. As long as some build tool can build something that we can call a release, it doesn't really matter to me what it is. -- Wendy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 38374] - Validation always skipped with Globals.CANCEL_KEY
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=38374. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=38374 --- Additional Comments From [EMAIL PROTECTED] 2006-04-06 05:57 --- Rob, you have an interesting point, but requests are cancellable, not forwards. If you no longer want the request to be cancelled, use a redirect per comment #38 to start a new request. Unless you can make a valid case that forwards are cancellable, I'd say the behavior, while problematic for your situation, is semantically correct. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Action 1 consolidation testing (was Towards a stable 1.3 release)
On 4/5/06, James Mitchell [EMAIL PROTECTED] wrote: Why 2.0.4? Building from source?!? Jeez! At least I'm not _that_ bad ;) Because 2.0.3 had some serious regressions, and it was just as easy to grab the 2.0.4 release candidate as to go back to 2.0.2. It's the plugins I'm building from source, though, to get some new features that I wanted. I'm more inclined to work on a Maven 2 build and just remove whatever is in our way (e.g. failing tests, bad reports due to incomplete plugins, etc) to get to a distributable release. What do you think? If this involves adopting most of Maven 2's conventions, and restructuring where necessary, then _absolutely_. I think m2 can handle the Struts build now, (with the possible exception of the Cactus tests,) it's just not something I was ready to take on alone. Just wait until you see 'mvn integration-test' work. :) -- Wendy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Action 1 consolidation testing (was Towards a stable 1.3 release)
On 4/5/06, James Mitchell [EMAIL PROTECTED] wrote: I was pleasantly surprised (after making my changes to the 4 or 5 tests in core) to run 'mvn install' in struts/action/build/ and see the reactor kick off and fully build/test/install all/some of SAF. Same for compile, test, and a few other targets. Just curious... what version of m2 are you using, and have you added -U on the command line to make it update everything? I wonder if you're using an old version of Surefire (the testing plugin). -- Wendy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [Action2] Replacing the OpenSymphony copyright
Don Brown wrote: Don, you do know that there are automated tools in the Apache 'commiters' repository to replace copyrights ? I used 2 different version one in Java and one in Jython. While it's been about 2 years since I looked it's probably still there. -Rob While I don't mind doing the grunt work, I had a question: is there a policy on the use of the $Id line as the first line in the license? Does it require any subversion configuration for it to be replaced properly? TIA, Don - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Action 1 consolidation testing (was Towards a stable 1.3 release)
I'm using a stock download of 2.0.3. Oh how I dream of finding the missing manual for Maven 2 command line options :( -- James Mitchell On Apr 6, 2006, at 1:25 AM, Wendy Smoak wrote: On 4/5/06, James Mitchell [EMAIL PROTECTED] wrote: I was pleasantly surprised (after making my changes to the 4 or 5 tests in core) to run 'mvn install' in struts/action/build/ and see the reactor kick off and fully build/test/install all/some of SAF. Same for compile, test, and a few other targets. Just curious... what version of m2 are you using, and have you added -U on the command line to make it update everything? I wonder if you're using an old version of Surefire (the testing plugin). -- Wendy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 38374] - Validation always skipped with Globals.CANCEL_KEY
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=38374. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=38374 --- Additional Comments From [EMAIL PROTECTED] 2006-04-06 06:41 --- I would but we are stashing an error message in the request in response to the cancel. We could use the Session for messages but then we would need to clean them up. Using the validate = false, would also work in all but one of our use cases. I started working on an adapter/Wrapper, since just removing the attribute doesn't work in Resin . I need to read up on the Servlet Spec concerning this. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
