[GitHub] struts pull request: WW-4634 Centre alignment doesn't seem to work...
Github user aleksandr-m commented on the pull request: https://github.com/apache/struts/pull/95#issuecomment-221976394 Looks fine. Good job. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4634 Centre alignment doesn't seem to work...
Github user victorsosa commented on the pull request: https://github.com/apache/struts/pull/95#issuecomment-221804220 Yes, I am ok --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4634 Centre alignment doesn't seem to work...
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/95#issuecomment-221785224 I assume we're ok with this and this PR can be merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4634 Centre alignment doesn't seem to work...
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/95#issuecomment-221621914 @victorsosa osm! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4634 Centre alignment doesn't seem to work...
Github user victorsosa commented on the pull request: https://github.com/apache/struts/pull/95#issuecomment-221567053 I will fix the 103 test cases, give me some time --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4634 Centre alignment doesn't seem to work...
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/95#issuecomment-221556310 103 tests need to be updated, I think it isn't worth --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4634 Centre alignment doesn't seem to work...
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/95#issuecomment-221556014 Tests are failing :( ``` Error Message expected:<...bel: but was:<...bel: Stacktrace junit.framework.ComparisonFailure: expected:<...bel: but was:<...bel: at junit.framework.Assert.assertEquals(Assert.java:100) at junit.framework.Assert.assertEquals(Assert.java:107) at junit.framework.TestCase.assertEquals(TestCase.java:269) at org.apache.struts2.views.jsp.AbstractUITagTest.verify(AbstractUITagTest.java:246) at org.apache.struts2.views.jsp.ui.LabelTest.testSimple(LabelTest.java:49) ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4634 Centre alignment doesn't seem to work...
Github user cnenning commented on the pull request: https://github.com/apache/struts/pull/95#issuecomment-221490265 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4634 Centre alignment doesn't seem to work...
Github user aleksandr-m commented on the pull request:
https://github.com/apache/struts/pull/95#issuecomment-221326208
@victorsosa IMO it would be great. BUT if we really really want it to be
backward compatible then we can do both. Add a class for future **and** use
align attribute with `class="align-${parameters.align?html}"` like you propose
in this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4634 Centre alignment doesn't seem to work...
Github user victorsosa commented on the pull request:
https://github.com/apache/struts/pull/95#issuecomment-221314653
@aleksandr-m You mean something like in
controlheader.ftl and .tdInput {text-align:left;} in styles.css. <-- This is
for 2.5.
THat means **drop align attribute completely** from S2 tags; So from now on
the only way to set the align to _center_ for example is to overwrite the css
class _tdInput_ in 2.5, right?
I will change to that code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4634 Centre alignment doesn't seem to work...
Github user aleksandr-m commented on the pull request:
https://github.com/apache/struts/pull/95#issuecomment-221056549
I would prefer to follow html5 and drop align attribute completely from S2
tags, BUT @victorsosa can you at least add some css class to input cell along
with your solution.
Something like:
```
if align then class="tdInput align-${parameters.align?html}" else
class="tdInput"
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4634 Centre alignment doesn't seem to work...
Github user victorsosa commented on the pull request: https://github.com/apache/struts/pull/95#issuecomment-220818804 @lukaszlenart ok --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4634 Centre alignment doesn't seem to work...
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/95#issuecomment-220817379 @victorsosa this commit a0b34806b0f700a1fd240b698c4cec474711bbd0 dropped `align` attribute for buttons, it shouldn't affect `textfield` tag. Anyway, I think we should merge this PR and if needed prepare another one to target 2.3 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4634 Centre alignment doesn't seem to work...
Github user aleksandr-m commented on the pull request: https://github.com/apache/struts/pull/95#issuecomment-220795005 @victorsosa You see, this commit already *broke* backward compatibility, but it was incomplete in the way it didn't introduce css class for the input cell. It is 2.5 so some breaking changes are expected. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4634 Centre alignment doesn't seem to work...
Github user victorsosa commented on the pull request: https://github.com/apache/struts/pull/95#issuecomment-220740769 It will break back compatibility as @lukaszlenart said. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4634 Centre alignment doesn't seem to work...
Github user aleksandr-m commented on the pull request:
https://github.com/apache/struts/pull/95#issuecomment-220522532
@victorsosa I mean something like `` in
controlheader.ftl and `.tdInput {text-align:left;}` in styles.css. <-- This is
for 2.5.
And if alignment doesn't work in 2.3 and your solution fixes it, then this
PR should target `support-2-3` branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4634 Centre alignment doesn't seem to work...
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/95#issuecomment-219829308 All the tags are implemented in FreeMarker, those archive templates are deprecated and should be thrown away. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4634 Centre alignment doesn't seem to work...
Github user aleksandr-m commented on the pull request: https://github.com/apache/struts/pull/95#issuecomment-219829978 @lukaszlenart Ahh ok. Thanks for clarifying that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4634 Centre alignment doesn't seem to work...
Github user victorsosa commented on the pull request: https://github.com/apache/struts/pull/95#issuecomment-219826548 the css class for that cell is in the controlheader.ftl already. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4634 Centre alignment doesn't seem to work...
Github user victorsosa commented on the pull request: https://github.com/apache/struts/pull/95#issuecomment-219826190 OH ok, got you https://github.com/apache/struts/tree/master/core/src/main/resources/template/archive I miss that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4634 Centre alignment doesn't seem to work...
Github user aleksandr-m commented on the pull request: https://github.com/apache/struts/pull/95#issuecomment-219824169 Yep, the aforementioned commit misses css class for that cell in the `controlheader.ftl`. It should be the same way as for the buttons. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4634 Centre alignment doesn't seem to work...
Github user aleksandr-m commented on the pull request: https://github.com/apache/struts/pull/95#issuecomment-219823160 How the Velocity templating is working? The only Velocity templates I see are in the [archive](https://github.com/apache/struts/tree/master/core/src/main/resources/template/archive). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4634 Centre alignment doesn't seem to work...
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/95#issuecomment-219820654 So it's not a regression bug ;-) Yes, we do support Velocity. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4634 Centre alignment doesn't seem to work...
Github user victorsosa commented on the pull request: https://github.com/apache/struts/pull/95#issuecomment-219820007 @lukaszlenart the parameter align was remove on this commit https://github.com/victorsosa/struts/commit/a0b34806b0f700a1fd240b698c4cec474711bbd0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4634 Centre alignment doesn't seem to work...
Github user aleksandr-m commented on the pull request: https://github.com/apache/struts/pull/95#issuecomment-219820070 Issue is about Velocity tags, not FreeMarker. Are we still supporting Velocity tags? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4634 Centre alignment doesn't seem to work...
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/95#issuecomment-219817155 I'm just wondering what was the main reason, I have prepared a unit test and it didn't pass when using 2.3.29-SNAPSHOT which means 2.3.28.1 is broken the same way. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4634 Centre alignment doesn't seem to work...
Github user victorsosa commented on the pull request: https://github.com/apache/struts/pull/95#issuecomment-219813310 CSS class to this table cell is what we have now and to have back compatibility as @lukaszlenart said. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4634 Centre alignment doesn't seem to work...
Github user aleksandr-m commented on the pull request: https://github.com/apache/struts/pull/95#issuecomment-219809968 Why not just add some CSS class to this table cell? Then end-users can style it as they want and align parameter will not be needed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4634 Centre alignment doesn't seem to work...
Github user victorsosa commented on the pull request: https://github.com/apache/struts/pull/95#issuecomment-219713305 Another thing I will change the name to just > align-center because this css class can be used in other places that are using the align attribute; which is s Not supported in HTML5. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4634 Centre alignment doesn't seem to work...
Github user victorsosa commented on a diff in the pull request:
https://github.com/apache/struts/pull/95#discussion_r63517163
--- Diff: core/src/main/resources/template/xhtml/controlheader.ftl ---
@@ -21,5 +21,8 @@
*/
-->
<#include
"/${parameters.templateDir}/${parameters.expandTheme}/controlheader-core.ftl" />
-
+class="tdAlign${parameters.align?html}"
--- End diff --
Done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4634 Centre alignment doesn't seem to work...
Github user victorsosa commented on the pull request: https://github.com/apache/struts/pull/95#issuecomment-219709110 Yes, it fix the main issue and keep the back compatibility. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4634 Centre alignment doesn't seem to work...
Github user lukaszlenart commented on a diff in the pull request:
https://github.com/apache/struts/pull/95#discussion_r63516015
--- Diff: core/src/main/resources/template/xhtml/controlheader.ftl ---
@@ -21,5 +21,8 @@
*/
-->
<#include
"/${parameters.templateDir}/${parameters.expandTheme}/controlheader-core.ftl" />
-
+class="tdAlign${parameters.align?html}"
--- End diff --
yes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4634 Centre alignment doesn't seem to work...
Github user victorsosa commented on a diff in the pull request:
https://github.com/apache/struts/pull/95#discussion_r63515782
--- Diff: core/src/main/resources/template/xhtml/controlheader.ftl ---
@@ -21,5 +21,8 @@
*/
-->
<#include
"/${parameters.templateDir}/${parameters.expandTheme}/controlheader-core.ftl" />
-
+class="tdAlign${parameters.align?html}"
--- End diff --
You mean like this class="tdAlign-${parameters.align?html}" ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4634 Centre alignment doesn't seem to work...
Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/95#issuecomment-219706843 This doesn't fix the main issue, right? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4634 Centre alignment doesn't seem to work...
Github user lukaszlenart commented on a diff in the pull request:
https://github.com/apache/struts/pull/95#discussion_r63514815
--- Diff: core/src/main/resources/template/xhtml/controlheader.ftl ---
@@ -21,5 +21,8 @@
*/
-->
<#include
"/${parameters.templateDir}/${parameters.expandTheme}/controlheader-core.ftl" />
-
+class="tdAlign${parameters.align?html}"
--- End diff --
Can you use `-` to separate prefix and suffix?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org
[GitHub] struts pull request: WW-4634 Centre alignment doesn't seem to work...
GitHub user victorsosa opened a pull request: https://github.com/apache/struts/pull/95 WW-4634 Centre alignment doesn't seem to work in Velocity tags Fix for WW-4634 Centre alignment doesn't seem to work in Velocity tags You can merge this pull request into a Git repository by running: $ git pull https://github.com/victorsosa/struts WW-4634 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/struts/pull/95.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #95 commit da8b13a87ef0d6af54a8cabbc62d54fbca67f683 Author: victor sosa Date: 2016-03-03T18:16:11Z Merge pull request #8 from apache/master update pull commit a5d716393999110b3701563479a96e83136a8b97 Author: victor sosa Date: 2016-03-03T18:41:11Z Merge pull request #9 from victorsosa/easymock_update Easymock update commit 6bb1ec67ad539d4bf6850f8314ef521e06b8295e Author: victor sosa Date: 2016-03-04T22:07:16Z Merge pull request #10 from apache/master pull update commit 379b75292e6d084dc881e71f0a826c45934d9df8 Author: victor sosa Date: 2016-03-27T18:43:40Z Merge pull request #11 from apache/master update pull commit 6b360108e57b8986c6409b26cba9b3cd4f16a603 Author: victorsosa Date: 2016-05-17T12:37:13Z WW-4634 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
