DO NOT REPLY [Bug 14471] - [validator] validator-rules.xml JavaScript fails when field not present in jsp

2006-01-09 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=14471


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2006-01-09 09:59 ---
(In reply to comment #19)
Rachel, sorry I don't agree - however you can overcome this by plugging in your 
own custom/modified version of the required validation.

(In reply to comment #15)
Paul, thanks for the patch - I had just fixed the "focus" issue for Bug 21043 - 
unfortunately not seeing this first :-(. Anyway, applied your patch for this 
issue - thanks:

http://svn.apache.org/viewcvs?rev=367249&view=rev

This will be available to test in the next nightly build:

http://cvs.apache.org/builds/jakarta-commons/nightly/commons-validator/

Closing as FIXED 

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 14471] - [validator] validator-rules.xml JavaScript fails when field not present in jsp

2005-08-28 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=14471


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|normal  |enhancement




--- Additional Comments From [EMAIL PROTECTED]  2005-08-29 07:18 ---
Marking as an enhancement as it works as advertised.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 14471] - [validator] validator-rules.xml JavaScript fails when field not present in jsp

2005-08-24 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=14471





--- Additional Comments From [EMAIL PROTECTED]  2005-08-24 14:54 ---
(In reply to comment #15)
> ...Except for the validateRequired method, which by its nature demands that
> absent required fields generate an error response.

Paul,
I disagree with this premise.  You may have a field that is required only for
certain users and is hidden or absent to other users.  To me it seems, the
absence of any field should ignore any validation.  If the field is absolutely
required and is not on the form, then that is the fault of the coder.  The user
will not be able to fix the required error if the field does not exist, so why
give them a validation error for a field that does not exist?

btw, thank you for fixing the other validation routines to ignore absent fields.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 14471] - [validator] validator-rules.xml JavaScript fails when field not present in jsp

2005-08-23 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=14471





--- Additional Comments From [EMAIL PROTECTED]  2005-08-24 06:47 ---
Paul, I'm willing to apply your quick patch.  Could you please make it against
the commons-validator trunk?  Thanks.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 14471] - [validator] validator-rules.xml JavaScript fails when field not present in jsp

2005-08-23 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=14471


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2005-08-24 06:29 ---
*** Bug 34730 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 14471] - [validator] validator-rules.xml JavaScript fails when field not present in jsp

2005-08-14 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=14471


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|NEEDINFO




--- Additional Comments From [EMAIL PROTECTED]  2005-08-14 19:48 ---
Niall, any update on this patch?

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 14471] - [validator] validator-rules.xml JavaScript fails when field not present in jsp

2004-12-09 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=14471


[EMAIL PROTECTED] changed:

   What|Removed |Added

Attachment #3820 is|0   |1
   obsolete||
Attachment #8263 is|0   |1
   obsolete||




--- Additional Comments From [EMAIL PROTECTED]  2004-12-09 22:24 ---
Created an attachment (id=13713)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=13713&action=view)
JS Validation skips fields that are not present.

The attachment contains an update to the javascript methods. There are three
main changes:

1) Absent fields are skipped over. For most methods, this line has been added:
if (!isFieldPresent(field)) {
  continue;
}
...Except for the validateRequired method, which by its nature demands that
absent required fields generate an error response.

2) Focus is not set to fields that are absent, hidden, or disabled:
if(isFieldFocusable(focusField)) {
  focusField.focus();
}

3) Two new methods in validateUtilities: isFieldPresent and isFieldFocusable

These changes are intended to patch this problem in the 1.1.x branch of
Validator. I know Niall (see comment #13) is working on some hefty changes that
solve the problem too, but that may end up in 1.2? I don't know. I am just
looking for a simple fix. Thanks!

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 14471] - [validator] validator-rules.xml JavaScript fails when field not present in jsp

2004-12-03 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=14471


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2004-12-03 17:59 ---
Niall, your proposal looks very good and interesting, but also pretty hefty in
its changes. I am just looking for a small patch compared to the extant that you
are proposing. Do you think I should still continue?

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 14471] - [validator] validator-rules.xml JavaScript fails when field not present in jsp

2004-12-02 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=14471





--- Additional Comments From [EMAIL PROTECTED]  2004-12-03 08:43 ---
I'm currently doing some work on an extension to Commons Validator under Bug 
32343.

If the proposal is accepted then I believe this issue will be resolved. Theres 
a working Example webapp here, if you are interested in taking a look:

http://www.niallp.pwp.blueyonder.co.uk/validatorjs.html

Niall

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 14471] - [validator] validator-rules.xml JavaScript fails when field not present in jsp

2004-12-02 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=14471


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 14471] - [validator] validator-rules.xml JavaScript fails when field not present in jsp

2004-12-02 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=14471


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|enhancement |normal
 Status|REOPENED|ASSIGNED




--- Additional Comments From [EMAIL PROTECTED]  2004-12-02 19:47 ---
This is not an enhancement, but a bug. I am running into this problem today, and
the best patch available is from comment #1, which is placing this code after
retrieving the field:
if (field == null) {
  continue;
}

To answer comment #7: When fields are not required, there should not be a
penalty if the field is absent. All server-side validation works under this
premesis. For example, when the "maxlength" validation is specified for a form
property, but the field is absent in the submission, the validation is not
applied. Thus, the implication is that it is acceptable for non-required fields
to be absent.

So to "push it deeper -- down into validation.xml as a  optional
attribute" is not needed. By definition, fields without the "required"
validation are optional.

However, today's JavaScript validation is deficient and a penalty occurs for
non-required fields. The JavaScript blindly tries to access properties for
fields that may not exist. This penalty needs to be removed to match 
expectations.

I am willing to work on this if no one else is.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 14471] - [validator] validator-rules.xml JavaScript fails when field not present in jsp

2004-11-24 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=14471


[EMAIL PROTECTED] changed:

   What|Removed |Added

Summary|validator-rules.xml |[validator] validator-
   |JavaScript fails when field |rules.xml JavaScript fails
   |not present in jsp  |when field not present in
   ||jsp




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]