Re: Need help with 1.3.9

2007-06-11 Thread Henri Yandell

On 6/6/07, Henri Yandell [EMAIL PROTECTED] wrote:

On 5/3/07, Paul Benedict [EMAIL PROTECTED] wrote:
 My hands are full with two jobs at the moment. I can roll the 1.3.9
 release because Maven is easy, but I'd like someone to help out with
 these pre-tasks, if anyone is available:

 * Checkin release notes for 1.3.9
 * Correct any site errors
 (http://www.nabble.com/struts-1.x-website-needs-fixing-badly-tf3648645.html)
 * Test the webapps

They're not building for me:

 cd apps
 mvn install

[INFO] Skipping missing optional mojo:
org.apache.maven.plugins:maven-site-plugin:attach-descriptor
[INFO] 
[ERROR] BUILD ERROR
[INFO] 
[INFO] The plugin 'org.codehaus.cargo:cargo-maven2-plugin' does not
exist or no valid version could be found


I've gone ahead and added a version (Paul pointed this out on IM).
Builds for me now, so time to walk through the apps.

Hen

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Need help with 1.3.9

2007-06-11 Thread Henri Yandell

On 5/3/07, Paul Benedict [EMAIL PROTECTED] wrote:

* Test the webapps


Blank: GOOD.
Cookbook: GOOD.
EL-Examples:

 html-el:multibox. When first started, none of the checkboxes were
selected. Also, the '50' on the right hand side is not selectable due
to the 'disabled=${!empty pageScope}'. Bit of a confusing example to
have that sneaking in there; any idea why that bit is used? 'empty
pageScope'? The same thing appears all over.

 html-el:string. The bottom two on the left hand side don't change
the backing bean when save is hit. Possibly they just shouldn't be
enabled as the two on the bottom right have the same behaviour.

Struts-Faces-Example1: GOOD.
Struts-Faces-Example2: GOOD.
Struts-Mailreader: GOOD.
Struts-Scripting-Mailreader: GOOD.

Hen

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Need help with 1.3.9

2007-06-11 Thread Henri Yandell

On 6/11/07, Henri Yandell [EMAIL PROTECTED] wrote:

On 5/3/07, Paul Benedict [EMAIL PROTECTED] wrote:
 * Test the webapps

EL-Examples:


Digging more into the major issues:


  html-el:multibox. When first started, none of the checkboxes were selected.


Looks to me like the text is plain wrong. The underlying testBean
doesn't fill the multiboxes with any data, so presumably the text
should say should NOT be selected. I've made that change (easy to
change back :)  - r546298).


  html-el:string. The bottom two on the left hand side don't change
the backing bean when save is hit. Possibly they just shouldn't be
enabled as the two on the bottom right have the same behaviour.


Presumably the problem here is that there are three fields with the
same name, and (for my browser/server combination) the first field is
the one that wins. I'm going to go ahead and add the disabled to the
two bottom left field (r546294).

Hen

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Need help with 1.3.9

2007-05-03 Thread Paul Benedict
My hands are full with two jobs at the moment. I can roll the 1.3.9 
release because Maven is easy, but I'd like someone to help out with 
these pre-tasks, if anyone is available:


* Checkin release notes for 1.3.9
* Correct any site errors 
(http://www.nabble.com/struts-1.x-website-needs-fixing-badly-tf3648645.html)

* Test the webapps

PS: Make any changes also in HEAD.

Paul



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]